From 60d898a848e539bd01b08dfaa21550df51d970f3 Mon Sep 17 00:00:00 2001 From: Nick Date: Sat, 5 Sep 2026 20:08:56 +0100 Subject: [PATCH] fix(ci): type-check gates the protected merge status (#148) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The required-checks job's needs list omitted type-check — a red type-check job left the protected merge gate green. Handoff §3.1: job existence is not proof; the dependency chain is the proof. --- .gitea/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml index 00a47494..862f7b1e 100644 --- a/.gitea/workflows/ci.yml +++ b/.gitea/workflows/ci.yml @@ -195,7 +195,9 @@ jobs: required-checks: if: gitea.event_name == 'pull_request' runs-on: self-hosted - needs: [lint, unit-tests, canary, best-practices, documentation, gitea-offline] + # #148: type-check MUST gate the protected status — a red type-check job + # previously left the protected merge gate green (dependency-chain hole). + needs: [lint, unit-tests, canary, best-practices, documentation, type-check, gitea-offline] steps: - name: Publish protected-branch gate run: echo "All required CI checks passed"