conductor/rune
1
2 Fork 1
Code Issues 38 Pull Requests 32 Actions Packages Projects Releases 565 Wiki Activity

[rebase w2] src/rune/token_optimizer.py::TokenOptimizer.TokenOptimizer._load #772

New Issue
Closed
opened 2026-09-29 08:07:26 +01:00 by conductor · 3 comments
conductor commented 2026-09-29 08:07:26 +01:00
Owner
Copy link
Copy source

Identity (from the Wave 0 inventory — machine-generated)

  • File: src/rune/token_optimizer.py
  • Unit: TokenOptimizer.TokenOptimizer._load
  • Signature: def TokenOptimizer.TokenOptimizer._load(self) (async: False)
  • Line range: 76–86
  • Decorators: none
  • Internal call edges (callers/callees inside the repo, from inventory):
    • CacheEntry (line 83)

Current behaviour

One honest paragraph from READING THE CODE at the line range above — what it
actually does, not what the docstring promises. Write this at disposition
time; the factory does not fabricate it.

The three questions — each answered WITH EVIDENCE

  1. IMPROVE? Can the unit be improved within its scope? Evidence or "no — because …".
    (Bounded to unit scope; larger findings spawn NEW issues, never expand this one.)
  2. FIX? Is it broken, buggy, or failing its expected outcome? Evidence: a failing
    test, a reproduced fault, or a code-level defect citation. A "no" needs evidence too.
  3. MISSING CONNECTORS? Are there expected outcomes this unit should connect to but
    doesn't (unwired events, dead parameters, promised-but-absent calls)? Evidence required.

A silent skip on any question is a factory bug — answer all three.

Language verdict (per tranche R1 §6 rubric — evidence beats instinct)

Choose exactly one, with the evidence line:

  • KEEP-PYTHON — one sentence of justification.
  • RECODE- — rubric scores (all 7 dimensions) + benchmark-gate plan: the compiled
    replacement must beat the Python original on the MEASURED hot path, or the recode is
    rejected and recorded. No win, no recode.
  • MERGE-into: — name the target and why.
  • DEPRECATE — name the caller that no longer needs it.

Go is NOT pre-decided. Python is not pre-decided. The rubric decides.

Constraint context

  • henxels structural contract: this unit's module ≤ 1,200 lines (or on the debt table's
    exception list — check before adding lines).
  • Spine: any module-surface change requires store/spine/current.json regen with the code
    change (test_manifest_maps_every_module is the arbiter for new top-level modules).
  • Debt table: docs/structural-contract.md.

Pipeline plan

  1. Branch issue-<N> from current master (existing issue-N convention).
  2. Scaffolding activation for any construction (construction_mode/decision per unit change).
  3. Research rounds are MANDATORY for any RECODE verdict (research-stage-headless; ≥2
    live-verified external sources per claim; per-source lessons; kill test per candidate).
  4. Implementation behind the interop contract (R1 §5): compiled units are standalone
    binaries — argv in, JSON on stdout, non-zero exit on failure, --version mandatory;
    Python wraps in a thin adapter; store stays the shared truth.
  5. Local gates: pytest + ruff + spine-store regen (if surface changed) + henxels.
  6. PR → pipeline-gate + ci + required checks → merge-robot → auto-version.

Verification

  • The specific test proving this unit's change: (write at disposition).
  • The keep-green set it must not break: full suite must stay green; named
    keep-green tests for this unit's callers.

Provenance

  • Tranche: tranche R1 language rebase (2026-09-29), ~/.config/opencode/tranches/2026-09-29-language-rebase-tranche-R1.md
  • Wave: 2 (leaf utilities & canaries)
  • Inventory: docs/rebase-inventory.json (regenerate with scripts/rebase_inventory.py — never hand-edit)
  • Factory: scripts/rebase_issue_factory.py
## Identity (from the Wave 0 inventory — machine-generated) - **File**: `src/rune/token_optimizer.py` - **Unit**: `TokenOptimizer.TokenOptimizer._load` - **Signature**: `def TokenOptimizer.TokenOptimizer._load(self)` (async: False) - **Line range**: 76–86 - **Decorators**: none - **Internal call edges** (callers/callees inside the repo, from inventory): - `CacheEntry` (line 83) ## Current behaviour One honest paragraph from READING THE CODE at the line range above — what it actually does, not what the docstring promises. Write this at disposition time; the factory does not fabricate it. ## The three questions — each answered WITH EVIDENCE 1. **IMPROVE?** Can the unit be improved within its scope? Evidence or "no — because …". (Bounded to unit scope; larger findings spawn NEW issues, never expand this one.) 2. **FIX?** Is it broken, buggy, or failing its expected outcome? Evidence: a failing test, a reproduced fault, or a code-level defect citation. A "no" needs evidence too. 3. **MISSING CONNECTORS?** Are there expected outcomes this unit should connect to but doesn't (unwired events, dead parameters, promised-but-absent calls)? Evidence required. A silent skip on any question is a factory bug — answer all three. ## Language verdict (per tranche R1 §6 rubric — evidence beats instinct) Choose exactly one, with the evidence line: - **KEEP-PYTHON** — one sentence of justification. - **RECODE-<lang>** — rubric scores (all 7 dimensions) + benchmark-gate plan: the compiled replacement must beat the Python original on the MEASURED hot path, or the recode is rejected and recorded. No win, no recode. - **MERGE-into:<module>** — name the target and why. - **DEPRECATE** — name the caller that no longer needs it. Go is NOT pre-decided. Python is not pre-decided. The rubric decides. ## Constraint context - henxels structural contract: this unit's module ≤ 1,200 lines (or on the debt table's exception list — check before adding lines). - Spine: any module-surface change requires `store/spine/current.json` regen with the code change (`test_manifest_maps_every_module` is the arbiter for new top-level modules). - Debt table: docs/structural-contract.md. ## Pipeline plan 1. Branch `issue-<N>` from current master (existing issue-N convention). 2. Scaffolding activation for any construction (construction_mode/decision per unit change). 3. Research rounds are MANDATORY for any RECODE verdict (research-stage-headless; ≥2 live-verified external sources per claim; per-source lessons; kill test per candidate). 4. Implementation behind the interop contract (R1 §5): compiled units are standalone binaries — argv in, JSON on stdout, non-zero exit on failure, `--version` mandatory; Python wraps in a thin adapter; store stays the shared truth. 5. Local gates: pytest + ruff + spine-store regen (if surface changed) + henxels. 6. PR → pipeline-gate + ci + required checks → merge-robot → auto-version. ## Verification - The specific test proving this unit's change: (write at disposition). - The keep-green set it must not break: full suite must stay green; named keep-green tests for this unit's callers. ## Provenance - Tranche: tranche R1 language rebase (2026-09-29), ~/.config/opencode/tranches/2026-09-29-language-rebase-tranche-R1.md - Wave: 2 (leaf utilities & canaries) - Inventory: docs/rebase-inventory.json (regenerate with scripts/rebase_inventory.py — never hand-edit) - Factory: scripts/rebase_issue_factory.py
gitea-actions Bot commented 2026-09-29 08:21:40 +01:00
Copy link
Copy source

⚠️ Priority gate: this issue has no priority. Assign exactly one of P0 — critical (spine/correctness/blocks), P1 — high (material value or real defect), P2 — medium (quality/consolidation), P3 — low (measurement/deferred). An issue without a priority is not filed.

⚠️ **Priority gate:** this issue has no priority. Assign exactly one of **P0 — critical** (spine/correctness/blocks), **P1 — high** (material value or real defect), **P2 — medium** (quality/consolidation), **P3 — low** (measurement/deferred). An issue without a priority is not filed.
gitea-actions Bot added the bugcustodiangrowthidentityinfrastructurememory labels 2026-09-29 08:21:41 +01:00
conductor commented 2026-09-30 12:18:10 +01:00
Author
Owner
Copy link
Copy source

Disposition — _load (82–92)

Current behaviour (from code read): if the storage file exists, json.loads it, rebuilds self.cache as CacheEntry(**entry_data) per key, and adopts persisted stats — all inside a blanket try/except Exception: pass. Any failure (missing file, corrupt JSON, schema drift) degrades to an empty cache silently.

  1. IMPROVE? Bounded observation: the silent pass makes the degrade-to-empty path unobservable in logs. This was the amplifier that turned #770's TypeError into total silent loss. A one-line log on the except branch would be a genuine improvement — but the behaviour itself (corrupt storage → empty cache, no crash) is now the FROZEN contract of test_corrupt_storage_degrades_to_empty_cache, so the change must preserve that contract. Not blocking; recorded as the named improvement for this unit.
  2. FIX? No — post-#770 the roundtrip is sound (frozen tests green). The blanket except itself is the contract for corrupt input, tested and intentional; it only became harmful when paired with a serializer that emitted unloadable data, which is fixed.
  3. MISSING CONNECTORS? No — called from __init__ only, which is the correct single load point; the persistence counterpart _save is wired through the dirty-flag machinery.

Language verdict (rebase R1 §6 rubric): KEEP-PYTHON. The wave's heaviest work in this module is 2 re.sub per turn (rubric :280) — no hot loop exists here; every candidate compiled crossing costs ~658 µs (14,000× the cost of the work it would replace), and this unit is already on the CPython 3.11+ PEP 659 shape the rubric awards (rubric :282). No benchmark gate is owed: no measured hot path exists to beat. Zero RECODE.

## Disposition — `_load` (82–92) **Current behaviour (from code read):** if the storage file exists, `json.load`s it, rebuilds `self.cache` as `CacheEntry(**entry_data)` per key, and adopts persisted stats — all inside a blanket `try/except Exception: pass`. Any failure (missing file, corrupt JSON, schema drift) degrades to an empty cache silently. 1. **IMPROVE?** Bounded observation: the silent `pass` makes the degrade-to-empty path unobservable in logs. This was the amplifier that turned #770's `TypeError` into total silent loss. A one-line log on the except branch would be a genuine improvement — but the behaviour itself (corrupt storage → empty cache, no crash) is now the FROZEN contract of `test_corrupt_storage_degrades_to_empty_cache`, so the change must preserve that contract. Not blocking; recorded as the named improvement for this unit. 2. **FIX?** No — post-#770 the roundtrip is sound (frozen tests green). The blanket except itself is the *contract* for corrupt input, tested and intentional; it only became harmful when paired with a serializer that emitted unloadable data, which is fixed. 3. **MISSING CONNECTORS?** No — called from `__init__` only, which is the correct single load point; the persistence counterpart `_save` is wired through the dirty-flag machinery. **Language verdict (rebase R1 §6 rubric): KEEP-PYTHON.** The wave's heaviest work in this module is 2 `re.sub` per turn (rubric `:280`) — no hot loop exists here; every candidate compiled crossing costs ~658 µs (14,000× the cost of the work it would replace), and this unit is already on the CPython 3.11+ PEP 659 shape the rubric awards (rubric `:282`). No benchmark gate is owed: no measured hot path exists to beat. Zero RECODE.
conductor commented 2026-09-30 20:48:19 +01:00
Author
Owner
Copy link
Copy source

Folded into epic #2303 — per-file epic for src/rune/token_optimizer.py (w2). Absorbed child; closing as absorbed (content preserved, reversible by reopen).

Folded into epic #2303 — per-file epic for `src/rune/token_optimizer.py` (w2). Absorbed child; closing as absorbed (content preserved, reversible by reopen).
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
P0 — critical
Spine/core correctness or blocks other work — do first
 P1 — high
Material user value or real defect (money, bugs, next-stage dep)
 P2 — medium
Quality/consolidation improvement
 P3 — low
Measurement / benchmark / deferred policy
 blocked
Dependencies open
 bug
Confirmed defect or regression
 custodian
epic
Rune v1 course-correction issue graph
 feature
New capability or improvement
 governance
growth
identity
in-progress
Currently being worked on by Rune
 incomplete
Incomplete work — draft PR with ledger, awaiting resume
 infrastructure
life
memory
memory-atlas
Memory Research Atlas child domain
 needs-testing
Needs manual testing with dumbed-down steps before close
 perception
ready
Order satisfied - Rune may start
 release-drift
research
Research jobs — spikes, watchlists, evidence work
 rune
rune
 scaffolding
scaffolding
 spine,correction
spine,correction
 spine,deferred
spine,deferred
 spine,resolved
spine,resolved
 strangler,burn,endgame,deferred
strangler,burn,endgame,deferred
 strangler,burn,endgame,inventory,epic
strangler,burn,endgame,inventory,epic
 tui
tui
 tui,epic
tui,epic
 tui,openspec
tui,openspec
 v1-course-correction
Rune v1 course-correction issue graph
No labels bug custodian growth identity infrastructure memory
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
conductor
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conductor/rune#772