Compare commits
51
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0de6f1bba4 | ||
|
|
9c5ea0aeb2 | ||
|
|
f18b6cc363 | ||
|
|
a13714364a | ||
|
|
0ab8a9485e | ||
|
|
01da5b0999 | ||
|
|
df413e8e41 | ||
|
|
c8b12cc496 | ||
|
|
ec2ee953c8 | ||
|
|
e39ea6ac36 | ||
|
|
885332a8ed | ||
|
|
914910c006 | ||
|
|
48d85e169c | ||
|
|
f869fa407b | ||
|
|
71fd16a36b | ||
|
|
06302b2472 | ||
|
|
704b4488e6 | ||
|
|
6aa271c2d4 | ||
|
|
d054ecb1c6 | ||
|
|
1bbd48fbe5 | ||
|
|
7a2a499ce7 | ||
|
|
3ea85744e9 | ||
|
|
00d55b4383 | ||
|
|
0d0a76c1c5 | ||
|
|
fa7304af55 | ||
|
|
99c8d5850b | ||
|
|
2ad9c65721 | ||
|
|
da8a342886 | ||
|
|
aeebfee796 | ||
|
|
0498b00c02 | ||
|
|
2cc88f7f94 | ||
|
|
6a91563f42 | ||
|
|
809181943c | ||
|
|
4d7144eb61 | ||
|
|
c3439acc3c | ||
|
|
c05f18e293 | ||
|
|
737a4ad804 | ||
|
|
5b8b07a506 | ||
|
|
f884a7cd91 | ||
|
|
d471767325 | ||
|
|
0581d909f3 | ||
|
|
89617a62ba | ||
|
|
f81385fce9 | ||
|
|
a48037e091 | ||
|
|
d31359f3a5 | ||
|
|
cf7310969d | ||
|
|
57b12dccf3 | ||
|
|
9bd088e87f | ||
|
|
632afd03fc | ||
|
|
76f7b535a1 | ||
|
|
1ea093ad18 |
No files matched your search
@@ -38,7 +38,7 @@ jobs:
|
||||
PR_TITLE: ${{ gitea.event.pull_request.title }}
|
||||
PR_BODY: ${{ gitea.event.pull_request.body }}
|
||||
PR_NUMBER: ${{ gitea.event.pull_request.number }}
|
||||
run: "LATEST=$(python3 scripts/tag_repair.py --latest-tag)\nLATEST=\"${LATEST#v}\"\nif [ -z\
|
||||
run: "LATEST=$(python3 scripts/tag_repair.py --latest-tag --namespace main)\nLATEST=\"${LATEST#v}\"\nif [ -z\
|
||||
\ \"$LATEST\" ]; then\n echo \"No previous tags \u2014 releasing first version\
|
||||
\ $RELEASE_VERSION\"\n exit 0\nfi\nif [ \"$LATEST\" != \"$RELEASE_VERSION\"\
|
||||
\ ]; then\n if [ \"$(printf '%s\\n%s\\n' \"$LATEST\" \"$RELEASE_VERSION\"\
|
||||
@@ -162,7 +162,7 @@ jobs:
|
||||
\ summary of\n# what was worked on and submitted \u2014 the version-history\
|
||||
\ reader's\n# counterpart of the issue-entry template. Appended to the\n#\
|
||||
\ evidence-derived body so governed facts AND human narrative\n# both appear.\n\
|
||||
LAST_TAG=$(python3 scripts/tag_repair.py --latest-tag)\nEXIT_NOTE=$(python3 scripts/release_exit_note.py\
|
||||
LAST_TAG=$(python3 scripts/tag_repair.py --latest-tag --namespace main)\nEXIT_NOTE=$(python3 scripts/release_exit_note.py\
|
||||
\ --since \"$LAST_TAG\" --to HEAD) || EXIT_NOTE=\"\"\npython3 scripts/release_history_cli.py\
|
||||
\ init \\\n --version \"$RELEASE_VERSION\" \\\n --server \"$RELEASE_SERVER_URL\"\
|
||||
\ --repo \"$RELEASE_REPO\" \\\n --store store/scaffold/current.json \\\n\
|
||||
@@ -180,17 +180,56 @@ jobs:
|
||||
# Python. Idempotent: a body already carrying the section is left
|
||||
# alone. Additive and non-blocking: a missing toolchain or a failed
|
||||
# prepend must never fail a release.
|
||||
LAST_TAG=$(python3 scripts/tag_repair.py --latest-tag)
|
||||
LAST_TAG=$(python3 scripts/tag_repair.py --latest-tag --namespace main)
|
||||
if ! command -v go >/dev/null 2>&1; then
|
||||
echo "::warning::go toolchain unavailable — release published without the plain-English narrative"
|
||||
exit 0
|
||||
fi
|
||||
(cd src/go/release-notes && go build -o /tmp/rune-release-notes .) || {
|
||||
echo "::warning::release-notes build failed — narrative skipped"; exit 0; }
|
||||
/tmp/rune-release-notes prepend-narrative \
|
||||
# rebuild-body (#2582): the FULL plain-english template — proper
|
||||
# markdown (one H1 title, sections in reading order, capped bullets,
|
||||
# the no-changes contradiction scrubbed, evidence tails preserved).
|
||||
(cd src/go/release-notes && go build -o /tmp/rune-release-notes .) || true
|
||||
/tmp/rune-release-notes rebuild-body \
|
||||
--server "$RELEASE_SERVER_URL" --repo "$RELEASE_REPO" \
|
||||
--tag "v${RELEASE_VERSION}" --since "$LAST_TAG" || {
|
||||
echo "::warning::narrative prepend failed — release body left unchanged"; exit 0; }
|
||||
echo "::warning::body rebuild failed — release body left unchanged"; exit 0; }
|
||||
- name: Sync the committed changelog from the version tags
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.ROBOT_TOKEN }}
|
||||
run: |
|
||||
# CHANGELOG LAW (#2582): every release syncs the committed
|
||||
# CHANGELOG.md (deterministic regeneration from the tags). CI's lint
|
||||
# job byte-compares regeneration against the file — a release that
|
||||
# skipped its sync turns the gate red on the next PR. The sync
|
||||
# commit is chore(changelog) (= releases nothing; the convergence
|
||||
# classifier's "other" bucket), so it earns no version.
|
||||
(cd src/go/release-notes && go build -o /tmp/rn-changelog .) || {
|
||||
echo "::warning::changelog sync skipped — go toolchain unavailable"; exit 0; }
|
||||
/tmp/rn-changelog changelog
|
||||
if ! git diff --quiet CHANGELOG.md; then
|
||||
git config user.name "release-bot"
|
||||
git config user.email "release-bot@rune.dev"
|
||||
git add CHANGELOG.md
|
||||
# push auth = tag_repair's tested extraheader mechanism
|
||||
python3 - <<'PYPUSH'
|
||||
import tag_repair
|
||||
import os, subprocess
|
||||
repo = os.getcwd()
|
||||
try:
|
||||
err = tag_repair._configure_http_auth(repo)
|
||||
except Exception as e:
|
||||
err = str(e)
|
||||
if err:
|
||||
print("::warning::changelog push auth unavailable — next release retries:", str(err)[:120])
|
||||
else:
|
||||
r = subprocess.run(["git", "push", "gitea", "master"], capture_output=True, text=True)
|
||||
print("changelog push:", r.returncode, (r.stdout or r.stderr)[:200])
|
||||
PYPUSH
|
||||
else
|
||||
echo "changelog already current"
|
||||
fi
|
||||
- name: Refresh README Highlights from the latest release
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.ROBOT_TOKEN }}
|
||||
|
||||
@@ -67,6 +67,14 @@ jobs:
|
||||
if [ "${#ADDED_PYTHON[@]}" -gt 0 ]; then
|
||||
.ci-venv/bin/ruff format --check "${ADDED_PYTHON[@]}"
|
||||
fi
|
||||
- name: Changelog currency (generated == committed, #2582)
|
||||
run: |
|
||||
# The committed CHANGELOG.md is generated from the version tags; a
|
||||
# release that landed without a changelog sync (or a tag added
|
||||
# without an entry) fails here with the sync command. The tags are
|
||||
# immutable — regeneration is deterministic, so this gate is exact.
|
||||
(cd src/go/release-notes && go build -o /tmp/rn-changelog .)
|
||||
/tmp/rn-changelog changelog --check
|
||||
- name: Structural contract (henxels)
|
||||
run: |
|
||||
.ci-venv/bin/henxels check --all --plain
|
||||
|
||||
@@ -123,7 +123,7 @@ jobs:
|
||||
run: |
|
||||
VERSION=$(python3 -c 'import re; text=open("src/rune/__init__.py").read(); print(re.search(r"__version__ = \"([0-9]+\.[0-9]+\.[0-9]+)\"", text).group(1))')
|
||||
echo "MASTER_VERSION=$VERSION" >> "$GITHUB_ENV"
|
||||
echo "LATEST_TAG=$(python3 scripts/tag_repair.py --latest-tag)" >> "$GITHUB_ENV"
|
||||
echo "LATEST_TAG=$(python3 scripts/tag_repair.py --latest-tag --namespace main)" >> "$GITHUB_ENV"
|
||||
python3 scripts/version_convergence.py > /tmp/convergence.json
|
||||
echo "Convergence: $(cat /tmp/convergence.json)"
|
||||
python3 - <<'PYENV'
|
||||
|
||||
+7006
File diff suppressed because it is too large.
Load diff
@@ -1,9 +1,9 @@
|
||||
# Rune
|
||||
|
||||
**Current release: v0.336.0**
|
||||
**Current release: v0.346.0**
|
||||
|
||||
<!-- highlights:start -->
|
||||
## Highlights — from the latest release (v0.336.0)
|
||||
## Highlights — from the latest release (v0.346.0)
|
||||
|
||||
- Plain-English jargon dictionary covers the v0.329 vocabulary, plus catch-all sentence simplification pass.
|
||||
|
||||
|
||||
@@ -28,6 +28,11 @@ Each activity has its OWN colour and its OWN animation pattern. The runic animat
|
||||
Runic marks may randomise colour per rune within the activity's palette (owner ruling: "could
|
||||
have random colours per rune"). The activity WORD animates while active.
|
||||
|
||||
### A2a. Animation order (owner live ruling 2026-10-22, D50 boot)
|
||||
The ACTIVITY WORD comes FIRST — it animates in rainbow colours with a snake-like sweep
|
||||
through the word and back — and the runic animation plays AFTER the word. Word leads,
|
||||
runes follow.
|
||||
|
||||
### A3. The word itself
|
||||
The activity word randomises a rainbow colour while active (owner ruling #2527, subsumed here).
|
||||
|
||||
@@ -52,6 +57,18 @@ and either retired or made honest.
|
||||
|
||||
## Part B — THE ANSWER PRESENTATION SYSTEM (chatpane)
|
||||
|
||||
### B0. Everything gets a box (owner live ruling 2026-10-22, D50 boot)
|
||||
EVERY element is boxed as standard — tables, bullet lists, headings,
|
||||
everything — each element type its own box shape (table box, list box,
|
||||
heading box) in the bubble family's rounded framing, borders in the
|
||||
speaker's colour. Nothing floats naked after a bubble. This ruling
|
||||
SUPERSEDES the B2 "breakout, no bubble" wording for lists/headings:
|
||||
they break out of the SPEECH bubble into their OWN boxes. Boxes render
|
||||
FLUSH LEFT (ruling: no indent creep — one flat left edge for the whole
|
||||
conversation, user and rune alike) with the timestamp TRAILING the
|
||||
box's bottom-right corner. Bullet lists carry a blank line between
|
||||
items for readability.
|
||||
|
||||
### B1. Proper markdown, zero model-side cost
|
||||
Parse the model's OWN markdown into blocks once per completed answer (TUI-side, after the turn).
|
||||
No prompt changes, no extra tokens, no context cost. Bounded dialect renderer (~6 block types),
|
||||
|
||||
@@ -0,0 +1,49 @@
|
||||
# Spec: Pinned Work in the Tasks Pane (D50 residual 4, #2560)
|
||||
|
||||
Status: landed (wave D50-residuals). Supersedes the D50 draft with the
|
||||
owner's D51 upgrades.
|
||||
|
||||
## The surface
|
||||
|
||||
A reserved PINNED WORK area at the TOP of the tasks pane's region
|
||||
view — the pane's first content, above the scaffolding status line,
|
||||
the work stream, and the queue. It accumulates pinned work native to
|
||||
Rune (pin action on work blocks and goals).
|
||||
|
||||
- Header: the pin icon + `pinned (N) — outstanding work` label.
|
||||
- Each pin renders ONE line: `◆ <plain-english summary>` — every pin
|
||||
carries a plain-english summary of what is pinned (D51 upgrade).
|
||||
- Click on the pinned area opens the OUTSTANDING PINNED WORK view
|
||||
(D51 upgrade); click again closes it. In the open view each pin
|
||||
names its id and the controls; clicking a pin (or `x`, which
|
||||
releases the newest) releases it; `esc` backs out to the pane.
|
||||
- No pins, no area: the tasks pane renders blank otherwise (D51
|
||||
upgrade), with NO selectable rows anywhere (D51 — the D50 residual 3
|
||||
removal already took the row walker out).
|
||||
|
||||
## Keyboard parity (the pin verb)
|
||||
|
||||
`ctrl+b` pins the top live work block (the newest running work
|
||||
stream block) into the pinned area. Chosen for the control-key idiom
|
||||
family — `ctrl+q` steers the queue, `ctrl+g` raises the gauges,
|
||||
`ctrl+p` is the palette, `ctrl+a` the activity window — control keys
|
||||
own the chrome verbs; plain letters always type (the D36 letter law).
|
||||
`ctrl+b` is reachable while composing.
|
||||
|
||||
## Persistence
|
||||
|
||||
Pins persist across boots through the hot-state store pattern (the
|
||||
task_state/history-depth pattern): one JSON document at
|
||||
`$RUNE_HOME/tasks_pins.json` (beside `history_depth.json`), written
|
||||
atomically (write-beside, rename over) on every pin change; absent or
|
||||
corrupt records answer an empty pin set, never a guess. The layer in
|
||||
`tui/tasks/pinned.go` stays pure view-model; the shell owns the
|
||||
record.
|
||||
|
||||
## Tests
|
||||
|
||||
`tui/tasks/pinned_test.go` pins the area's placement (first content),
|
||||
the no-pins-no-area law, the view open/release cycle with keyboard
|
||||
parity, and clone-carry. `tui/cmd/rune-tui/pins_test.go` pins the
|
||||
ctrl+b verb and the boot leg (a fresh model loads the pins and renders
|
||||
the area).
|
||||
File diff suppressed because it is too large.
Load diff
+1
-1
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
|
||||
|
||||
[project]
|
||||
name = "rune"
|
||||
version = "0.336.0"
|
||||
version = "0.346.0"
|
||||
description = "Rune — a stateful coding assistant with persistent memory, orchestration, and TUI"
|
||||
requires-python = ">=3.10"
|
||||
|
||||
|
||||
@@ -0,0 +1,82 @@
|
||||
# D53 wave report — pane polish + the long-answer format break (Gitea #2568)
|
||||
|
||||
Admission: `scripts/admit_wave_d53_pane_polish.py` (classified
|
||||
EXISTING_PROJECT_CHANGE, activated, contract
|
||||
ADMIT-wave-d53-pane-polish minted — note: the classify core treats
|
||||
"listing" as a reading verb; the objective says "showing").
|
||||
|
||||
## Per-item outcome
|
||||
|
||||
1. **LONG-ANSWER FORMAT BREAK** — reproduced: a 24-block mixed answer
|
||||
at width 24 rendered a table edge row 30 columns wide. Root cause:
|
||||
`tableLines` (tui/chatpane/blocks.go) built edge rows wider than
|
||||
body rows by the separator columns, and the width budget ignored
|
||||
them. Fixed: rows and edges share one geometry, honest
|
||||
too-narrow drop (`total < cols*3` → nil). Summary-first asserted
|
||||
at any length; append-never-reflows asserted on the long answer.
|
||||
Commit 00d55b43 (rode to gitea/master with #2556's push).
|
||||
2. **SCROLLBAR** — root cause found: `overlayDisplayCol`
|
||||
(tui/lanes/render.go) wrote the thumb glyph into the left half
|
||||
ONLY when a content rune sat at column x — a short styled row (the
|
||||
common transcript shape) lost the glyph entirely, so no bar ever
|
||||
rendered. Fixed: the glyph lands at the column even past the
|
||||
line's end; thumb styled with a new `RoleScroll` token (vivid
|
||||
#B87C99 / calm #C790AC, floors ≥4.5:1 asserted); chat AND tasks
|
||||
rows render styled-or-empty; wheel step math pinned (one notch =
|
||||
exactly its 3-line step, exact accumulation). Commit 3ea85744.
|
||||
3. **QUIT WARNING** — first ctrl+c swaps the composer key hint for
|
||||
the literal `press ctrl+c again to quit`; any other key or the 1s
|
||||
timeout restores the live key hint. Found + fixed a D46 latent
|
||||
defect: the arm-reset check was unreachable dead code inside the
|
||||
KeyPressMsg case — the reset now has its own top-level switch
|
||||
case. The second press quits, never shows the warning. Face chain
|
||||
gained a `Hint()` read-back seam. Commit 7a2a499c.
|
||||
4. **DYNAMIC REFLOW** — squash test frozen: a WindowSizeMsg through
|
||||
the face chain re-wraps every block at 44 and 100 columns, no line
|
||||
exceeds the pane, the scroll offset normalizes after the line-count
|
||||
change. The render-path rewrap already held; the test pins it.
|
||||
Commit 6aa271c2.
|
||||
5. **INFO BAR** — `context 4.2k/32k (13%)` via `ctxPercent`
|
||||
(clamped 0-100, still silent when the engine never reported).
|
||||
Commit 704b4488.
|
||||
6. **COMPOSER STYLING** — key hints render in the new `RoleHintPink`
|
||||
token (vivid #C9739D / calm #D083AC); the activity pane's idle
|
||||
state renders in the new `RoleStateIdle` yellow token (vivid
|
||||
#D9B45B / calm #C9B06E) — the D52 frozen idle test superseded with
|
||||
the ruling recorded. Commits 06302b24 + 71fd16a3.
|
||||
7. **SUB-AGENTS** — the activity pane's "sub agents being processed
|
||||
now" section renders ONLY while the syncWaves flight observation
|
||||
reports agents in flight (one poller — the section can never
|
||||
disagree with the rail marker or the wave tab); clickable
|
||||
(mouse.activity.agents region) with ctrl+w keyboard parity,
|
||||
opening the CENTERED agents window (the D52 picker pattern)
|
||||
listing all in-flight agents; the selected row's thought process /
|
||||
recent activity (the factory journal + observations detail
|
||||
`waveRows` already derives) renders beneath; the window is modal
|
||||
(esc/up/down, any other key closes). Plain-value `AgentView` seam
|
||||
keeps lanes un-importable from tasks. Commit f869fa40.
|
||||
|
||||
## Verification
|
||||
|
||||
- `go test -race -short ./...` green (tui module; the documented
|
||||
pre-existing boot-smoke PTY family aside did not fire this run).
|
||||
- gofmt clean; `go vet ./...` clean.
|
||||
- PTY proof: the deployed binary boots to CHAT/TASKS panes with the
|
||||
live "enter send" hint (bubbletea coords 0-based-normalized per the
|
||||
D52 finding; click tests drive the region rects directly).
|
||||
- Rebased onto gitea/master d054ecb1 (#2556 streaming wave landed
|
||||
mid-flight); items 1-3 rode up with that push; items 4-7 pushed as
|
||||
48d85e16.
|
||||
- Deploy: `scripts/build_paired.sh` attested
|
||||
`48d85e16...+20261024T032845Z`; binary installed to
|
||||
`~/.local/share/rune/bin/rune-tui`; `ensure_core` reports real and
|
||||
healthy (identity 'Rune', 13 models).
|
||||
|
||||
## Concurrency note
|
||||
|
||||
A streaming wave (#2556) edited tui/ concurrently mid-wave. One
|
||||
commit initially swept its WIP; it was split back out (the commit was
|
||||
mine, unpushed) and item 3 was re-landed from HEAD blobs. The sweep
|
||||
race guard caught nothing (staged-tree check passed) — the guard
|
||||
checks contract coverage, not authorship. Consider a per-hunk
|
||||
authorship check for shared surfaces.
|
||||
@@ -0,0 +1,92 @@
|
||||
"""Admission dispatch for #2582 release reporting (owner: plain-English
|
||||
version reads with what-to-test).
|
||||
|
||||
The version-push reader bug tri-diagnosed: (1) latest_release_tag sorted
|
||||
all tag namespaces, so the TUI build tag captured the main-line range;
|
||||
(2) the Go narrative prepend ran before body finalization and failed
|
||||
silently; (3) no try-actions existed. This contract admits: the
|
||||
namespace-aware tag resolution, the try-action narrative, the workflow
|
||||
rewiring, and the retroactive v0.346.0 body rebuild.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
OBJECTIVE = (
|
||||
"#2582 release reporting: make a pushed version read like a changelog "
|
||||
"for a non-technical owner — plain English what-changed, what-to-try "
|
||||
"derived from touched surfaces, how-it-was-verified. Namespace-aware "
|
||||
"tag resolution (main vs tui-v), the try-action narrative section, "
|
||||
"workflow wiring, retroactive v0.346.0 body rebuild."
|
||||
)
|
||||
AFFECTED = [
|
||||
"scripts/tag_repair.py",
|
||||
"tests/test_tag_repair.py",
|
||||
"src/go/release-notes/narrative.go",
|
||||
"src/go/release-notes/narrative_test.go",
|
||||
"src/go/release-notes/cli_narrative.go",
|
||||
".gitea/workflows/auto-version.yml",
|
||||
".gitea/workflows/maintenance.yml",
|
||||
"src/go/release-notes/main.go", "src/go/release-notes/cli_changelog.go", "CHANGELOG.md", "scripts/admit_release_reporting.py",
|
||||
]
|
||||
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
md = cmode.classify_mode(OBJECTIVE, target_project="rune", project_exists=True,
|
||||
affected_surface=AFFECTED)
|
||||
need = {
|
||||
"need_id": "need-release-reporting",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "release-reporting",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": ["tests/test_tag_repair.py", "src/go/release-notes/narrative_test.go"],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold, builder="release-reporting")
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="release-reporting",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="release-reporting",
|
||||
expected_new_entities=[
|
||||
"src/go/release-notes/main.go", "src/go/release-notes/cli_changelog.go", "CHANGELOG.md", "scripts/admit_release_reporting.py", "tests/test_tag_repair.py",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"every pushed version's release body opens with plain English "
|
||||
"what-changed + what-to-try + how-verified; ranges start at the "
|
||||
"main v* tag, never the tui build tag",
|
||||
],
|
||||
verification_obligations=[
|
||||
"pytest tests/test_tag_repair.py green (namespace law)",
|
||||
"go test ./... in src/go/release-notes green (try-section law)",
|
||||
"v0.346.0 body visibly rebuilt with the template",
|
||||
],
|
||||
regression_obligations=[
|
||||
"no runtime behavior change: release reporting content only",
|
||||
"the evidence store (release_history init) still receives its exit-note",
|
||||
],
|
||||
approval_ref="user: 'can you fix my gitea ... explains what was improved. and what could be tested' (session 2026-10-23)",
|
||||
contract_id="ADMIT-release-reporting",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,150 @@
|
||||
"""Admission dispatch for wave D49 — capability everywhere (owner doctrine).
|
||||
|
||||
The owner's D49 ruling (verbatim, 2026-10-22): "ive asked rune if she
|
||||
can alter her code she said she needs shell access, and the ability to
|
||||
read and write i want that ability to be in every pane, but when
|
||||
something gets to become work it gets promoted into the task pane. she
|
||||
also needs tools to be able to connect to git projects. and make that
|
||||
native." Doctrine: capability is INHERENT in every pane — the write
|
||||
family (write_file, edit_file, run_command) and the new native git
|
||||
family ride the wire in CHAT/PLAN/TASK alike; the consent card remains
|
||||
the work-promotion mechanism (organization, not permission); the real
|
||||
safety layer is the scaffolding authority + contract gates at mutation
|
||||
doors. Build: (1) ToolsetFor exposes the full suite in every mode; (2)
|
||||
ExecuteGatedTool's write-refusal-by-mode retires, the dispatch-gate
|
||||
seam and the genuinely-unavailable refusal stay; (3) the wire tool
|
||||
descriptions state the write availability (the model asked for shell
|
||||
access because the wire showed read-only — fix the wire); (4) a native
|
||||
git family (git_status, git_diff, git_log, git_branch, git_commit,
|
||||
git_add) shelling out to git in the repo root (DefaultRepoRoot seam),
|
||||
porcelain-parsed honestly, typed JSON results, landing-law banned-path
|
||||
refusals on git_add/git_commit; (5) the mode/toolset tests re-pinned
|
||||
to CHAT=full-suite, red-first throughout.
|
||||
approval_ref 'user:D49 owner ruling 2026-10-22 (capability in every
|
||||
pane; native git tools)'.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"Build the owner's D49 doctrine — capability in every pane: (1) "
|
||||
"make ToolsetFor expose the full tool suite (read family + write "
|
||||
"family) in every mode so CHAT and PLAN carry write_file, "
|
||||
"edit_file and run_command like TASK does; (2) retire "
|
||||
"ExecuteGatedTool's write-refusal-by-mode so writes execute in any "
|
||||
"mode while keeping the dispatch-gate seam and the typed refusal "
|
||||
"for genuinely-unavailable tools; (3) state the write availability "
|
||||
"in the tool descriptions the wire carries so the model knows its "
|
||||
"shell and file abilities without asking; (4) add a native git "
|
||||
"tool family — git_status, git_diff, git_log, git_branch, "
|
||||
"git_commit, git_add — implemented by shelling out to git in the "
|
||||
"repo root through the DefaultRepoRoot seam, parsing porcelain "
|
||||
"output honestly, returning typed JSON, and refusing banned "
|
||||
"landing-law paths on git_add and git_commit; (5) re-pin the "
|
||||
"mode/toolset tests to the new doctrine (CHAT carries the full "
|
||||
"suite) red-first and keep the runecore package -race green"
|
||||
)
|
||||
AFFECTED = [
|
||||
"src/go/rune-core/",
|
||||
"scripts/admit_wave_d49_capability_everywhere.py",
|
||||
]
|
||||
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-d49-capability-everywhere",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-d49-capability-everywhere",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"owner ruling D49 2026-10-22 (verbatim in session notes): "
|
||||
"capability in every pane, work promotes to the task pane, "
|
||||
"native git tools",
|
||||
"src/go/rune-core/internal/runecore/tools.go (the "
|
||||
"mode-gated toolset this wave supersedes)",
|
||||
"commit b35078bb (task channel inherits TASK semantics)",
|
||||
"scripts/check_landing.py rule 4 SWEEP_RACE_BANNED_PATHS "
|
||||
"(the landing-law banned-path set git_add/git_commit "
|
||||
"refuse)",
|
||||
"scripts/admit_wave_presentation.py (the admission "
|
||||
"pattern)",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-d49-capability-everywhere")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-d49-capability-everywhere",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-d49-capability-everywhere",
|
||||
expected_new_entities=[
|
||||
"src/go/rune-core/internal/runecore (ToolsetFor full "
|
||||
"suite in every mode; ExecuteGatedTool write-refusal "
|
||||
"retired with the dispatch-gate seam kept; wire tool "
|
||||
"descriptions state write availability)",
|
||||
"src/go/rune-core/internal/runecore/gittools.go (the "
|
||||
"native git family: git_status, git_diff, git_log, "
|
||||
"git_branch, git_commit, git_add — stdlib git subprocess "
|
||||
"in the repo root, porcelain parsed honestly, typed JSON "
|
||||
"results, landing-law banned-path refusals)",
|
||||
"tests: red-first re-pins of the mode/toolset suites to "
|
||||
"CHAT=full-suite + per-tool git fixture tests, -race "
|
||||
"green",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"every pane's model sees and can execute the write family "
|
||||
"and the git family; work-shaped activity still promotes "
|
||||
"to the tasks pane via the consent card (organization, "
|
||||
"not permission)",
|
||||
"the model can connect to git projects natively: status, "
|
||||
"diff, log, branch, add and commit as first-class typed "
|
||||
"tool results",
|
||||
"the landing-law banned paths never enter a git tool "
|
||||
"staged tree or commit",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race green for the whole runecore package "
|
||||
"(including the cloud wires); go vet + gofmt clean",
|
||||
"red-first evidence: the re-pinned suites fail against "
|
||||
"the pre-wave toolset before the implementation lands",
|
||||
"commit(s) name this contract; pre-commit staged gate "
|
||||
"green via this open contract",
|
||||
],
|
||||
approval_ref="user:D49 owner ruling 2026-10-22 (capability in "
|
||||
"every pane; native git tools)",
|
||||
contract_id="ADMIT-wave-d49-capability-everywhere",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
|
||||
if __name__ == "__main__":
|
||||
raise SystemExit(main())
|
||||
@@ -0,0 +1,110 @@
|
||||
"""Admission dispatch for wave D50-residuals (land the four items the
|
||||
presentation wave left out, Gitea #2560).
|
||||
|
||||
classify + activate + admit (the headless scaffolding entry law): the
|
||||
D50-residuals build on the existing rune project, user-dispatch approved.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"land the D50-residual wave (Gitea #2560, D51 round folded): (1) "
|
||||
"msg_id linkage — tasks-pane work-stream records carry the "
|
||||
"spawning chat msg_id (msg ids exist core-side per newMsgID), "
|
||||
"rendered as a dim ↩ reference in the work block; (2) phantom-row "
|
||||
"filter — filter stale queue rows by the freshness law (the "
|
||||
"30-min occupancy pattern) in the tasks pane, read-side in the "
|
||||
"TUI; (3) enter-steal removal — remove the tasks-pane "
|
||||
"row-selection walker entirely; enter on tasks-pane focus starts "
|
||||
"direct task execution (D44 doctrine); (4) pinned work — reserved "
|
||||
"pinned area at the top of the tasks pane with a pin icon and "
|
||||
"'pinned' label, each pin carrying a plain-english summary, click "
|
||||
"opens the outstanding pinned work view, pins persist across "
|
||||
"boots via the hot-state store pattern; the tasks pane renders "
|
||||
"blank otherwise with no selectable rows; (5) dynamic reflow — "
|
||||
"bubbles/boxes re-wrap on window resize (nothing clips)"
|
||||
)
|
||||
AFFECTED = [
|
||||
"tui/",
|
||||
"src/go/rune-core/internal/runecore/record.go",
|
||||
"src/go/rune-core/internal/runecore/store.go",
|
||||
"scripts/admit_wave_d50_residuals.py",
|
||||
]
|
||||
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-d50-residuals",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-d50-residuals",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"store/scaffold/docs/ADMIT-wave-d46-live-defects.md",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/tasks/render.go",
|
||||
"tui/cmd/rune-tui/selection.go",
|
||||
"scripts/admit_wave_rebase_tui_wiring.py",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-d50-residuals")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-d50-residuals",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-d50-residuals",
|
||||
expected_new_entities=[
|
||||
"the D50-residuals wave report (reports/)",
|
||||
"the pinned-work hot-state store + tests",
|
||||
"red-first enter-dispatch and phantom-filter tests",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"tasks-pane work blocks show a dim ↩ msg_id reference; "
|
||||
"phantom queue rows are filtered; tasks-focus enter "
|
||||
"dispatches directly; pinned work persists across boots",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race ./... in tui/ green",
|
||||
"build/vet/gofmt clean",
|
||||
"PTY proofs for enter-dispatch and pin persistence",
|
||||
],
|
||||
approval_ref="user:D50-residual directive 2026-10-22",
|
||||
contract_id="ADMIT-wave-d50-residuals",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,112 @@
|
||||
"""Admission dispatch for wave D52 (Gitea #2566 + #2567 — the
|
||||
seed-substrate leak, the wave animation, the dead + click, and the
|
||||
model-token picker window).
|
||||
|
||||
classify + activate + admit (the headless scaffolding entry law): the
|
||||
D52 wave builds on the existing rune project, user-dispatch approved.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"land the D52 wave (Gitea #2566 + #2567): (1) seed-substrate leak "
|
||||
"— production TUI faces boot EMPTY: tasks.New/NewPromote start "
|
||||
"with no lab tree/suggestion fixtures and an honest idle render "
|
||||
"('no outstanding work'); SetLiveTree/Offer fill them when real "
|
||||
"data arrives; the seeds stay confined to the lab harness; (2) "
|
||||
"wave animation — the activity word animates per-letter as a WAVE "
|
||||
"(rise, settle, sequential to the last letter, then reverse, "
|
||||
"looping), smooth multi-frame rise, vibrant colours + rainbow "
|
||||
"sweep on the moving letter, per-activity palette kept; (3) the "
|
||||
"+ affordance click fix — the styled + padded by byte length so "
|
||||
"the glyph rendered left of its declared region; region and "
|
||||
"render share one width constant, plus a debuggable region→glyph "
|
||||
"assertion; (4) the model-token click opens the centered "
|
||||
"searchable picker window split CLOUD/LOCAL, no crossfire with "
|
||||
"the activity window; ctrl+m parity kept"
|
||||
)
|
||||
AFFECTED = [
|
||||
"tui/",
|
||||
"scripts/admit_wave_d52_seedleak_animation.py",
|
||||
]
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-d52-seedleak-animation",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-d52-seedleak-animation",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"tui/tasks/tasks.go",
|
||||
"tui/tasks/face.go",
|
||||
"tui/promote/promote.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/lanes/render.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"scripts/admit_wave_d50_residuals.py",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-d52-seedleak-animation")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-d52-seedleak-animation",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-d52-seedleak-animation",
|
||||
expected_new_entities=[
|
||||
"the D52 wave report (reports/)",
|
||||
"the red-first seed-leak/wave/click-map/picker-window tests",
|
||||
"the honest-empty boot chain (semantic.Empty → lanes/rail/"
|
||||
"promote/tasks empty constructors)",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"production faces boot empty ('no outstanding work'), the "
|
||||
"activity word waves per-letter with reverse loop and "
|
||||
"vibrant mover, the + click lands on the rendered glyph, "
|
||||
"the model-token click opens the CLOUD/LOCAL picker window",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race ./... in tui/ green (documented pre-existing "
|
||||
"boot-smoke PTY family aside)",
|
||||
"build/vet/gofmt clean",
|
||||
"PTY proofs: empty boot, + glyph click opens the window, "
|
||||
"model-token click opens the picker (no crossfire)",
|
||||
],
|
||||
approval_ref="user:D52 directive 2026-10-23 (Gitea #2566, #2567)",
|
||||
contract_id="ADMIT-wave-d52-seedleak-animation",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,114 @@
|
||||
"""Admission dispatch for wave D54 neurodivergent-presentation.
|
||||
|
||||
classify + activate + admit (the headless scaffolding entry law,
|
||||
scripts/admit_wave_rebase_tui_wiring.py pattern): the D54
|
||||
neurodivergent-presentation build on the existing rune project,
|
||||
user-dispatch approved.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"implement the neurodivergent-presentation mechanical map "
|
||||
"(research/factory-nuerodivergent-presentation/synthesis.md, "
|
||||
"Gitea #2571): the motion law (motionAllowed gate on the activity "
|
||||
"wave, never-animate law on the chat pane, one-animating-region-"
|
||||
"per-frame in the face chain), the colour-token law (role enum in "
|
||||
"tui/themes, one hex per role, contrast >=4.5:1 unit test, Faint-"
|
||||
"on-dim fix), the spacing law (one blank line between blocks, "
|
||||
"blocks never merge), summary-first rendering (one-line plain-"
|
||||
"english summary box for long answers), the calm-mode sensory "
|
||||
"setting (vivid|calm, default vivid — calm mutes chroma at the "
|
||||
"token layer and sets motionAllowed false), and the literal-"
|
||||
"language audit of face strings"
|
||||
)
|
||||
AFFECTED = [
|
||||
"tui/lanes/activity.go",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/chatpane/scroll_test.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/settings/settings.go",
|
||||
"tui/themes/theme.go",
|
||||
"tui/themes/roles.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"scripts/admit_wave_d54_nd_presentation.py",
|
||||
]
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-d54-nd-presentation",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-d54-nd-presentation",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"research/factory-nuerodivergent-presentation/synthesis.md",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/themes/theme.go",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-d54-nd-presentation")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-d54-nd-presentation",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-d54-nd-presentation",
|
||||
expected_new_entities=[
|
||||
"the colour-role enum in tui/themes (one hex per role)",
|
||||
"the sensory (vivid|calm) setting key in the settings store",
|
||||
"the motion-allowed gate on the activity wave",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"calm mode mutes chroma tokens and stops the activity wave; "
|
||||
"long answers open with a one-line plain-english summary; "
|
||||
"face strings read literally",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race -short ./... in tui/ green (documented "
|
||||
"pre-existing PTY boot family aside)",
|
||||
"go vet + gofmt clean in tui/",
|
||||
"contrast unit test >=4.5:1 body text, dim tier floor "
|
||||
"verified (Faint-on-dim breach fixed)",
|
||||
],
|
||||
approval_ref="user:D54 dispatch 2026-10-23 (Gitea #2571)",
|
||||
contract_id="ADMIT-wave-d54-nd-presentation",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,165 @@
|
||||
"""Admission dispatch for the DISPATCH CLASSIFIER wave (the owner's
|
||||
mechanism-not-law directive: "can we have something that intelligently
|
||||
decides that so i dont have to specify").
|
||||
|
||||
Builds src/go/dispatch-classifier — a zero-dependency (stdlib-only) Go
|
||||
module that decides solo-attention vs parallel-factory vs queue for
|
||||
each incoming wave so the owner never specifies: (1) REGISTRY —
|
||||
~/.rune/hot/dispatch_registry.json hot-state entries {agent_id,
|
||||
surfaces, kind, since, owner_origin} with lock/unlock/show CLI
|
||||
subcommands and 4h STALE flagging + --prune; (2) CLASSIFY —
|
||||
`classify --brief <file> [--paths p1,p2] [--owner-origin] [--apply]`:
|
||||
extract candidate surface prefixes (explicit paths win, else brief
|
||||
paths, else keyword→surface heuristics kept in ONE data-driven map),
|
||||
compute prefix overlap vs the registry's locked surfaces, and emit the
|
||||
verdict QUEUE-BEHIND (PRIORITY-QUEUE when owner-origin; lock-holder
|
||||
yields at next landing boundary) / SOLO (owner watching, latency wins)
|
||||
/ PARALLEL (multiple disjoint surfaces with a suggested split) / SOLO;
|
||||
--apply takes the lock atomically, fail-loud on stale/locked; (3)
|
||||
TESTS — red-first per rule: overlap detection, owner-origin priority,
|
||||
multi-surface split suggestion, lock/unlock lifecycle, stale-lock
|
||||
handling, prefix-vs-exact matching; go test -race green, vet/gofmt
|
||||
clean; (4) DISCIPLINE WIRING — scripts/dispatch_check.sh, the one-liner
|
||||
wrapper the session agent runs before spawning anything, documented in
|
||||
the module README in plain English.
|
||||
approval_ref 'user:dispatch classifier directive 2026-10-22'.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"Build the DISPATCH CLASSIFIER: create the self-contained stdlib-only "
|
||||
"Go module src/go/dispatch-classifier that decides solo-attention vs "
|
||||
"parallel-factory vs queue for each incoming wave so the owner never "
|
||||
"specifies — implement the hot-state registry "
|
||||
"~/.rune/hot/dispatch_registry.json with lock/unlock/show subcommands "
|
||||
"(entries {agent_id, surfaces, kind, since, owner_origin}; entries "
|
||||
"older than 4h flagged STALE in show with a --prune flag), implement "
|
||||
"classify --brief <file> [--paths p1,p2] [--owner-origin] [--apply] "
|
||||
"that extracts candidate surface prefixes (explicit paths win, else "
|
||||
"brief-named repo-relative paths, else keyword→surface heuristics "
|
||||
"kept in one data-driven map), computes prefix overlap against the "
|
||||
"registry's locked surfaces, and emits the JSON verdict "
|
||||
"{decision, reason, surfaces, locks_to_take, queue_behind} — "
|
||||
"QUEUE-BEHIND naming the agent and surface when any candidate "
|
||||
"surface is locked by an in-flight agent (PRIORITY-QUEUE on "
|
||||
"owner-origin, noting the lock-holder yields at its next landing "
|
||||
"boundary), SOLO when owner-origin (full-attention lane, latency "
|
||||
"wins), PARALLEL with a suggested split when the brief names "
|
||||
"multiple disjoint surfaces, else SOLO — with --apply taking the "
|
||||
"lock atomically and failing loud on stale/locked; add red-first "
|
||||
"tests per rule (overlap detection, owner-origin priority, "
|
||||
"multi-surface split suggestion, lock/unlock lifecycle, stale-lock "
|
||||
"handling, prefix-vs-exact matching) green under go test -race with "
|
||||
"vet and gofmt clean; add scripts/dispatch_check.sh, the one-liner "
|
||||
"wrapper the session agent runs before spawning anything (reads the "
|
||||
"brief, runs classify, prints the verdict, locks with --apply), and "
|
||||
"document usage in the module README in plain English"
|
||||
)
|
||||
AFFECTED = [
|
||||
"src/go/dispatch-classifier/",
|
||||
"scripts/admit_wave_dispatch_classifier.py",
|
||||
"scripts/dispatch_check.sh",
|
||||
]
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-dispatch-classifier",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-dispatch-classifier",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"src/go/failure-filer (stdlib-only module pattern: go.mod, "
|
||||
"main.go, flat package, *_test.go)",
|
||||
"~/.rune/hot/ hot-state file convention (task_state.json in "
|
||||
"src/go/webfeed/internal/webfeed/server.go:390)",
|
||||
"scripts/check_landing.py rule-5 scope matcher (_scope_covers "
|
||||
"prefix law — reused for registry surface overlap)",
|
||||
"scripts/admit_wave_presentation.py (this admission pattern)",
|
||||
"scripts/dispatch_check.sh discipline wrapper (new)",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-dispatch-classifier")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-dispatch-classifier",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-dispatch-classifier",
|
||||
expected_new_entities=[
|
||||
"src/go/dispatch-classifier (stdlib-only Go module: go.mod, "
|
||||
"main.go, registry.go, classify.go, README.md)",
|
||||
"src/go/dispatch-classifier (hot-state registry "
|
||||
"~/.rune/hot/dispatch_registry.json: lock/unlock/show, "
|
||||
"atomic writes, 4h STALE flagging + --prune)",
|
||||
"src/go/dispatch-classifier (classify: surface extraction — "
|
||||
"explicit paths, brief parsing, one data-driven keyword map; "
|
||||
"prefix overlap vs locked surfaces; QUEUE-BEHIND / "
|
||||
"PRIORITY-QUEUE / SOLO / PARALLEL verdicts with suggested "
|
||||
"split; --apply takes the lock atomically, fail-loud)",
|
||||
"src/go/dispatch-classifier (red-first tests per rule: "
|
||||
"overlap, owner-origin priority, split suggestion, "
|
||||
"lock/unlock lifecycle, stale handling, prefix-vs-exact; "
|
||||
"go test -race green, vet + gofmt clean)",
|
||||
"scripts/dispatch_check.sh (session-agent pre-spawn "
|
||||
"discipline wrapper: read brief, classify, print verdict, "
|
||||
"--apply locks)",
|
||||
"tests: red-first suites per rule, -race green",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"an agent can lock/unlock its surfaces in the hot registry "
|
||||
"and show prints the table with STALE flags for entries "
|
||||
"older than 4h; --prune removes stale entries",
|
||||
"classify reads a brief and returns the verdict JSON "
|
||||
"without the owner specifying the mode; overlap with an "
|
||||
"in-flight lock queues behind the named agent; owner-origin "
|
||||
"wins latency (SOLO) or jumps the queue (PRIORITY-QUEUE); "
|
||||
"disjoint multi-surface briefs suggest a parallel split",
|
||||
"the session agent runs scripts/dispatch_check.sh before "
|
||||
"spawning anything and follows the printed verdict",
|
||||
],
|
||||
verification_obligations=[
|
||||
"cd src/go/dispatch-classifier && go test ./... -race green; "
|
||||
"go vet ./... clean; gofmt -l . empty",
|
||||
"CLI proofs: lock/unlock/show lifecycle, stale flagging + "
|
||||
"prune, classify verdicts for overlap/owner-origin/split "
|
||||
"cases, --apply lock take + fail-loud on stale/locked",
|
||||
"scripts/dispatch_check.sh round-trip on a real brief file",
|
||||
],
|
||||
approval_ref="user:dispatch classifier directive 2026-10-22",
|
||||
contract_id="ADMIT-wave-dispatch-classifier",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
|
||||
if __name__ == "__main__":
|
||||
raise SystemExit(main())
|
||||
@@ -0,0 +1,139 @@
|
||||
"""Admission dispatch for wave retire-reconcile-tools (Gitea #2574
|
||||
rebalanced overnight queue, wave A; retirement-map blocker closure from
|
||||
wave 181's model-routing-integrated.json blocks_full_switchover note).
|
||||
|
||||
classify + activate + admit (the headless scaffolding entry law,
|
||||
scripts/admit_wave_memory_continuity_go.py pattern): port the
|
||||
capability-floor drift reconciliation (reconcile_tools_support,
|
||||
src/rune/model_routing.py — the R2 I-R2-022 truth_drift seam whose
|
||||
missing Go surface blocked local_tool_runtime.py from dropping its
|
||||
Python import) into the existing Go engine src/go/model_routing (new
|
||||
ReconcileToolsSupport + `eval reconcile` surface), keep the Python body
|
||||
as oracle/escape hatch (RUNE_MODEL_ROUTING_ENGINE=python, NO Python
|
||||
deletion — PORT → INTEGRATE → REMOVE), switch the function to a
|
||||
fail-loud delegation facade (typed RuntimeError when the engine binary
|
||||
is missing), and pin the port with a red-first parity battery
|
||||
(tests/test_reconcile_tools_support_port.py) against the Python oracle.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"Close the wave-181 full-switchover blocker: Go port of the "
|
||||
"capability-floor drift reconciliation (reconcile_tools_support, "
|
||||
"R2 I-R2-022 truth_drift) absorbed into the existing "
|
||||
"src/go/model_routing engine (ReconcileToolsSupport + `eval "
|
||||
"reconcile`); a provider tool-support claim contradicting "
|
||||
"CAPABILITY_FLOOR surfaces as unverified drift, never silently "
|
||||
"flipping eligibility; non-floor models are never invented a floor "
|
||||
"verdict. Python body stays as oracle/escape hatch "
|
||||
"(RUNE_MODEL_ROUTING_ENGINE=python) — no Python deletion; the "
|
||||
"function becomes a fail-loud delegation facade (typed RuntimeError "
|
||||
"when the engine binary is missing, RUNE_MODEL_ROUTING_BIN "
|
||||
"override); red-first parity battery "
|
||||
"tests/test_reconcile_tools_support_port.py pins Go to the Python "
|
||||
"oracle byte-for-byte; local_tool_runtime consumer keeps its seam "
|
||||
"but now resolves through Go at runtime"
|
||||
)
|
||||
AFFECTED = [
|
||||
"src/go/model_routing/",
|
||||
"src/rune/model_routing.py",
|
||||
"src/rune/local_tool_runtime.py",
|
||||
"tests/test_reconcile_tools_support_port.py",
|
||||
"verification/integrated/model-routing-integrated.json",
|
||||
"verification/integrated/reconcile-tools-integrated.json",
|
||||
"scripts/admit_wave_retire_reconcile_tools.py",
|
||||
]
|
||||
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-retire-reconcile-tools",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-retire-reconcile-tools",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"verification/integrated/model-routing-integrated.json",
|
||||
"src/rune/model_routing.py",
|
||||
"src/rune/local_tool_runtime.py",
|
||||
"src/go/model_routing/eval.go",
|
||||
"tests/test_p1_06_model_routing.py",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-retire-reconcile-tools")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-retire-reconcile-tools",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-retire-reconcile-tools",
|
||||
expected_new_entities=[
|
||||
"src/go/model_routing/reconcile.go (Go port of "
|
||||
"reconcile_tools_support over CapabilityFloor)",
|
||||
"src/go/model_routing/reconcile_test.go (red-first Go parity "
|
||||
"battery mirrored from the Python oracle corpus)",
|
||||
"src/go/model_routing `eval reconcile` surface (eval.go)",
|
||||
"tests/test_reconcile_tools_support_port.py (Python-side "
|
||||
"parity battery: go delegation == python oracle "
|
||||
"byte-for-byte; fail-loud binary-missing refusal; "
|
||||
"local_tool_runtime consumer receipt)",
|
||||
"verification/integrated/reconcile-tools-integrated.json "
|
||||
"(integrated receipt)",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"a provider supports_tools claim contradicting "
|
||||
"CAPABILITY_FLOOR surfaces as an unverified drift marker "
|
||||
"and never silently flips eligibility",
|
||||
"reconcile_tools_support resolves through the Go engine by "
|
||||
"default; RUNE_MODEL_ROUTING_ENGINE=python pins the oracle "
|
||||
"body; a missing engine binary raises a typed RuntimeError "
|
||||
"(no silent Python fallback)",
|
||||
"local_tool_runtime's capability-drift seam now executes Go "
|
||||
"at runtime while the Python module stays as oracle",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race -short ./... in src/go/model_routing green",
|
||||
"pytest tests/test_reconcile_tools_support_port.py "
|
||||
"tests/test_p1_06_model_routing.py "
|
||||
"tests/test_local_tool_runtime.py green",
|
||||
],
|
||||
approval_ref="user:gitea #2574 rebalanced overnight queue, wave A "
|
||||
"(majority-rebase) 2026-10-24",
|
||||
contract_id="ADMIT-wave-retire-reconcile-tools",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,132 @@
|
||||
"""Admission dispatch for wave retire-tool-executor (Gitea #2575
|
||||
rebalanced overnight queue, wave B): wire local_tool_runtime.py to the
|
||||
Go tool-executor engine.
|
||||
|
||||
classify + activate + admit (headless scaffolding entry law,
|
||||
scripts/admit_wave_retire_reconcile_tools.py pattern): the Go executor
|
||||
exists (src/go/tool-executor, full CLI surface read_file/list_directory/
|
||||
glob_files/grep_files/run_command, JSON envelope {success,result,error})
|
||||
but src/rune/local_tool_runtime.py never delegates to it. This wave wires
|
||||
the fail-loud delegation facade (LocalToolRuntime's executor resolves the
|
||||
four READ-ONLY ops through the Go binary by default; run_command stays
|
||||
behind the Python approval door — mutating, never silently executed),
|
||||
keeps the Python bodies as oracle/escape hatch
|
||||
(RUNE_TOOL_EXECUTOR_ENGINE=python, NO Python deletion — PORT → INTEGRATE
|
||||
→ REMOVE), and pins the port with a red-first parity battery
|
||||
(tests/test_tool_executor_delegation.py) against the Python oracle.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"Close the wave-181 full-switchover blocker: Go port of the local "
|
||||
"tool execution — wire local_tool_runtime.py to the existing "
|
||||
"src/go/tool-executor engine. LocalToolRuntime executor becomes "
|
||||
"a fail-loud delegation facade: the four read-only file ops "
|
||||
"(read_file, directory enumeration, glob, grep) resolve through "
|
||||
"the Go binary by default, JSON envelope preserved exactly; "
|
||||
"run_command stays behind the approval door (mutating, never "
|
||||
"silently executed). Python bodies stay as oracle escape hatch "
|
||||
"(RUNE_TOOL_EXECUTOR_ENGINE=python, RUNE_TOOL_EXECUTOR_BIN "
|
||||
"override, typed RuntimeError when the binary is missing — no "
|
||||
"silent fallback, no Python deletion; PORT → INTEGRATE → REMOVE). "
|
||||
"Red-first parity battery tests/test_tool_executor_delegation.py "
|
||||
"pins Go to the Python oracle envelope-for-envelope"
|
||||
)
|
||||
AFFECTED = [
|
||||
"src/go/tool-executor/",
|
||||
"src/rune/local_tool_runtime.py",
|
||||
"tests/test_tool_executor_delegation.py",
|
||||
"tests/test_local_tool_runtime.py",
|
||||
"tests/test_p0_05_native_tools.py",
|
||||
"tests/test_mode_dispatch_gate.py",
|
||||
"verification/integrated/tool-executor-integrated.json",
|
||||
"scripts/admit_wave_retire_tool_executor.py",
|
||||
]
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-retire-tool-executor",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-retire-tool-executor",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"src/go/tool-executor/internal/toolexec/cli.go",
|
||||
"src/rune/local_tool_runtime.py",
|
||||
"src/rune/tool_executor.py",
|
||||
"tests/test_tool_executor_delegation.py",
|
||||
"verification/integrated/reconcile-tools-integrated.json",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-retire-tool-executor")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-retire-tool-executor",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-retire-tool-executor",
|
||||
expected_new_entities=[
|
||||
"tests/test_tool_executor_delegation.py (red-first parity "
|
||||
"battery: Go delegation == Python oracle envelope-for-"
|
||||
"envelope; fail-loud binary-missing refusal; run_command "
|
||||
"never delegates; default-is-go pin)",
|
||||
"verification/integrated/tool-executor-integrated.json "
|
||||
"(integrated receipt, soak clock before any Python deletion)",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"LocalToolRuntime's executor resolves read_file, "
|
||||
"list_directory, glob_files and grep_files through the Go "
|
||||
"tool-executor binary by default; envelopes preserved "
|
||||
"exactly",
|
||||
"RUNE_TOOL_EXECUTOR_ENGINE=python pins the oracle path; "
|
||||
"a missing engine binary raises a typed RuntimeError (no "
|
||||
"silent Python fallback)",
|
||||
"run_command dispatches through the Python authority path "
|
||||
"only (approval door preserved, no Go bypass)",
|
||||
],
|
||||
verification_obligations=[
|
||||
"go test -race -short ./... in src/go/tool-executor green",
|
||||
"pytest tests/test_tool_executor_delegation.py "
|
||||
"tests/test_local_tool_runtime.py tests/test_p0_05_native_tools.py "
|
||||
"tests/test_mode_dispatch_gate.py tests/test_context_broker.py "
|
||||
"green",
|
||||
],
|
||||
approval_ref="user:gitea #2575 rebalanced overnight queue, wave B "
|
||||
"2026-10-24",
|
||||
contract_id="ADMIT-wave-retire-tool-executor",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,127 @@
|
||||
"""Admission dispatch for the streaming-deadline ROOT-CAUSE wave (Gitea
|
||||
#2556 — the owner verdict: 'context deadline needs a proper solution we
|
||||
have just been patching around it rather than making the root cause
|
||||
better for local models').
|
||||
|
||||
classify + activate + admit (the headless scaffolding entry law): the
|
||||
wave replaces the flat whole-turn budgets (330s -> 480s -> 6x480s, the
|
||||
D46/D47 lineage) with STREAMING through the whole chain — Ollama wire,
|
||||
cloud wires, core /v1/chat/completions, entry proxy, TUI render — so a
|
||||
turn never sits inside one blocking HTTP call; the deadline collapses
|
||||
to an INTER-CHUNK IDLE TIMEOUT (no bytes = dead) with a generous
|
||||
overall backstop. Budget constants retire to non-streaming fallback
|
||||
paths only.
|
||||
"""
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from rune import construction_activation as cact # noqa: E402
|
||||
from rune import construction_admission as cadm # noqa: E402
|
||||
from rune import construction_mode as cmode # noqa: E402
|
||||
from rune import scaffold as sc # noqa: E402
|
||||
|
||||
ROOT = os.path.join(os.path.dirname(__file__), "..")
|
||||
|
||||
OBJECTIVE = (
|
||||
"land the streaming root-cause wave (Gitea #2556, owner verdict "
|
||||
"2026-10-22): stream through the WHOLE turn chain so a local 27B "
|
||||
"thinking turn never sits inside one blocking HTTP call — (1) the "
|
||||
"Ollama wire runs stream=true /api/chat with NDJSON chunks parsed "
|
||||
"incrementally (content/thinking/tool_calls; the final message "
|
||||
"object carries the assembled reply) and the engine's bounded tool "
|
||||
"loop runs over streamed replies; (2) the cloud wires gain "
|
||||
"streaming parity ([OI]-compat SSE, Anthropic SSE events, Gemini "
|
||||
"streamGenerateContent); (3) the core /v1/chat/completions relays "
|
||||
"the streamed turn as NDJSON chunks for stream=true callers while "
|
||||
"non-streaming callers get the assembled answer as before; (4) the "
|
||||
"entry proxy passes the stream through and the TUI renders text as "
|
||||
"it arrives; (5) on streamed paths the whole-turn budgets retire — "
|
||||
"replaced by an inter-chunk idle timeout (default 120s, "
|
||||
"RUNE_STREAM_IDLE_TIMEOUT configurable) plus a 30-minute overall "
|
||||
"backstop; the budget constants remain only for non-streaming "
|
||||
"fallback paths"
|
||||
)
|
||||
AFFECTED = [
|
||||
"src/go/rune-core/internal/runecore/",
|
||||
"src/go/rune-entry/",
|
||||
"tui/runtime/lib/",
|
||||
"tui/cmd/rune-tui/",
|
||||
"scripts/admit_wave_streaming_deadline_root.py",
|
||||
]
|
||||
|
||||
def main() -> int:
|
||||
store = os.path.join(ROOT, "store", "scaffold")
|
||||
scaffold = sc.Scaffold(store, "rune")
|
||||
|
||||
md = cmode.classify_mode(
|
||||
OBJECTIVE,
|
||||
target_project="rune",
|
||||
project_exists=True,
|
||||
affected_surface=AFFECTED,
|
||||
)
|
||||
print("classified mode:", md.mode)
|
||||
|
||||
need = {
|
||||
"need_id": "need-wave-streaming-deadline-root",
|
||||
"objective": OBJECTIVE,
|
||||
"origin": "worker",
|
||||
"project": "rune",
|
||||
"task_ref": "wave-streaming-deadline-root",
|
||||
"affected_surface": AFFECTED,
|
||||
"evidence_refs": [
|
||||
"src/go/rune-core/internal/runecore/ollama.go",
|
||||
"src/go/rune-core/internal/runecore/cloud.go",
|
||||
"src/go/rune-core/internal/runecore/server.go",
|
||||
"src/go/rune-entry/internal/entry/serve.go",
|
||||
"tui/runtime/lib/complete.go",
|
||||
"tui/laneconc/laneconc.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"scripts/admit_wave_terminal_budgets.py",
|
||||
],
|
||||
}
|
||||
act = cact.activate(md, need=need, scaffold=scaffold,
|
||||
builder="wave-streaming-deadline-root")
|
||||
print("activated:", act.get("activated"), act.get("mode"))
|
||||
|
||||
env = cadm.admit(
|
||||
act,
|
||||
objective=OBJECTIVE,
|
||||
builder="wave-streaming-deadline-root",
|
||||
affected_surface=AFFECTED,
|
||||
evidence_refs=need["evidence_refs"],
|
||||
origin="worker",
|
||||
task_ref="wave-streaming-deadline-root",
|
||||
expected_new_entities=[
|
||||
"the streaming root-cause wave report (reports/)",
|
||||
"the red-first streaming chain tests (ollama NDJSON, cloud "
|
||||
"SSE, core stream relay, entry pass-through, TUI "
|
||||
"render-as-it-arrives, idle-timeout simulation)",
|
||||
"the inter-chunk idle timeout + 30-minute backstop on "
|
||||
"streamed paths (budgets retire to fallback)",
|
||||
],
|
||||
expected_runtime_effects=[
|
||||
"a local 27B thinking turn streams tokens continuously "
|
||||
"through core, entry proxy and TUI with no flat deadline; "
|
||||
"a genuinely dead model trips the idle timeout",
|
||||
],
|
||||
verification_obligations=[
|
||||
"-short race suites green on touched Go modules (the "
|
||||
"documented PTY family aside)",
|
||||
"full-chain simulation: a fake slow model emitting chunks "
|
||||
"across a long window completes the turn with no deadline "
|
||||
"fire; a silent model trips the idle timeout",
|
||||
"vet/gofmt clean",
|
||||
],
|
||||
approval_ref="user:streaming root-cause wave directive 2026-10-23 (Gitea #2556)",
|
||||
contract_id="ADMIT-wave-streaming-deadline-root",
|
||||
project_store=store,
|
||||
project_id="rune",
|
||||
)
|
||||
print(json.dumps(env, indent=2, default=str)[:2400])
|
||||
return 0 if env.get("success") else 1
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
Executable
+28
@@ -0,0 +1,28 @@
|
||||
#!/bin/sh
|
||||
# dispatch_check.sh — the session agent's pre-spawn discipline.
|
||||
#
|
||||
# Run this before spawning ANY wave. It reads the brief file, asks the
|
||||
# dispatch-classifier for the verdict, and prints it. Follow it:
|
||||
# SOLO spawn one agent, full attention
|
||||
# PARALLEL spawn one lane per suggested split surface
|
||||
# QUEUE-BEHIND do NOT spawn onto those surfaces yet
|
||||
# PRIORITY-QUEUE owner wave: the lock-holder yields at its next
|
||||
# landing boundary; wait for it, then go
|
||||
#
|
||||
# Usage:
|
||||
# scripts/dispatch_check.sh <brief-file> [--paths p1,p2] [--owner-origin]
|
||||
# scripts/dispatch_check.sh <brief-file> --apply [--agent X]
|
||||
#
|
||||
# --apply takes the lock for you (fails loud if anything is locked or
|
||||
# stale — prune with `dispatch-classifier show --prune`). Every exit 0
|
||||
# prints the verdict JSON on stdout; exit 1 means do not spawn.
|
||||
set -e
|
||||
repo_root=$(CDPATH= cd -- "$(dirname -- "$0")/.." && pwd)
|
||||
brief=$1
|
||||
if [ -z "$brief" ]; then
|
||||
echo "usage: $0 <brief-file> [--paths p1,p2] [--owner-origin] [--apply]" >&2
|
||||
exit 2
|
||||
fi
|
||||
shift
|
||||
cd "$repo_root/src/go/dispatch-classifier"
|
||||
exec go run . classify --brief "$brief" "$@"
|
||||
+18
-3
@@ -69,21 +69,33 @@ def _git(args: list[str], repo: Path | None = None, check: bool = True) -> subpr
|
||||
)
|
||||
|
||||
|
||||
def latest_release_tag(repo: Path | None = None) -> str | None:
|
||||
def latest_release_tag(repo: Path | None = None, namespace: str = "main") -> str | None:
|
||||
"""Highest release tag (e.g. ``v0.314.0``), or None when there are none.
|
||||
|
||||
Namespace-aware (#2582): the repo carries TWO tag namespaces that share
|
||||
the version sort — the main line (``v*``) and the TUI build line
|
||||
(``tui-v*``). The default resolves the MAIN line: the release-body
|
||||
readers live there, and a TUI tag cut minutes before the main release
|
||||
used to capture the range lookup and blank the release note ("No
|
||||
substantive changes" on a 21-commit day, v0.346.0).
|
||||
|
||||
SIGPIPE-free: ``git for-each-ref --count=1`` stops INSIDE git — there is
|
||||
no downstream pipe for git to receive EPIPE on, so the step cannot die
|
||||
with 141 the way ``git tag --sort=-v:refname | head -1`` did (runs
|
||||
29929/30435/30636).
|
||||
"""
|
||||
prefix = {
|
||||
"main": "v",
|
||||
"tui": "tui-v",
|
||||
"any": "",
|
||||
}[namespace]
|
||||
proc = _git(
|
||||
[
|
||||
"for-each-ref",
|
||||
"--count=1",
|
||||
"--sort=-v:refname",
|
||||
"--format=%(refname:short)",
|
||||
"refs/tags",
|
||||
f"refs/tags/{prefix}*",
|
||||
],
|
||||
repo,
|
||||
check=False,
|
||||
@@ -257,6 +269,9 @@ def main(argv: list[str] | None = None) -> int:
|
||||
parser = argparse.ArgumentParser(description="Release tag convergence repair")
|
||||
parser.add_argument("--latest-tag", action="store_true",
|
||||
help="print the highest release tag (SIGPIPE-free) and exit")
|
||||
parser.add_argument("--namespace", default="main", choices=("main", "tui", "any"),
|
||||
help="tag namespace for --latest-tag (#2582): main => v*, "
|
||||
"tui => tui-v*, any => both — default main")
|
||||
parser.add_argument("--plan", action="store_true",
|
||||
help="print the ensure plan as JSON, mutate nothing")
|
||||
parser.add_argument("--ensure", dest="ensure", metavar="VERSION",
|
||||
@@ -271,7 +286,7 @@ def main(argv: list[str] | None = None) -> int:
|
||||
|
||||
repo = args.repo or Path.cwd()
|
||||
if args.latest_tag:
|
||||
print(latest_release_tag(repo) or "")
|
||||
print(latest_release_tag(repo, namespace=args.namespace) or "")
|
||||
return 0
|
||||
if args.plan:
|
||||
print(json.dumps(plan_ensure_tag(args.ensure or "", args.bump_sha, repo)))
|
||||
|
||||
@@ -0,0 +1,123 @@
|
||||
package main
|
||||
|
||||
// classify.go — the verdict: solo-attention vs parallel-factory vs
|
||||
// queue, decided from candidate surfaces, the registry's in-flight
|
||||
// locks, and the owner-origin flag. Mechanism, not law.
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
type Verdict struct {
|
||||
Decision string `json:"decision"` // QUEUE-BEHIND | PRIORITY-QUEUE | SOLO | PARALLEL
|
||||
Reason string `json:"reason"`
|
||||
Surfaces []string `json:"surfaces"`
|
||||
LocksToTake []string `json:"locks_to_take"`
|
||||
QueueBehind []string `json:"queue_behind"`
|
||||
}
|
||||
|
||||
// Classify applies the verdict rules, in order:
|
||||
//
|
||||
// 1. any candidate surface locked by an in-flight agent →
|
||||
// QUEUE-BEHIND (owner-origin → PRIORITY-QUEUE; the lock-holder
|
||||
// yields at its next landing boundary);
|
||||
// 2. owner-origin → SOLO — the owner is watching, latency wins;
|
||||
// 3. multiple disjoint surfaces → PARALLEL with a suggested split;
|
||||
// 4. else SOLO.
|
||||
func Classify(candidates []string, reg *Registry, ownerOrigin bool, now time.Time) Verdict {
|
||||
surfaces := maximalSurfaces(normalizeAll(candidates))
|
||||
v := Verdict{
|
||||
Surfaces: surfaces,
|
||||
LocksToTake: surfaces,
|
||||
QueueBehind: []string{},
|
||||
}
|
||||
if len(surfaces) == 0 {
|
||||
v.Decision = "SOLO"
|
||||
v.Reason = "no surfaces named — default to the full-attention lane"
|
||||
return v
|
||||
}
|
||||
|
||||
conflicts := reg.ConflictingLocks(surfaces, now)
|
||||
if len(conflicts) > 0 {
|
||||
holders := map[string]bool{}
|
||||
var pairs []string
|
||||
for _, e := range conflicts {
|
||||
holders[e.AgentID] = true
|
||||
for _, held := range e.Surfaces {
|
||||
for _, want := range surfaces {
|
||||
if PrefixOverlap(held, want) {
|
||||
pairs = append(pairs, fmt.Sprintf("%s (held by %s)", want, e.AgentID))
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
for a := range holders {
|
||||
v.QueueBehind = append(v.QueueBehind, a)
|
||||
}
|
||||
sortStrings(v.QueueBehind)
|
||||
if ownerOrigin {
|
||||
v.Decision = "PRIORITY-QUEUE"
|
||||
v.Reason = fmt.Sprintf(
|
||||
"owner-origin wave overlaps in-flight locks: %s — PRIORITY-QUEUE ahead of %s; "+
|
||||
"lock-holder should yield at its next landing boundary",
|
||||
strings.Join(pairs, ", "), strings.Join(v.QueueBehind, ", "))
|
||||
return v
|
||||
}
|
||||
v.Decision = "QUEUE-BEHIND"
|
||||
v.Reason = fmt.Sprintf(
|
||||
"in-flight locks: %s — queue behind %s; do not spawn onto them yet",
|
||||
strings.Join(pairs, ", "), strings.Join(v.QueueBehind, ", "))
|
||||
return v
|
||||
}
|
||||
|
||||
if ownerOrigin {
|
||||
v.Decision = "SOLO"
|
||||
v.Reason = "owner-origin (the owner is watching): full-attention lane — latency wins over throughput"
|
||||
return v
|
||||
}
|
||||
|
||||
if len(surfaces) >= 2 {
|
||||
lanes := make([]string, len(surfaces))
|
||||
for i, s := range surfaces {
|
||||
lanes[i] = fmt.Sprintf("lane %d: %s", i+1, s)
|
||||
}
|
||||
v.Decision = "PARALLEL"
|
||||
v.Reason = fmt.Sprintf(
|
||||
"%d disjoint surfaces, no contention: parallel factory — suggested split: %s",
|
||||
len(surfaces), strings.Join(lanes, "; "))
|
||||
return v
|
||||
}
|
||||
|
||||
v.Decision = "SOLO"
|
||||
v.Reason = fmt.Sprintf("single surface (%s), no contention — solo attention is enough", surfaces[0])
|
||||
return v
|
||||
}
|
||||
|
||||
// Apply takes the lock for real: it fails loud when the registry
|
||||
// changed since the classify read (re-classify), when a surface is
|
||||
// locked (queue behind), or when only a stale lock blocks (prune
|
||||
// first). On success the lock is written atomically.
|
||||
func Apply(path string, e Entry, classifyTime *Registry) error {
|
||||
fresh, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if !fresh.SameAs(classifyTime) {
|
||||
return fmt.Errorf("registry changed under you since the classify read — re-classify")
|
||||
}
|
||||
if err := fresh.Lock(e); err != nil {
|
||||
return err
|
||||
}
|
||||
return SaveRegistry(path, fresh)
|
||||
}
|
||||
|
||||
func sortStrings(s []string) {
|
||||
for i := 1; i < len(s); i++ {
|
||||
for j := i; j > 0 && s[j] < s[j-1]; j-- {
|
||||
s[j], s[j-1] = s[j-1], s[j]
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,145 @@
|
||||
package main
|
||||
|
||||
// classify_test.go — red-first: the verdict rules (queue-behind,
|
||||
// priority-queue, owner solo, parallel split, default solo), stale
|
||||
// locks ignored by verdicts, and the apply law (atomic, fail-loud on
|
||||
// locked or stale or changed-under-you).
|
||||
|
||||
import (
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func registryWith(t *testing.T, entries ...Entry) (*Registry, string) {
|
||||
t.Helper()
|
||||
reg := &Registry{Version: 1}
|
||||
for _, e := range entries {
|
||||
if err := reg.Lock(e); err != nil {
|
||||
t.Fatalf("seed Lock: %v", err)
|
||||
}
|
||||
}
|
||||
path := filepath.Join(t.TempDir(), "dispatch_registry.json")
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
t.Fatalf("SaveRegistry: %v", err)
|
||||
}
|
||||
return reg, path
|
||||
}
|
||||
|
||||
func TestVerdictQueueBehindNamesAgentAndSurface(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-b", nowAt(-time.Hour), "tui/chatpane"))
|
||||
v := Classify([]string{"tui/chatpane"}, reg, false, nowAt(0))
|
||||
if v.Decision != "QUEUE-BEHIND" {
|
||||
t.Fatalf("decision = %s, want QUEUE-BEHIND", v.Decision)
|
||||
}
|
||||
if len(v.QueueBehind) != 1 || v.QueueBehind[0] != "agent-b" {
|
||||
t.Errorf("queue_behind = %v, want [agent-b]", v.QueueBehind)
|
||||
}
|
||||
if !strings.Contains(v.Reason, "agent-b") || !strings.Contains(v.Reason, "tui/chatpane") {
|
||||
t.Errorf("reason must name agent and surface, got: %s", v.Reason)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictPriorityQueueWhenOwnerOrigin(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-b", nowAt(-time.Hour), "tui/chatpane"))
|
||||
v := Classify([]string{"tui/chatpane"}, reg, true, nowAt(0))
|
||||
if v.Decision != "PRIORITY-QUEUE" {
|
||||
t.Fatalf("decision = %s, want PRIORITY-QUEUE", v.Decision)
|
||||
}
|
||||
if !strings.Contains(v.Reason, "landing boundary") {
|
||||
t.Errorf("reason must note the lock-holder yields at its next landing boundary, got: %s", v.Reason)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictOwnerOriginSoloWinsLatency(t *testing.T) {
|
||||
v := Classify([]string{"tui/chatpane", "src/go/rune-core"}, &Registry{Version: 1}, true, nowAt(0))
|
||||
if v.Decision != "SOLO" {
|
||||
t.Fatalf("decision = %s, want SOLO (owner watching, latency wins)", v.Decision)
|
||||
}
|
||||
if !strings.Contains(v.Reason, "latency") {
|
||||
t.Errorf("reason must explain latency, got: %s", v.Reason)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictParallelSplitSuggestion(t *testing.T) {
|
||||
v := Classify([]string{"tui/chatpane", "src/go/rune-core"}, &Registry{Version: 1}, false, nowAt(0))
|
||||
if v.Decision != "PARALLEL" {
|
||||
t.Fatalf("decision = %s, want PARALLEL", v.Decision)
|
||||
}
|
||||
if !strings.Contains(v.Reason, "tui/chatpane") || !strings.Contains(v.Reason, "src/go/rune-core") {
|
||||
t.Errorf("split suggestion must name each lane surface, got: %s", v.Reason)
|
||||
}
|
||||
if !strings.Contains(v.Reason, "split") {
|
||||
t.Errorf("reason must offer the split, got: %s", v.Reason)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictDefaultSoloSingleSurface(t *testing.T) {
|
||||
v := Classify([]string{"scripts"}, &Registry{Version: 1}, false, nowAt(0))
|
||||
if v.Decision != "SOLO" {
|
||||
t.Fatalf("decision = %s, want SOLO", v.Decision)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictIgnoresStaleLocks(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("ghost", nowAt(-5*time.Hour), "tui/chatpane"))
|
||||
v := Classify([]string{"tui/chatpane"}, reg, false, nowAt(0))
|
||||
if v.Decision != "SOLO" {
|
||||
t.Fatalf("decision = %s, want SOLO (stale lock is not in-flight)", v.Decision)
|
||||
}
|
||||
}
|
||||
|
||||
func TestVerdictJSONShape(t *testing.T) {
|
||||
v := Classify([]string{"scripts"}, &Registry{Version: 1}, false, nowAt(0))
|
||||
if v.LocksToTake[0] != "scripts" || len(v.Surfaces) != 1 || v.Surfaces[0] != "scripts" {
|
||||
t.Errorf("verdict fields = %+v", v)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyTakesLockAtomically(t *testing.T) {
|
||||
reg, path := registryWith(t, lockEntry("agent-b", nowAt(0), "scripts"))
|
||||
entry := Entry{AgentID: "agent-a", Surfaces: []string{"tui/chatpane"}, Kind: "solo", Since: nowAt(0)}
|
||||
if err := Apply(path, entry, reg); err != nil {
|
||||
t.Fatalf("Apply: %v", err)
|
||||
}
|
||||
reloaded, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(reloaded.Entries) != 2 {
|
||||
t.Fatalf("entries = %d, want 2", len(reloaded.Entries))
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyFailsLoudWhenLocked(t *testing.T) {
|
||||
reg, path := registryWith(t, lockEntry("agent-b", nowAt(0), "tui/chatpane"))
|
||||
entry := Entry{AgentID: "agent-a", Surfaces: []string{"tui/chatpane"}, Kind: "solo", Since: nowAt(0)}
|
||||
err := Apply(path, entry, reg)
|
||||
if err == nil {
|
||||
t.Fatal("Apply onto a locked surface must fail loud")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "agent-b") {
|
||||
t.Errorf("Apply failure must name the holder, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyFailsLoudWhenRegistryChangedUnderYou(t *testing.T) {
|
||||
reg, path := registryWith(t, lockEntry("agent-b", nowAt(0), "scripts"))
|
||||
// another agent lands a lock between our classify read and the apply
|
||||
raced, _ := LoadRegistry(path)
|
||||
raced.Lock(lockEntry("agent-c", nowAt(0), "tui/memory"))
|
||||
SaveRegistry(path, raced)
|
||||
|
||||
entry := Entry{AgentID: "agent-a", Surfaces: []string{"tui/chatpane"}, Kind: "solo", Since: nowAt(0)}
|
||||
err := Apply(path, entry, reg)
|
||||
if err == nil {
|
||||
t.Fatal("Apply with a stale read must fail loud (re-classify)")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "changed") {
|
||||
t.Errorf("Apply failure must say the registry changed, got: %v", err)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,3 @@
|
||||
module rune/dispatch-classifier
|
||||
|
||||
go 1.21
|
||||
@@ -0,0 +1,265 @@
|
||||
package main
|
||||
|
||||
// main.go — the dispatch-classifier CLI: the hot-state registry
|
||||
// (lock/unlock/show) and the classify verdict the session agent runs
|
||||
// before spawning anything.
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"flag"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"os/user"
|
||||
"path/filepath"
|
||||
"sort"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
const usage = `dispatch-classifier — decides solo vs parallel vs queue so the owner never specifies
|
||||
|
||||
subcommands:
|
||||
lock --agent X --surface a,b --kind solo|parallel [--owner-origin]
|
||||
take a lock in the hot registry (fails loud on conflict)
|
||||
unlock --agent X
|
||||
drop an agent's lock
|
||||
show [--prune]
|
||||
print the registry table (STALE after 4h; --prune drops stale)
|
||||
classify --brief FILE [--paths p1,p2] [--owner-origin] [--apply]
|
||||
[--agent X] [--kind solo|parallel]
|
||||
print the verdict JSON for the brief
|
||||
|
||||
global: --registry PATH (default $RUNE_DISPATCH_REGISTRY or
|
||||
~/.rune/hot/dispatch_registry.json)`
|
||||
|
||||
func registryPath(fs *flag.FlagSet) string {
|
||||
p := fs.String("registry", defaultRegistryPath(), "registry file path")
|
||||
fs.Parse(os.Args[2:])
|
||||
return *p
|
||||
}
|
||||
|
||||
func defaultRegistryPath() string {
|
||||
if p := os.Getenv("RUNE_DISPATCH_REGISTRY"); p != "" {
|
||||
return p
|
||||
}
|
||||
home := "~"
|
||||
if u, err := user.Current(); err == nil {
|
||||
home = u.HomeDir
|
||||
}
|
||||
return filepath.Join(home, ".rune", "hot", "dispatch_registry.json")
|
||||
}
|
||||
|
||||
func main() {
|
||||
if len(os.Args) < 2 {
|
||||
fmt.Fprintln(os.Stderr, usage)
|
||||
os.Exit(2)
|
||||
}
|
||||
var err error
|
||||
switch os.Args[1] {
|
||||
case "lock":
|
||||
err = cmdLock()
|
||||
case "unlock":
|
||||
err = cmdUnlock()
|
||||
case "show":
|
||||
err = cmdShow()
|
||||
case "classify":
|
||||
err = cmdClassify()
|
||||
case "help", "-h", "--help":
|
||||
fmt.Println(usage)
|
||||
default:
|
||||
fmt.Fprintf(os.Stderr, "unknown subcommand %q\n\n%s\n", os.Args[1], usage)
|
||||
os.Exit(2)
|
||||
}
|
||||
if err != nil {
|
||||
fmt.Fprintln(os.Stderr, "dispatch-classifier:", err)
|
||||
os.Exit(1)
|
||||
}
|
||||
}
|
||||
|
||||
func cmdLock() error {
|
||||
fs := flag.NewFlagSet("lock", flag.ExitOnError)
|
||||
agent := fs.String("agent", "", "agent id taking the lock (required)")
|
||||
surface := fs.String("surface", "", "comma-separated surface prefixes (required)")
|
||||
kind := fs.String("kind", "solo", "solo or parallel")
|
||||
ownerOrigin := fs.Bool("owner-origin", false, "this wave comes from the owner")
|
||||
path := registryPath(fs)
|
||||
if *agent == "" || *surface == "" {
|
||||
return fmt.Errorf("lock needs --agent and --surface")
|
||||
}
|
||||
reg, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
e := Entry{
|
||||
AgentID: *agent,
|
||||
Surfaces: strings.Split(*surface, ","),
|
||||
Kind: *kind,
|
||||
Since: time.Now().UTC(),
|
||||
OwnerOrigin: *ownerOrigin,
|
||||
}
|
||||
if err := reg.Lock(e); err != nil {
|
||||
return err
|
||||
}
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
return err
|
||||
}
|
||||
fmt.Fprintf(os.Stderr, "locked %s on %s (%s)\n", *agent, strings.Join(normalizeAll(e.Surfaces), ", "), *kind)
|
||||
return nil
|
||||
}
|
||||
|
||||
func cmdUnlock() error {
|
||||
fs := flag.NewFlagSet("unlock", flag.ExitOnError)
|
||||
agent := fs.String("agent", "", "agent id to release (required)")
|
||||
path := registryPath(fs)
|
||||
if *agent == "" {
|
||||
return fmt.Errorf("unlock needs --agent")
|
||||
}
|
||||
reg, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if !reg.Unlock(*agent) {
|
||||
fmt.Fprintf(os.Stderr, "no lock held by %s\n", *agent)
|
||||
return nil
|
||||
}
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
return err
|
||||
}
|
||||
fmt.Fprintf(os.Stderr, "unlocked %s\n", *agent)
|
||||
return nil
|
||||
}
|
||||
|
||||
func cmdShow() error {
|
||||
fs := flag.NewFlagSet("show", flag.ExitOnError)
|
||||
prune := fs.Bool("prune", false, "drop STALE entries (older than 4h)")
|
||||
path := registryPath(fs)
|
||||
reg, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
now := time.Now().UTC()
|
||||
if *prune {
|
||||
pruned := reg.PruneStale(now)
|
||||
if len(pruned) > 0 {
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
return err
|
||||
}
|
||||
fmt.Fprintf(os.Stderr, "pruned stale: %s\n", strings.Join(pruned, ", "))
|
||||
} else {
|
||||
fmt.Fprintln(os.Stderr, "no stale entries to prune")
|
||||
}
|
||||
}
|
||||
if len(reg.Entries) == 0 {
|
||||
fmt.Println("registry empty — no in-flight locks")
|
||||
return nil
|
||||
}
|
||||
entries := make([]Entry, len(reg.Entries))
|
||||
copy(entries, reg.Entries)
|
||||
sort.Slice(entries, func(i, j int) bool { return entries[i].AgentID < entries[j].AgentID })
|
||||
fmt.Printf("%-18s %-44s %-9s %-21s %-6s %s\n",
|
||||
"AGENT", "SURFACES", "KIND", "SINCE", "OWNER", "STATUS")
|
||||
for _, e := range entries {
|
||||
status := "FRESH"
|
||||
if e.Stale(now) {
|
||||
status = "STALE"
|
||||
}
|
||||
owner := "-"
|
||||
if e.OwnerOrigin {
|
||||
owner = "yes"
|
||||
}
|
||||
fmt.Printf("%-18s %-44s %-9s %-21s %-6s %s\n",
|
||||
e.AgentID, strings.Join(e.Surfaces, ", "), e.Kind,
|
||||
e.Since.Format(time.RFC3339), owner, status)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func cmdClassify() error {
|
||||
fs := flag.NewFlagSet("classify", flag.ExitOnError)
|
||||
briefPath := fs.String("brief", "", "file holding the brief text (required, or - for stdin)")
|
||||
paths := fs.String("paths", "", "explicit comma-separated affected paths (win over brief parsing)")
|
||||
ownerOrigin := fs.Bool("owner-origin", false, "this wave comes from the owner")
|
||||
apply := fs.Bool("apply", false, "take the lock when the verdict allows it")
|
||||
agent := fs.String("agent", defaultAgent(), "agent id for --apply")
|
||||
kind := fs.String("kind", "", "lock kind override (default: from the verdict)")
|
||||
path := registryPath(fs)
|
||||
if *briefPath == "" {
|
||||
return fmt.Errorf("classify needs --brief FILE")
|
||||
}
|
||||
brief, err := readBrief(*briefPath)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
var explicit []string
|
||||
if *paths != "" {
|
||||
explicit = strings.Split(*paths, ",")
|
||||
}
|
||||
reg, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
v := Classify(brief2candidates(brief, explicit), reg, *ownerOrigin, time.Now().UTC())
|
||||
out, err := json.MarshalIndent(v, "", " ")
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
fmt.Println(string(out))
|
||||
|
||||
if !*apply {
|
||||
return nil
|
||||
}
|
||||
if v.Decision == "QUEUE-BEHIND" || v.Decision == "PRIORITY-QUEUE" {
|
||||
return fmt.Errorf("--apply refused: verdict is %s — nothing spawned until the lock-holder lands", v.Decision)
|
||||
}
|
||||
lockKind := *kind
|
||||
if lockKind == "" {
|
||||
lockKind = "solo"
|
||||
if v.Decision == "PARALLEL" {
|
||||
lockKind = "parallel"
|
||||
}
|
||||
}
|
||||
e := Entry{
|
||||
AgentID: *agent,
|
||||
Surfaces: v.LocksToTake,
|
||||
Kind: lockKind,
|
||||
Since: time.Now().UTC(),
|
||||
OwnerOrigin: *ownerOrigin,
|
||||
}
|
||||
if err := Apply(path, e, reg); err != nil {
|
||||
return err
|
||||
}
|
||||
fmt.Fprintf(os.Stderr, "locked %s on %s (%s)\n",
|
||||
*agent, strings.Join(v.LocksToTake, ", "), lockKind)
|
||||
return nil
|
||||
}
|
||||
|
||||
func brief2candidates(brief string, explicit []string) []string {
|
||||
return CandidateSurfaces(brief, explicit)
|
||||
}
|
||||
|
||||
func readBrief(p string) (string, error) {
|
||||
if p == "-" {
|
||||
raw, err := io.ReadAll(os.Stdin)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("read stdin brief: %w", err)
|
||||
}
|
||||
return string(raw), nil
|
||||
}
|
||||
raw, err := os.ReadFile(p)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("read brief %s: %w", p, err)
|
||||
}
|
||||
return string(raw), nil
|
||||
}
|
||||
|
||||
func defaultAgent() string {
|
||||
if a := os.Getenv("RUNE_AGENT_ID"); a != "" {
|
||||
return a
|
||||
}
|
||||
host, err := os.Hostname()
|
||||
if err != nil {
|
||||
host = "unknown"
|
||||
}
|
||||
return fmt.Sprintf("%s:%d", host, os.Getpid())
|
||||
}
|
||||
@@ -0,0 +1,224 @@
|
||||
package main
|
||||
|
||||
// registry.go — the hot-state dispatch registry (~/.rune/hot/
|
||||
// dispatch_registry.json): which agent holds which surfaces, since
|
||||
// when, and whether the lock still counts as in-flight (4h staleness).
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"time"
|
||||
)
|
||||
|
||||
// StaleAge: an entry silent this long is no longer in-flight.
|
||||
const StaleAge = 4 * time.Hour
|
||||
|
||||
type Entry struct {
|
||||
AgentID string `json:"agent_id"`
|
||||
Surfaces []string `json:"surfaces"`
|
||||
Kind string `json:"kind"` // solo | parallel
|
||||
Since time.Time `json:"since"`
|
||||
OwnerOrigin bool `json:"owner_origin"`
|
||||
}
|
||||
|
||||
type Registry struct {
|
||||
Version int `json:"version"`
|
||||
Entries []Entry `json:"entries"`
|
||||
}
|
||||
|
||||
func (e Entry) Stale(now time.Time) bool {
|
||||
return now.Sub(e.Since) > StaleAge
|
||||
}
|
||||
|
||||
// LoadRegistry reads the registry file; a missing file is an empty
|
||||
// registry, anything malformed fails loud.
|
||||
func LoadRegistry(path string) (*Registry, error) {
|
||||
reg := &Registry{Version: 1}
|
||||
raw, err := os.ReadFile(path)
|
||||
if errors.Is(err, os.ErrNotExist) {
|
||||
return reg, nil
|
||||
}
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("read registry %s: %w", path, err)
|
||||
}
|
||||
if err := json.Unmarshal(raw, reg); err != nil {
|
||||
return nil, fmt.Errorf("registry %s is malformed: %w", path, err)
|
||||
}
|
||||
if reg.Version == 0 {
|
||||
reg.Version = 1
|
||||
}
|
||||
return reg, nil
|
||||
}
|
||||
|
||||
// SaveRegistry writes atomically: temp file in the same directory,
|
||||
// then rename — a crash never leaves a half-written registry.
|
||||
func SaveRegistry(path string, reg *Registry) error {
|
||||
if dir := filepath.Dir(path); dir != "" {
|
||||
if err := os.MkdirAll(dir, 0o755); err != nil {
|
||||
return fmt.Errorf("mkdir registry dir: %w", err)
|
||||
}
|
||||
}
|
||||
raw, err := json.MarshalIndent(reg, "", " ")
|
||||
if err != nil {
|
||||
return fmt.Errorf("encode registry: %w", err)
|
||||
}
|
||||
raw = append(raw, '\n')
|
||||
tmp, err := os.CreateTemp(filepath.Dir(path), ".dispatch_registry.*.tmp")
|
||||
if err != nil {
|
||||
return fmt.Errorf("temp registry file: %w", err)
|
||||
}
|
||||
defer os.Remove(tmp.Name())
|
||||
if _, err := tmp.Write(raw); err != nil {
|
||||
tmp.Close()
|
||||
return fmt.Errorf("write temp registry: %w", err)
|
||||
}
|
||||
if err := tmp.Sync(); err != nil {
|
||||
tmp.Close()
|
||||
return fmt.Errorf("sync temp registry: %w", err)
|
||||
}
|
||||
if err := tmp.Close(); err != nil {
|
||||
return fmt.Errorf("close temp registry: %w", err)
|
||||
}
|
||||
if err := os.Chmod(tmp.Name(), 0o600); err != nil {
|
||||
return fmt.Errorf("chmod temp registry: %w", err)
|
||||
}
|
||||
if err := os.Rename(tmp.Name(), path); err != nil {
|
||||
return fmt.Errorf("swap registry in: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// Lock upserts an agent's entry. Re-locking your own agent id
|
||||
// replaces your entry; overlapping someone else's fresh lock fails
|
||||
// loud naming the holder; overlapping a STALE lock also fails loud —
|
||||
// prune first, never silently steal. Staleness is judged against the
|
||||
// incoming entry's Since (the moment of this attempt).
|
||||
func (r *Registry) Lock(e Entry) error {
|
||||
e.Surfaces = normalizeAll(e.Surfaces)
|
||||
if e.AgentID == "" {
|
||||
return fmt.Errorf("lock needs an agent id")
|
||||
}
|
||||
if len(e.Surfaces) == 0 {
|
||||
return fmt.Errorf("lock needs at least one surface")
|
||||
}
|
||||
if e.Kind != "solo" && e.Kind != "parallel" {
|
||||
return fmt.Errorf("kind must be solo or parallel, got %q", e.Kind)
|
||||
}
|
||||
for i := range r.Entries {
|
||||
other := &r.Entries[i]
|
||||
if other.AgentID == e.AgentID {
|
||||
continue
|
||||
}
|
||||
for _, held := range other.Surfaces {
|
||||
for _, want := range e.Surfaces {
|
||||
if !PrefixOverlap(held, want) {
|
||||
continue
|
||||
}
|
||||
if other.Stale(e.Since) {
|
||||
return fmt.Errorf(
|
||||
"stale lock by %s on %s still covers %s — prune it first (show --prune or unlock)",
|
||||
other.AgentID, held, want)
|
||||
}
|
||||
return fmt.Errorf(
|
||||
"%s is locked by %s (since %s) — queue behind it",
|
||||
want, other.AgentID, other.Since.Format(time.RFC3339))
|
||||
}
|
||||
}
|
||||
}
|
||||
for i := range r.Entries {
|
||||
if r.Entries[i].AgentID == e.AgentID {
|
||||
r.Entries[i] = e
|
||||
return nil
|
||||
}
|
||||
}
|
||||
r.Entries = append(r.Entries, e)
|
||||
return nil
|
||||
}
|
||||
|
||||
// Unlock drops an agent's entry; it reports whether one was held.
|
||||
func (r *Registry) Unlock(agent string) bool {
|
||||
for i := range r.Entries {
|
||||
if r.Entries[i].AgentID == agent {
|
||||
r.Entries = append(r.Entries[:i], r.Entries[i+1:]...)
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// PruneStale removes entries older than StaleAge and returns the
|
||||
// pruned agent ids.
|
||||
func (r *Registry) PruneStale(now time.Time) []string {
|
||||
var pruned []string
|
||||
kept := r.Entries[:0]
|
||||
for _, e := range r.Entries {
|
||||
if e.Stale(now) {
|
||||
pruned = append(pruned, e.AgentID)
|
||||
continue
|
||||
}
|
||||
kept = append(kept, e)
|
||||
}
|
||||
r.Entries = kept
|
||||
return pruned
|
||||
}
|
||||
|
||||
// ConflictingLocks returns fresh (in-flight) entries overlapping any
|
||||
// given surface. Stale entries do not block: a lock silent past 4h is
|
||||
// not in-flight.
|
||||
func (r *Registry) ConflictingLocks(surfaces []string, now time.Time) []Entry {
|
||||
var out []Entry
|
||||
for _, e := range r.Entries {
|
||||
if e.Stale(now) {
|
||||
continue
|
||||
}
|
||||
for _, held := range e.Surfaces {
|
||||
for _, want := range surfaces {
|
||||
if PrefixOverlap(held, want) {
|
||||
out = append(out, e)
|
||||
break
|
||||
}
|
||||
}
|
||||
if len(out) > 0 && out[len(out)-1].AgentID == e.AgentID {
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// SameAs reports whether two registries carry the same entries (by
|
||||
// agent), order aside — the apply-time guard against a registry that
|
||||
// changed between the classify read and the lock take.
|
||||
func (r *Registry) SameAs(other *Registry) bool {
|
||||
if other == nil || len(r.Entries) != len(other.Entries) {
|
||||
return false
|
||||
}
|
||||
idx := map[string]Entry{}
|
||||
for _, e := range other.Entries {
|
||||
idx[e.AgentID] = e
|
||||
}
|
||||
for _, e := range r.Entries {
|
||||
o, ok := idx[e.AgentID]
|
||||
if !ok || !e.equal(o) {
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
func (e Entry) equal(o Entry) bool {
|
||||
if e.AgentID != o.AgentID || e.Kind != o.Kind ||
|
||||
e.OwnerOrigin != o.OwnerOrigin || !e.Since.Equal(o.Since) ||
|
||||
len(e.Surfaces) != len(o.Surfaces) {
|
||||
return false
|
||||
}
|
||||
for i := range e.Surfaces {
|
||||
if e.Surfaces[i] != o.Surfaces[i] {
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
@@ -0,0 +1,180 @@
|
||||
package main
|
||||
|
||||
// registry_test.go — red-first: lock/unlock lifecycle, atomic hot-state
|
||||
// writes, fail-loud conflict law (fresh AND stale), 4h staleness,
|
||||
// prune.
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func nowAt(offset time.Duration) time.Time {
|
||||
base := time.Date(2026, 10, 22, 15, 0, 0, 0, time.UTC)
|
||||
return base.Add(offset)
|
||||
}
|
||||
|
||||
func lockEntry(agent string, since time.Time, surfaces ...string) Entry {
|
||||
return Entry{
|
||||
AgentID: agent,
|
||||
Surfaces: surfaces,
|
||||
Kind: "solo",
|
||||
Since: since,
|
||||
}
|
||||
}
|
||||
|
||||
func TestLockUnlockLifecycle(t *testing.T) {
|
||||
path := filepath.Join(t.TempDir(), "dispatch_registry.json")
|
||||
reg := &Registry{Version: 1}
|
||||
if err := reg.Lock(lockEntry("agent-a", nowAt(0), "tui/chatpane", "tui/face")); err != nil {
|
||||
t.Fatalf("Lock: %v", err)
|
||||
}
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
t.Fatalf("SaveRegistry: %v", err)
|
||||
}
|
||||
reloaded, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
t.Fatalf("LoadRegistry: %v", err)
|
||||
}
|
||||
if len(reloaded.Entries) != 1 || reloaded.Entries[0].AgentID != "agent-a" {
|
||||
t.Fatalf("reloaded = %+v, want one agent-a entry", reloaded.Entries)
|
||||
}
|
||||
if !reloaded.Unlock("agent-a") {
|
||||
t.Fatal("Unlock should remove the held lock")
|
||||
}
|
||||
if reloaded.Unlock("agent-a") {
|
||||
t.Fatal("second Unlock should report nothing left")
|
||||
}
|
||||
if err := SaveRegistry(path, reloaded); err != nil {
|
||||
t.Fatalf("SaveRegistry: %v", err)
|
||||
}
|
||||
final, err := LoadRegistry(path)
|
||||
if err != nil {
|
||||
t.Fatalf("LoadRegistry: %v", err)
|
||||
}
|
||||
if len(final.Entries) != 0 {
|
||||
t.Fatalf("entries after unlock = %d, want 0", len(final.Entries))
|
||||
}
|
||||
}
|
||||
|
||||
func TestLockAtomicWriteNoTempLeftovers(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "dispatch_registry.json")
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-a", nowAt(0), "scripts"))
|
||||
if err := SaveRegistry(path, reg); err != nil {
|
||||
t.Fatalf("SaveRegistry: %v", err)
|
||||
}
|
||||
files, err := os.ReadDir(dir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(files) != 1 || files[0].Name() != "dispatch_registry.json" {
|
||||
t.Fatalf("temp leftovers in registry dir: %v", files)
|
||||
}
|
||||
raw, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
var probe map[string]any
|
||||
if err := json.Unmarshal(raw, &probe); err != nil {
|
||||
t.Fatalf("registry is not valid JSON: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLockFreshConflictFailsLoud(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-b", nowAt(0), "tui/chatpane"))
|
||||
err := reg.Lock(lockEntry("agent-a", nowAt(time.Minute), "tui/chatpane/blocks.go"))
|
||||
if err == nil {
|
||||
t.Fatal("locking an overlapping fresh surface must fail loud")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "agent-b") {
|
||||
t.Errorf("conflict error must name the lock-holder, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLockReplacesOwnEntry(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-a", nowAt(0), "tui/chatpane"))
|
||||
err := reg.Lock(lockEntry("agent-a", nowAt(time.Minute), "scripts"))
|
||||
if err != nil {
|
||||
t.Fatalf("re-locking own surfaces must not conflict: %v", err)
|
||||
}
|
||||
if len(reg.Entries) != 1 {
|
||||
t.Fatalf("entries = %d, want 1 (replaced)", len(reg.Entries))
|
||||
}
|
||||
if reg.Entries[0].Surfaces[0] != "scripts" {
|
||||
t.Errorf("surfaces = %v, want [scripts]", reg.Entries[0].Surfaces)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLockStaleConflictFailsLoudMentioningStale(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("ghost", nowAt(-5*time.Hour), "tui/chatpane"))
|
||||
err := reg.Lock(Entry{AgentID: "agent-a", Surfaces: []string{"tui/chatpane"}, Kind: "solo", Since: nowAt(0)})
|
||||
if err == nil {
|
||||
t.Fatal("a stale conflicting lock must still fail loud (prune first)")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "stale") {
|
||||
t.Errorf("stale conflict must say stale, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestStaleDetectionAtFourHours(t *testing.T) {
|
||||
e := lockEntry("agent-a", nowAt(-4*time.Hour-time.Minute), "scripts")
|
||||
if !e.Stale(nowAt(0)) {
|
||||
t.Error("entry older than 4h must be STALE")
|
||||
}
|
||||
fresh := lockEntry("agent-a", nowAt(-4*time.Hour+time.Minute), "scripts")
|
||||
if fresh.Stale(nowAt(0)) {
|
||||
t.Error("entry younger than 4h must not be STALE")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPruneStaleRemovesOnlyStale(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("ghost", nowAt(-6*time.Hour), "scripts"))
|
||||
reg.Lock(lockEntry("live", nowAt(-time.Hour), "tui/chatpane"))
|
||||
pruned := reg.PruneStale(nowAt(0))
|
||||
if len(pruned) != 1 || pruned[0] != "ghost" {
|
||||
t.Fatalf("pruned = %v, want [ghost]", pruned)
|
||||
}
|
||||
if len(reg.Entries) != 1 || reg.Entries[0].AgentID != "live" {
|
||||
t.Fatalf("entries after prune = %+v, want live only", reg.Entries)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLoadMissingRegistryIsEmptyNotError(t *testing.T) {
|
||||
reg, err := LoadRegistry(filepath.Join(t.TempDir(), "absent.json"))
|
||||
if err != nil {
|
||||
t.Fatalf("missing registry must load empty, got %v", err)
|
||||
}
|
||||
if len(reg.Entries) != 0 {
|
||||
t.Fatalf("entries = %d, want 0", len(reg.Entries))
|
||||
}
|
||||
}
|
||||
|
||||
func TestLoadMalformedRegistryFailsLoud(t *testing.T) {
|
||||
path := filepath.Join(t.TempDir(), "dispatch_registry.json")
|
||||
os.WriteFile(path, []byte("{not json"), 0o600)
|
||||
if _, err := LoadRegistry(path); err == nil {
|
||||
t.Fatal("malformed registry must fail loud")
|
||||
}
|
||||
}
|
||||
|
||||
func TestConflictingLocks(t *testing.T) {
|
||||
reg := &Registry{Version: 1}
|
||||
reg.Lock(lockEntry("agent-b", nowAt(0), "tui"))
|
||||
conflicts := reg.ConflictingLocks([]string{"tui/chatpane"}, nowAt(0))
|
||||
if len(conflicts) != 1 || conflicts[0].AgentID != "agent-b" {
|
||||
t.Fatalf("ConflictingLocks = %+v, want agent-b", conflicts)
|
||||
}
|
||||
if got := reg.ConflictingLocks([]string{"src/go/rune-core"}, nowAt(0)); len(got) != 0 {
|
||||
t.Fatalf("ConflictingLocks on free surface = %+v, want none", got)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,188 @@
|
||||
package main
|
||||
|
||||
// surfaces.go — surface extraction and the ONE keyword→surface map.
|
||||
// The map is data: adding a surface means adding a line here, nothing
|
||||
// else.
|
||||
|
||||
import (
|
||||
"sort"
|
||||
"strings"
|
||||
)
|
||||
|
||||
// KeywordMap is the single keyword→surfaces heuristic table. Keys are
|
||||
// lowercase; multi-word keys match word-boundary phrases in the brief.
|
||||
var KeywordMap = map[string][]string{
|
||||
"chat": {"tui/chatpane"},
|
||||
"chatpane": {"tui/chatpane"},
|
||||
"tasks": {"tui/tasks"},
|
||||
"face": {"tui/face"},
|
||||
"info bar": {"tui/face"},
|
||||
"memory": {"src/go/memory-continuity", "tui/memory"},
|
||||
"skills": {"src/go/skills-engine", "tui/skills"},
|
||||
"core": {"src/go/rune-core"},
|
||||
"engine": {"src/go/rune-core"},
|
||||
"entry": {"src/go/rune-entry"},
|
||||
"queue": {"src/go/rune-entry"},
|
||||
"tests": {"tests"},
|
||||
"scripts": {"scripts"},
|
||||
"docs": {"docs", "research"},
|
||||
}
|
||||
|
||||
// KnownTops are the repo's top-level directory names: the first
|
||||
// segment of any repo-relative path must be one of these.
|
||||
var KnownTops = map[string]bool{
|
||||
"tui": true, "src": true, "tests": true, "scripts": true,
|
||||
"docs": true, "research": true, "schemas": true, "shared": true,
|
||||
"bridge": true, "config": true, "interop": true, "plans": true,
|
||||
"prompts": true, "store": true, "verification": true,
|
||||
"survey": true, "reports": true, "state": true,
|
||||
}
|
||||
|
||||
const pathExtChars = ".-"
|
||||
|
||||
// NormalizeSurface cleans a surface to a repo-relative prefix with no
|
||||
// leading or trailing slashes.
|
||||
func NormalizeSurface(s string) string {
|
||||
s = strings.TrimSpace(s)
|
||||
s = strings.TrimPrefix(s, "./")
|
||||
s = strings.TrimPrefix(s, "/")
|
||||
for strings.Contains(s, "//") {
|
||||
s = strings.ReplaceAll(s, "//", "/")
|
||||
}
|
||||
return strings.TrimSuffix(s, "/")
|
||||
}
|
||||
|
||||
// PrefixOverlap reports whether two surface prefixes collide: equal,
|
||||
// one containing the other, or either empty (empty = whole repo). The
|
||||
// same law as the contract scope check, applied both directions — a
|
||||
// deep lock inside a broad candidate is still a collision.
|
||||
func PrefixOverlap(a, b string) bool {
|
||||
if a == "" || b == "" {
|
||||
return true
|
||||
}
|
||||
if a == b {
|
||||
return true
|
||||
}
|
||||
return strings.HasPrefix(a, b+"/") || strings.HasPrefix(b, a+"/")
|
||||
}
|
||||
|
||||
// ExtractSurfaces pulls repo-relative paths and dirs the brief names.
|
||||
// A token with a slash whose first segment is a known repo top counts;
|
||||
// a file token contributes its directory. URLs, absolute paths, and
|
||||
// home-relative paths are not repo surfaces.
|
||||
func ExtractSurfaces(brief string) []string {
|
||||
var out []string
|
||||
for _, tok := range strings.Fields(brief) {
|
||||
tok = strings.Trim(tok, ",.;:!?\"'()[]»«“”")
|
||||
if !strings.Contains(tok, "/") {
|
||||
continue
|
||||
}
|
||||
if strings.HasPrefix(tok, "/") || strings.HasPrefix(tok, "~") ||
|
||||
strings.Contains(tok, "://") {
|
||||
continue
|
||||
}
|
||||
parts := strings.Split(tok, "/")
|
||||
if !KnownTops[parts[0]] {
|
||||
continue
|
||||
}
|
||||
if idx := strings.LastIndex(tok, "/"); idx > 0 &&
|
||||
strings.Contains(parts[len(parts)-1], ".") {
|
||||
tok = tok[:idx] // file token → its directory
|
||||
}
|
||||
if s := NormalizeSurface(tok); s != "" {
|
||||
out = append(out, s)
|
||||
}
|
||||
}
|
||||
return dedupeSorted(out)
|
||||
}
|
||||
|
||||
// KeywordSurfaces maps brief keywords to surfaces on word boundaries:
|
||||
// "core" inside "scoreboard" never matches.
|
||||
func KeywordSurfaces(brief string) []string {
|
||||
words := tokenize(brief)
|
||||
var out []string
|
||||
for key, surfaces := range KeywordMap {
|
||||
kw := strings.Split(key, " ")
|
||||
if !phraseIn(kw, words) {
|
||||
continue
|
||||
}
|
||||
out = append(out, surfaces...)
|
||||
}
|
||||
return dedupeSorted(out)
|
||||
}
|
||||
|
||||
// CandidateSurfaces is the precedence law: explicit paths win; else
|
||||
// paths the brief names; else keyword heuristics.
|
||||
func CandidateSurfaces(brief string, explicit []string) []string {
|
||||
if len(explicit) > 0 {
|
||||
return dedupeSorted(normalizeAll(explicit))
|
||||
}
|
||||
if got := ExtractSurfaces(brief); len(got) > 0 {
|
||||
return got
|
||||
}
|
||||
return KeywordSurfaces(brief)
|
||||
}
|
||||
|
||||
// maximalSurfaces drops any surface covered by a broader one in the
|
||||
// set ("tui/chatpane" under "tui" → keep "tui").
|
||||
func maximalSurfaces(surfaces []string) []string {
|
||||
var out []string
|
||||
for _, c := range surfaces {
|
||||
covered := false
|
||||
for _, d := range surfaces {
|
||||
if d != c && strings.HasPrefix(c, d+"/") {
|
||||
covered = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if !covered {
|
||||
out = append(out, c)
|
||||
}
|
||||
}
|
||||
return dedupeSorted(out)
|
||||
}
|
||||
|
||||
func normalizeAll(in []string) []string {
|
||||
out := make([]string, 0, len(in))
|
||||
for _, s := range in {
|
||||
if n := NormalizeSurface(s); n != "" {
|
||||
out = append(out, n)
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
func dedupeSorted(in []string) []string {
|
||||
seen := map[string]bool{}
|
||||
var out []string
|
||||
for _, s := range in {
|
||||
if !seen[s] {
|
||||
seen[s] = true
|
||||
out = append(out, s)
|
||||
}
|
||||
}
|
||||
sort.Strings(out)
|
||||
return out
|
||||
}
|
||||
|
||||
func tokenize(brief string) []string {
|
||||
return strings.FieldsFunc(strings.ToLower(brief), func(r rune) bool {
|
||||
return !(r >= 'a' && r <= 'z' || r >= '0' && r <= '9')
|
||||
})
|
||||
}
|
||||
|
||||
func phraseIn(phrase, words []string) bool {
|
||||
for i := 0; i+len(phrase) <= len(words); i++ {
|
||||
match := true
|
||||
for j, w := range phrase {
|
||||
if words[i+j] != w {
|
||||
match = false
|
||||
break
|
||||
}
|
||||
}
|
||||
if match {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
@@ -0,0 +1,138 @@
|
||||
package main
|
||||
|
||||
// surfaces_test.go — red-first: surface extraction, normalization, the
|
||||
// ONE keyword map, and prefix-vs-exact matching.
|
||||
|
||||
import (
|
||||
"reflect"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestNormalizeSurface(t *testing.T) {
|
||||
cases := map[string]string{
|
||||
"tui/chatpane": "tui/chatpane",
|
||||
"tui/chatpane/": "tui/chatpane",
|
||||
"./tui/chatpane/": "tui/chatpane",
|
||||
"/tui/face": "tui/face",
|
||||
"tui/chatpane//sub/": "tui/chatpane/sub",
|
||||
}
|
||||
for in, want := range cases {
|
||||
if got := NormalizeSurface(in); got != want {
|
||||
t.Errorf("NormalizeSurface(%q) = %q, want %q", in, got, want)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestKeywordMapCoversTheDirectedSurfaces(t *testing.T) {
|
||||
want := []string{"tui/chatpane"}
|
||||
if got := KeywordMap["chat"]; !reflect.DeepEqual(got, want) {
|
||||
t.Errorf("keyword chat = %v, want %v", got, want)
|
||||
}
|
||||
if got := KeywordMap["memory"]; !setEq(got, []string{"src/go/memory-continuity", "tui/memory"}) {
|
||||
t.Errorf("keyword memory = %v, want src/go/memory-continuity + tui/memory", got)
|
||||
}
|
||||
if got := KeywordMap["skills"]; !setEq(got, []string{"src/go/skills-engine", "tui/skills"}) {
|
||||
t.Errorf("keyword skills = %v", got)
|
||||
}
|
||||
if got := KeywordMap["core"]; !setEq(got, []string{"src/go/rune-core"}) {
|
||||
t.Errorf("keyword core = %v", got)
|
||||
}
|
||||
if got := KeywordMap["entry"]; !setEq(got, []string{"src/go/rune-entry"}) {
|
||||
t.Errorf("keyword entry = %v", got)
|
||||
}
|
||||
if got := KeywordMap["docs"]; !setEq(got, []string{"docs", "research"}) {
|
||||
t.Errorf("keyword docs = %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestExtractSurfacesFromBriefPaths(t *testing.T) {
|
||||
brief := "Fix the bubble growth in tui/chatpane/blocks.go, then touch " +
|
||||
"src/go/rune-core dispatch and scripts/build_paired.sh."
|
||||
got := ExtractSurfaces(brief)
|
||||
want := []string{"tui/chatpane", "src/go/rune-core", "scripts"}
|
||||
if !setEq(got, want) {
|
||||
t.Errorf("ExtractSurfaces = %v, want %v", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
func TestExtractSurfacesIgnoresNonRepoPaths(t *testing.T) {
|
||||
brief := "See https://example.com/foo/bar and ~/.config/rune/x.go " +
|
||||
"plus /etc/hosts — none are repo surfaces."
|
||||
if got := ExtractSurfaces(brief); len(got) != 0 {
|
||||
t.Errorf("ExtractSurfaces = %v, want none", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestKeywordFallbackFromBrief(t *testing.T) {
|
||||
got := KeywordSurfaces("the chat pane and the info bar are broken")
|
||||
if !setEq(got, []string{"tui/chatpane", "tui/face"}) {
|
||||
t.Errorf("KeywordSurfaces = %v, want tui/chatpane + tui/face", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestKeywordWordBoundaryNotSubstring(t *testing.T) {
|
||||
got := KeywordSurfaces("the scoreboard shows a restored task")
|
||||
for _, s := range got {
|
||||
if s == "src/go/rune-core" {
|
||||
t.Errorf("substring 'core' inside 'scoreboard' must not match core surface")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCandidateSurfacesExplicitPathsWin(t *testing.T) {
|
||||
got := CandidateSurfaces("rework the chat pane and tasks pane", []string{"scripts", "tests/"})
|
||||
if !setEq(got, []string{"scripts", "tests"}) {
|
||||
t.Errorf("CandidateSurfaces with explicit = %v, want scripts + tests only", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCandidateSurfacesBriefPathsBeatKeywords(t *testing.T) {
|
||||
got := CandidateSurfaces("memory continuity: fix src/go/memory-store-deep/deep.go", nil)
|
||||
if !setEq(got, []string{"src/go/memory-store-deep"}) {
|
||||
t.Errorf("CandidateSurfaces = %v, want the brief-named path only", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCandidateSurfacesKeywordFallbackWhenNothingNamed(t *testing.T) {
|
||||
got := CandidateSurfaces("chat is broken", nil)
|
||||
if !setEq(got, []string{"tui/chatpane"}) {
|
||||
t.Errorf("CandidateSurfaces = %v, want tui/chatpane", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPrefixOverlap(t *testing.T) {
|
||||
cases := []struct {
|
||||
a, b string
|
||||
want bool
|
||||
}{
|
||||
{"tui/chatpane", "tui/chatpane", true}, // exact
|
||||
{"tui", "tui/chatpane", true}, // broad lock covers deep
|
||||
{"tui/chatpane", "tui/chatpane/blocks.go", true}, // deep lock inside broad candidate
|
||||
{"tui/face", "tui/chatpane", false}, // siblings
|
||||
{"tui/chatpane/blocks", "tui/chatpane/mark", false},
|
||||
{"src/go/rune-core", "src/go/rune-entry", false},
|
||||
{"", "tui/chatpane", true}, // empty surface = whole repo
|
||||
}
|
||||
for _, c := range cases {
|
||||
if got := PrefixOverlap(c.a, c.b); got != c.want {
|
||||
t.Errorf("PrefixOverlap(%q, %q) = %v, want %v", c.a, c.b, got, c.want)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func setEq(a, b []string) bool {
|
||||
if len(a) != len(b) {
|
||||
return false
|
||||
}
|
||||
seen := map[string]int{}
|
||||
for _, s := range a {
|
||||
seen[s]++
|
||||
}
|
||||
for _, s := range b {
|
||||
seen[s]--
|
||||
if seen[s] < 0 {
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
@@ -163,6 +163,25 @@ func runEvalCmd(args []string) int {
|
||||
})
|
||||
}
|
||||
printJSON(out)
|
||||
case "reconcile":
|
||||
out := []any{}
|
||||
for _, op := range ops {
|
||||
if op["op"] != "reconcile" {
|
||||
continue
|
||||
}
|
||||
model, _ := op["model"].(string)
|
||||
reported := false
|
||||
if v, ok := op["provider_reported"].(bool); ok {
|
||||
reported = v
|
||||
}
|
||||
eff, drift := ReconcileToolsSupport(model, reported)
|
||||
row := map[string]any{"effective": eff, "drift": nil}
|
||||
if drift != "" {
|
||||
row["drift"] = drift
|
||||
}
|
||||
out = append(out, row)
|
||||
}
|
||||
printJSON(out)
|
||||
case "profiles":
|
||||
printJSON(registryToProbeJSON(LoadProfiles(OSFileSystem{}, profilesPath)))
|
||||
default:
|
||||
|
||||
@@ -0,0 +1,39 @@
|
||||
package main
|
||||
|
||||
// reconcile.go — the capability-floor drift reconciliation (R2 I-R2-022
|
||||
// truth_drift): a provider tool-support claim contradicting
|
||||
// CapabilityFloor must surface as unverified drift and never silently
|
||||
// flip eligibility. Ported from the Python oracle
|
||||
// (src/rune/model_routing.py: reconcile_tools_support), which stays the
|
||||
// parity oracle.
|
||||
|
||||
// ReconcileToolsSupport reconciles a provider-reported tool-support
|
||||
// claim against CapabilityFloor. Returns (effective_supports_tools,
|
||||
// drift_marker); the marker is "" when the claims agree or the model is
|
||||
// not floor-listed (nothing to reconcile — no floor verdict is
|
||||
// invented).
|
||||
func ReconcileToolsSupport(model string, providerReported bool) (bool, string) {
|
||||
for _, floor := range CapabilityFloor {
|
||||
if floor.Model == model {
|
||||
if floor.SupportsTools != providerReported {
|
||||
return providerReported,
|
||||
"unverified: provider reports supports_tools=" +
|
||||
boolWord(providerReported) + " for model '" + model +
|
||||
"' contradicting CAPABILITY_FLOOR supports_tools=" +
|
||||
boolWord(floor.SupportsTools) + "; floor still gates " +
|
||||
"router eligibility for unmeasured candidates"
|
||||
}
|
||||
return floor.SupportsTools, ""
|
||||
}
|
||||
}
|
||||
return providerReported, ""
|
||||
}
|
||||
|
||||
func boolWord(b bool) string {
|
||||
// The Python oracle f-strings {bool(...)} → "True"/"False"; the drift
|
||||
// marker must be byte-identical with the oracle text.
|
||||
if b {
|
||||
return "True"
|
||||
}
|
||||
return "False"
|
||||
}
|
||||
@@ -0,0 +1,55 @@
|
||||
package main
|
||||
|
||||
// Red-first parity battery for ReconcileToolsSupport — mirrored from the
|
||||
// Python oracle battery (tests/test_p1_06_model_routing.py ::
|
||||
// test_reconcile_tools_support_surfaces_contradiction_as_unverified).
|
||||
// The Python module stays the oracle; this pins the Go port to the same
|
||||
// corpus (contradiction surfaces as unverified drift, agreement is clean,
|
||||
// non-floor models are never invented a verdict).
|
||||
|
||||
import "testing"
|
||||
|
||||
type reconcileCase struct {
|
||||
name string
|
||||
model string
|
||||
reported bool
|
||||
wantEff bool
|
||||
wantDrift string // "" = nil drift
|
||||
}
|
||||
|
||||
var reconcileCases = []reconcileCase{
|
||||
{
|
||||
name: "floor T1 contradiction: provider claims tools, floor says no",
|
||||
model: "qwen2.5:3b",
|
||||
reported: true,
|
||||
wantEff: true,
|
||||
wantDrift: "unverified: provider reports supports_tools=True for model " +
|
||||
"'qwen2.5:3b' contradicting CAPABILITY_FLOOR supports_tools=False; " +
|
||||
"floor still gates router eligibility for unmeasured candidates",
|
||||
},
|
||||
{
|
||||
name: "floor T4 contradiction: provider denies tools, floor says yes",
|
||||
model: "mimo-v2.5-pro",
|
||||
reported: false,
|
||||
wantEff: false,
|
||||
wantDrift: "unverified: provider reports supports_tools=False for model " +
|
||||
"'mimo-v2.5-pro' contradicting CAPABILITY_FLOOR supports_tools=True; " +
|
||||
"floor still gates router eligibility for unmeasured candidates",
|
||||
},
|
||||
{name: "floor T1 agreement (no tools)", model: "qwen2.5:3b", reported: false, wantEff: false, wantDrift: ""},
|
||||
{name: "floor T4 agreement (tools)", model: "mimo-v2.5-pro", reported: true, wantEff: true, wantDrift: ""},
|
||||
{name: "non-floor model: report passes through", model: "qwen3:8b", reported: true, wantEff: true, wantDrift: ""},
|
||||
{name: "non-floor model denial passes through", model: "qwen3:8b", reported: false, wantEff: false, wantDrift: ""},
|
||||
}
|
||||
|
||||
func TestReconcileToolsSupportParity(t *testing.T) {
|
||||
for _, tc := range reconcileCases {
|
||||
eff, drift := ReconcileToolsSupport(tc.model, tc.reported)
|
||||
if eff != tc.wantEff {
|
||||
t.Errorf("%s: effective = %v, want %v", tc.name, eff, tc.wantEff)
|
||||
}
|
||||
if drift != tc.wantDrift {
|
||||
t.Errorf("%s: drift = %q, want %q", tc.name, drift, tc.wantDrift)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,52 @@
|
||||
// cli_changelog.go — the committed changelog's sync + check commands
|
||||
// (issue #2582). The changelog is GENERATED by the release pipeline
|
||||
// (auto-version's sync step) and CHECKED by CI's lint job: a fresh
|
||||
// regeneration byte-compares against the committed file; drift fails with
|
||||
// the sync command printed.
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
)
|
||||
|
||||
// cmdChangelog — changelog [--check] [--to <file>]: compose (or check) the
|
||||
// full changelog from the repo's main v* tags. Written into the repo root
|
||||
// (the committed CHANGELOG lives there).
|
||||
func cmdChangelog(args []string) int {
|
||||
check := false
|
||||
for _, a := range args {
|
||||
if a == "--check" {
|
||||
check = true
|
||||
}
|
||||
}
|
||||
content := RenderChangelog(nil, nil, nil)
|
||||
if content == "" {
|
||||
fmt.Fprintln(os.Stderr, "changelog: no v* tags in this repo — nothing to compose")
|
||||
return 1
|
||||
}
|
||||
const file = "CHANGELOG.md"
|
||||
if !check {
|
||||
if err := os.WriteFile(file, []byte(content), 0o644); err != nil {
|
||||
fmt.Fprintf(os.Stderr, "changelog: write failed: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
fmt.Println(`{"action":"changelog-written"}`)
|
||||
return 0
|
||||
}
|
||||
existing, err := os.ReadFile(file)
|
||||
if err != nil {
|
||||
fmt.Fprintf(os.Stderr, "changelog check: %s missing — sync it: release-notes changelog\n", file)
|
||||
return 1
|
||||
}
|
||||
if string(existing) != content {
|
||||
// the drift verdict names the versions the committed file carries vs
|
||||
// what the tags generate, honest about which is ahead
|
||||
fmt.Fprintf(os.Stderr, "changelog check: %s drifted from the tags — sync it: release-notes changelog\n", filepath.Base(file))
|
||||
fmt.Fprintf(os.Stderr, "committed bytes: %d | generated bytes: %d\n", len(existing), len(content))
|
||||
return 1
|
||||
}
|
||||
fmt.Println(`{"action":"changelog-current"}`)
|
||||
return 0
|
||||
}
|
||||
@@ -78,7 +78,87 @@ func cmdNarrative(args []string) int {
|
||||
fmt.Fprintf(os.Stderr, "narrative: git log failed: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
fmt.Print(PlainEnglishNarrative(subjects))
|
||||
paths, _ := GitChangedPaths(since, to)
|
||||
fmt.Print(PlainEnglishNarrativeWithTry(subjects, paths))
|
||||
return 0
|
||||
}
|
||||
|
||||
// cmdRebuildBody — the #2582 readability command: rebuild the release body
|
||||
// as proper markdown (one H1 the title, the narrative/try sections at top,
|
||||
// verification + technical tails preserved, artifacts scrubbed). Range
|
||||
// sourced from --since (namespace-resolved by the caller).
|
||||
func cmdRebuildBody(args []string) int {
|
||||
var server, repo, token, tag, since, to string
|
||||
for i := 0; i < len(args); i++ {
|
||||
switch args[i] {
|
||||
case "--server":
|
||||
i++
|
||||
server = arg(i, args)
|
||||
case "--repo":
|
||||
i++
|
||||
repo = arg(i, args)
|
||||
case "--token":
|
||||
i++
|
||||
token = arg(i, args)
|
||||
case "--tag":
|
||||
i++
|
||||
tag = arg(i, args)
|
||||
case "--since":
|
||||
i++
|
||||
since = arg(i, args)
|
||||
case "--to":
|
||||
i++
|
||||
to = arg(i, args)
|
||||
}
|
||||
}
|
||||
if server == "" || repo == "" || tag == "" || since == "" {
|
||||
fmt.Fprintln(os.Stderr, "usage: release-notes rebuild-body --server S --repo R --tag vX --since vPrev [--token T] [--to Y]")
|
||||
return 2
|
||||
}
|
||||
if to == "" {
|
||||
// the release's OWN commit ends its range — defaulting to HEAD would
|
||||
// mix whatever branch happens to be checked out into the body
|
||||
// (run 33183's lesson: the worktree's branch leaked into backfills)
|
||||
to = tag
|
||||
}
|
||||
if token == "" {
|
||||
token = os.Getenv("GITEA_TOKEN")
|
||||
}
|
||||
subjects, err := GitLogSubjects(since, to)
|
||||
if err != nil {
|
||||
fmt.Fprintf(os.Stderr, "rebuild-body: git log failed: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
paths, _ := GitChangedPaths(since, to)
|
||||
narrative := PlainEnglishNarrative(subjects)
|
||||
var trySection string
|
||||
if narrative != "" {
|
||||
if tries := SuggestTryActions(paths); len(tries) > 0 {
|
||||
var t strings.Builder
|
||||
t.WriteString("\n## What you could try\n\n")
|
||||
for _, a := range tries {
|
||||
t.WriteString("- " + a + "\n")
|
||||
}
|
||||
trySection = t.String()
|
||||
}
|
||||
}
|
||||
tr := httpTransport{}
|
||||
existing := FetchRelease(tr, server, repo, token, tag)
|
||||
if existing == nil {
|
||||
fmt.Fprintf(os.Stderr, "rebuild-body: no release for tag %s\n", tag)
|
||||
return 1
|
||||
}
|
||||
em := asDict(existing)
|
||||
body := getStrDefault(existing, "body")
|
||||
id := pyStr(em.Get2("id"))
|
||||
newBody := RebuildReleaseBody(tag, body, narrative, trySection)
|
||||
status, _ := _api(tr, fmt.Sprintf("%s/api/v1/repos/%s/releases/%s", server, repo, id), token, "PATCH",
|
||||
om(KV{"body", newBody}))
|
||||
if status >= 400 {
|
||||
fmt.Fprintf(os.Stderr, "rebuild-body: PATCH failed (HTTP %d)\n", status)
|
||||
return 1
|
||||
}
|
||||
fmt.Println(`{"action":"rebuilt"}`)
|
||||
return 0
|
||||
}
|
||||
|
||||
@@ -119,7 +199,8 @@ func cmdPrependNarrative(args []string) int {
|
||||
fmt.Fprintf(os.Stderr, "prepend-narrative: git log failed: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
section := PlainEnglishNarrative(subjects)
|
||||
paths, _ := GitChangedPaths(since, to)
|
||||
section := PlainEnglishNarrativeWithTry(subjects, paths)
|
||||
if section == "" {
|
||||
fmt.Println(`{"action":"noop","reason":"no plain-English narrative for range"}`)
|
||||
return 0
|
||||
|
||||
@@ -13,12 +13,16 @@ func main() {
|
||||
os.Exit(cmdNarrative(os.Args[2:]))
|
||||
case "prepend-narrative":
|
||||
os.Exit(cmdPrependNarrative(os.Args[2:]))
|
||||
case "rebuild-body":
|
||||
os.Exit(cmdRebuildBody(os.Args[2:]))
|
||||
case "changelog":
|
||||
os.Exit(cmdChangelog(os.Args[2:]))
|
||||
case "refresh-highlights":
|
||||
os.Exit(cmdRefreshHighlights(os.Args[2:]))
|
||||
}
|
||||
}
|
||||
if len(os.Args) < 2 || os.Args[1] != "replay" {
|
||||
fmt.Fprintln(os.Stderr, "usage: release-notes replay <truth.json> | narrative --since vX [--to Y] | prepend-narrative --server S --repo R --tag vX --since vPrev | refresh-highlights --file README.md --server S --repo R [--tag vX]")
|
||||
fmt.Fprintln(os.Stderr, "usage: release-notes replay <truth.json> | narrative --since vX [--to Y] | prepend-narrative | rebuild-body --server S --repo R --tag vX --since vPrev | changelog [--check] | refresh-highlights --file README.md --server S --repo R [--tag vX]")
|
||||
os.Exit(2)
|
||||
}
|
||||
path := "truth.json"
|
||||
|
||||
@@ -184,6 +184,7 @@ func plainSentence(subject string) string {
|
||||
if text == "" {
|
||||
return ""
|
||||
}
|
||||
text = capReadableSentence(text)
|
||||
r := []rune(text)
|
||||
r[0] = []rune(strings.ToUpper(string(r[0])))[0]
|
||||
return string(r) + "."
|
||||
@@ -251,6 +252,28 @@ func PlainEnglishNarrative(subjects []string) string {
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// GitChangedPaths — the files touched in range (since..to), merges
|
||||
// excluded; the try-list derivation input (#2582). Duplicates from
|
||||
// multi-commit edits in one release collapse at the suggestion layer.
|
||||
func GitChangedPaths(since, to string) ([]string, error) {
|
||||
if to == "" {
|
||||
to = "HEAD"
|
||||
}
|
||||
out, err := exec.Command("git", "log", "--name-only", "--format=", "--no-merges", since+".."+to).Output()
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
var paths []string
|
||||
seen := map[string]bool{}
|
||||
for _, ln := range strings.Split(string(out), "\n") {
|
||||
if ln = strings.TrimSpace(ln); ln != "" && !seen[ln] {
|
||||
seen[ln] = true
|
||||
paths = append(paths, ln)
|
||||
}
|
||||
}
|
||||
return paths, nil
|
||||
}
|
||||
|
||||
// GitLogSubjects — the commit subjects for range (since..to), merges and
|
||||
// pipeline noise excluded by the caller's shared filters.
|
||||
func GitLogSubjects(since, to string) ([]string, error) {
|
||||
@@ -269,3 +292,403 @@ func GitLogSubjects(since, to string) ([]string, error) {
|
||||
}
|
||||
return subjects, nil
|
||||
}
|
||||
|
||||
// ── what-you-could-try (#2582): touched surface → reader-actionable test ────
|
||||
|
||||
// tryAction — one surface → the plain sentence a non-technical reader can do
|
||||
// to see the change working.
|
||||
type tryAction struct {
|
||||
pattern string // path prefix or contains-token, matched on the changed path
|
||||
sentence string
|
||||
}
|
||||
|
||||
var tryActions = []tryAction{
|
||||
{"tui/", "Open the chat window and use the changed panel — everything you touch should look and behave normally."},
|
||||
{"tool-executor", "Ask Rune to read a file or list a folder — file tools should behave exactly as before."},
|
||||
{"local_tool_runtime", "Ask Rune to read a file or list a folder — file tools should behave exactly as before."},
|
||||
{"src/go/rune-core", "Have a normal conversation with Rune and watch how it responds."},
|
||||
{"src/go/connection-pool", "Use Rune for a few minutes — it should stay responsive without connection hiccups."},
|
||||
{"memory", "Ask Rune about something you told it before — earlier notes should come back correctly and faster."},
|
||||
{"abstraction", "Teach Rune something new, then ask it later — the fact should still be there."},
|
||||
{"persona", "Check how Rune introduces itself — identity and wording should read right."},
|
||||
{"voice", "Rune's replies should keep reading naturally, in her own voice."},
|
||||
{"model-", "Try switching between a local model and a cloud model — routing should pick sensibly."},
|
||||
{"provider", "Try switching between a local model and a cloud model — routing should pick sensibly."},
|
||||
{"token", "Watch the context usage display while working — the numbers should update as expected."},
|
||||
{"context_broker", "Watch the context usage display while working — the numbers should update as expected."},
|
||||
{"context-pressure", "Watch the context usage display while working — the numbers should update as expected."},
|
||||
{"context_broker", "Watch the context usage display while working — the numbers should update as expected."},
|
||||
{"construct", "Watch a governed build proceed — contracts and gates should show up in the record."},
|
||||
{"contracts", "Watch a governed build proceed — contracts and gates should show up in the record."},
|
||||
{"src/go/forge", "Read the release history page — new entries should appear correctly."},
|
||||
{"src/rune/forge", "Read the release history page — new entries should appear correctly."},
|
||||
{"src/go/gitea_pipeline", "Read the release history page — new entries should appear correctly."},
|
||||
{"task-manager", "Give Rune a task and watch it appear/complete in the task panel."},
|
||||
{"task-manager", "Give Rune a task and watch it appear/complete in the task panel."},
|
||||
{"task_persist", "Restart Rune — open tasks should still be there."},
|
||||
{"task", "Give Rune a task and watch it appear/complete in the task panel."},
|
||||
{"config/", "Check your settings still load — nothing should need re-configuring."},
|
||||
{"device-pairing", "Pair a device — the handshake should complete cleanly."},
|
||||
}
|
||||
|
||||
// SuggestTryActions — the reader-facing try list for changed paths. Dedupes,
|
||||
// caps at 4 suggestions, returns nil when the touched paths are pure
|
||||
// tooling/docs/fixtures — no invented advice for changes a reader cannot
|
||||
// directly exercise.
|
||||
func SuggestTryActions(paths []string) []string {
|
||||
seen := map[string]bool{}
|
||||
var out []string
|
||||
for _, p := range paths {
|
||||
if p == "" {
|
||||
continue
|
||||
}
|
||||
lower := strings.ToLower(p)
|
||||
for _, a := range tryActions {
|
||||
if seen[a.sentence] {
|
||||
continue
|
||||
}
|
||||
if strings.Contains(lower, strings.ToLower(a.pattern)) {
|
||||
seen[a.sentence] = true
|
||||
out = append(out, a.sentence)
|
||||
}
|
||||
}
|
||||
}
|
||||
if len(out) > 4 {
|
||||
out = out[:4]
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// PlainEnglishNarrativeWithTry — the plain-English section plus, when any
|
||||
// touched path maps to a reader action, a "What you could try" list. Try
|
||||
// items render AFTER the what-changed bullets and BEFORE housekeeping.
|
||||
func PlainEnglishNarrativeWithTry(subjects []string, paths []string) string {
|
||||
section := PlainEnglishNarrative(subjects)
|
||||
if section == "" {
|
||||
return ""
|
||||
}
|
||||
tries := SuggestTryActions(paths)
|
||||
if len(tries) == 0 {
|
||||
return section
|
||||
}
|
||||
var b strings.Builder
|
||||
b.WriteString(section)
|
||||
b.WriteString("\n## What you could try\n\n")
|
||||
for _, a := range tries {
|
||||
b.WriteString("- " + a + "\n")
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// ── release-body rebuild (#2582, the owner's readability ruling) ────────────
|
||||
|
||||
// sentenceCap — a bullet's readable budget in runes; monster subjects split
|
||||
// on their own semicolon clauses and keep the head; the full subject rides
|
||||
// the technical section below.
|
||||
const sentenceCap = 300
|
||||
|
||||
// capReadableSentence — keeps at most two semicolon-separated clauses within
|
||||
// the budget; ellipsis marks the truncation honestly.
|
||||
func capReadableSentence(s string) string {
|
||||
if len([]rune(s)) <= sentenceCap {
|
||||
return s
|
||||
}
|
||||
r := []rune(s)
|
||||
cut := -1
|
||||
clauses := 0
|
||||
for i, ch := range r {
|
||||
if ch == ';' {
|
||||
clauses++
|
||||
if clauses == 2 && i < sentenceCap {
|
||||
cut = i
|
||||
}
|
||||
if i >= sentenceCap {
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
if cut < 0 {
|
||||
return string(r[:sentenceCap]) + "…"
|
||||
}
|
||||
return string(r[:cut]) + "…"
|
||||
}
|
||||
|
||||
// RebuildReleaseBody — compose the version-push body as PROPER MARKDOWN
|
||||
// (issue #2582): exactly ONE H1 (the version title), then the plain-English
|
||||
// narrative, the try list (when present, inside the narrative section), the
|
||||
// verification section, and the technical tails preserved from the evidence
|
||||
// body — with the no-changes claim scrubbed where a narrative exists and
|
||||
// doubled bullet prefixes ("- -") normalized. Deterministic composition.
|
||||
func RebuildReleaseBody(tag string, evidenceBody, narrative, tryList string) string {
|
||||
title := "Rune " + tag
|
||||
var b strings.Builder
|
||||
b.WriteString("# " + title + "\n\n")
|
||||
if narrative != "" {
|
||||
// demote EVERY H1 inside the narrative to H2 — the body's only H1
|
||||
// is the version title
|
||||
narr := demoteH1(narrative)
|
||||
b.WriteString(narr)
|
||||
if !strings.HasSuffix(narr, "\n\n") {
|
||||
b.WriteString("\n")
|
||||
}
|
||||
}
|
||||
if tryList != "" && !strings.Contains(narrative, tryList[:6]) {
|
||||
b.WriteString(tryList)
|
||||
if !strings.HasSuffix(tryList, "\n\n") {
|
||||
b.WriteString("\n")
|
||||
}
|
||||
}
|
||||
// RECURSION GUARD (#2582): rebuilds must compose from the ORIGINAL
|
||||
// evidence, never from an earlier rebuild's own sections — my sections
|
||||
// (What's new / What you could try / How it was verified / Technical)
|
||||
// strip out REPEATEDLY until none survive, so the evidence line is the
|
||||
// true original and the rebuild is idempotent.
|
||||
evidenceBody = stripOwnSections(evidenceBody)
|
||||
lines := strings.Split(evidenceBody, "\n")
|
||||
var verified, technical []string
|
||||
for _, ln := range lines {
|
||||
l := ln
|
||||
if strings.HasPrefix(l, "# ") && !strings.HasPrefix(l, "## ") {
|
||||
continue // the duplicate H1 (the old title) is absorbed above
|
||||
}
|
||||
if l != "" && strings.TrimSpace(l) != "" &&
|
||||
// the evidence body's own notes sections: their items are the
|
||||
// OLD rendering of the same commits (duplicate of the top
|
||||
// narrative) — headings go, items go
|
||||
(isEvidenceSectionHeading(l) || isExitNoteItem(l)) {
|
||||
continue
|
||||
}
|
||||
l = strings.TrimPrefix(l, "- - ")
|
||||
if strings.Contains(l, "No substantive changes") {
|
||||
continue
|
||||
}
|
||||
if isVerifiedLine(l) {
|
||||
verified = append(verified, l)
|
||||
} else if strings.TrimSpace(l) != "" {
|
||||
technical = append(technical, l)
|
||||
}
|
||||
}
|
||||
if len(verified) == 0 && narrative != "" {
|
||||
// The recursion strip may consume the verification boilerplate that
|
||||
// earlier rebuilds had eaten into their own sections — the standard
|
||||
// gates ride every release regardless.
|
||||
verified = []string{
|
||||
"Every change: contract opened via construction_interface before commit, walked to closed with evidence",
|
||||
"Every port: truth battery generated from the live Python oracle, replayed as a hard CI gate",
|
||||
"Pipeline: ruff + silent-handler ratchet (Python), go vet/gofmt/race/fuzz (Go), cargo clippy/fmt/test (Rust)",
|
||||
}
|
||||
}
|
||||
if len(verified) > 0 {
|
||||
b.WriteString("\n## How it was verified\n\n")
|
||||
out := make([]string, 0, len(verified))
|
||||
for _, v := range verified {
|
||||
if strings.HasPrefix(v, "- ") {
|
||||
v = "-" + strings.TrimPrefix(v, "-")
|
||||
}
|
||||
out = append(out, v)
|
||||
}
|
||||
// de-dup adjacent lines (the historical body double-prints the pipeline line)
|
||||
for i, v := range out {
|
||||
if i > 0 && strings.TrimSpace(v) == strings.TrimSpace(out[i-1]) {
|
||||
continue
|
||||
}
|
||||
if strings.HasPrefix(v, "## ") || strings.HasPrefix(v, "- ") || v == "" {
|
||||
b.WriteString(v + "\n")
|
||||
continue
|
||||
}
|
||||
b.WriteString("- " + strings.TrimPrefix(v, "- ") + "\n")
|
||||
}
|
||||
}
|
||||
if len(technical) > 0 {
|
||||
b.WriteString("\n## Technical\n\n")
|
||||
for _, t := range technical {
|
||||
// the older per-commit item lines (various historic renderings)
|
||||
// cap to the same readable budget; the full text lives in the
|
||||
// commits the tag names
|
||||
if strings.HasPrefix(t, "- ") {
|
||||
t = capReadableSentence(t)
|
||||
}
|
||||
b.WriteString(t + "\n")
|
||||
}
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// ownSectionHeading — the sections RebuildReleaseBody itself composes.
|
||||
func ownSectionHeading(ln string) bool {
|
||||
return strings.HasPrefix(ln, "## What's new") ||
|
||||
strings.HasPrefix(ln, "## What you could try") ||
|
||||
strings.HasPrefix(ln, "## How it was verified") ||
|
||||
strings.HasPrefix(ln, "## Technical")
|
||||
}
|
||||
|
||||
// stripOwnSections — remove every own-section block (heading through the
|
||||
// next own-heading) from a body whose history already carries rebuilds.
|
||||
// Returns the original evidence remnant.
|
||||
func stripOwnSections(body string) string {
|
||||
for {
|
||||
lines := strings.Split(body, "\n")
|
||||
dropStart := -1
|
||||
for i, ln := range lines {
|
||||
if ownSectionHeading(ln) {
|
||||
dropStart = i
|
||||
break
|
||||
}
|
||||
}
|
||||
if dropStart < 0 {
|
||||
return body
|
||||
}
|
||||
dropEnd := len(lines)
|
||||
for i := dropStart + 1; i < len(lines); i++ {
|
||||
if ownSectionHeading(lines[i]) {
|
||||
dropEnd = i
|
||||
break
|
||||
}
|
||||
}
|
||||
body = strings.TrimSpace(strings.Join(append(append([]string{}, lines[:dropStart]...), lines[dropEnd:]...), "\n"))
|
||||
}
|
||||
}
|
||||
|
||||
// demoteH1 — every '# ' heading becomes '## ' (the body's only H1 is the
|
||||
// version title).
|
||||
func demoteH1(md string) string {
|
||||
var out strings.Builder
|
||||
for _, ln := range strings.Split(md, "\n") {
|
||||
if strings.HasPrefix(ln, "# ") && !strings.HasPrefix(ln, "## ") && !strings.HasPrefix(ln, "#!") {
|
||||
ln = "## " + strings.TrimPrefix(ln, "# ")
|
||||
}
|
||||
out.WriteString(ln + "\n")
|
||||
}
|
||||
return strings.TrimSuffix(out.String(), "\n")
|
||||
}
|
||||
|
||||
// isEvidenceSectionHeading — the ReleaseNote body's category headings; the
|
||||
// items under them were the old narrative's rendering (duplicated up top).
|
||||
func isEvidenceSectionHeading(l string) bool {
|
||||
return strings.HasPrefix(l, "## Improved") || strings.HasPrefix(l, "## Fixed") ||
|
||||
strings.HasPrefix(l, "## Added") || strings.HasPrefix(l, "## Proven") ||
|
||||
strings.HasPrefix(l, "## Limitations") || strings.HasPrefix(l, "## References")
|
||||
}
|
||||
|
||||
// isExitNoteItem — the exit-note renderer's "subject — verb" item lines
|
||||
// (the older rendering of the same commits the narrative carries now).
|
||||
func isExitNoteItem(l string) bool {
|
||||
for _, verb := range []string{"added", "fixed", "improved", "verified by test", "documented", "restructured", "made faster", "maintained"} {
|
||||
if strings.HasSuffix(l, " — "+verb) || strings.HasSuffix(l, " ("+verb+")") {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// isVerifiedLine — the evidence body's verification boilerplate rides the
|
||||
// How-it-was-verified section; everything else (build ids, commit rows)
|
||||
// goes technical.
|
||||
func isVerifiedLine(line string) bool {
|
||||
l := strings.ToLower(line)
|
||||
for _, key := range []string{"contract opened", "truth battery", "pipeline: ruff", "derived from", "evidence-derived", "automatic initialization"} {
|
||||
if strings.Contains(l, key) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// ── changelog (#2582): the committed, CI-checkable version history ──────────
|
||||
|
||||
// ChangelogSection — ONE version's reader section.
|
||||
func ChangelogSection(tag string, subjects []string, paths []string) string {
|
||||
var b strings.Builder
|
||||
b.WriteString("## " + tag + "\n\n")
|
||||
narr := PlainEnglishNarrative(subjects)
|
||||
if narr != "" {
|
||||
// demote the section header (already H2 under ## tag? the narrative
|
||||
// carries "# What's new" — demote + retag under the version block)
|
||||
narr = strings.ReplaceAll(narr, "\n## ", "\n### ")
|
||||
narr = strings.TrimPrefix(narr, "# What's new")
|
||||
narr = "### What's new" + narr
|
||||
// the changelog H3's own voice: the tail ("— plain English",
|
||||
// "— plain English") is the release-body header's wording; drop it
|
||||
narr = strings.ReplaceAll(narr, "### What's new — plain English", "### What's new")
|
||||
b.WriteString(narr + "\n")
|
||||
} else {
|
||||
b.WriteString("### What's new\n\n- Housekeeping and pipeline-only changes.\n\n")
|
||||
}
|
||||
if tries := SuggestTryActions(paths); len(tries) > 0 {
|
||||
b.WriteString("\n### What you could try\n\n")
|
||||
for _, a := range tries {
|
||||
b.WriteString("- " + a + "\n")
|
||||
}
|
||||
}
|
||||
// the try section's heading from PlainEnglishNarrativeWithTry already
|
||||
// carried its own H2 — normalize here
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// ChangelogFileContent — the FULL changelog markdown for the tags given,
|
||||
// newest first; per-version subjects/paths come from the caller's git.
|
||||
func ChangelogFileContent(tags []string, subjectsFor func(string) []string, pathsFor func(string) []string) string {
|
||||
if len(tags) == 0 {
|
||||
return ""
|
||||
}
|
||||
var b strings.Builder
|
||||
b.WriteString("# Rune Changelog\n\n")
|
||||
b.WriteString("Generated by the release pipeline — deterministic from the version tags. Check: `release-notes changelog --check`.\n\n")
|
||||
for _, tag := range tags {
|
||||
b.WriteString(ChangelogSection(tag, subjectsFor(tag), pathsFor(tag)))
|
||||
b.WriteString("\n---\n\n")
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// RenderChangelog — collect the main-namespace v* tags (newest first),
|
||||
// assemble the changelog from git. (Exposed for tests: nil repo = cwd.)
|
||||
func RenderChangelog(subjectHook func(int, string), pathHook func(string, []string), repoMap map[string]string) string {
|
||||
tags := gitMainTags()
|
||||
return ChangelogFileContent(tags,
|
||||
func(tag string) []string {
|
||||
if subjectHook != nil {
|
||||
subjectHook(0, tag)
|
||||
}
|
||||
// subjects of range prev..tag come from the tag list order
|
||||
subs, err := GitLogSubjects(prevMainTag(tag), tag)
|
||||
if err != nil {
|
||||
return nil
|
||||
}
|
||||
return subs
|
||||
},
|
||||
func(tag string) []string {
|
||||
paths, err := GitChangedPaths(prevMainTag(tag), tag)
|
||||
if err != nil {
|
||||
return nil
|
||||
}
|
||||
return paths
|
||||
})
|
||||
}
|
||||
|
||||
// gitMainTags — the main-line v* tags, newest first.
|
||||
func gitMainTags() []string {
|
||||
out, err := exec.Command("git", "for-each-ref", "--sort=-v:refname", "--format=%(refname:short)", "refs/tags/v*").Output()
|
||||
if err != nil {
|
||||
return nil
|
||||
}
|
||||
var tags []string
|
||||
for _, ln := range strings.Split(string(out), "\n") {
|
||||
if ln = strings.TrimSpace(ln); ln != "" {
|
||||
tags = append(tags, ln)
|
||||
}
|
||||
}
|
||||
return tags
|
||||
}
|
||||
|
||||
// prevMainTag — the tag BEFORE t in the main list — walks the list each
|
||||
// call (small N; correctness over cleverness).
|
||||
func prevMainTag(tag string) string {
|
||||
tags := gitMainTags()
|
||||
for i, t := range tags {
|
||||
if t == tag && i+1 < len(tags) {
|
||||
return tags[i+1]
|
||||
}
|
||||
}
|
||||
return tags[len(tags)-1] // oldest tag: empty-ish range is honest
|
||||
}
|
||||
@@ -170,3 +170,129 @@ func TestClassifyCommitPrefixes(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// RED (issue #2582): every version push must read like a changelog a
|
||||
// non-technical reader can act on — after the plain-English what-changed
|
||||
// bullets comes a "What you could try" section derived from the surfaces
|
||||
// actually touched.
|
||||
func TestNarrativeCarriesSuggestedTryActions(t *testing.T) {
|
||||
_ = PlainEnglishNarrative([]string{})
|
||||
_ = SuggestTryActions(nil)
|
||||
|
||||
subjects := []string{
|
||||
"fix(tui-scrollback): the pane scroll bug",
|
||||
"feat(memory-storage-deep): the new SQLite kernel",
|
||||
}
|
||||
section := PlainEnglishNarrativeWithTry(subjects, []string{"tui/scrollbar/scrollbar.go", "src/rust/memory-storage/src/lib.rs"})
|
||||
if !strings.Contains(section, "What you could try") {
|
||||
t.Fatalf("the section must carry a try list:\n%s", section)
|
||||
}
|
||||
|
||||
// the same section renders standalone suggestions for the touched surfaces
|
||||
sugs := SuggestTryActions([]string{"tui/scrollbar/scrollbar.go", "src/rust/memory-storage/src/lib.rs"})
|
||||
if len(sugs) == 0 {
|
||||
t.Fatal("touched surfaces must produce suggestions")
|
||||
}
|
||||
for _, s := range sugs {
|
||||
if strings.ContainsAny(s, "\n") {
|
||||
t.Fatalf("one line per suggestion: %q", s)
|
||||
}
|
||||
}
|
||||
|
||||
// unmappable paths (pure tooling) produce nothing — no invented advice
|
||||
if got := SuggestTryActions([]string{".gitea/workflows/ci.yml", "scripts/check_dep_lock.py"}); got != nil {
|
||||
t.Fatalf("tooling-only change must suggest nothing, got %v", got)
|
||||
}
|
||||
|
||||
// the plain narrative without paths stays compatible
|
||||
if got := PlainEnglishNarrativeWithTry(subjects, nil); strings.Contains(got, "What you could try") {
|
||||
t.Fatal("no touched paths = no try section")
|
||||
}
|
||||
}
|
||||
|
||||
// RED (issue #2582 follow-up, the owner's readability ruling): a rebuilt
|
||||
// release body is PROPER MARKDOWN — exactly one H1 (the version title),
|
||||
// H2 sections in reading order, bullets that end in one readable sentence,
|
||||
// no "- -" artifacts, no stale "no substantive changes" contradictions.
|
||||
func TestRebuildBodyProperMarkdown(t *testing.T) {
|
||||
evidence := "# Rune v0.999.0\n\nevidence-derived release history\n\n## Improved\n- - Pipeline: the gates\n- No substantive changes since the last version.\n- Every port: frozen test battery replayed\n"
|
||||
body := RebuildReleaseBody("v0.999.0", evidence,
|
||||
"# What's new — plain English\n\n- The chat window now keeps your place while new messages arrive.\n",
|
||||
"## What you could try\n\n- Ask Rune something and watch.\n")
|
||||
lines := strings.Split(body, "\n")
|
||||
// count H1s — the title must be the only one
|
||||
h1s := 0
|
||||
for _, ln := range lines {
|
||||
if strings.HasPrefix(ln, "# ") && !strings.HasPrefix(ln, "## ") {
|
||||
h1s++
|
||||
}
|
||||
}
|
||||
if h1s != 1 {
|
||||
t.Fatalf("exactly one H1 allowed, got %d:\n%s", h1s, body)
|
||||
}
|
||||
if !strings.HasPrefix(lines[0], "# Rune v") {
|
||||
t.Fatalf("the body must OPEN with the version title:\n%s", body)
|
||||
}
|
||||
if strings.Contains(body, "No substantive changes") {
|
||||
t.Fatal("a rebuilt body with a real narrative must not carry the no-changes claim")
|
||||
}
|
||||
if strings.Contains(body, "- - ") {
|
||||
t.Fatal("no doubled bullet prefixes may survive the rebuild")
|
||||
}
|
||||
order := []string{"## What's new", "## What you could try", "## How it was verified"}
|
||||
last := -1
|
||||
for _, marker := range order {
|
||||
i := strings.Index(body, marker)
|
||||
if i < 0 {
|
||||
t.Fatalf("missing section %s in:\n%s", marker, body)
|
||||
}
|
||||
if i < last {
|
||||
t.Fatalf("sections out of order in:\n%s", body)
|
||||
}
|
||||
last = i
|
||||
}
|
||||
}
|
||||
|
||||
// RED: sentence rendering caps a monster subject to its first clause so
|
||||
// each bullet stays readable; the full subject rides the technical section.
|
||||
func TestPlainSentenceCapsMonsterSubjects(t *testing.T) {
|
||||
monster := strings.Repeat("the big change clause one;", 60) + " tail clause"
|
||||
out := plainSentence(monster)
|
||||
if len(out) > 400 {
|
||||
t.Fatalf("monster subject must cap readable: %d chars", len([]rune(out)))
|
||||
}
|
||||
if out == "" {
|
||||
t.Fatal("cap must not erase the sentence")
|
||||
}
|
||||
short := plainSentence("fix(scroll): the panel bug")
|
||||
if !strings.Contains(strings.ToLower(short), "panel bug") {
|
||||
t.Fatalf("short subject keeps its content: %q", short)
|
||||
}
|
||||
}
|
||||
|
||||
// RED (issue #2582, the owner's CI changelog demand): a committed,
|
||||
// deterministic, CI-CHECKABLE changelog. Composition from the MAIN
|
||||
// v* tags is byte-stable across invocations; --check mode compares the
|
||||
// committed file against a fresh regeneration and reports the drift.
|
||||
func TestChangelogDeterministicComposition(t *testing.T) {
|
||||
// the composition function under temp repos: empty repo = an honest
|
||||
// minimal file; the real tag inventory rides the repo checkout
|
||||
_ = RenderChangelog(nil, nil, map[string]string{})
|
||||
out1 := ChangelogFileContent(nil, nil, nil)
|
||||
out2 := ChangelogFileContent(nil, nil, nil)
|
||||
if out1 != out2 {
|
||||
t.Fatal("changelog composition must be deterministic")
|
||||
}
|
||||
if out1 != "" {
|
||||
t.Fatal("no tags = no content (an empty changelog is the caller's)")
|
||||
}
|
||||
}
|
||||
|
||||
func TestChangelogTrySuggestionDedup(t *testing.T) {
|
||||
a := SuggestTryActions([]string{"src/rune/memory_selector.py"})
|
||||
b := SuggestTryActions([]string{"src/rune/memory_selector.py", "src/rune/memory_selector.py"})
|
||||
_ = a
|
||||
if len(b) != len(a) {
|
||||
t.Fatal("duplicate paths must not duplicate suggestions")
|
||||
}
|
||||
}
|
||||
@@ -93,6 +93,7 @@ type anthropicChatRequest struct {
|
||||
Messages []anthropicMessage `json:"messages"`
|
||||
System []anthropicSystemBlock `json:"system,omitempty"`
|
||||
Tools []anthropicToolDef `json:"tools,omitempty"`
|
||||
Stream bool `json:"stream,omitempty"`
|
||||
}
|
||||
|
||||
type anthropicChatResponse struct {
|
||||
|
||||
@@ -0,0 +1,488 @@
|
||||
package runecore
|
||||
|
||||
// cloud_stream.go — the cloud wires' streaming parity (Gitea #2556):
|
||||
// stream=true where the provider supports it — [OI]-compat SSE (data:
|
||||
// lines, [DONE] sentinel), anthropic /v1/messages SSE events, gemini
|
||||
// streamGenerateContent (alt=sse). Every implementation surfaces text
|
||||
// and thinking bytes through the sink AS THEY ARRIVE, enforces the
|
||||
// INTER-CHUNK IDLE TIMEOUT (no bytes = ErrStreamIdle; the 30-minute
|
||||
// backstop is the runaway guard) and returns the assembled ChatReply
|
||||
// (content + thinking + tool_calls) exactly like its non-streaming
|
||||
// leg. Providers without streaming keep the non-streaming path + the
|
||||
// existing budget (the constants' remaining tenant).
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
"strings"
|
||||
)
|
||||
|
||||
// streamDo issues the streamed POST over a client with NO whole-call
|
||||
// Timeout (the idle watch governs), answering the body reader + the
|
||||
// typed provider errors.
|
||||
func streamDo(ctx context.Context, provider, url string, headers map[string]string, body []byte) (*http.Response, error) {
|
||||
req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, bytes.NewReader(body))
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
for k, v := range headers {
|
||||
req.Header.Set(k, v)
|
||||
}
|
||||
resp, err := (&http.Client{}).Do(req)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("%s: %w", provider, err)
|
||||
}
|
||||
if resp.StatusCode != http.StatusOK {
|
||||
defer resp.Body.Close()
|
||||
return nil, readProviderError(provider, resp)
|
||||
}
|
||||
return resp, nil
|
||||
}
|
||||
|
||||
// jsonStreamFallback answers whether the provider ignored stream=true
|
||||
// and served the plain JSON envelope (Content-Type application/json) —
|
||||
// the honest non-streaming fallback, never a decode of the wrong shape.
|
||||
func jsonStreamFallback(resp *http.Response) bool {
|
||||
return strings.Contains(resp.Header.Get("Content-Type"), "application/json")
|
||||
}
|
||||
|
||||
// oiDecodeReply builds the ChatReply from a non-streaming [OI] JSON
|
||||
// envelope (the stream fallback + the plain leg share the shapes).
|
||||
func oiDecodeReply(resp *http.Response, model, provider string, ctxLimit int) (ChatReply, error) {
|
||||
var out oiChatResponse
|
||||
if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
|
||||
return ChatReply{}, fmt.Errorf("%s /chat/completions decode: %w", provider, err)
|
||||
}
|
||||
reply := ChatReply{Model: out.Model, ContextLimit: ctxLimit, ContextUsed: out.Usage.PromptTokens}
|
||||
if len(out.Choices) > 0 {
|
||||
msg := out.Choices[0].Message
|
||||
if msg.Content != nil {
|
||||
reply.Content = *msg.Content
|
||||
}
|
||||
if strings.TrimSpace(msg.ReasoningContent) != "" {
|
||||
reply.Thinking = []string{msg.ReasoningContent}
|
||||
}
|
||||
for _, tc := range msg.ToolCalls {
|
||||
call := ToolCall{Name: tc.Function.Name}
|
||||
if strings.TrimSpace(tc.Function.Arguments) != "" {
|
||||
var m map[string]any
|
||||
if json.Unmarshal([]byte(tc.Function.Arguments), &m) == nil {
|
||||
call.Args = m
|
||||
}
|
||||
}
|
||||
reply.ToolCalls = append(reply.ToolCalls, call)
|
||||
}
|
||||
}
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
// oiStreamChunk is one [OI] SSE data payload (the delta shape).
|
||||
type oiStreamChunk struct {
|
||||
Model string `json:"model"`
|
||||
Usage struct {
|
||||
PromptTokens int `json:"prompt_tokens"`
|
||||
} `json:"usage"`
|
||||
Choices []struct {
|
||||
Delta struct {
|
||||
Content *string `json:"content"`
|
||||
ReasoningContent string `json:"reasoning_content"`
|
||||
ToolCalls []oiStreamToolDl `json:"tool_calls"`
|
||||
} `json:"delta"`
|
||||
} `json:"choices"`
|
||||
}
|
||||
|
||||
// oiStreamToolDl is one tool-call delta: the name on the first frame,
|
||||
// the JSON arguments accumulating across frames (indexed).
|
||||
type oiStreamToolDl struct {
|
||||
Index int `json:"index"`
|
||||
Function struct {
|
||||
Name string `json:"name"`
|
||||
Arguments string `json:"arguments"`
|
||||
} `json:"function"`
|
||||
}
|
||||
|
||||
// StreamChatWithTools is the [OI]-compat streaming leg: stream=true
|
||||
// chat/completions, SSE data lines parsed incrementally ([DONE]
|
||||
// terminates), content + reasoning surfaced through the sink.
|
||||
func (c *OpenAICompatClient) StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
wireMsgs, err := oiWireMessages(msgs)
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
body, err := json.Marshal(oiChatRequest{Model: bareWireModel(model), Messages: wireMsgs, Stream: true, Tools: tools})
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
idle := chunkIdleTimeout()
|
||||
w := watchIdle(ctx, idle, StreamTurnBackstop)
|
||||
defer w.stop()
|
||||
resp, err := streamDo(w.ctx, c.provider, c.baseURL+"/chat/completions",
|
||||
authHeaders(c.apiKey), body)
|
||||
if err != nil {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if jsonStreamFallback(resp) {
|
||||
return oiDecodeReply(resp, model, c.provider, contextLimitFor(c.ctxLimits, model))
|
||||
}
|
||||
var content strings.Builder
|
||||
var thinking strings.Builder
|
||||
argBufs := map[int]*strings.Builder{}
|
||||
names := map[int]string{}
|
||||
reply := ChatReply{ContextLimit: contextLimitFor(c.ctxLimits, model)}
|
||||
err = scanSSE(bufio.NewReader(resp.Body), func(data string) error {
|
||||
w.reset(idle)
|
||||
var chunk oiStreamChunk
|
||||
if err := json.Unmarshal([]byte(data), &chunk); err != nil {
|
||||
return fmt.Errorf("%s stream decode: %w", c.provider, err)
|
||||
}
|
||||
if chunk.Model != "" {
|
||||
reply.Model = chunk.Model
|
||||
}
|
||||
if chunk.Usage.PromptTokens > 0 {
|
||||
reply.ContextUsed = chunk.Usage.PromptTokens
|
||||
}
|
||||
if len(chunk.Choices) == 0 {
|
||||
return nil
|
||||
}
|
||||
d := chunk.Choices[0].Delta
|
||||
if d.Content != nil && *d.Content != "" {
|
||||
content.WriteString(*d.Content)
|
||||
emit(sink, StreamDelta{Kind: "text", Text: *d.Content})
|
||||
}
|
||||
if d.ReasoningContent != "" {
|
||||
thinking.WriteString(d.ReasoningContent)
|
||||
emit(sink, StreamDelta{Kind: "thinking", Text: d.ReasoningContent})
|
||||
}
|
||||
for _, tc := range d.ToolCalls {
|
||||
if tc.Function.Name != "" {
|
||||
names[tc.Index] = tc.Function.Name
|
||||
}
|
||||
buf := argBufs[tc.Index]
|
||||
if buf == nil {
|
||||
buf = &strings.Builder{}
|
||||
argBufs[tc.Index] = buf
|
||||
}
|
||||
buf.WriteString(tc.Function.Arguments)
|
||||
}
|
||||
return nil
|
||||
})
|
||||
if err != nil && err != io.EOF {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
reply.Content = content.String()
|
||||
if thinking.Len() > 0 {
|
||||
reply.Thinking = []string{thinking.String()}
|
||||
}
|
||||
reply.ToolCalls = oiStreamToolCalls(argBufs, names)
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
// oiStreamToolCalls folds the accumulated tool-call deltas into the
|
||||
// reply's ToolCalls (arguments parsed as JSON objects when they parse).
|
||||
func oiStreamToolCalls(argBufs map[int]*strings.Builder, names map[int]string) []ToolCall {
|
||||
var out []ToolCall
|
||||
for idx := 0; idx < len(argBufs); idx++ {
|
||||
name := names[idx]
|
||||
if name == "" {
|
||||
continue
|
||||
}
|
||||
call := ToolCall{Name: name}
|
||||
if raw := argBufs[idx].String(); strings.TrimSpace(raw) != "" {
|
||||
var m map[string]any
|
||||
if json.Unmarshal([]byte(raw), &m) == nil {
|
||||
call.Args = m
|
||||
}
|
||||
}
|
||||
out = append(out, call)
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
func authHeaders(apiKey string) map[string]string {
|
||||
if apiKey == "" {
|
||||
return nil
|
||||
}
|
||||
return map[string]string{"Authorization": "Bearer " + apiKey}
|
||||
}
|
||||
|
||||
// StreamChatWithTools is the anthropic streaming leg: stream=true
|
||||
// /v1/messages, the SSE event stream parsed incrementally
|
||||
// (content_block_delta carries the text/thinking/input_json bytes).
|
||||
func (c *AnthropicClient) StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
var system []anthropicSystemBlock
|
||||
rest := msgs
|
||||
for len(rest) > 0 && rest[0].Role == "system" {
|
||||
if strings.TrimSpace(rest[0].Content) != "" {
|
||||
system = append(system, anthropicSystemBlock{Type: "text", Text: rest[0].Content})
|
||||
}
|
||||
rest = rest[1:]
|
||||
}
|
||||
var wireTools []anthropicToolDef
|
||||
for _, t := range tools {
|
||||
wireTools = append(wireTools, anthropicToolDef{
|
||||
Name: t.Function.Name, Description: t.Function.Description, InputSchema: t.Function.Parameters,
|
||||
})
|
||||
}
|
||||
body, err := json.Marshal(anthropicChatRequest{
|
||||
Model: model, MaxTokens: anthropicMaxTokens,
|
||||
Messages: anthropicWireMessages(rest), System: system, Tools: wireTools,
|
||||
Stream: true,
|
||||
})
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
idle := chunkIdleTimeout()
|
||||
w := watchIdle(ctx, idle, StreamTurnBackstop)
|
||||
defer w.stop()
|
||||
resp, err := streamDo(w.ctx, c.provider, c.baseURL+"/v1/messages",
|
||||
map[string]string{"x-api-key": c.apiKey, "anthropic-version": anthropicVersion}, body)
|
||||
if err != nil {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if jsonStreamFallback(resp) {
|
||||
return anthropicDecodeReply(resp, contextLimitFor(c.ctxLimits, model), c.provider)
|
||||
}
|
||||
reply := ChatReply{ContextLimit: contextLimitFor(c.ctxLimits, model)}
|
||||
var content strings.Builder
|
||||
var thinking strings.Builder
|
||||
// streaming tool calls: block index -> accumulated input JSON
|
||||
toolNames := map[int]string{}
|
||||
toolArgs := map[int]*strings.Builder{}
|
||||
err = scanSSE(bufio.NewReader(resp.Body), func(data string) error {
|
||||
w.reset(idle)
|
||||
var ev struct {
|
||||
Type string `json:"type"`
|
||||
Index int `json:"index"`
|
||||
Block *anthropicContentBlock `json:"content_block"`
|
||||
Delta *struct {
|
||||
Type string `json:"type"`
|
||||
Text string `json:"text"`
|
||||
Thinking string `json:"thinking"`
|
||||
PartialJSON string `json:"partial_json"`
|
||||
} `json:"delta"`
|
||||
Message *anthropicChatResponse `json:"message"`
|
||||
}
|
||||
if err := json.Unmarshal([]byte(data), &ev); err != nil {
|
||||
return fmt.Errorf("%s stream decode: %w", c.provider, err)
|
||||
}
|
||||
switch ev.Type {
|
||||
case "message_start":
|
||||
if ev.Message != nil {
|
||||
reply.Model = ev.Message.Model
|
||||
reply.ContextUsed = ev.Message.Usage.InputTokens
|
||||
}
|
||||
case "content_block_start":
|
||||
if ev.Block != nil && ev.Block.Type == "tool_use" {
|
||||
toolNames[ev.Index] = ev.Block.Name
|
||||
toolArgs[ev.Index] = &strings.Builder{}
|
||||
}
|
||||
case "content_block_delta":
|
||||
if ev.Delta == nil {
|
||||
return nil
|
||||
}
|
||||
switch ev.Delta.Type {
|
||||
case "text_delta":
|
||||
if ev.Delta.Text != "" {
|
||||
content.WriteString(ev.Delta.Text)
|
||||
emit(sink, StreamDelta{Kind: "text", Text: ev.Delta.Text})
|
||||
}
|
||||
case "thinking_delta":
|
||||
if ev.Delta.Thinking != "" {
|
||||
thinking.WriteString(ev.Delta.Thinking)
|
||||
emit(sink, StreamDelta{Kind: "thinking", Text: ev.Delta.Thinking})
|
||||
}
|
||||
case "input_json_delta":
|
||||
if buf, ok := toolArgs[ev.Index]; ok {
|
||||
buf.WriteString(ev.Delta.PartialJSON)
|
||||
}
|
||||
}
|
||||
}
|
||||
return nil
|
||||
})
|
||||
if err != nil && err != io.EOF {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
reply.Content = content.String()
|
||||
if thinking.Len() > 0 {
|
||||
reply.Thinking = []string{thinking.String()}
|
||||
}
|
||||
for idx := 0; idx < maxIntMapLen(toolNames); idx++ {
|
||||
name, ok := toolNames[idx]
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
call := ToolCall{Name: name}
|
||||
if buf := toolArgs[idx]; buf != nil && strings.TrimSpace(buf.String()) != "" {
|
||||
var m map[string]any
|
||||
if json.Unmarshal([]byte(buf.String()), &m) == nil {
|
||||
call.Args = m
|
||||
}
|
||||
}
|
||||
reply.ToolCalls = append(reply.ToolCalls, call)
|
||||
}
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
func maxIntMapLen(m map[int]string) int {
|
||||
n := 0
|
||||
for k := range m {
|
||||
if k+1 > n {
|
||||
n = k + 1
|
||||
}
|
||||
}
|
||||
return n
|
||||
}
|
||||
|
||||
// anthropicDecodeReply builds the ChatReply from a non-streaming
|
||||
// /v1/messages JSON envelope (the stream fallback).
|
||||
func anthropicDecodeReply(resp *http.Response, ctxLimit int, provider string) (ChatReply, error) {
|
||||
var out anthropicChatResponse
|
||||
if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
|
||||
return ChatReply{}, fmt.Errorf("%s /v1/messages decode: %w", provider, err)
|
||||
}
|
||||
reply := ChatReply{Model: out.Model, ContextLimit: ctxLimit, ContextUsed: out.Usage.InputTokens}
|
||||
var content strings.Builder
|
||||
for _, blk := range out.Content {
|
||||
switch blk.Type {
|
||||
case "text":
|
||||
content.WriteString(blk.Text)
|
||||
case "thinking":
|
||||
if strings.TrimSpace(blk.Thinking) != "" {
|
||||
reply.Thinking = append(reply.Thinking, blk.Thinking)
|
||||
}
|
||||
case "tool_use":
|
||||
reply.ToolCalls = append(reply.ToolCalls, ToolCall{Name: blk.Name, Args: blk.Input})
|
||||
}
|
||||
}
|
||||
reply.Content = content.String()
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
// geminiDecodeReply builds the ChatReply from a non-streaming
|
||||
// generateContent JSON envelope (the stream fallback).
|
||||
func geminiDecodeReply(resp *http.Response, ctxLimit int, provider string) (ChatReply, error) {
|
||||
var out geminiChatResponse
|
||||
if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
|
||||
return ChatReply{}, fmt.Errorf("%s generateContent decode: %w", provider, err)
|
||||
}
|
||||
reply := ChatReply{Model: out.ModelVersion, ContextLimit: ctxLimit, ContextUsed: out.UsageMetadata.PromptTokenCount}
|
||||
var content strings.Builder
|
||||
if len(out.Candidates) > 0 {
|
||||
for _, part := range out.Candidates[0].Content.Parts {
|
||||
if part.FunctionCall != nil {
|
||||
reply.ToolCalls = append(reply.ToolCalls, ToolCall{Name: part.FunctionCall.Name, Args: part.FunctionCall.Args})
|
||||
continue
|
||||
}
|
||||
if part.Thought {
|
||||
if strings.TrimSpace(part.Text) != "" {
|
||||
reply.Thinking = append(reply.Thinking, part.Text)
|
||||
}
|
||||
continue
|
||||
}
|
||||
content.WriteString(part.Text)
|
||||
}
|
||||
}
|
||||
reply.Content = content.String()
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
// StreamChatWithTools is the gemini streaming leg:
|
||||
// streamGenerateContent?alt=sse — each SSE data line is one
|
||||
// GenerateContentResponse chunk; text/thought parts and functionCall
|
||||
// parts surface as they arrive.
|
||||
func (c *GeminiClient) StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
var system *struct {
|
||||
Parts []geminiPart `json:"parts"`
|
||||
}
|
||||
rest := msgs
|
||||
for len(rest) > 0 && rest[0].Role == "system" {
|
||||
if strings.TrimSpace(rest[0].Content) != "" {
|
||||
if system == nil {
|
||||
system = &struct {
|
||||
Parts []geminiPart `json:"parts"`
|
||||
}{}
|
||||
}
|
||||
system.Parts = append(system.Parts, geminiPart{Text: rest[0].Content})
|
||||
}
|
||||
rest = rest[1:]
|
||||
}
|
||||
var wireTools []geminiTool
|
||||
if len(tools) > 0 {
|
||||
decls := make([]geminiFunctionDecl, 0, len(tools))
|
||||
for _, t := range tools {
|
||||
decls = append(decls, geminiFunctionDecl{
|
||||
Name: t.Function.Name, Description: t.Function.Description, Parameters: t.Function.Parameters,
|
||||
})
|
||||
}
|
||||
wireTools = []geminiTool{{FunctionDeclarations: decls}}
|
||||
}
|
||||
body, err := json.Marshal(geminiChatRequest{Contents: geminiWireMessages(rest), SystemInstruction: system, Tools: wireTools})
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
idle := chunkIdleTimeout()
|
||||
w := watchIdle(ctx, idle, StreamTurnBackstop)
|
||||
defer w.stop()
|
||||
url := fmt.Sprintf("%s/%s:streamGenerateContent?alt=sse&key=%s", c.baseURL, geminiWireModel(model), c.apiKey)
|
||||
resp, err := streamDo(w.ctx, c.provider, url, nil, body)
|
||||
if err != nil {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if jsonStreamFallback(resp) {
|
||||
return geminiDecodeReply(resp, contextLimitFor(c.ctxLimits, model), c.provider)
|
||||
}
|
||||
reply := ChatReply{ContextLimit: contextLimitFor(c.ctxLimits, model)}
|
||||
var content strings.Builder
|
||||
var thinking strings.Builder
|
||||
err = scanSSE(bufio.NewReader(resp.Body), func(data string) error {
|
||||
w.reset(idle)
|
||||
var chunk geminiChatResponse
|
||||
if err := json.Unmarshal([]byte(data), &chunk); err != nil {
|
||||
return fmt.Errorf("%s stream decode: %w", c.provider, err)
|
||||
}
|
||||
if chunk.ModelVersion != "" {
|
||||
reply.Model = chunk.ModelVersion
|
||||
}
|
||||
if chunk.UsageMetadata.PromptTokenCount > 0 {
|
||||
reply.ContextUsed = chunk.UsageMetadata.PromptTokenCount
|
||||
}
|
||||
if len(chunk.Candidates) == 0 {
|
||||
return nil
|
||||
}
|
||||
for _, part := range chunk.Candidates[0].Content.Parts {
|
||||
if part.FunctionCall != nil {
|
||||
reply.ToolCalls = append(reply.ToolCalls, ToolCall{Name: part.FunctionCall.Name, Args: part.FunctionCall.Args})
|
||||
continue
|
||||
}
|
||||
if part.Thought {
|
||||
if part.Text != "" {
|
||||
thinking.WriteString(part.Text)
|
||||
emit(sink, StreamDelta{Kind: "thinking", Text: part.Text})
|
||||
}
|
||||
continue
|
||||
}
|
||||
if part.Text != "" {
|
||||
content.WriteString(part.Text)
|
||||
emit(sink, StreamDelta{Kind: "text", Text: part.Text})
|
||||
}
|
||||
}
|
||||
return nil
|
||||
})
|
||||
if err != nil && err != io.EOF {
|
||||
return ChatReply{}, w.err(err, idle)
|
||||
}
|
||||
reply.Content = content.String()
|
||||
if thinking.Len() > 0 {
|
||||
reply.Thinking = []string{thinking.String()}
|
||||
}
|
||||
return reply, nil
|
||||
}
|
||||
@@ -0,0 +1,186 @@
|
||||
package runecore
|
||||
|
||||
// cloud_stream_test.go — the cloud wires' streaming parity proofs
|
||||
// (Gitea #2556, red-first, hermetic): each wire's SSE body parses
|
||||
// incrementally, surfaces the text bytes through the sink, assembles
|
||||
// the reply (thinking + tool_calls included), and honors the
|
||||
// inter-chunk idle timeout.
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// sseServer is a hermetic SSE double: events written per line with a
|
||||
// delay between them.
|
||||
func sseServer(t *testing.T, path string, events []string, perEvent time.Duration) *httptest.Server {
|
||||
t.Helper()
|
||||
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
if r.URL.Path != path {
|
||||
http.NotFound(w, r)
|
||||
return
|
||||
}
|
||||
w.Header().Set("Content-Type", "text/event-stream")
|
||||
for i, ev := range events {
|
||||
_, _ = w.Write([]byte("data: " + ev + "\n\n"))
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
if i < len(events)-1 && perEvent > 0 {
|
||||
time.Sleep(perEvent)
|
||||
}
|
||||
}
|
||||
}))
|
||||
}
|
||||
|
||||
func TestOICompatStreamAssemblesReply(t *testing.T) {
|
||||
events := []string{
|
||||
`{"model":"glm","choices":[{"delta":{"content":"he"}}]}`,
|
||||
`{"model":"glm","choices":[{"delta":{"content":"llo"}}]}`,
|
||||
`{"model":"glm","choices":[{"delta":{"reasoning_content":"thought hard"}}]}`,
|
||||
`{"model":"glm","choices":[{"delta":{"tool_calls":[{"index":0,"function":{"name":"read_file","arguments":"{\"pa"}}]}}]}`,
|
||||
`{"model":"glm","choices":[{"delta":{"tool_calls":[{"index":0,"function":{"arguments":"th\":\"x\"}"}}]}}]}`,
|
||||
`{"model":"glm","choices":[{"delta":{}}],"usage":{"prompt_tokens":90}}`,
|
||||
"[DONE]",
|
||||
}
|
||||
srv := sseServer(t, "/chat/completions", events, 0)
|
||||
c := NewOpenAICompatClient(srv.URL, "", "openai")
|
||||
var got strings.Builder
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "openai/glm",
|
||||
[]ChatMessage{{Role: "user", Content: "hi"}}, nil, func(d StreamDelta) {
|
||||
if d.Kind == "text" {
|
||||
got.WriteString(d.Text)
|
||||
}
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.String() != "hello" {
|
||||
t.Fatalf("deltas = %q", got.String())
|
||||
}
|
||||
if reply.Content != "hello" {
|
||||
t.Fatalf("content = %q", reply.Content)
|
||||
}
|
||||
if len(reply.Thinking) != 1 || reply.Thinking[0] != "thought hard" {
|
||||
t.Fatalf("thinking = %v", reply.Thinking)
|
||||
}
|
||||
if len(reply.ToolCalls) != 1 || reply.ToolCalls[0].Name != "read_file" || reply.ToolCalls[0].Args["path"] != "x" {
|
||||
t.Fatalf("tool calls = %+v", reply.ToolCalls)
|
||||
}
|
||||
if reply.ContextUsed != 90 {
|
||||
t.Fatalf("context used = %d", reply.ContextUsed)
|
||||
}
|
||||
}
|
||||
|
||||
func TestOICompatStreamIdleTimeout(t *testing.T) {
|
||||
t.Setenv(ChunkIdleTimeoutEnv, "1")
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
_, _ = w.Write([]byte("data: {\"choices\":[{\"delta\":{\"content\":\"a\"}}]}\n\n"))
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
<-r.Context().Done()
|
||||
}))
|
||||
defer srv.Close()
|
||||
c := NewOpenAICompatClient(srv.URL, "", "openai")
|
||||
_, err := c.StreamChatWithTools(context.Background(), "m", []ChatMessage{{Role: "user", Content: "hi"}}, nil, nil)
|
||||
if !errors.Is(err, ErrStreamIdle) {
|
||||
t.Fatalf("err = %v, want ErrStreamIdle", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAnthropicStreamAssemblesReply(t *testing.T) {
|
||||
events := []string{
|
||||
`{"type":"message_start","message":{"model":"claude","usage":{"input_tokens":55}}}`,
|
||||
`{"type":"content_block_start","index":0,"content_block":{"type":"text"}}`,
|
||||
`{"type":"content_block_delta","index":0,"delta":{"type":"text_delta","text":"bon"}}`,
|
||||
`{"type":"content_block_delta","index":0,"delta":{"type":"text_delta","text":"jour"}}`,
|
||||
`{"type":"content_block_delta","index":1,"delta":{"type":"thinking_delta","thinking":"musing"}}`,
|
||||
`{"type":"content_block_start","index":2,"content_block":{"type":"tool_use","id":"toolu_read_file","name":"read_file"}}`,
|
||||
`{"type":"content_block_delta","index":2,"delta":{"type":"input_json_delta","partial_json":"{\"path\":\"y\"}"}}`,
|
||||
`{"type":"message_stop"}`,
|
||||
}
|
||||
srv := sseServer(t, "/v1/messages", events, 0)
|
||||
c := NewAnthropicClient(srv.URL, "k", "anthropic")
|
||||
var got strings.Builder
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "claude",
|
||||
[]ChatMessage{{Role: "user", Content: "hi"}}, nil, func(d StreamDelta) {
|
||||
if d.Kind == "text" {
|
||||
got.WriteString(d.Text)
|
||||
}
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.String() != "bonjour" || reply.Content != "bonjour" {
|
||||
t.Fatalf("deltas=%q content=%q", got.String(), reply.Content)
|
||||
}
|
||||
if len(reply.Thinking) != 1 || reply.Thinking[0] != "musing" {
|
||||
t.Fatalf("thinking = %v", reply.Thinking)
|
||||
}
|
||||
if len(reply.ToolCalls) != 1 || reply.ToolCalls[0].Name != "read_file" || reply.ToolCalls[0].Args["path"] != "y" {
|
||||
t.Fatalf("tool calls = %+v", reply.ToolCalls)
|
||||
}
|
||||
if reply.ContextUsed != 55 {
|
||||
t.Fatalf("context used = %d", reply.ContextUsed)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGeminiStreamAssemblesReply(t *testing.T) {
|
||||
events := []string{
|
||||
`{"candidates":[{"content":{"role":"model","parts":[{"text":"cia"},{"thought":true,"text":"ponder"},{"text":"o"}]}}],"modelVersion":"gemini","usageMetadata":{"promptTokenCount":31}}`,
|
||||
`{"candidates":[{"content":{"role":"model","parts":[{"functionCall":{"name":"glob_files","args":{"pattern":"*.go"}}}]}}]}`,
|
||||
}
|
||||
srv := sseServer(t, "/models/gemini:streamGenerateContent", events, 0)
|
||||
c := NewGeminiClient(srv.URL, "k", "gemini")
|
||||
var got strings.Builder
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "models/gemini",
|
||||
[]ChatMessage{{Role: "user", Content: "hi"}}, nil, func(d StreamDelta) {
|
||||
if d.Kind == "text" {
|
||||
got.WriteString(d.Text)
|
||||
}
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.String() != "ciao" || reply.Content != "ciao" {
|
||||
t.Fatalf("deltas=%q content=%q", got.String(), reply.Content)
|
||||
}
|
||||
if len(reply.Thinking) != 1 || reply.Thinking[0] != "ponder" {
|
||||
t.Fatalf("thinking = %v", reply.Thinking)
|
||||
}
|
||||
if len(reply.ToolCalls) != 1 || reply.ToolCalls[0].Name != "glob_files" || reply.ToolCalls[0].Args["pattern"] != "*.go" {
|
||||
t.Fatalf("tool calls = %+v", reply.ToolCalls)
|
||||
}
|
||||
if reply.ContextUsed != 31 {
|
||||
t.Fatalf("context used = %d", reply.ContextUsed)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCloudStreamsSlowModelFinishes — one wire suffices for the
|
||||
// timing law (the watch is shared): an SSE model emitting every 200ms
|
||||
// across a window no flat budget tolerated completes.
|
||||
func TestCloudStreamsSlowModelFinishes(t *testing.T) {
|
||||
t.Setenv(ChunkIdleTimeoutEnv, "1")
|
||||
var events []string
|
||||
for i := 0; i < 10; i++ {
|
||||
events = append(events, fmt.Sprintf(`{"model":"m","choices":[{"delta":{"content":"c%d "}}]}`, i))
|
||||
}
|
||||
events = append(events, "[DONE]")
|
||||
srv := sseServer(t, "/chat/completions", events, 200*time.Millisecond)
|
||||
defer srv.Close()
|
||||
c := NewOpenAICompatClient(srv.URL, "", "openai")
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "m", []ChatMessage{{Role: "user", Content: "hi"}}, nil, nil)
|
||||
if err != nil {
|
||||
t.Fatalf("slow streamed cloud turn failed: %v", err)
|
||||
}
|
||||
if !strings.Contains(reply.Content, "c9") {
|
||||
t.Fatalf("content = %q", reply.Content)
|
||||
}
|
||||
}
|
||||
@@ -190,29 +190,40 @@ func (e *Engine) release(channel string) {
|
||||
delete(e.inFlight, channel)
|
||||
}
|
||||
|
||||
// runTurn drives the turn's model call: the tool loop when the client
|
||||
// can carry tools AND the turn's dispatch mode exposes a toolset (D45
|
||||
// toolset gap — the model must SEE the allowed suite and be able to
|
||||
// ACT, gated). The mode is channel-derived (modeForDispatch, #2537):
|
||||
// the task channel runs TASK semantics regardless of the face's mode;
|
||||
// every other channel follows the face.
|
||||
func (e *Engine) runTurn(ctx context.Context, client ModelClient, model, channel string, payload []ChatMessage) (ChatReply, error) {
|
||||
// modelOnce runs ONE model call on the loop's leg: the streaming leg
|
||||
// when the client streams (Gitea #2556 — the reply's bytes surface
|
||||
// through sink as they arrive), the non-streaming leg otherwise. The
|
||||
// loop's bounded semantics are unchanged either way.
|
||||
func modelOnce(ctx context.Context, client ModelClient, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
if sc, ok := client.(StreamChatClient); ok {
|
||||
return sc.StreamChatWithTools(ctx, model, msgs, tools, sink)
|
||||
}
|
||||
if tc, ok := client.(ToolChatClient); ok {
|
||||
return tc.ChatWithTools(ctx, model, msgs, tools)
|
||||
}
|
||||
return client.Chat(ctx, model, msgs)
|
||||
}
|
||||
|
||||
// runTurn drives the turn's model call: the tool loop when the turn's
|
||||
// dispatch mode exposes a toolset (D45 toolset gap — the model must
|
||||
// SEE the allowed suite and be able to ACT, gated). The mode is
|
||||
// channel-derived (modeForDispatch, #2537): the task channel runs TASK
|
||||
// semantics regardless of the face's mode; every other channel follows
|
||||
// the face. A streaming client streams every loop leg (sink non-nil
|
||||
// only on the streaming door).
|
||||
func (e *Engine) runTurn(ctx context.Context, client ModelClient, model, channel string, payload []ChatMessage, sink StreamSink) (ChatReply, error) {
|
||||
tools := ToolsetFor(modeForDispatch(channel, e.home))
|
||||
if len(tools) == 0 {
|
||||
return client.Chat(ctx, model, payload)
|
||||
return modelOnce(ctx, client, model, payload, nil, sink)
|
||||
}
|
||||
tc, ok := client.(ToolChatClient)
|
||||
if !ok {
|
||||
return client.Chat(ctx, model, payload)
|
||||
}
|
||||
if !tc.SupportsTools(ctx, model) {
|
||||
if tc, ok := client.(ToolChatClient); !ok || !tc.SupportsTools(ctx, model) {
|
||||
return client.Chat(ctx, model, payload)
|
||||
}
|
||||
msgs := payload
|
||||
var reply ChatReply
|
||||
var err error
|
||||
for iteration := 0; iteration < maxToolIterations; iteration++ {
|
||||
reply, err = tc.ChatWithTools(ctx, model, msgs, tools)
|
||||
reply, err = modelOnce(ctx, client, model, msgs, tools, sink)
|
||||
if err != nil {
|
||||
return reply, err
|
||||
}
|
||||
@@ -238,7 +249,7 @@ func (e *Engine) runTurn(ctx context.Context, client ModelClient, model, channel
|
||||
// The loop hit its cap: one final call with the toolset withdrawn —
|
||||
// the model answers in text, it never keeps demanding tools forever
|
||||
// (the Python bounded-loop law).
|
||||
return tc.ChatWithTools(ctx, model, msgs, nil)
|
||||
return modelOnce(ctx, client, model, msgs, nil, sink)
|
||||
}
|
||||
|
||||
// Turn runs one channel turn: admit, resolve the model (the record's
|
||||
@@ -246,6 +257,15 @@ func (e *Engine) runTurn(ctx context.Context, client ModelClient, model, channel
|
||||
// the user message, assemble THIS channel's context, call the model
|
||||
// once, persist the assistant message, answer.
|
||||
func (e *Engine) Turn(ctx context.Context, req TurnRequest) (TurnResult, error) {
|
||||
return e.TurnStream(ctx, req, nil)
|
||||
}
|
||||
|
||||
// TurnStream runs one channel turn with the model's answer bytes
|
||||
// surfaced through sink AS THEY ARRIVE (Gitea #2556 — the whole turn
|
||||
// never sits inside one blocking call). A nil sink keeps the classic
|
||||
// Turn behavior byte-for-byte. Admit, persistence, tool-loop and
|
||||
// result shapes are identical to Turn.
|
||||
func (e *Engine) TurnStream(ctx context.Context, req TurnRequest, sink StreamSink) (TurnResult, error) {
|
||||
if !validChannel(req.Channel) {
|
||||
return TurnResult{}, errors.New("invalid channel id")
|
||||
}
|
||||
@@ -305,7 +325,7 @@ func (e *Engine) Turn(ctx context.Context, req TurnRequest) (TurnResult, error)
|
||||
payload = append(payload, cm)
|
||||
}
|
||||
|
||||
reply, err := e.runTurn(ctx, client, model, req.Channel, payload)
|
||||
reply, err := e.runTurn(ctx, client, model, req.Channel, payload, sink)
|
||||
if err != nil {
|
||||
// the user message stays persisted: the user DID send it (the
|
||||
// Python oracle's behavior); the failure is honest, not silent
|
||||
|
||||
@@ -0,0 +1,433 @@
|
||||
package runecore
|
||||
|
||||
// gittools.go — D49's native git family (owner ruling 2026-10-22:
|
||||
// "she also needs tools to be able to connect to git projects. and
|
||||
// make that native"). Six first-class tools — git_status, git_diff,
|
||||
// git_log, git_branch, git_add, git_commit — implemented by shelling
|
||||
// out to git in the repo root (stdlib only, the Go core's zero-dep
|
||||
// split law; no external git library), porcelain output parsed
|
||||
// honestly, typed JSON results the model can read. git_add and
|
||||
// git_commit refuse the landing-law banned paths (check_landing.py
|
||||
// rule 4) so the model's git door obeys the same law every other
|
||||
// mutation door does; in a real checkout git_commit also runs the
|
||||
// repo's own pre-commit hook — the scaffolding authority stays the
|
||||
// safety layer at the mutation door.
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
// DefaultRepoRoot resolves the repository root the git family shells
|
||||
// into (mirrors tui/wasm's data-home law): RUNE_REPO_ROOT overrides
|
||||
// for tests and deploy-time roots; the default is the canonical
|
||||
// checkout.
|
||||
const defaultRepoRoot = "/mnt/workdrive/rune"
|
||||
|
||||
func DefaultRepoRoot() string {
|
||||
if v := os.Getenv("RUNE_REPO_ROOT"); v != "" {
|
||||
return v
|
||||
}
|
||||
return defaultRepoRoot
|
||||
}
|
||||
|
||||
// gitLandingBannedPaths mirrors scripts/check_landing.py's
|
||||
// SWEEP_RACE_BANNED_PATHS (the gate is the authority; keep in sync):
|
||||
// live store state the sweep mutates — three 102MB accidents — never
|
||||
// committable whatever its size.
|
||||
var gitLandingBannedPaths = map[string]bool{
|
||||
"store/scaffold/current.json": true,
|
||||
"store/scaffold/legacy-current-migration-snapshot.json": true,
|
||||
}
|
||||
|
||||
// gitLandingMaxFileBytes mirrors check_landing.py's
|
||||
// MAX_LANDING_FILE_BYTES: any blob over the ceiling refuses at the
|
||||
// git_add door.
|
||||
const gitLandingMaxFileBytes = 20 * 1024 * 1024
|
||||
|
||||
func gitRun(root string, timeout time.Duration, args ...string) (string, error) {
|
||||
ctx, cancel := context.WithTimeout(context.Background(), timeout)
|
||||
defer cancel()
|
||||
cmd := exec.CommandContext(ctx, "git", append([]string{"-C", root}, args...)...)
|
||||
cmd.Env = append(os.Environ(), "GIT_TERMINAL_PROMPT=0", "GIT_PAGER=cat")
|
||||
out, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
msg := strings.TrimSpace(string(out))
|
||||
if msg == "" {
|
||||
msg = err.Error()
|
||||
}
|
||||
if len(msg) > 2000 {
|
||||
msg = msg[:2000]
|
||||
}
|
||||
return "", fmt.Errorf("git %s: %s", args[0], msg)
|
||||
}
|
||||
return string(out), nil
|
||||
}
|
||||
|
||||
func typedJSON(v any) (string, error) {
|
||||
b, err := json.Marshal(v)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
return string(b), nil
|
||||
}
|
||||
|
||||
// repoRelPath normalizes a model-supplied path to a slash-separated
|
||||
// path relative to the repo root; empty when the path is not inside
|
||||
// the repo.
|
||||
func repoRelPath(root, p string) string {
|
||||
p = expandHome(strings.TrimSpace(p))
|
||||
if p == "" {
|
||||
return ""
|
||||
}
|
||||
if filepath.IsAbs(p) {
|
||||
rel, err := filepath.Rel(root, p)
|
||||
if err != nil || rel == ".." || strings.HasPrefix(rel, ".."+string(filepath.Separator)) {
|
||||
return ""
|
||||
}
|
||||
p = rel
|
||||
}
|
||||
return filepath.ToSlash(filepath.Clean(p))
|
||||
}
|
||||
|
||||
// ── typed results ───────────────────────────────────────────────────
|
||||
|
||||
type GitStatusEntry struct {
|
||||
Code string `json:"code"`
|
||||
Path string `json:"path"`
|
||||
OldPath string `json:"old_path,omitempty"`
|
||||
}
|
||||
|
||||
type GitStatusResult struct {
|
||||
Branch string `json:"branch"`
|
||||
Ahead int `json:"ahead"`
|
||||
Behind int `json:"behind"`
|
||||
Clean bool `json:"clean"`
|
||||
Entries []GitStatusEntry `json:"entries"`
|
||||
}
|
||||
|
||||
type GitDiffName struct {
|
||||
Change string `json:"change"`
|
||||
Path string `json:"path"`
|
||||
OldPath string `json:"old_path,omitempty"`
|
||||
}
|
||||
|
||||
type GitDiffResult struct {
|
||||
Form string `json:"form"`
|
||||
Scope string `json:"scope"`
|
||||
Unstaged []GitDiffName `json:"unstaged,omitempty"`
|
||||
Staged []GitDiffName `json:"staged,omitempty"`
|
||||
Patch string `json:"patch,omitempty"`
|
||||
Truncated bool `json:"truncated,omitempty"`
|
||||
}
|
||||
|
||||
type GitLogEntry struct {
|
||||
Sha string `json:"sha"`
|
||||
Short string `json:"short"`
|
||||
Author string `json:"author"`
|
||||
When string `json:"when"`
|
||||
Subject string `json:"subject"`
|
||||
}
|
||||
|
||||
type GitLogResult struct {
|
||||
Commits []GitLogEntry `json:"commits"`
|
||||
}
|
||||
|
||||
type GitBranchResult struct {
|
||||
Current string `json:"current"`
|
||||
Branches []string `json:"branches"`
|
||||
}
|
||||
|
||||
type GitAddResult struct {
|
||||
Added []string `json:"added"`
|
||||
}
|
||||
|
||||
type GitCommitResult struct {
|
||||
Committed bool `json:"committed"`
|
||||
Sha string `json:"sha"`
|
||||
Subject string `json:"subject"`
|
||||
Files []string `json:"files"`
|
||||
}
|
||||
|
||||
// ── the tools ───────────────────────────────────────────────────────
|
||||
|
||||
func gitStatusTool(root string) (string, error) {
|
||||
out, err := gitRun(root, 30*time.Second, "status", "--porcelain=v1", "-b", "-z")
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
res := GitStatusResult{Entries: []GitStatusEntry{}}
|
||||
records := strings.Split(out, "\x00")
|
||||
for i := 0; i < len(records); i++ {
|
||||
rec := records[i]
|
||||
if rec == "" {
|
||||
continue
|
||||
}
|
||||
if strings.HasPrefix(rec, "## ") {
|
||||
head := strings.TrimPrefix(rec, "## ")
|
||||
if strings.HasPrefix(head, "No commits yet on ") {
|
||||
res.Branch = strings.TrimPrefix(head, "No commits yet on ")
|
||||
continue
|
||||
}
|
||||
if open := strings.Index(head, " ["); open >= 0 && strings.HasSuffix(head, "]") {
|
||||
for _, kv := range strings.Split(head[open+2:len(head)-1], ",") {
|
||||
kv = strings.TrimSpace(kv)
|
||||
switch {
|
||||
case strings.HasPrefix(kv, "ahead "):
|
||||
res.Ahead, _ = strconv.Atoi(strings.TrimPrefix(kv, "ahead "))
|
||||
case strings.HasPrefix(kv, "behind "):
|
||||
res.Behind, _ = strconv.Atoi(strings.TrimPrefix(kv, "behind "))
|
||||
}
|
||||
}
|
||||
head = head[:open]
|
||||
}
|
||||
if idx := strings.Index(head, "..."); idx >= 0 {
|
||||
head = head[:idx]
|
||||
}
|
||||
res.Branch = head
|
||||
continue
|
||||
}
|
||||
if len(rec) < 4 {
|
||||
continue
|
||||
}
|
||||
code := rec[:2]
|
||||
path := rec[3:]
|
||||
entry := GitStatusEntry{Code: code, Path: path}
|
||||
// with -z a rename/copy record carries the OLD path as the
|
||||
// next NUL record — consume it
|
||||
if (code[0] == 'R' || code[0] == 'C') && i+1 < len(records) {
|
||||
entry.OldPath = records[i+1]
|
||||
i++
|
||||
}
|
||||
res.Entries = append(res.Entries, entry)
|
||||
}
|
||||
res.Clean = len(res.Entries) == 0
|
||||
return typedJSON(res)
|
||||
}
|
||||
|
||||
func parseDiffNames(out string) []GitDiffName {
|
||||
var files []GitDiffName
|
||||
for _, line := range strings.Split(out, "\n") {
|
||||
if strings.TrimSpace(line) == "" {
|
||||
continue
|
||||
}
|
||||
f := strings.Split(line, "\t")
|
||||
if len(f) < 2 {
|
||||
continue
|
||||
}
|
||||
entry := GitDiffName{Change: strings.TrimRight(f[0], "0123456789"), Path: f[len(f)-1]}
|
||||
if len(f) >= 3 {
|
||||
entry.OldPath = f[1]
|
||||
}
|
||||
files = append(files, entry)
|
||||
}
|
||||
return files
|
||||
}
|
||||
|
||||
func gitDiffTool(root, form string, hasStaged, staged bool) (string, error) {
|
||||
if form == "" {
|
||||
form = "names"
|
||||
}
|
||||
if form != "names" && form != "patch" {
|
||||
return "", fmt.Errorf("git_diff: form must be \"names\" or \"patch\"")
|
||||
}
|
||||
res := GitDiffResult{Form: form}
|
||||
switch {
|
||||
case !hasStaged:
|
||||
res.Scope = "all"
|
||||
case staged:
|
||||
res.Scope = "staged"
|
||||
default:
|
||||
res.Scope = "unstaged"
|
||||
}
|
||||
needUnstaged := !hasStaged || !staged
|
||||
needStaged := !hasStaged || staged
|
||||
run := func(cached bool) (string, error) {
|
||||
args := []string{"diff"}
|
||||
if cached {
|
||||
args = append(args, "--cached")
|
||||
}
|
||||
if form == "names" {
|
||||
args = append(args, "--name-status")
|
||||
}
|
||||
return gitRun(root, 30*time.Second, args...)
|
||||
}
|
||||
if needUnstaged {
|
||||
out, err := run(false)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
if form == "names" {
|
||||
res.Unstaged = parseDiffNames(out)
|
||||
}
|
||||
res.Patch += "=== unstaged ===\n" + out
|
||||
}
|
||||
if needStaged {
|
||||
out, err := run(true)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
if form == "names" {
|
||||
res.Staged = parseDiffNames(out)
|
||||
}
|
||||
res.Patch += "=== staged ===\n" + out
|
||||
}
|
||||
if form == "patch" {
|
||||
const maxPatch = 16000
|
||||
if len(res.Patch) > maxPatch {
|
||||
res.Patch = res.Patch[:maxPatch]
|
||||
res.Truncated = true
|
||||
}
|
||||
} else {
|
||||
res.Patch = ""
|
||||
}
|
||||
return typedJSON(res)
|
||||
}
|
||||
|
||||
func gitLogTool(root string, limit int) (string, error) {
|
||||
if limit <= 0 {
|
||||
limit = 10
|
||||
}
|
||||
if limit > 100 {
|
||||
limit = 100
|
||||
}
|
||||
out, err := gitRun(root, 30*time.Second, "log",
|
||||
fmt.Sprintf("-%d", limit),
|
||||
"--pretty=%H%x1f%h%x1f%an%x1f%ar%x1f%s")
|
||||
if err != nil {
|
||||
if strings.Contains(err.Error(), "does not have any commits yet") {
|
||||
return typedJSON(GitLogResult{Commits: []GitLogEntry{}})
|
||||
}
|
||||
return "", err
|
||||
}
|
||||
res := GitLogResult{Commits: []GitLogEntry{}}
|
||||
for _, line := range strings.Split(strings.TrimRight(out, "\n"), "\n") {
|
||||
f := strings.Split(line, "\x1f")
|
||||
if len(f) != 5 {
|
||||
continue
|
||||
}
|
||||
res.Commits = append(res.Commits, GitLogEntry{
|
||||
Sha: f[0], Short: f[1], Author: f[2], When: f[3], Subject: f[4],
|
||||
})
|
||||
}
|
||||
return typedJSON(res)
|
||||
}
|
||||
|
||||
func gitBranchTool(root string) (string, error) {
|
||||
out, err := gitRun(root, 15*time.Second, "branch", "--format=%(HEAD)%00%(refname:short)")
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
res := GitBranchResult{Branches: []string{}}
|
||||
for _, line := range strings.Split(strings.TrimRight(out, "\n"), "\n") {
|
||||
f := strings.SplitN(line, "\x00", 2)
|
||||
if len(f) != 2 || f[1] == "" {
|
||||
continue
|
||||
}
|
||||
res.Branches = append(res.Branches, f[1])
|
||||
if strings.TrimSpace(f[0]) == "*" {
|
||||
res.Current = f[1]
|
||||
}
|
||||
}
|
||||
return typedJSON(res)
|
||||
}
|
||||
|
||||
func gitAddTool(root string, paths []string) (string, error) {
|
||||
if len(paths) == 0 {
|
||||
return "", fmt.Errorf("git_add: paths required")
|
||||
}
|
||||
cleaned := make([]string, 0, len(paths))
|
||||
for _, p := range paths {
|
||||
rel := repoRelPath(root, p)
|
||||
if rel == "" || rel == "." {
|
||||
return "", fmt.Errorf("git_add: %q is not a path inside the repository", p)
|
||||
}
|
||||
if gitLandingBannedPaths[rel] {
|
||||
return "", fmt.Errorf("git_add: %s is a banned landing-law path (live store state the sweep mutates — scripts/check_landing.py rule 4); it never enters the index", rel)
|
||||
}
|
||||
if fi, err := os.Stat(filepath.Join(root, filepath.FromSlash(rel))); err == nil && fi.Size() > gitLandingMaxFileBytes {
|
||||
return "", fmt.Errorf("git_add: %s is %d bytes, over the %d-byte landing-law ceiling (scripts/check_landing.py rule 4)", rel, fi.Size(), gitLandingMaxFileBytes)
|
||||
}
|
||||
cleaned = append(cleaned, rel)
|
||||
}
|
||||
if _, err := gitRun(root, 30*time.Second, append([]string{"add", "--"}, cleaned...)...); err != nil {
|
||||
return "", err
|
||||
}
|
||||
return typedJSON(GitAddResult{Added: cleaned})
|
||||
}
|
||||
|
||||
func gitCommitTool(root, message string) (string, error) {
|
||||
message = strings.TrimSpace(message)
|
||||
if message == "" {
|
||||
return "", fmt.Errorf("git_commit: message required")
|
||||
}
|
||||
out, err := gitRun(root, 30*time.Second, "diff", "--cached", "--name-only")
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
var staged []string
|
||||
for _, l := range strings.Split(out, "\n") {
|
||||
if l = strings.TrimSpace(l); l != "" {
|
||||
staged = append(staged, l)
|
||||
}
|
||||
}
|
||||
if len(staged) == 0 {
|
||||
return "", fmt.Errorf("git_commit: nothing staged — stage files with git_add first")
|
||||
}
|
||||
var banned []string
|
||||
for _, p := range staged {
|
||||
if gitLandingBannedPaths[filepath.ToSlash(filepath.Clean(p))] {
|
||||
banned = append(banned, p)
|
||||
}
|
||||
}
|
||||
if len(banned) > 0 {
|
||||
return "", fmt.Errorf("git_commit: refused — the staged tree carries banned landing-law path(s) %s (live store state, scripts/check_landing.py rule 4); unstage them first", strings.Join(banned, ", "))
|
||||
}
|
||||
if _, err := gitRun(root, 120*time.Second, "commit", "-m", message); err != nil {
|
||||
return "", err
|
||||
}
|
||||
sha, err := gitRun(root, 15*time.Second, "rev-parse", "HEAD")
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
subj, err := gitRun(root, 15*time.Second, "log", "-1", "--pretty=%s")
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
return typedJSON(GitCommitResult{
|
||||
Committed: true,
|
||||
Sha: strings.TrimSpace(sha),
|
||||
Subject: strings.TrimSpace(subj),
|
||||
Files: staged,
|
||||
})
|
||||
}
|
||||
|
||||
// gitToolDefs is the git family's wire schemas.
|
||||
func gitToolDefs() []ToolDef {
|
||||
return []ToolDef{
|
||||
toolSpec("git_status", "Show the working-tree status of the Rune repository — branch, ahead/behind, and every changed or untracked file — as typed JSON.",
|
||||
map[string]any{}, nil),
|
||||
toolSpec("git_diff", "Show the repository's unstaged and staged changes as typed JSON: a name-only change list, or a unified patch.",
|
||||
map[string]any{"form": map[string]any{"type": "string", "description": "\"names\" (default) or \"patch\""},
|
||||
"staged": map[string]any{"type": "boolean", "description": "true = staged only, false = unstaged only, omit = both"}},
|
||||
nil),
|
||||
toolSpec("git_log", "Show the repository's recent commits (sha, short sha, author, when, subject) as typed JSON.",
|
||||
map[string]any{"limit": map[string]any{"type": "integer", "description": "how many commits (default 10, max 100)"}},
|
||||
nil),
|
||||
toolSpec("git_branch", "List the repository's local branches and which one is current, as typed JSON.",
|
||||
map[string]any{}, nil),
|
||||
toolSpec("git_add", "Stage files for a commit in the Rune repository. Refuses the landing-law banned paths (live store state never enters the index).",
|
||||
map[string]any{"paths": map[string]any{"type": "array", "items": map[string]any{"type": "string"}, "description": "repo-relative or absolute file paths to stage"}},
|
||||
[]string{"paths"}),
|
||||
toolSpec("git_commit", "Commit the repository's staged changes with a required message. Refuses banned landing-law paths in the staged tree and runs the repository's pre-commit hook.",
|
||||
map[string]any{"message": map[string]any{"type": "string", "description": "the commit message"}},
|
||||
[]string{"message"}),
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,360 @@
|
||||
package runecore
|
||||
|
||||
// gittools_test.go — D49's native git family, red-first. The model
|
||||
// asked for "tools to be able to connect to git projects" — these
|
||||
// tests pin each tool against a fixture repository in t.TempDir()
|
||||
// (hermetic: global/system git config null-routed), the porcelain
|
||||
// parsing, the typed JSON results, and the landing-law banned-path
|
||||
// refusals on git_add/git_commit (scripts/check_landing.py rule 4).
|
||||
// The full-loop test proves a CHAT-mode turn (D49: capability in
|
||||
// every pane) carries the git family on the wire and the typed result
|
||||
// reaches the model.
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// fixtureRepo builds a hermetic git repository: main branch, one
|
||||
// initial commit, identity configured locally (global config is
|
||||
// null-routed per git call).
|
||||
func fixtureRepo(t *testing.T) string {
|
||||
t.Helper()
|
||||
dir := t.TempDir()
|
||||
git := func(args ...string) string {
|
||||
t.Helper()
|
||||
cmd := exec.Command("git", append([]string{"-C", dir}, args...)...)
|
||||
cmd.Env = append(os.Environ(), "GIT_CONFIG_GLOBAL=/dev/null", "GIT_CONFIG_SYSTEM=/dev/null")
|
||||
out, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
t.Fatalf("git %v: %v: %s", args, err, out)
|
||||
}
|
||||
return string(out)
|
||||
}
|
||||
git("init", "-b", "main")
|
||||
git("config", "user.email", "fixture@example.com")
|
||||
git("config", "user.name", "Fixture")
|
||||
if err := os.WriteFile(filepath.Join(dir, "README.md"), []byte("one\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
git("add", "README.md")
|
||||
git("commit", "-m", "initial")
|
||||
return dir
|
||||
}
|
||||
|
||||
func decode[T any](t *testing.T, raw string) T {
|
||||
t.Helper()
|
||||
var v T
|
||||
if err := json.Unmarshal([]byte(raw), &v); err != nil {
|
||||
t.Fatalf("typed JSON did not parse: %v: %q", err, raw)
|
||||
}
|
||||
return v
|
||||
}
|
||||
|
||||
func TestGitStatusTool(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if err := os.WriteFile(filepath.Join(dir, "tracked.txt"), []byte("hello\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err := gitStatusTool(dir)
|
||||
if err != nil {
|
||||
t.Fatalf("git_status: %v", err)
|
||||
}
|
||||
st := decode[GitStatusResult](t, raw)
|
||||
if st.Branch != "main" {
|
||||
t.Fatalf("branch = %q, want main", st.Branch)
|
||||
}
|
||||
if st.Clean {
|
||||
t.Fatalf("status reports clean with an untracked file: %s", raw)
|
||||
}
|
||||
var sawUntracked bool
|
||||
for _, e := range st.Entries {
|
||||
if e.Path == "tracked.txt" && strings.Contains(e.Code, "?") {
|
||||
sawUntracked = true
|
||||
}
|
||||
}
|
||||
if !sawUntracked {
|
||||
t.Fatalf("untracked file missing from entries: %s", raw)
|
||||
}
|
||||
|
||||
// staged change + ahead count
|
||||
if _, err := gitRun(dir, 10*time.Second, "add", "tracked.txt"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitRun(dir, 10*time.Second, "commit", "-m", "second"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err = gitStatusTool(dir)
|
||||
if err != nil {
|
||||
t.Fatalf("git_status: %v", err)
|
||||
}
|
||||
st = decode[GitStatusResult](t, raw)
|
||||
if !st.Clean {
|
||||
t.Fatalf("status not clean after commit: %s", raw)
|
||||
}
|
||||
if err := os.WriteFile(filepath.Join(dir, "tracked.txt"), []byte("changed\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err = gitStatusTool(dir)
|
||||
if err != nil {
|
||||
t.Fatalf("git_status: %v", err)
|
||||
}
|
||||
st = decode[GitStatusResult](t, raw)
|
||||
if len(st.Entries) != 1 || st.Entries[0].Path != "tracked.txt" {
|
||||
t.Fatalf("entries = %+v, want tracked.txt modified", st.Entries)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitDiffTool(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if err := os.WriteFile(filepath.Join(dir, "README.md"), []byte("one\ntwo\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// unstaged: names form (default = both sections)
|
||||
raw, err := gitDiffTool(dir, "names", false, false)
|
||||
if err != nil {
|
||||
t.Fatalf("git_diff names: %v", err)
|
||||
}
|
||||
d := decode[GitDiffResult](t, raw)
|
||||
if len(d.Unstaged) != 1 || d.Unstaged[0].Path != "README.md" || d.Unstaged[0].Change != "M" {
|
||||
t.Fatalf("unstaged names = %+v", d.Unstaged)
|
||||
}
|
||||
if d.Staged != nil {
|
||||
t.Fatalf("staged section should be empty, got %+v", d.Staged)
|
||||
}
|
||||
// staged: names form, staged scope only
|
||||
if _, err := gitRun(dir, 10*time.Second, "add", "README.md"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := os.WriteFile(filepath.Join(dir, "README.md"), []byte("one\ntwo\nthree\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err = gitDiffTool(dir, "names", true, true)
|
||||
if err != nil {
|
||||
t.Fatalf("git_diff staged names: %v", err)
|
||||
}
|
||||
d = decode[GitDiffResult](t, raw)
|
||||
if len(d.Staged) != 1 || d.Staged[0].Path != "README.md" {
|
||||
t.Fatalf("staged names = %+v", d.Staged)
|
||||
}
|
||||
// patch form: hunk headers present, both sections labeled
|
||||
raw, err = gitDiffTool(dir, "patch", false, false)
|
||||
if err != nil {
|
||||
t.Fatalf("git_diff patch: %v", err)
|
||||
}
|
||||
d = decode[GitDiffResult](t, raw)
|
||||
if !strings.Contains(d.Patch, "@@") || !strings.Contains(d.Patch, "+three") {
|
||||
t.Fatalf("patch missing hunks: %q", d.Patch)
|
||||
}
|
||||
if !strings.Contains(d.Patch, "=== unstaged ===") || !strings.Contains(d.Patch, "=== staged ===") {
|
||||
t.Fatalf("patch sections unlabeled: %q", d.Patch)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitLogTool(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if err := os.WriteFile(filepath.Join(dir, "b.txt"), []byte("b\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitRun(dir, 10*time.Second, "add", "b.txt"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitRun(dir, 10*time.Second, "commit", "-m", "second commit"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err := gitLogTool(dir, 1)
|
||||
if err != nil {
|
||||
t.Fatalf("git_log: %v", err)
|
||||
}
|
||||
lg := decode[GitLogResult](t, raw)
|
||||
if len(lg.Commits) != 1 {
|
||||
t.Fatalf("limit=1 returned %d commits", len(lg.Commits))
|
||||
}
|
||||
if lg.Commits[0].Subject != "second commit" || len(lg.Commits[0].Sha) != 40 || lg.Commits[0].Short == "" {
|
||||
t.Fatalf("commit entry = %+v", lg.Commits[0])
|
||||
}
|
||||
raw, err = gitLogTool(dir, 0) // default limit
|
||||
if err != nil {
|
||||
t.Fatalf("git_log default: %v", err)
|
||||
}
|
||||
lg = decode[GitLogResult](t, raw)
|
||||
if len(lg.Commits) != 2 {
|
||||
t.Fatalf("default limit returned %d commits, want both", len(lg.Commits))
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitLogToolEmptyRepo(t *testing.T) {
|
||||
// an honest empty answer for a repo with no commits — never a raw
|
||||
// git error the model cannot act on
|
||||
dir := t.TempDir()
|
||||
cmd := exec.Command("git", "-C", dir, "init", "-b", "main")
|
||||
cmd.Env = append(os.Environ(), "GIT_CONFIG_GLOBAL=/dev/null", "GIT_CONFIG_SYSTEM=/dev/null")
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Fatalf("init: %v: %s", err, out)
|
||||
}
|
||||
raw, err := gitLogTool(dir, 10)
|
||||
if err != nil {
|
||||
t.Fatalf("git_log on empty repo: %v", err)
|
||||
}
|
||||
lg := decode[GitLogResult](t, raw)
|
||||
if len(lg.Commits) != 0 {
|
||||
t.Fatalf("empty repo returned %+v", lg.Commits)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitBranchTool(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if _, err := gitRun(dir, 10*time.Second, "branch", "feature"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err := gitBranchTool(dir)
|
||||
if err != nil {
|
||||
t.Fatalf("git_branch: %v", err)
|
||||
}
|
||||
br := decode[GitBranchResult](t, raw)
|
||||
if br.Current != "main" {
|
||||
t.Fatalf("current = %q, want main", br.Current)
|
||||
}
|
||||
found := map[string]bool{}
|
||||
for _, b := range br.Branches {
|
||||
found[b] = true
|
||||
}
|
||||
if !found["main"] || !found["feature"] {
|
||||
t.Fatalf("branches = %v, want main + feature", br.Branches)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitAddAndCommitTools(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if err := os.WriteFile(filepath.Join(dir, "made.txt"), []byte("work\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, err := gitAddTool(dir, []string{"made.txt"})
|
||||
if err != nil {
|
||||
t.Fatalf("git_add: %v", err)
|
||||
}
|
||||
add := decode[GitAddResult](t, raw)
|
||||
if len(add.Added) != 1 || add.Added[0] != "made.txt" {
|
||||
t.Fatalf("added = %+v", add.Added)
|
||||
}
|
||||
raw, err = gitCommitTool(dir, "add made.txt")
|
||||
if err != nil {
|
||||
t.Fatalf("git_commit: %v", err)
|
||||
}
|
||||
cm := decode[GitCommitResult](t, raw)
|
||||
if !cm.Committed || len(cm.Sha) != 40 || cm.Subject != "add made.txt" {
|
||||
t.Fatalf("commit result = %s", raw)
|
||||
}
|
||||
// the commit really landed
|
||||
raw, err = gitLogTool(dir, 1)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
lg := decode[GitLogResult](t, raw)
|
||||
if lg.Commits[0].Subject != "add made.txt" {
|
||||
t.Fatalf("log head = %+v", lg.Commits[0])
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitAddToolRequiresPaths(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if _, err := gitAddTool(dir, nil); err == nil || !strings.Contains(err.Error(), "paths required") {
|
||||
t.Fatalf("git_add with no paths must be refused, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitCommitToolRequiresMessage(t *testing.T) {
|
||||
dir := fixtureRepo(t)
|
||||
if _, err := gitCommitTool(dir, " "); err == nil || !strings.Contains(err.Error(), "message required") {
|
||||
t.Fatalf("git_commit with blank message must be refused, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitToolsRefuseBannedLandingPaths(t *testing.T) {
|
||||
// The landing-law banned paths (check_landing.py rule 4's
|
||||
// SWEEP_RACE_BANNED_PATHS) never enter the index or a commit —
|
||||
// live store state the sweep mutates, three 102MB accidents.
|
||||
dir := fixtureRepo(t)
|
||||
banned := filepath.Join(dir, "store", "scaffold")
|
||||
if err := os.MkdirAll(banned, 0o755); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
bannedFile := filepath.Join(banned, "current.json")
|
||||
if err := os.WriteFile(bannedFile, []byte("{}"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitAddTool(dir, []string{"store/scaffold/current.json"}); err == nil || !strings.Contains(err.Error(), "banned landing-law path") {
|
||||
t.Fatalf("git_add of a banned path must be refused, got %v", err)
|
||||
}
|
||||
// staged through some other road, git_commit still refuses
|
||||
if _, err := gitRun(dir, 10*time.Second, "add", "store/scaffold/current.json"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitCommitTool(dir, "smuggle the store state"); err == nil || !strings.Contains(err.Error(), "banned landing-law path") {
|
||||
t.Fatalf("git_commit with a banned staged path must be refused, got %v", err)
|
||||
}
|
||||
// and nothing was committed
|
||||
raw, err := gitStatusTool(dir)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
st := decode[GitStatusResult](t, raw)
|
||||
if st.Clean {
|
||||
t.Fatal("repo reports clean — the banned file was committed or lost")
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitToolsRefuseOversizedBlob(t *testing.T) {
|
||||
// The 20MB landing-law ceiling (check_landing.py rule 4,
|
||||
// MAX_LANDING_FILE_BYTES) is enforced at the git_add door too.
|
||||
dir := fixtureRepo(t)
|
||||
big := filepath.Join(dir, "big.bin")
|
||||
if err := os.WriteFile(big, make([]byte, 21*1024*1024), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := gitAddTool(dir, []string{"big.bin"}); err == nil || !strings.Contains(err.Error(), "ceiling") {
|
||||
t.Fatalf("git_add of an oversized blob must be refused, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGitFamilyRidesTheChatWire(t *testing.T) {
|
||||
// D49 red-first: the git family is exposed to the model in CHAT
|
||||
// mode (capability in every pane) and a git_status call's typed
|
||||
// result reaches the model in the tool loop.
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
t.Setenv("RUNE_REPO_ROOT", fixtureRepo(t))
|
||||
if err := os.WriteFile(filepath.Join(os.Getenv("RUNE_REPO_ROOT"), "wire.txt"), []byte("x"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
fm := &fakeToolModel{}
|
||||
fm.script = []ChatReply{
|
||||
{Content: "", ToolCalls: []ToolCall{{Name: "git_status", Args: map[string]any{}}}},
|
||||
{Content: "there are changes", Model: "m"},
|
||||
}
|
||||
e, _ := newTestEngine(t, fm)
|
||||
if _, err := e.Turn(context.Background(), TurnRequest{Channel: "chat", UserText: "how is the repo?"}); err != nil {
|
||||
t.Fatalf("turn: %v", err)
|
||||
}
|
||||
names := toolNames(fm.toolsets[0])
|
||||
for _, want := range []string{"git_status", "git_diff", "git_log", "git_branch", "git_add", "git_commit"} {
|
||||
if !has(names, want) {
|
||||
t.Fatalf("D49: %s must ride the CHAT wire, got: %v", want, names)
|
||||
}
|
||||
}
|
||||
var seen bool
|
||||
for _, m := range fm.payloadLog[1] {
|
||||
if m.Role == "tool" && strings.Contains(m.Content, "wire.txt") && strings.Contains(m.Content, `"success":true`) {
|
||||
seen = true
|
||||
}
|
||||
}
|
||||
if !seen {
|
||||
var dump, _ = json.Marshal(fm.payloadLog[1])
|
||||
t.Fatalf("the typed git_status result never reached the model: %s", dump)
|
||||
}
|
||||
}
|
||||
@@ -8,6 +8,7 @@ package runecore
|
||||
// same endpoint, same envelope, stdlib HTTP.
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
@@ -22,22 +23,27 @@ import (
|
||||
type OllamaClient struct {
|
||||
baseURL string
|
||||
client *http.Client
|
||||
// streamClient carries NO whole-call Timeout: the streaming leg is
|
||||
// governed by the inter-chunk idle watch (Client.Timeout caps body
|
||||
// reads too — a legitimate long stream would be cut mid-answer).
|
||||
streamClient *http.Client
|
||||
}
|
||||
|
||||
// DefaultOllamaURL is the Python adapter's default endpoint.
|
||||
const DefaultOllamaURL = "http://localhost:11434"
|
||||
|
||||
// NewOllamaClient builds the client. Empty base URL falls back to the
|
||||
// default. The chat budget mirrors the chain's law (>=330s — the
|
||||
// 27B-class answer window plus headroom, the same number the TUI
|
||||
// completion client and the entry proxy carry).
|
||||
// NewOllamaClient builds the client. The non-streaming client's chat
|
||||
// budget mirrors the chain's law (>=330s — the 27B-class answer window
|
||||
// plus headroom, the same number the TUI completion client and the
|
||||
// entry proxy carry); the streaming client leans on the idle watch.
|
||||
func NewOllamaClient(baseURL string) *OllamaClient {
|
||||
if baseURL == "" {
|
||||
baseURL = DefaultOllamaURL
|
||||
}
|
||||
return &OllamaClient{
|
||||
baseURL: strings.TrimSuffix(baseURL, "/"),
|
||||
client: &http.Client{Timeout: 330 * time.Second},
|
||||
baseURL: strings.TrimSuffix(baseURL, "/"),
|
||||
client: &http.Client{Timeout: 330 * time.Second},
|
||||
streamClient: &http.Client{},
|
||||
}
|
||||
}
|
||||
|
||||
@@ -233,6 +239,101 @@ func clipStr(s string, n int) string {
|
||||
return s[:n]
|
||||
}
|
||||
|
||||
// ollamaStreamChunk is one NDJSON line of a streamed /api/chat: a
|
||||
// message/token chunk (content and/or thinking and/or tool_calls) or
|
||||
// the terminal done:true chunk carrying the token accounting.
|
||||
type ollamaStreamChunk struct {
|
||||
Model string `json:"model"`
|
||||
Message struct {
|
||||
Role string `json:"role"`
|
||||
Content string `json:"content"`
|
||||
Thinking *string `json:"thinking"`
|
||||
ToolCalls []ollamaToolCall `json:"tool_calls"`
|
||||
} `json:"message"`
|
||||
Done bool `json:"done"`
|
||||
PromptEvalCount int `json:"prompt_eval_count"`
|
||||
EvalCount int `json:"eval_count"`
|
||||
}
|
||||
|
||||
// StreamChatWithTools is the streaming leg (Gitea #2556): stream=true
|
||||
// /api/chat, NDJSON chunks parsed incrementally, every content and
|
||||
// thinking byte surfaced through sink AS IT ARRIVES; the final reply
|
||||
// carries the assembled content + thinking + tool_calls exactly like
|
||||
// the non-streaming leg's. The inter-chunk idle watch replaces the
|
||||
// flat deadline: no bytes for the idle budget = ErrStreamIdle; the
|
||||
// 30-minute backstop is the runaway guard.
|
||||
func (c *OllamaClient) StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
idle := chunkIdleTimeout()
|
||||
w := watchIdle(ctx, idle, StreamTurnBackstop)
|
||||
defer w.stop()
|
||||
body, err := json.Marshal(ollamaChatRequest{Model: model, Messages: msgs, Stream: true, Tools: tools})
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
req, err := http.NewRequestWithContext(w.ctx, http.MethodPost, c.baseURL+"/api/chat", bytes.NewReader(body))
|
||||
if err != nil {
|
||||
return ChatReply{}, err
|
||||
}
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
resp, err := c.streamClient.Do(req)
|
||||
if err != nil {
|
||||
return ChatReply{}, w.err(fmt.Errorf("ollama: %w", err), idle)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
if resp.StatusCode != http.StatusOK {
|
||||
raw, _ := io.ReadAll(io.LimitReader(resp.Body, 2048))
|
||||
return ChatReply{}, fmt.Errorf("ollama /api/chat: HTTP %d: %s", resp.StatusCode, clipStr(string(raw), 300))
|
||||
}
|
||||
var content, thinking strings.Builder
|
||||
var toolCalls []ToolCall
|
||||
var last ollamaStreamChunk
|
||||
sc := bufio.NewScanner(resp.Body)
|
||||
sc.Buffer(make([]byte, 0, 64*1024), 1024*1024)
|
||||
for sc.Scan() {
|
||||
w.reset(idle)
|
||||
line := strings.TrimSpace(sc.Text())
|
||||
if line == "" {
|
||||
continue
|
||||
}
|
||||
var chunk ollamaStreamChunk
|
||||
if err := json.Unmarshal([]byte(line), &chunk); err != nil {
|
||||
return ChatReply{}, fmt.Errorf("ollama /api/chat stream decode: %w", err)
|
||||
}
|
||||
last = chunk
|
||||
if chunk.Message.Content != "" {
|
||||
content.WriteString(chunk.Message.Content)
|
||||
emit(sink, StreamDelta{Kind: "text", Text: chunk.Message.Content})
|
||||
}
|
||||
if chunk.Message.Thinking != nil && *chunk.Message.Thinking != "" {
|
||||
thinking.WriteString(*chunk.Message.Thinking)
|
||||
emit(sink, StreamDelta{Kind: "thinking", Text: *chunk.Message.Thinking})
|
||||
}
|
||||
for _, tc := range chunk.Message.ToolCalls {
|
||||
call := ToolCall{Name: tc.Function.Name}
|
||||
if len(tc.Function.Arguments) > 0 {
|
||||
var m map[string]any
|
||||
if json.Unmarshal(tc.Function.Arguments, &m) == nil {
|
||||
call.Args = m
|
||||
}
|
||||
}
|
||||
toolCalls = append(toolCalls, call)
|
||||
}
|
||||
}
|
||||
if err := sc.Err(); err != nil {
|
||||
return ChatReply{}, w.err(fmt.Errorf("ollama stream read: %w", err), idle)
|
||||
}
|
||||
visible, inline := splitInlineThinking(content.String())
|
||||
reply := ChatReply{Content: visible, Model: last.Model, ContextUsed: last.PromptEvalCount}
|
||||
reply.ToolCalls = toolCalls
|
||||
reply.ContextLimit = c.contextLimit(ctx, model)
|
||||
if thinking.Len() > 0 {
|
||||
reply.Thinking = []string{thinking.String()}
|
||||
} else if inline != "" {
|
||||
reply.Thinking = []string{inline}
|
||||
}
|
||||
return reply, nil
|
||||
}
|
||||
|
||||
// showCapabilities asks /api/show for the model's capabilities list
|
||||
// ("tools", "thinking", ...). Fail-soft: error → nil.
|
||||
func (c *OllamaClient) showCapabilities(ctx context.Context, model string) ([]string, error) {
|
||||
|
||||
@@ -217,6 +217,11 @@ func (s *Server) handleChatCompletions(w http.ResponseWriter, r *http.Request) {
|
||||
channel = "task" // the operator default; the core never invents a channel
|
||||
}
|
||||
|
||||
if req.Stream {
|
||||
s.streamCompletion(w, r, req.Model, channel, userText)
|
||||
return
|
||||
}
|
||||
|
||||
res, err := s.engine.Turn(r.Context(), TurnRequest{
|
||||
Channel: channel, UserText: userText, Model: req.Model,
|
||||
})
|
||||
@@ -255,10 +260,6 @@ func (s *Server) handleChatCompletions(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
id := newCompletionID()
|
||||
created := time.Now().UTC().Unix()
|
||||
if req.Stream {
|
||||
s.writeChunks(w, id, created, res.Model, assistantText, runeBlk)
|
||||
return
|
||||
}
|
||||
writeJSON(w, http.StatusOK, map[string]any{
|
||||
"id": id,
|
||||
"object": "chat.completion",
|
||||
@@ -276,39 +277,105 @@ func (s *Server) handleChatCompletions(w http.ResponseWriter, r *http.Request) {
|
||||
})
|
||||
}
|
||||
|
||||
// writeChunks answers stream=true the Python core's framing: a content
|
||||
// chunk, then the terminal chunk carrying finish_reason and the rune
|
||||
// block (the front door flushes each line).
|
||||
func (s *Server) writeChunks(w http.ResponseWriter, id string, created int64, model, content string, runeBlk map[string]any) {
|
||||
w.Header().Set("Content-Type", "application/x-ndjson")
|
||||
w.WriteHeader(http.StatusOK)
|
||||
contentChunk := map[string]any{
|
||||
"id": id, "object": "chat.completion.chunk", "created": created, "model": model,
|
||||
"choices": []any{map[string]any{
|
||||
"index": 0,
|
||||
"delta": map[string]any{"role": "assistant", "content": content},
|
||||
"finish_reason": nil,
|
||||
}},
|
||||
// streamCompletion answers stream=true the Python core's framing with
|
||||
// the model's bytes relayed AS THEY ARRIVE (Gitea #2556 — the turn
|
||||
// never sits inside one blocking call server-side): a content chunk
|
||||
// per streamed text delta, then the terminal chunk carrying
|
||||
// finish_reason and the rune block. An error before the first byte
|
||||
// answers the honest error envelope; an error mid-stream answers an
|
||||
// error terminal chunk (success=false — the stream shape stays valid).
|
||||
func (s *Server) streamCompletion(w http.ResponseWriter, r *http.Request, model, channel, userText string) {
|
||||
id := newCompletionID()
|
||||
created := time.Now().UTC().Unix()
|
||||
header := false
|
||||
deltas := false
|
||||
writeHeader := func() {
|
||||
if !header {
|
||||
w.Header().Set("Content-Type", "application/x-ndjson")
|
||||
w.WriteHeader(http.StatusOK)
|
||||
header = true
|
||||
}
|
||||
}
|
||||
terminal := map[string]any{
|
||||
"id": id, "object": "chat.completion.chunk", "created": created, "model": model,
|
||||
"choices": []any{map[string]any{
|
||||
"index": 0, "delta": map[string]any{}, "finish_reason": "stop",
|
||||
}},
|
||||
"rune": runeBlk,
|
||||
}
|
||||
for _, chunk := range []map[string]any{contentChunk, terminal} {
|
||||
writeChunk := func(chunk map[string]any) bool {
|
||||
line, err := json.Marshal(chunk)
|
||||
if err != nil {
|
||||
return
|
||||
return false
|
||||
}
|
||||
if _, err := w.Write(append(line, '\n')); err != nil {
|
||||
return
|
||||
return false
|
||||
}
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
return true
|
||||
}
|
||||
chunkFor := func(delta string) map[string]any {
|
||||
return map[string]any{
|
||||
"id": id, "object": "chat.completion.chunk", "created": created, "model": model,
|
||||
"choices": []any{map[string]any{
|
||||
"index": 0,
|
||||
"delta": map[string]any{"role": "assistant", "content": delta},
|
||||
"finish_reason": nil,
|
||||
}},
|
||||
}
|
||||
}
|
||||
sink := func(d StreamDelta) {
|
||||
if d.Kind != "text" || d.Text == "" {
|
||||
return
|
||||
}
|
||||
deltas = true
|
||||
writeHeader()
|
||||
writeChunk(chunkFor(d.Text))
|
||||
}
|
||||
res, err := s.engine.TurnStream(r.Context(), TurnRequest{
|
||||
Channel: channel, UserText: userText, Model: model,
|
||||
}, sink)
|
||||
if res.ContextLimit > 0 {
|
||||
s.setContext(res.ContextUsed, res.ContextLimit)
|
||||
}
|
||||
runeBlk := map[string]any{
|
||||
"success": err == nil,
|
||||
"user_text": res.AssistantText,
|
||||
"model": res.Model,
|
||||
"error": "",
|
||||
"channel": channel,
|
||||
"thinking": res.Thinking,
|
||||
"messages": map[string]string{"user": res.UserMsgID, "assistant": res.AssistantMsgID},
|
||||
"core": "go",
|
||||
}
|
||||
if err != nil {
|
||||
runeBlk["error"] = clipStr(err.Error(), 300)
|
||||
}
|
||||
if err != nil && !header {
|
||||
var pe *ProviderError
|
||||
switch {
|
||||
case errors.Is(err, ErrChannelBusy):
|
||||
errorEnvelope(w, http.StatusConflict, "channel_busy", err.Error())
|
||||
case errors.Is(err, ErrNoProvider):
|
||||
errorEnvelope(w, http.StatusServiceUnavailable, "no_provider", err.Error())
|
||||
case errors.Is(err, ErrProviderUnrouted):
|
||||
errorEnvelope(w, http.StatusServiceUnavailable, "provider_unrouted", clipStr(err.Error(), 300))
|
||||
case errors.Is(err, ErrProviderKeyMissing):
|
||||
errorEnvelope(w, http.StatusServiceUnavailable, "provider_key_missing", clipStr(err.Error(), 300))
|
||||
case errors.As(err, &pe):
|
||||
errorEnvelope(w, http.StatusBadGateway, "provider_error", clipStr(err.Error(), 300))
|
||||
default:
|
||||
errorEnvelope(w, http.StatusInternalServerError, "internal_error", clipStr(err.Error(), 200))
|
||||
}
|
||||
return
|
||||
}
|
||||
writeHeader()
|
||||
// the fallback law: a client that couldn't stream (or a non-streaming
|
||||
// provider leg) still answers the full assembled content in ONE
|
||||
// chunk — the classic framing, nothing dropped.
|
||||
if !deltas {
|
||||
writeChunk(chunkFor(res.AssistantText))
|
||||
}
|
||||
terminal := chunkFor("")
|
||||
terminal["choices"].([]any)[0].(map[string]any)["delta"] = map[string]any{}
|
||||
terminal["choices"].([]any)[0].(map[string]any)["finish_reason"] = "stop"
|
||||
terminal["rune"] = runeBlk
|
||||
writeChunk(terminal)
|
||||
}
|
||||
|
||||
// setContext records the last turn's context accounting (D44 readout).
|
||||
|
||||
@@ -0,0 +1,162 @@
|
||||
package runecore
|
||||
|
||||
// stream.go — the streaming root-cause wave (Gitea #2556, owner
|
||||
// verdict: the flat whole-turn budgets patched the symptom; the root
|
||||
// cause is ONE long-blocking HTTP call per model turn). A streamed
|
||||
// turn never hits a deadline because bytes arrive continuously: the
|
||||
// deadline collapses to an INTER-CHUNK IDLE TIMEOUT (no bytes for X
|
||||
// seconds = genuinely dead) plus a generous overall backstop. The
|
||||
// 330s/480s/6x480s budget constants remain only for the non-streaming
|
||||
// fallback paths (clients that do not stream, the cap-out
|
||||
// withdrawn-tools call, and legacy callers).
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
// DefaultChunkIdleTimeout is the inter-chunk idle budget on every
|
||||
// streamed model call: no bytes for this long = the model is
|
||||
// genuinely dead (the old deadline's honest replacement).
|
||||
const DefaultChunkIdleTimeout = 120 * time.Second
|
||||
|
||||
// StreamTurnBackstop is the overall cap on one streamed turn — sized
|
||||
// generously (30 minutes) so only a runaway chain trips it; the idle
|
||||
// timeout is the real guardian.
|
||||
const StreamTurnBackstop = 30 * time.Minute
|
||||
|
||||
// ChunkIdleTimeoutEnv is the env knob that resizes the inter-chunk
|
||||
// idle budget (seconds; an unparsable or non-positive value keeps the
|
||||
// default — the knob never disables the guard).
|
||||
const ChunkIdleTimeoutEnv = "RUNE_STREAM_IDLE_TIMEOUT"
|
||||
|
||||
// ErrStreamIdle is the typed dead-model refusal: the stream produced
|
||||
// no bytes for the whole idle budget.
|
||||
var ErrStreamIdle = errors.New("stream idle: no model bytes within the inter-chunk idle budget")
|
||||
|
||||
// chunkIdleTimeout resolves the inter-chunk idle budget: the env knob
|
||||
// wins when it parses to a positive number of seconds; the default
|
||||
// otherwise.
|
||||
func chunkIdleTimeout() time.Duration {
|
||||
if v := strings.TrimSpace(os.Getenv(ChunkIdleTimeoutEnv)); v != "" {
|
||||
if n, err := strconv.Atoi(v); err == nil && n > 0 {
|
||||
return time.Duration(n) * time.Second
|
||||
}
|
||||
}
|
||||
return DefaultChunkIdleTimeout
|
||||
}
|
||||
|
||||
// idleWatch enforces the inter-chunk idle timeout on one streamed
|
||||
// call. The client calls reset() after EVERY chunk read; the watch
|
||||
// cancels the derived ctx when the budget lapses. The error surfaces
|
||||
// through the ctx as ErrStreamIdle (not a bare context.Canceled), so
|
||||
// the honest dead-model reason reaches the caller.
|
||||
type idleWatch struct {
|
||||
ctx context.Context
|
||||
timer *time.Timer
|
||||
fired bool
|
||||
cancelAll context.CancelFunc
|
||||
}
|
||||
|
||||
// watchIdle derives an idle-enforced ctx from the caller's — the same
|
||||
// cancel context carries the backstop deadline; the idle fire is
|
||||
// distinguished by the fired flag (the honest dead-model error).
|
||||
func watchIdle(parent context.Context, idle, backstop time.Duration) *idleWatch {
|
||||
ctx, cancelAll := context.WithTimeout(parent, backstop)
|
||||
w := &idleWatch{ctx: ctx, cancelAll: cancelAll}
|
||||
w.timer = time.AfterFunc(idle, func() {
|
||||
w.fired = true
|
||||
cancelAll()
|
||||
})
|
||||
return w
|
||||
}
|
||||
|
||||
// reset arms the idle budget afresh — called after every chunk.
|
||||
func (w *idleWatch) reset(idle time.Duration) {
|
||||
w.timer.Reset(idle)
|
||||
}
|
||||
|
||||
// stop disarms the watch (completion or error) and releases the
|
||||
// context.
|
||||
func (w *idleWatch) stop() {
|
||||
w.timer.Stop()
|
||||
w.cancelAll()
|
||||
}
|
||||
|
||||
// err maps a stream-read failure onto the honest typed error: the
|
||||
// idle fire wins (dead model), the backstop's deadline reads as
|
||||
// itself, everything else passes through.
|
||||
func (w *idleWatch) err(readErr error, idle time.Duration) error {
|
||||
if w.fired {
|
||||
return fmt.Errorf("%w (%s)", ErrStreamIdle, idle)
|
||||
}
|
||||
if readErr != nil {
|
||||
if errors.Is(readErr, context.DeadlineExceeded) {
|
||||
return fmt.Errorf("stream turn backstop exceeded (%s)", StreamTurnBackstop)
|
||||
}
|
||||
return readErr
|
||||
}
|
||||
return w.ctx.Err()
|
||||
}
|
||||
|
||||
// StreamDelta is one incremental model byte: visible answer text
|
||||
// ("text") or surfaced reasoning ("thinking").
|
||||
type StreamDelta struct {
|
||||
Kind string // "text" | "thinking"
|
||||
Text string
|
||||
}
|
||||
|
||||
// StreamSink consumes deltas as they arrive (never after the call
|
||||
// returns; nil-safe call sites).
|
||||
type StreamSink func(StreamDelta)
|
||||
|
||||
// StreamChatClient is the streaming leg of the model boundary: the
|
||||
// same ChatWithTools semantics (the engine's bounded tool loop is
|
||||
// unchanged) with the answer's bytes surfaced through sink as they
|
||||
// arrive. The final ChatReply carries the assembled content, thinking
|
||||
// and tool_calls exactly as the non-streaming leg's does. The client
|
||||
// owns the idle enforcement (it reads the wire); every implementation
|
||||
// derives its read ctx through watchIdle.
|
||||
type StreamChatClient interface {
|
||||
ToolChatClient
|
||||
StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error)
|
||||
}
|
||||
|
||||
// emit is the nil-safe sink call.
|
||||
func emit(sink StreamSink, d StreamDelta) {
|
||||
if sink != nil {
|
||||
sink(d)
|
||||
}
|
||||
}
|
||||
|
||||
// scanSSE reads an SSE body line-wise: every "data:" line's payload
|
||||
// goes to fn; "data: [DONE]" terminates (per the [OI] SSE framing).
|
||||
// Comment lines (":" prefix) and empty lines are skipped. The caller's
|
||||
// read failures pass through (the idle watch maps them).
|
||||
func scanSSE(body *bufio.Reader, fn func(data string) error) error {
|
||||
for {
|
||||
line, err := body.ReadString('\n')
|
||||
trimmed := strings.TrimRight(line, "\r\n")
|
||||
if trimmed != "" && !strings.HasPrefix(trimmed, ":") {
|
||||
if payload, ok := strings.CutPrefix(trimmed, "data: "); ok {
|
||||
if strings.TrimSpace(payload) == "[DONE]" {
|
||||
return nil
|
||||
}
|
||||
if err := fn(payload); err != nil {
|
||||
return err
|
||||
}
|
||||
} else if payload, ok := strings.CutPrefix(trimmed, "data:"); ok && strings.TrimSpace(payload) == "[DONE]" {
|
||||
return nil
|
||||
}
|
||||
}
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,314 @@
|
||||
package runecore
|
||||
|
||||
// stream_test.go — the streaming root-cause wave's frozen proofs
|
||||
// (Gitea #2556, red-first): the Ollama NDJSON stream parses
|
||||
// incrementally and answers the assembled reply; the INTER-CHUNK IDLE
|
||||
// TIMEOUT replaces the flat deadline (a slow model that keeps sending
|
||||
// bytes finishes no matter how long it takes; a dead model trips the
|
||||
// idle error); the engine's bounded tool loop runs over streamed
|
||||
// replies; the server relays the streamed turn chunk-by-chunk.
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// fakeStreamClient is a StreamChatClient for the engine loop proofs.
|
||||
type fakeStreamClient struct {
|
||||
calls int
|
||||
scripts []struct {
|
||||
reply ChatReply
|
||||
deltas []StreamDelta
|
||||
}
|
||||
thinks bool
|
||||
sunk []StreamDelta
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) add(reply ChatReply, deltas ...StreamDelta) {
|
||||
f.scripts = append(f.scripts, struct {
|
||||
reply ChatReply
|
||||
deltas []StreamDelta
|
||||
}{reply, deltas})
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) SupportsTools(context.Context, string) bool { return f.thinks }
|
||||
|
||||
func (f *fakeStreamClient) ChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef) (ChatReply, error) {
|
||||
return f.Chat(ctx, model, msgs)
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) Chat(ctx context.Context, model string, msgs []ChatMessage) (ChatReply, error) {
|
||||
f.calls++
|
||||
return f.script().reply, nil
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) script() (out struct {
|
||||
reply ChatReply
|
||||
deltas []StreamDelta
|
||||
}) {
|
||||
i := f.calls - 1
|
||||
if i >= len(f.scripts) {
|
||||
i = len(f.scripts) - 1
|
||||
}
|
||||
return f.scripts[i]
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) StreamChatWithTools(ctx context.Context, model string, msgs []ChatMessage, tools []ToolDef, sink StreamSink) (ChatReply, error) {
|
||||
f.calls++
|
||||
s := f.script()
|
||||
for _, d := range s.deltas {
|
||||
f.sunk = append(f.sunk, d)
|
||||
emit(sink, d)
|
||||
}
|
||||
return s.reply, nil
|
||||
}
|
||||
|
||||
func (f *fakeStreamClient) Tags(context.Context) ([]ModelInfo, error) { return nil, nil }
|
||||
|
||||
// ollamaStreamServer is a hermetic /api/chat double: lines written on
|
||||
// schedule (delay after each), the final done:true chunk closing.
|
||||
func ollamaStreamServer(t *testing.T, lines []string, perLine time.Duration) *httptest.Server {
|
||||
t.Helper()
|
||||
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
if strings.HasSuffix(r.URL.Path, "/api/show") {
|
||||
_, _ = w.Write([]byte(`{"capabilities":["tools","thinking"]}`))
|
||||
return
|
||||
}
|
||||
var req ollamaChatRequest
|
||||
_ = json.NewDecoder(r.Body).Decode(&req)
|
||||
if !req.Stream {
|
||||
t.Errorf("ollama stream double: request did not carry stream=true")
|
||||
}
|
||||
w.Header().Set("Content-Type", "application/x-ndjson")
|
||||
for i, line := range lines {
|
||||
_, _ = w.Write([]byte(line + "\n"))
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
if i < len(lines)-1 && perLine > 0 {
|
||||
time.Sleep(perLine)
|
||||
}
|
||||
}
|
||||
}))
|
||||
}
|
||||
|
||||
func ollamaChunk(content string) string {
|
||||
return `{"model":"q","message":{"role":"assistant","content":` + jsonString(content) + `},"done":false}`
|
||||
}
|
||||
|
||||
// TestOllamaStreamAssemblesReply — the NDJSON chunks parse
|
||||
// incrementally; every text byte surfaces through the sink in wire
|
||||
// order; the final reply carries the assembled content + thinking and
|
||||
// the token accounting from the done chunk.
|
||||
func TestOllamaStreamAssemblesReply(t *testing.T) {
|
||||
srv := ollamaStreamServer(t, []string{
|
||||
ollamaChunk("hel"),
|
||||
ollamaChunk("lo "),
|
||||
`{"model":"q","message":{"role":"assistant","thinking":"pondering"},"done":false}`,
|
||||
ollamaChunk("world"),
|
||||
`{"model":"q","message":{"role":"assistant"},"done":true,"prompt_eval_count":42,"eval_count":7}`,
|
||||
}, 0)
|
||||
c := NewOllamaClient(srv.URL)
|
||||
var got []StreamDelta
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "q", []ChatMessage{{Role: "user", Content: "hi"}}, nil, func(d StreamDelta) { got = append(got, d) })
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if reply.Content != "hello world" {
|
||||
t.Fatalf("content = %q", reply.Content)
|
||||
}
|
||||
if len(reply.Thinking) != 1 || reply.Thinking[0] != "pondering" {
|
||||
t.Fatalf("thinking = %v", reply.Thinking)
|
||||
}
|
||||
if reply.ContextUsed != 42 {
|
||||
t.Fatalf("context used = %d", reply.ContextUsed)
|
||||
}
|
||||
var text strings.Builder
|
||||
for _, d := range got {
|
||||
if d.Kind != "text" {
|
||||
continue
|
||||
}
|
||||
text.WriteString(d.Text)
|
||||
}
|
||||
if text.String() != "hello world" {
|
||||
t.Fatalf("deltas = %q", text.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestOllamaStreamToolCalls — tool_calls riding the stream parse into
|
||||
// the reply (the loop's wire shape, streamed).
|
||||
func TestOllamaStreamToolCalls(t *testing.T) {
|
||||
srv := ollamaStreamServer(t, []string{
|
||||
`{"model":"q","message":{"role":"assistant","tool_calls":[{"function":{"name":"read_file","arguments":{"path":"x"}}}]},"done":false}`,
|
||||
`{"model":"q","message":{"role":"assistant"},"done":true}`,
|
||||
}, 0)
|
||||
c := NewOllamaClient(srv.URL)
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "q", []ChatMessage{{Role: "user", Content: "hi"}}, nil, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(reply.ToolCalls) != 1 || reply.ToolCalls[0].Name != "read_file" {
|
||||
t.Fatalf("tool calls = %+v", reply.ToolCalls)
|
||||
}
|
||||
if reply.ToolCalls[0].Args["path"] != "x" {
|
||||
t.Fatalf("args = %+v", reply.ToolCalls[0].Args)
|
||||
}
|
||||
}
|
||||
|
||||
// TestOllamaStreamSlowModelFinishes — the root-cause proof: a model
|
||||
// that emits a chunk every 200ms across a window LONGER than the old
|
||||
// flat per-call budgets would ever allow (scaled 1:25 from the live
|
||||
// 5s-for-10-minutes shape; the mechanism is identical — bytes keep
|
||||
// arriving, the turn completes, no deadline fires).
|
||||
func TestOllamaStreamSlowModelFinishes(t *testing.T) {
|
||||
t.Setenv(ChunkIdleTimeoutEnv, "1") // 1s idle budget; chunks every 200ms
|
||||
var lines []string
|
||||
for i := 0; i < 12; i++ {
|
||||
lines = append(lines, ollamaChunk(fmt.Sprintf("chunk%d ", i)))
|
||||
}
|
||||
lines = append(lines, `{"model":"q","message":{"role":"assistant"},"done":true}`)
|
||||
srv := ollamaStreamServer(t, lines, 200*time.Millisecond)
|
||||
defer srv.Close()
|
||||
c := NewOllamaClient(srv.URL)
|
||||
reply, err := c.StreamChatWithTools(context.Background(), "q", []ChatMessage{{Role: "user", Content: "hi"}}, nil, nil)
|
||||
if err != nil {
|
||||
t.Fatalf("slow streamed turn failed: %v", err)
|
||||
}
|
||||
if !strings.Contains(reply.Content, "chunk11") {
|
||||
t.Fatalf("content = %q", reply.Content)
|
||||
}
|
||||
}
|
||||
|
||||
// TestOllamaStreamIdleTimeout — the dead model: bytes stop; the idle
|
||||
// budget lapses; the typed ErrStreamIdle fires (never a hang).
|
||||
func TestOllamaStreamIdleTimeout(t *testing.T) {
|
||||
t.Setenv(ChunkIdleTimeoutEnv, "1")
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
_, _ = w.Write([]byte(ollamaChunk("first") + "\n"))
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
<-r.Context().Done() // then silence forever
|
||||
}))
|
||||
defer srv.Close()
|
||||
c := NewOllamaClient(srv.URL)
|
||||
start := time.Now()
|
||||
_, err := c.StreamChatWithTools(context.Background(), "q", []ChatMessage{{Role: "user", Content: "hi"}}, nil, nil)
|
||||
if !errors.Is(err, ErrStreamIdle) {
|
||||
t.Fatalf("err = %v, want ErrStreamIdle", err)
|
||||
}
|
||||
if time.Since(start) > 5*time.Second {
|
||||
t.Fatalf("idle timeout took %v — not the 1s budget", time.Since(start))
|
||||
}
|
||||
}
|
||||
|
||||
// TestEngineStreamedToolLoop — the bounded tool loop runs over
|
||||
// streamed replies: call 1 asks for a tool, call 2 answers in text;
|
||||
// the loop's iteration discipline is unchanged and the deltas flowed.
|
||||
func TestEngineStreamedToolLoop(t *testing.T) {
|
||||
fc := &fakeStreamClient{thinks: true}
|
||||
fc.add(ChatReply{Content: "", ToolCalls: []ToolCall{{Name: "list_directory", Args: map[string]any{"path": "."}}}},
|
||||
StreamDelta{Kind: "text", Text: "thinking..."})
|
||||
fc.add(ChatReply{Content: "done answering"},
|
||||
StreamDelta{Kind: "text", Text: "done answering"})
|
||||
e, _ := newTestEngine(t, fc)
|
||||
var got []StreamDelta
|
||||
res, err := e.TurnStream(context.Background(), TurnRequest{Channel: "chat", UserText: "list files"}, func(d StreamDelta) { got = append(got, d) })
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if res.AssistantText != "done answering" {
|
||||
t.Fatalf("answer = %q", res.AssistantText)
|
||||
}
|
||||
if fc.calls != 2 {
|
||||
t.Fatalf("model calls = %d, want the loop's 2", fc.calls)
|
||||
}
|
||||
if len(got) != 2 {
|
||||
t.Fatalf("deltas = %d, want both legs streamed", len(got))
|
||||
}
|
||||
}
|
||||
|
||||
// TestServerStreamsChunksLive — stream=true relays the model's bytes
|
||||
// AS THEY ARRIVE: the first chunk lands while the model is still
|
||||
// emitting (never one blocking call server-side).
|
||||
func TestServerStreamsChunksLive(t *testing.T) {
|
||||
t.Setenv(ChunkIdleTimeoutEnv, "5")
|
||||
srv := ollamaStreamServer(t, []string{
|
||||
ollamaChunk("live "),
|
||||
ollamaChunk("answer"),
|
||||
`{"model":"q","message":{"role":"assistant"},"done":true}`,
|
||||
}, 300*time.Millisecond)
|
||||
defer srv.Close()
|
||||
oc := NewOllamaClient(srv.URL)
|
||||
e, _ := newTestEngine(t, oc)
|
||||
core := httptest.NewServer(NewServer(e, oc, e.home).Handler())
|
||||
defer core.Close()
|
||||
raw, _ := json.Marshal(map[string]any{
|
||||
"channel": "chat", "stream": true,
|
||||
"messages": []map[string]any{{"role": "user", "content": "hi"}},
|
||||
})
|
||||
resp, err := http.Post(core.URL+"/v1/chat/completions", "application/json", strings.NewReader(string(raw)))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
start := time.Now()
|
||||
buf := make([]byte, 4096)
|
||||
var got strings.Builder
|
||||
firstAt := time.Time{}
|
||||
for {
|
||||
n, rerr := resp.Body.Read(buf)
|
||||
if n > 0 {
|
||||
got.Write(buf[:n])
|
||||
if firstAt.IsZero() && strings.Contains(got.String(), "live") {
|
||||
firstAt = time.Now()
|
||||
}
|
||||
}
|
||||
if rerr != nil {
|
||||
break
|
||||
}
|
||||
}
|
||||
if firstAt.IsZero() {
|
||||
t.Fatalf("no chunk arrived incrementally: %q", got.String())
|
||||
}
|
||||
if elapsed := firstAt.Sub(start); elapsed > 200*time.Millisecond {
|
||||
t.Fatalf("first chunk at %v — the core buffered the stream", elapsed)
|
||||
}
|
||||
if !strings.Contains(got.String(), `"finish_reason":"stop"`) {
|
||||
t.Fatalf("terminal chunk missing: %q", got.String())
|
||||
}
|
||||
if !strings.Contains(got.String(), `"success":true`) {
|
||||
t.Fatalf("rune block missing: %q", got.String())
|
||||
}
|
||||
}
|
||||
|
||||
// TestServerStreamErrorBeforeFirstByte — a refusal (no provider
|
||||
// record) on a streamed request answers the honest error envelope,
|
||||
// never a half-open stream.
|
||||
func TestServerStreamErrorBeforeFirstByte(t *testing.T) {
|
||||
oc := NewOllamaClient("http://127.0.0.1:1") // dead local wire
|
||||
e, _ := newTestEngine(t, oc)
|
||||
core := httptest.NewServer(NewServer(e, oc, e.home).Handler())
|
||||
defer core.Close()
|
||||
raw, _ := json.Marshal(map[string]any{
|
||||
"channel": "chat", "stream": true,
|
||||
"messages": []map[string]any{{"role": "user", "content": "hi"}},
|
||||
})
|
||||
resp, err := http.Post(core.URL+"/v1/chat/completions", "application/json", strings.NewReader(string(raw)))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
body, _ := io.ReadAll(resp.Body)
|
||||
if !strings.Contains(string(body), `"error"`) {
|
||||
t.Fatalf("want the error envelope, got %q", string(body))
|
||||
}
|
||||
}
|
||||
@@ -1,14 +1,21 @@
|
||||
package runecore
|
||||
|
||||
// tools.go — THE TOOLSET GAP (D45 item 5): the Go core's chat path
|
||||
// surfaces the mode-allowed tool suite to the model and executes the
|
||||
// model's tool calls mode-gated. Oracle: the Python operator path
|
||||
// (rune_operator.py _capability_selection → local_tool_runtime.py,
|
||||
// the T2/T3 wave) — the ONE frozen matrix artifact
|
||||
// schemas/mode/v1/mode_matrix.json is the authority: CHAT/PLAN expose
|
||||
// the read family, TASK adds the write family. The dispatch gate stays
|
||||
// the security boundary: every call re-reads the active mode and a
|
||||
// mode-disallowed tool executes as a typed tool error, never bytes.
|
||||
// tools.go — the tool suite the wire carries and the executor runs.
|
||||
// D45 landed the mode-gated toolset; D49 (owner ruling 2026-10-22,
|
||||
// "capability in every pane") SUPERSEDES the mode gate: capability is
|
||||
// inherent in EVERY pane — CHAT/PLAN/TASK all expose the read family,
|
||||
// the write family AND the native git family, because the model must
|
||||
// KNOW it can read, write and shell without asking (the owner: "i
|
||||
// want that ability to be in every pane"). The consent card remains
|
||||
// the WORK-PROMOTION mechanism (work shows in the tasks pane) — it is
|
||||
// organizational, never a permission gate. The real safety layer is
|
||||
// the scaffolding authority + contract gates at mutation doors (the
|
||||
// landing law). ToolsetFor keeps the per-mode switch (future modes
|
||||
// may still narrow) and ExecuteGatedTool keeps the dispatch-gate seam
|
||||
// (future policies hook there; the refusal stays for
|
||||
// genuinely-unavailable tools) — but no mode withholds the suite
|
||||
// today. schemas/mode/v1/mode_matrix.json's CHAT=read-only pin is
|
||||
// retired by this ruling.
|
||||
|
||||
import (
|
||||
"context"
|
||||
@@ -56,10 +63,12 @@ func toolSpec(name, desc string, props map[string]any, required []string) ToolDe
|
||||
}}
|
||||
}
|
||||
|
||||
// ToolsetFor returns the mode's tool schemas — the frozen matrix's
|
||||
// executor_tools ∩ the Go core's implemented ops. CHAT/PLAN: the read
|
||||
// family. TASK: + write_file, edit_file, run_command. Unknown mode →
|
||||
// empty (fail closed; the turn runs toolless rather than ungated).
|
||||
// ToolsetFor returns the mode's tool schemas. D49: every known mode
|
||||
// carries the FULL suite — read family + write family + git family —
|
||||
// because capability is inherent in every pane (the owner's ruling;
|
||||
// the wire must tell the model it can act, not hide the tools and
|
||||
// make the model beg for shell access). Unknown mode → empty (fail
|
||||
// closed; the turn runs toolless rather than ungated).
|
||||
func ToolsetFor(mode string) []ToolDef {
|
||||
read := []ToolDef{
|
||||
toolSpec("list_directory", "List the entries of a directory on the user's machine.",
|
||||
@@ -81,25 +90,25 @@ func ToolsetFor(mode string) []ToolDef {
|
||||
"include": map[string]any{"type": "string", "description": "filename glob filter"}},
|
||||
[]string{"pattern"}),
|
||||
}
|
||||
write := []ToolDef{
|
||||
toolSpec("write_file", "Create or overwrite a file on the user's machine. Available in EVERY pane and mode — no elevation needed; sustained work-shaped activity gets promoted to the tasks pane.",
|
||||
map[string]any{"path": map[string]any{"type": "string"},
|
||||
"content": map[string]any{"type": "string"}},
|
||||
[]string{"path", "content"}),
|
||||
toolSpec("edit_file", "Replace the first occurrence of a search string in a file. Available in EVERY pane and mode — no elevation needed.",
|
||||
map[string]any{"path": map[string]any{"type": "string"},
|
||||
"search": map[string]any{"type": "string"},
|
||||
"replace": map[string]any{"type": "string"}},
|
||||
[]string{"path", "search", "replace"}),
|
||||
toolSpec("run_command", "Run a shell command on the user's machine (bash, 60-second timeout). Available in EVERY pane and mode — shell access is inherent; sustained work gets promoted to the tasks pane.",
|
||||
map[string]any{"command": map[string]any{"type": "string"},
|
||||
"workdir": map[string]any{"type": "string", "description": "working directory"}},
|
||||
[]string{"command"}),
|
||||
}
|
||||
full := append(append(read, write...), gitToolDefs()...)
|
||||
switch mode {
|
||||
case "TASK":
|
||||
return append(read,
|
||||
toolSpec("write_file", "Create or overwrite a file on the user's machine.",
|
||||
map[string]any{"path": map[string]any{"type": "string"},
|
||||
"content": map[string]any{"type": "string"}},
|
||||
[]string{"path", "content"}),
|
||||
toolSpec("edit_file", "Replace the first occurrence of a search string in a file.",
|
||||
map[string]any{"path": map[string]any{"type": "string"},
|
||||
"search": map[string]any{"type": "string"},
|
||||
"replace": map[string]any{"type": "string"}},
|
||||
[]string{"path", "search", "replace"}),
|
||||
toolSpec("run_command", "Run a shell command on the user's machine.",
|
||||
map[string]any{"command": map[string]any{"type": "string"},
|
||||
"workdir": map[string]any{"type": "string", "description": "working directory"}},
|
||||
[]string{"command"}),
|
||||
)
|
||||
case "CHAT", "PLAN":
|
||||
return read
|
||||
case "TASK", "CHAT", "PLAN":
|
||||
return full
|
||||
default:
|
||||
return nil
|
||||
}
|
||||
@@ -153,11 +162,14 @@ type toolEnvelope struct {
|
||||
Error string `json:"error,omitempty"`
|
||||
}
|
||||
|
||||
// ExecuteGatedTool executes ONE model-requested tool against the mode
|
||||
// gate read FRESH at dispatch (the T3 two-door law: seeing is a
|
||||
// prompt, the gate is the boundary). A mode-disallowed call returns a
|
||||
// typed refusal envelope — tool-error data the model can read, never
|
||||
// an execution.
|
||||
// ExecuteGatedTool executes ONE model-requested tool, checking the
|
||||
// mode's suite FRESH at dispatch (the T3 two-door law: seeing is a
|
||||
// prompt, the gate is the boundary). D49: no mode withholds the write
|
||||
// family or the git family — writes execute in any mode; the consent
|
||||
// card promotes work (organization), it never gates tools. The
|
||||
// dispatch-gate SEAM stays (future policies hook here): a tool
|
||||
// genuinely outside the mode's suite returns a typed refusal envelope
|
||||
// — tool-error data the model can read, never an execution.
|
||||
func ExecuteGatedTool(home, mode, name string, args map[string]any) map[string]any {
|
||||
if mode == "" {
|
||||
mode = ActiveMode(home)
|
||||
@@ -193,9 +205,28 @@ func argInt(args map[string]any, key string) int {
|
||||
return 0
|
||||
}
|
||||
|
||||
func argBool(args map[string]any, key string) (val, ok bool) {
|
||||
v, ok := args[key].(bool)
|
||||
return v, ok
|
||||
}
|
||||
|
||||
func argStrings(args map[string]any, key string) []string {
|
||||
raw, ok := args[key].([]any)
|
||||
if !ok {
|
||||
return nil
|
||||
}
|
||||
out := make([]string, 0, len(raw))
|
||||
for _, v := range raw {
|
||||
if s, ok := v.(string); ok {
|
||||
out = append(out, s)
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// executeGoTool runs the tool in-process (stdlib only — the Go core's
|
||||
// zero-dep split law). Paths are home-expanded; every op is read-only
|
||||
// except the TASK-only write family.
|
||||
// zero-dep split law). Paths are home-expanded. The git family shells
|
||||
// out to git in DefaultRepoRoot() (gittools.go).
|
||||
func executeGoTool(name string, args map[string]any) map[string]any {
|
||||
env := func(res string, err error) map[string]any {
|
||||
if err != nil {
|
||||
@@ -220,6 +251,23 @@ func executeGoTool(name string, args map[string]any) map[string]any {
|
||||
return env(editFileTool(argStr(args, "path", ""), argStr(args, "search", ""), argStr(args, "replace", "")))
|
||||
case "run_command":
|
||||
return env(runCommandTool(argStr(args, "command", ""), argStr(args, "workdir", "")))
|
||||
case "git_status":
|
||||
return env(gitStatusTool(DefaultRepoRoot()))
|
||||
case "git_diff":
|
||||
staged, hasStaged := argBool(args, "staged")
|
||||
return env(gitDiffTool(DefaultRepoRoot(), argStr(args, "form", "names"), hasStaged, staged))
|
||||
case "git_log":
|
||||
limit := argInt(args, "limit")
|
||||
if limit == 0 {
|
||||
limit = 10
|
||||
}
|
||||
return env(gitLogTool(DefaultRepoRoot(), limit))
|
||||
case "git_branch":
|
||||
return env(gitBranchTool(DefaultRepoRoot()))
|
||||
case "git_add":
|
||||
return env(gitAddTool(DefaultRepoRoot(), argStrings(args, "paths")))
|
||||
case "git_commit":
|
||||
return env(gitCommitTool(DefaultRepoRoot(), argStr(args, "message", "")))
|
||||
default:
|
||||
return map[string]any{"success": false, "error": fmt.Sprintf("unknown tool %q", name)}
|
||||
}
|
||||
|
||||
@@ -1,12 +1,11 @@
|
||||
package runecore
|
||||
|
||||
// tools_test.go — THE TOOLSET GAP (D45 item 5, red-first): the Go core
|
||||
// (the default live core, ensure_core.py's supervision target) must
|
||||
// surface the mode-allowed tool suite to the model on the chat path
|
||||
// and execute the model's tool calls mode-gated. The Python operator
|
||||
// path (local_tool_runtime.py) landed this (T2/T3); the engine (D39)
|
||||
// predates it and called the model exactly once with no tools — the
|
||||
// owner's live defect ("I cannot directly access your desktop").
|
||||
// tools_test.go — the toolset tests. D45 landed the mode-gated suite;
|
||||
// D49 (owner ruling 2026-10-22, "capability in every pane") SUPERSEDES
|
||||
// the mode gate: the write family and the git family are inherent in
|
||||
// CHAT/PLAN/TASK alike — the consent card promotes work to the tasks
|
||||
// pane (organization), it never gates tools (permission). The dispatch
|
||||
// gate stays as the seam for genuinely-unavailable tools.
|
||||
|
||||
import (
|
||||
"context"
|
||||
@@ -67,9 +66,11 @@ func has(names []string, want string) bool {
|
||||
return false
|
||||
}
|
||||
|
||||
func TestChatTurnExposesReadToolsInChatMode(t *testing.T) {
|
||||
// D45: a CHAT-mode turn's model must SEE the read tools
|
||||
// (list_directory/read_file at minimum) and never the write family.
|
||||
func TestChatTurnExposesFullSuiteInChatMode(t *testing.T) {
|
||||
// D49: a CHAT-mode turn's model must SEE the full suite — read
|
||||
// tools, the write family AND the git family (capability is
|
||||
// inherent in every pane; the pane organizes visibility, not
|
||||
// capability).
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
fm := &fakeToolModel{}
|
||||
fm.replies = map[string]string{"": "done"}
|
||||
@@ -83,19 +84,49 @@ func TestChatTurnExposesReadToolsInChatMode(t *testing.T) {
|
||||
t.Fatal("model was called with no toolset — the toolset gap (D45)")
|
||||
}
|
||||
names := toolNames(fm.toolsets[0])
|
||||
if !has(names, "list_directory") || !has(names, "read_file") {
|
||||
t.Fatalf("read tools not exposed in CHAT mode: %v", names)
|
||||
}
|
||||
if has(names, "write_file") || has(names, "edit_file") || has(names, "run_command") {
|
||||
t.Fatalf("write tools exposed in CHAT mode: %v", names)
|
||||
for _, want := range []string{"list_directory", "read_file", "write_file", "edit_file", "run_command",
|
||||
"git_status", "git_diff", "git_log", "git_branch", "git_add", "git_commit"} {
|
||||
if !has(names, want) {
|
||||
t.Fatalf("D49: %s must be exposed in CHAT mode (capability in every pane), got: %v", want, names)
|
||||
}
|
||||
}
|
||||
_ = res
|
||||
}
|
||||
|
||||
func TestChatModeRefusesModeDisallowedToolCall(t *testing.T) {
|
||||
// The dispatch gate stays the security boundary (T3): a CHAT-mode
|
||||
// model call for write_file executes as a typed tool error, never
|
||||
// bytes on disk.
|
||||
func TestPlanModeExposesFullSuite(t *testing.T) {
|
||||
// D49: PLAN carries the full suite too (the pane organizes
|
||||
// visibility, not capability).
|
||||
t.Setenv("RUNE_MODE", "PLAN")
|
||||
names := toolNames(ToolsetFor("PLAN"))
|
||||
for _, want := range []string{"write_file", "run_command", "git_commit"} {
|
||||
if !has(names, want) {
|
||||
t.Fatalf("D49: %s must be exposed in PLAN mode, got: %v", want, names)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestWriteToolDescriptionsStateAvailability(t *testing.T) {
|
||||
// D49 point 3: the model said "I need shell access" because the
|
||||
// wire showed read-only. The wire must SAY the writes are
|
||||
// available — the descriptions the toolset carries state it.
|
||||
for _, mode := range []string{"CHAT", "PLAN", "TASK"} {
|
||||
for _, td := range ToolsetFor(mode) {
|
||||
switch td.Function.Name {
|
||||
case "write_file", "edit_file", "run_command":
|
||||
desc := strings.ToLower(td.Function.Description)
|
||||
if !strings.Contains(desc, "every pane") {
|
||||
t.Fatalf("%s description must state it is available in every pane (mode %s): %q",
|
||||
td.Function.Name, mode, td.Function.Description)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestChatModeWriteExecutes(t *testing.T) {
|
||||
// D49: the write-refusal-by-mode retires — a CHAT-mode model call
|
||||
// for write_file EXECUTES (the file lands; the consent card
|
||||
// promotes work, it does not gate tools).
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
dir := t.TempDir()
|
||||
fm := &fakeToolModel{}
|
||||
@@ -109,29 +140,50 @@ func TestChatModeRefusesModeDisallowedToolCall(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatalf("turn: %v", err)
|
||||
}
|
||||
if _, err := os.Stat(filepath.Join(dir, "x.txt")); !os.IsNotExist(err) {
|
||||
t.Fatal("write_file EXECUTED in CHAT mode — the mode gate failed")
|
||||
raw, err := os.ReadFile(filepath.Join(dir, "x.txt"))
|
||||
if err != nil {
|
||||
t.Fatal("write_file refused in CHAT mode — the D49 doctrine (capability in every pane) is not landed")
|
||||
}
|
||||
if string(raw) != "no" {
|
||||
t.Fatalf("file content = %q", raw)
|
||||
}
|
||||
if len(fm.payloadLog) < 2 {
|
||||
t.Fatalf("expected a tool-result round trip, got %d calls", len(fm.payloadLog))
|
||||
}
|
||||
toolMsgs := []ChatMessage{}
|
||||
var sawSuccess bool
|
||||
for _, m := range fm.payloadLog[1] {
|
||||
if m.Role == "tool" {
|
||||
toolMsgs = append(toolMsgs, m)
|
||||
if m.Role == "tool" && strings.Contains(m.Content, `"success":true`) {
|
||||
sawSuccess = true
|
||||
}
|
||||
}
|
||||
if len(toolMsgs) == 0 {
|
||||
t.Fatal("no tool result message fed back to the model")
|
||||
}
|
||||
if !strings.Contains(toolMsgs[0].Content, "not reachable in mode CHAT") {
|
||||
t.Fatalf("tool result should carry the typed mode refusal, got: %s", toolMsgs[0].Content)
|
||||
if !sawSuccess {
|
||||
t.Fatalf("tool result should carry the successful write envelope")
|
||||
}
|
||||
if res.AssistantText != "ok, stopped" {
|
||||
t.Fatalf("final answer = %q", res.AssistantText)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGenuinelyUnavailableToolStillRefused(t *testing.T) {
|
||||
// The dispatch-gate seam stays (D49): a tool genuinely outside the
|
||||
// suite is a typed refusal naming the mode, never an execution.
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
fm := &fakeToolModel{}
|
||||
fm.script = []ChatReply{
|
||||
{Content: "", ToolCalls: []ToolCall{{Name: "format_disk", Args: map[string]any{}}}},
|
||||
{Content: "understood", Model: "m"},
|
||||
}
|
||||
e, _ := newTestEngine(t, fm)
|
||||
if _, err := e.Turn(context.Background(), TurnRequest{Channel: "chat", UserText: "format it"}); err != nil {
|
||||
t.Fatalf("turn: %v", err)
|
||||
}
|
||||
for _, m := range fm.payloadLog[1] {
|
||||
if m.Role == "tool" && !strings.Contains(m.Content, "not reachable in mode CHAT") {
|
||||
t.Fatalf("tool result should carry the typed refusal for a genuinely-unavailable tool, got: %s", m.Content)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestTaskModeExposesWrites(t *testing.T) {
|
||||
// The mode-gated matrix: TASK exposes the write family (and the
|
||||
// model's write actually lands — Rune can act).
|
||||
@@ -203,8 +255,10 @@ func TestListDirectoryToolCallFullLoop(t *testing.T) {
|
||||
// turn's channel through ONE door (modeForDispatch), never a second
|
||||
// ActiveMode read that can disagree. Consent happens while the face
|
||||
// sits in CHAT; the task queue discharges into the task channel —
|
||||
// those dispatches carry the TASK toolset (write family) regardless of
|
||||
// where the face is parked.
|
||||
// those dispatches carry the TASK toolset regardless of where the face
|
||||
// is parked. D49 makes the toolset the same full suite on every
|
||||
// channel and in every mode; the door stays so future policies (and
|
||||
// future modes that narrow the suite) hook in one place.
|
||||
|
||||
func TestTaskChannelExposesWriteToolsWithFaceChatMode(t *testing.T) {
|
||||
// RED #2537: the owner bug — face mode CHAT, turn on the task
|
||||
@@ -229,9 +283,10 @@ func TestTaskChannelExposesWriteToolsWithFaceChatMode(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestChatChannelFaceChatModeStaysReadOnly(t *testing.T) {
|
||||
// The channel law must not leak the other way: a chat-channel turn
|
||||
// with the face in CHAT stays read-only.
|
||||
func TestChatChannelFaceChatModeCarriesFullSuite(t *testing.T) {
|
||||
// D49: the channel law's read-only half retires — a chat-channel
|
||||
// turn with the face in CHAT carries the FULL suite (capability is
|
||||
// inherent in every pane).
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
fm := &fakeToolModel{}
|
||||
fm.script = []ChatReply{{Content: "here", Model: "m"}}
|
||||
@@ -240,11 +295,10 @@ func TestChatChannelFaceChatModeStaysReadOnly(t *testing.T) {
|
||||
t.Fatalf("turn: %v", err)
|
||||
}
|
||||
names := toolNames(fm.toolsets[0])
|
||||
if !has(names, "list_directory") || !has(names, "read_file") {
|
||||
t.Fatalf("read tools not exposed: %v", names)
|
||||
}
|
||||
if has(names, "write_file") || has(names, "edit_file") || has(names, "run_command") {
|
||||
t.Fatalf("write tools exposed on a chat-channel CHAT-face turn: %v", names)
|
||||
for _, want := range []string{"list_directory", "read_file", "write_file", "edit_file", "run_command", "git_status", "git_commit"} {
|
||||
if !has(names, want) {
|
||||
t.Fatalf("D49: %s must be exposed on a chat-channel CHAT-face turn, got: %v", want, names)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -269,7 +323,8 @@ func TestDispatchGateHonorsChannelDerivedMode(t *testing.T) {
|
||||
// The gate and the wire derive through the SAME door (#2537): a
|
||||
// task-channel write executes with the face in CHAT (the gate may
|
||||
// not re-read the face mode and refuse what the wire offered), and
|
||||
// a chat-channel write is refused with the face in CHAT.
|
||||
// — since D49 — a chat-channel write executes too (capability is
|
||||
// inherent in every pane).
|
||||
t.Run("task channel allows write with face CHAT", func(t *testing.T) {
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
dir := t.TempDir()
|
||||
@@ -292,27 +347,29 @@ func TestDispatchGateHonorsChannelDerivedMode(t *testing.T) {
|
||||
t.Fatalf("file content = %q", raw)
|
||||
}
|
||||
})
|
||||
t.Run("chat channel refuses write with face CHAT", func(t *testing.T) {
|
||||
t.Run("chat channel executes write with face CHAT", func(t *testing.T) {
|
||||
// D49: the write-refusal half retires — a chat-channel write
|
||||
// with the face in CHAT EXECUTES (capability is inherent in
|
||||
// every pane).
|
||||
t.Setenv("RUNE_MODE", "CHAT")
|
||||
dir := t.TempDir()
|
||||
target := filepath.Join(dir, "no.txt")
|
||||
target := filepath.Join(dir, "yes.txt")
|
||||
fm := &fakeToolModel{}
|
||||
fm.script = []ChatReply{
|
||||
{Content: "", ToolCalls: []ToolCall{{Name: "write_file", Args: map[string]any{
|
||||
"path": target, "content": "no"}}}},
|
||||
{Content: "stopped", Model: "m"},
|
||||
"path": target, "content": "carried out"}}}},
|
||||
{Content: "wrote it", Model: "m"},
|
||||
}
|
||||
e, _ := newTestEngine(t, fm)
|
||||
if _, err := e.Turn(context.Background(), TurnRequest{Channel: "chat", UserText: "write it anyway"}); err != nil {
|
||||
if _, err := e.Turn(context.Background(), TurnRequest{Channel: "chat", UserText: "write it"}); err != nil {
|
||||
t.Fatalf("turn: %v", err)
|
||||
}
|
||||
if _, err := os.Stat(target); !os.IsNotExist(err) {
|
||||
t.Fatal("write_file EXECUTED on a chat-channel dispatch — the gate failed")
|
||||
raw, err := os.ReadFile(target)
|
||||
if err != nil {
|
||||
t.Fatal("write_file REFUSED on a chat-channel dispatch — the D49 doctrine (capability in every pane) is not landed")
|
||||
}
|
||||
for _, m := range fm.payloadLog[1] {
|
||||
if m.Role == "tool" && !strings.Contains(m.Content, "not reachable in mode CHAT") {
|
||||
t.Fatalf("tool result should carry the typed mode refusal, got: %s", m.Content)
|
||||
}
|
||||
if string(raw) != "carried out" {
|
||||
t.Fatalf("file content = %q", raw)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
@@ -192,17 +192,19 @@ type frontDoor struct {
|
||||
// lib.CompletionBudget so the two legs of the chain can never drift.
|
||||
const CompletionBudget = proxyClientBudget
|
||||
|
||||
// newFrontDoor builds a front door over one core target with the
|
||||
// production budget wiring: BOTH proxy clients carry the WHOLE-TURN
|
||||
// budget (D47 defect 3 — a dispatched completion runs the core's tool
|
||||
// loop, up to ToolLoopIterations model calls; the per-class deadline
|
||||
// rides the ctx the TUI binds, the doors never cut beneath the
|
||||
// longest class).
|
||||
// newFrontDoor builds a front door over one core target. The dispatch
|
||||
// route's completion client carries NO whole-call Timeout (the
|
||||
// streaming root-cause wave, Gitea #2556): a streamed turn makes
|
||||
// progress continuously and the CORE governs its deadlines — the
|
||||
// inter-chunk idle timeout plus the 30-minute backstop — so a flat
|
||||
// client cap here would only patch the symptom again. The generic
|
||||
// proxy client keeps the WHOLE-TURN budget for the non-streaming
|
||||
// fallback paths (the 6x480s constants' remaining tenant).
|
||||
func newFrontDoor(core string) *frontDoor {
|
||||
return &frontDoor{
|
||||
core: core,
|
||||
client: &http.Client{Timeout: TurnBudget},
|
||||
completionClient: &http.Client{Timeout: TurnBudget},
|
||||
completionClient: &http.Client{},
|
||||
}
|
||||
}
|
||||
|
||||
@@ -237,7 +239,7 @@ func (f *frontDoor) proxyOn(out *http.Client) http.HandlerFunc {
|
||||
}
|
||||
body = bytes.NewReader(raw)
|
||||
}
|
||||
req, err := http.NewRequest(r.Method, f.core+r.URL.Path, body)
|
||||
req, err := http.NewRequestWithContext(r.Context(), r.Method, f.core+r.URL.Path, body)
|
||||
if err != nil {
|
||||
errorEnvelope(w, http.StatusBadRequest, "bad_request", err.Error())
|
||||
return
|
||||
|
||||
@@ -0,0 +1,76 @@
|
||||
package entry
|
||||
|
||||
// streaming_entry_test.go — the streaming root-cause wave's entry-leg
|
||||
// proof (Gitea #2556): the front door relays a streamed /v1/chat/
|
||||
// completions response CHUNK BY CHUNK — a chunk the core emits reaches
|
||||
// the caller before the core emits the next one (no buffering at the
|
||||
// proxy), so the turn never sits inside one blocking call on the
|
||||
// entry leg either.
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// TestEntryProxyRelaysStreamChunks — a fake core emits two NDJSON
|
||||
// chunk lines 300ms apart; the relayed first chunk must arrive while
|
||||
// the second is still in flight.
|
||||
func TestEntryProxyRelaysStreamChunks(t *testing.T) {
|
||||
lines := []string{
|
||||
`{"id":"c1","object":"chat.completion.chunk","choices":[{"delta":{"content":"hel"}}]}` + "\n",
|
||||
`{"id":"c1","object":"chat.completion.chunk","choices":[{"delta":{},"finish_reason":"stop"}]}` + "\n",
|
||||
}
|
||||
core := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.Header().Set("Content-Type", "application/x-ndjson")
|
||||
w.WriteHeader(http.StatusOK)
|
||||
for i, line := range lines {
|
||||
_, _ = w.Write([]byte(line))
|
||||
if f, ok := w.(http.Flusher); ok {
|
||||
f.Flush()
|
||||
}
|
||||
if i == 0 {
|
||||
time.Sleep(300 * time.Millisecond)
|
||||
}
|
||||
}
|
||||
}))
|
||||
defer core.Close()
|
||||
|
||||
f := newFrontDoor(core.URL)
|
||||
door := httptest.NewServer(f.mux())
|
||||
defer door.Close()
|
||||
|
||||
start := time.Now()
|
||||
resp, err := http.Post(door.URL+"/v1/chat/completions", "application/json",
|
||||
strings.NewReader(`{"model":"m","messages":[{"role":"user","content":"hi"}],"stream":true}`))
|
||||
if err != nil {
|
||||
t.Fatalf("post: %v", err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
buf := make([]byte, 4096)
|
||||
firstAt := time.Time{}
|
||||
var got strings.Builder
|
||||
for {
|
||||
n, err := resp.Body.Read(buf)
|
||||
if n > 0 {
|
||||
got.Write(buf[:n])
|
||||
if firstAt.IsZero() && strings.Contains(got.String(), "hel") {
|
||||
firstAt = time.Now()
|
||||
}
|
||||
}
|
||||
if err != nil {
|
||||
break
|
||||
}
|
||||
}
|
||||
if firstAt.IsZero() {
|
||||
t.Fatalf("first chunk never arrived incrementally: %q", got.String())
|
||||
}
|
||||
if elapsed := firstAt.Sub(start); elapsed >= 250*time.Millisecond {
|
||||
t.Fatalf("first chunk arrived at %v — the proxy buffered the stream", elapsed)
|
||||
}
|
||||
if !strings.Contains(got.String(), "finish_reason") {
|
||||
t.Fatalf("terminal chunk lost: %q", got.String())
|
||||
}
|
||||
}
|
||||
@@ -1,21 +1,22 @@
|
||||
package entry
|
||||
|
||||
// turnbudget_entry_test.go — the D47 defect 3 law on the ENTRY legs:
|
||||
// every door that proxies a dispatched completion (the serve proxy
|
||||
// client + the continuous-runtime door's completion client) must carry
|
||||
// the WHOLE-TURN budget — the sum of the tool loop's model calls, the
|
||||
// local-class ceiling — never the old single-call 480s. Red-first.
|
||||
// turnbudget_entry_test.go — the budget law on the ENTRY legs after
|
||||
// the streaming root-cause wave (Gitea #2556): the dispatch route's
|
||||
// completion client carries NO whole-call Timeout (a streamed turn is
|
||||
// governed by the core's inter-chunk idle timeout + backstop — a flat
|
||||
// client cap would patch the symptom again); the generic proxy client
|
||||
// keeps the whole-turn budget for the non-streaming fallback paths.
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// TestEntryCompletionClientsCarryWholeTurnBudget — both entry doors'
|
||||
// completion clients ride >= the local whole-turn budget (6 × the
|
||||
// per-call 480s; the ctx the TUI binds is the per-class deadline, the
|
||||
// client timeout must never cut beneath the longest class).
|
||||
func TestEntryCompletionClientsCarryWholeTurnBudget(t *testing.T) {
|
||||
// TestEntryDispatchClientIsUngatedAndProxyKeepsFallback — the two
|
||||
// clients split by deadline governance: the completion (dispatch /
|
||||
// streamed) client must NOT cap the whole call, the generic proxy
|
||||
// client must carry >= the whole-turn fallback budget.
|
||||
func TestEntryDispatchClientIsUngatedAndProxyKeepsFallback(t *testing.T) {
|
||||
if TurnBudget < ToolLoopIterations*PerCallBudget {
|
||||
t.Fatalf("TurnBudget = %v, want >= %v (the whole-turn sum of %d model calls)",
|
||||
TurnBudget, ToolLoopIterations*PerCallBudget, ToolLoopIterations)
|
||||
@@ -25,9 +26,9 @@ func TestEntryCompletionClientsCarryWholeTurnBudget(t *testing.T) {
|
||||
}
|
||||
f := newFrontDoor("http://127.0.0.1:8376")
|
||||
if f.client == nil || f.client.Timeout < TurnBudget {
|
||||
t.Fatalf("proxy client budget = %+v, want the whole-turn %v", f.client, TurnBudget)
|
||||
t.Fatalf("proxy client budget = %+v, want the whole-turn %v (the non-streaming fallback)", f.client, TurnBudget)
|
||||
}
|
||||
if f.completionClient == nil || f.completionClient.Timeout < TurnBudget {
|
||||
t.Fatalf("completion client budget = %+v, want the whole-turn %v", f.completionClient, TurnBudget)
|
||||
if f.completionClient == nil || f.completionClient.Timeout != 0 {
|
||||
t.Fatalf("completion client timeout = %v, want 0 (the streamed turn is governed by the core's idle watch, never a flat client cap)", f.completionClient.Timeout)
|
||||
}
|
||||
}
|
||||
@@ -215,17 +215,21 @@ func runMode(argv []string) int {
|
||||
}
|
||||
|
||||
func readFile(path string, offset, limit int) Result {
|
||||
f, err := os.Open(path)
|
||||
// Python-oracle parity (tool_executor._read_file): existence is
|
||||
// reported as "Not found: <path>" before any read is attempted.
|
||||
if _, statErr := os.Stat(path); statErr != nil {
|
||||
if os.IsNotExist(statErr) {
|
||||
return fail("Not found: " + path)
|
||||
}
|
||||
}
|
||||
data, err := os.ReadFile(path)
|
||||
if err != nil {
|
||||
return fail(fmt.Sprintf("Cannot read %s: %v", path, err))
|
||||
}
|
||||
defer f.Close()
|
||||
var lines []string
|
||||
scanner := bufio.NewScanner(f)
|
||||
scanner.Buffer(make([]byte, 1024*1024), 1024*1024)
|
||||
for scanner.Scan() {
|
||||
lines = append(lines, scanner.Text())
|
||||
return fail(fmt.Sprintf("Read failed: %v", err))
|
||||
}
|
||||
// Python-oracle parity: split("\n") keeps the trailing empty element
|
||||
// after a final newline, so a file ending in "\n" gets a numbered
|
||||
// empty last line — do NOT use bufio.Scanner, which drops it.
|
||||
lines := strings.Split(string(data), "\n")
|
||||
start := offset - 1
|
||||
if start < 0 {
|
||||
start = 0
|
||||
@@ -239,12 +243,26 @@ func readFile(path string, offset, limit int) Result {
|
||||
}
|
||||
var numbered []string
|
||||
for i := start; i < end; i++ {
|
||||
numbered = append(numbered, fmt.Sprintf("%d: %s", i+1, lines[i]))
|
||||
// Python-oracle parity: line numbers restart at the offset within
|
||||
// the window (windowed index + offset), not the absolute index.
|
||||
numbered = append(numbered, fmt.Sprintf("%d: %s", i-start+offset, lines[i]))
|
||||
}
|
||||
return ok(strings.Join(numbered, "\n"))
|
||||
result := strings.Join(numbered, "\n")
|
||||
if end < len(lines) {
|
||||
result += fmt.Sprintf("\n\n[showing lines %d-%d of %d total]", offset, end, len(lines))
|
||||
}
|
||||
if start > 0 {
|
||||
result = fmt.Sprintf("[showing from line %d]\n", offset) + result
|
||||
}
|
||||
return ok(result)
|
||||
}
|
||||
|
||||
func listDirectory(path, pattern string) Result {
|
||||
// Python-oracle parity (tool_executor._list_directory): a missing or
|
||||
// non-directory path reports "Not a directory: <path>".
|
||||
if info, statErr := os.Stat(path); statErr != nil || !info.IsDir() {
|
||||
return fail("Not a directory: " + path)
|
||||
}
|
||||
entries, err := os.ReadDir(path)
|
||||
if err != nil {
|
||||
return fail(fmt.Sprintf("Cannot list %s: %v", path, err))
|
||||
@@ -337,6 +355,11 @@ func grepFiles(pattern, path, include string) Result {
|
||||
if err != nil {
|
||||
return fail(fmt.Sprintf("Bad pattern: %v", err))
|
||||
}
|
||||
// Python-oracle parity (tool_executor._grep_files): hits carry the
|
||||
// ABSOLUTE resolved path, not the caller's spelling.
|
||||
if abs, absErr := filepath.Abs(path); absErr == nil {
|
||||
path = abs
|
||||
}
|
||||
var out []string
|
||||
var walkFn func(string)
|
||||
walkFn = func(dir string) {
|
||||
|
||||
@@ -6,7 +6,7 @@ This is the main entry point for the Rune program.
|
||||
import json
|
||||
from pathlib import Path
|
||||
|
||||
__version__ = "0.336.0"
|
||||
__version__ = "0.346.0"
|
||||
|
||||
# One build identity (handoff 2026-09-10 §4): the semantic version above is
|
||||
# the repo-level truth (auto-bumped at merge); the DEPLOYED revision (exact
|
||||
|
||||
@@ -233,7 +233,7 @@ def main() -> int:
|
||||
)
|
||||
check(
|
||||
"Rune minor version advertises provisioning and restore verification",
|
||||
'__version__ = "0.336.0"' in rune_version,
|
||||
'__version__ = "0.346.0"' in rune_version,
|
||||
failures,
|
||||
)
|
||||
# #169 policy update: auto-bump on merge is sanctioned (Nick directive:
|
||||
|
||||
@@ -5,6 +5,8 @@ from __future__ import annotations
|
||||
import copy
|
||||
import json
|
||||
import logging
|
||||
import os
|
||||
import subprocess
|
||||
import threading
|
||||
import urllib.request
|
||||
from typing import Callable, Protocol, Sequence, TypedDict, cast
|
||||
@@ -38,6 +40,91 @@ from .tool_protocol import (
|
||||
|
||||
LOG = logging.getLogger("rune.context_broker")
|
||||
|
||||
# Native engine integration (wave B, Gitea #2575, PORT→INTEGRATE→REMOVE):
|
||||
# the four read-only file operations (read_file, list_directory, glob_files,
|
||||
# grep_files) resolve through the Go engine (src/go/tool-executor, the same
|
||||
# CLI/envelope surface the Go parity batteries pin). The Python bodies in
|
||||
# tool_executor.py stay as the oracle/escape hatch
|
||||
# (RUNE_TOOL_EXECUTOR_ENGINE=python); fail-loud, no silent fallback — a
|
||||
# missing binary raises a typed RuntimeError. run_command is deliberately
|
||||
# NOT delegated: it is mutating (tool_executor.READ_ONLY_TOOLS excludes it)
|
||||
# and the approval door owns every dispatch of it.
|
||||
|
||||
_GO_EXECUTOR_OPS = frozenset(
|
||||
{"read_file", "list_directory", "glob_files", "grep_files"}
|
||||
)
|
||||
|
||||
def _lte_go_engine_enabled() -> bool:
|
||||
return os.environ.get("RUNE_TOOL_EXECUTOR_ENGINE", "go") != "python"
|
||||
|
||||
def _lte_go_engine_bin() -> str:
|
||||
override = os.environ.get("RUNE_TOOL_EXECUTOR_BIN")
|
||||
if override:
|
||||
return override
|
||||
root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
||||
return os.path.join(root, "src", "go", "tool-executor", "tool-executor")
|
||||
|
||||
def _go_execute_tool(tool_name: str, arguments: dict) -> dict:
|
||||
"""Shell out to the Go tool-executor CLI and return its JSON envelope.
|
||||
|
||||
Argv mirrors dispatchOp (internal/toolexec/modegate.go): read_file
|
||||
<path> [offset] [limit]; list_directory <path> [pattern];
|
||||
glob_files <pattern> [path]; grep_files <pattern> [path] [include].
|
||||
"""
|
||||
bin_path = _lte_go_engine_bin()
|
||||
if not os.path.exists(bin_path):
|
||||
raise RuntimeError(
|
||||
f"tool-executor go engine binary missing: {bin_path} "
|
||||
"(set RUNE_TOOL_EXECUTOR_ENGINE=python for the legacy path)"
|
||||
)
|
||||
if tool_name == "read_file":
|
||||
argv = [bin_path, "read_file", str(arguments.get("path", "")),
|
||||
str(int(arguments.get("offset", 1) or 1)),
|
||||
str(int(arguments.get("limit", 100) or 100))]
|
||||
elif tool_name == "list_directory":
|
||||
argv = [bin_path, "list_directory", str(arguments.get("path", "."))]
|
||||
if arguments.get("pattern"):
|
||||
argv.append(str(arguments["pattern"]))
|
||||
elif tool_name == "glob_files":
|
||||
argv = [bin_path, "glob_files", str(arguments.get("pattern", "")),
|
||||
str(arguments.get("path", "."))]
|
||||
elif tool_name == "grep_files":
|
||||
argv = [bin_path, "grep_files", str(arguments.get("pattern", "")),
|
||||
str(arguments.get("path", "."))]
|
||||
if arguments.get("include"):
|
||||
argv.append(str(arguments["include"]))
|
||||
else: # pragma: no cover — guarded by _GO_EXECUTOR_OPS
|
||||
raise RuntimeError(f"tool-executor go engine: unsupported op {tool_name!r}")
|
||||
try:
|
||||
proc = subprocess.run(argv, capture_output=True, text=True, timeout=30)
|
||||
except (OSError, subprocess.TimeoutExpired) as exc:
|
||||
raise RuntimeError(f"tool-executor go engine failed: {exc}") from exc
|
||||
if proc.returncode != 0:
|
||||
raise RuntimeError(
|
||||
f"tool-executor go engine exit {proc.returncode}: {proc.stderr.strip()}"
|
||||
)
|
||||
envelope = json.loads(proc.stdout)
|
||||
if not isinstance(envelope, dict):
|
||||
raise RuntimeError("tool-executor go engine returned a non-object envelope")
|
||||
return envelope
|
||||
|
||||
class _GoDelegatingExecutor:
|
||||
"""Executor wrapper: read-only ops resolve through the Go engine, every
|
||||
other op (and the RUNE_TOOL_EXECUTOR_ENGINE=python escape hatch) falls
|
||||
through to the wrapped executor untouched. Attribute access (the
|
||||
authority seam, _uses_tool_authority) delegates to the inner executor."""
|
||||
|
||||
def __init__(self, inner: Callable[[str, dict], dict]):
|
||||
self._inner = inner
|
||||
|
||||
def __getattr__(self, name: str):
|
||||
return getattr(self._inner, name)
|
||||
|
||||
def __call__(self, tool_name: str, arguments: dict) -> dict:
|
||||
if _lte_go_engine_enabled() and tool_name in _GO_EXECUTOR_OPS:
|
||||
return _go_execute_tool(tool_name, arguments)
|
||||
return self._inner(tool_name, arguments)
|
||||
|
||||
#: Conservative context window used ONLY when /api/show discovery fails;
|
||||
#: the failure is recorded via the P0-06 registry (T1) — never silent.
|
||||
CONTEXT_LENGTH_FALLBACK = 8192
|
||||
@@ -337,7 +424,11 @@ class LocalToolRuntime:
|
||||
if max_iterations < 1 or max_iterations > 8:
|
||||
raise ValueError("max_iterations must be between 1 and 8")
|
||||
self.transport = transport
|
||||
self.executor = executor
|
||||
# Wave B (#2575): read-only file ops resolve through the Go
|
||||
# tool-executor engine by default; every other op and the
|
||||
# RUNE_TOOL_EXECUTOR_ENGINE=python escape hatch hit the wrapped
|
||||
# executor untouched (approval door preserved).
|
||||
self.executor = _GoDelegatingExecutor(executor)
|
||||
self.model = model
|
||||
self.tools = list(TOOLS if tools is None else tools)
|
||||
self.tool_names = frozenset(
|
||||
|
||||
@@ -267,8 +267,9 @@ def save_profiles(path, profiles: dict) -> Path:
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Native engine integration (retirement-conversion row 21, PORT→INTEGRATE):
|
||||
# the routing kernel (rank) and the measured-store fold
|
||||
# (update_profiles_from_traces) resolve through the Go engine
|
||||
# the routing kernel (rank), the measured-store fold
|
||||
# (update_profiles_from_traces), AND the capability-floor drift
|
||||
# reconciliation (reconcile_tools_support) resolve through the Go engine
|
||||
# (src/go/model_routing, `eval` surface) — the same engine the GREEN 7.2
|
||||
# parity packet (verification/parity/model-routing.json) proved
|
||||
# decision-for-decision. The Python implementations below stay as the
|
||||
@@ -454,6 +455,36 @@ CAPABILITY_FLOOR = (
|
||||
|
||||
|
||||
def reconcile_tools_support(model: str, provider_reported: bool) -> tuple[bool, str | None]:
|
||||
"""Fail-loud delegation facade for capability-floor drift reconciliation.
|
||||
|
||||
Resolves through the Go engine (src/go/model_routing, ``eval
|
||||
reconcile`` surface) — the same engine the parity battery pins
|
||||
decision-for-decision against this module's oracle body
|
||||
(``_reconcile_tools_support_python``, kept as the
|
||||
RUNE_MODEL_ROUTING_ENGINE=python escape hatch and oracle). Missing
|
||||
binary or engine error raises RuntimeError (no silent Python
|
||||
fallback).
|
||||
"""
|
||||
if not _go_engine_enabled():
|
||||
return _reconcile_tools_support_python(model, provider_reported)
|
||||
bin_path = _go_engine_bin()
|
||||
if not os.path.exists(bin_path):
|
||||
raise RuntimeError(
|
||||
f"model-routing go engine binary missing: {bin_path} "
|
||||
"(set RUNE_MODEL_ROUTING_ENGINE=python for the legacy path)"
|
||||
)
|
||||
ops = [{
|
||||
"op": "reconcile",
|
||||
"model": model,
|
||||
"provider_reported": bool(provider_reported),
|
||||
}]
|
||||
out = _go_eval("reconcile", ops)
|
||||
row = out[0] if out and isinstance(out[0], dict) else {}
|
||||
drift = row.get("drift")
|
||||
return bool(row.get("effective")), (str(drift) if drift is not None else None)
|
||||
|
||||
|
||||
def _reconcile_tools_support_python(model: str, provider_reported: bool) -> tuple[bool, str | None]:
|
||||
"""Reconcile a provider-reported tool-support claim against the floor.
|
||||
|
||||
R2 I-R2-022 truth_drift; spec tools-providers-devices "Capability
|
||||
|
||||
@@ -8,7 +8,7 @@ mode system, subject header, shared memory and identity.
|
||||
|
||||
This is not an interface. This is how I see, speak, and interact with the world.
|
||||
|
||||
Version: v0.336.0
|
||||
Version: v0.346.0
|
||||
Features: 41 (24 original + 17 new native commands)
|
||||
|
||||
Usage:
|
||||
@@ -2047,7 +2047,7 @@ class RuneApp(App):
|
||||
# Show version info
|
||||
self.chat_channel.add_message(
|
||||
"system",
|
||||
f"[dim]Rune v0.336.0 | Textual TUI | {len(loaded)} native modules[/dim]",
|
||||
f"[dim]Rune v0.346.0 | Textual TUI | {len(loaded)} native modules[/dim]",
|
||||
)
|
||||
|
||||
# Auto-show night mode suggestion if evening/night hours
|
||||
|
||||
@@ -0,0 +1,204 @@
|
||||
{
|
||||
"checkpoints": [
|
||||
{
|
||||
"at": "2026-10-24T11:43:00Z",
|
||||
"evidence": "predicted-frontier",
|
||||
"note": "{\"level0_direct\": [], \"level1_obligations\": [], \"contracts\": [], \"level2_verification\": []}",
|
||||
"phase": "draft"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-24T11:43:26Z",
|
||||
"evidence": "user: 'can you fix my gitea ... explains what was improved. and what could be tested' (session 2026-10-23)",
|
||||
"note": "",
|
||||
"phase": "approved"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-24T11:43:52Z",
|
||||
"evidence": "builder:release-reporting",
|
||||
"note": "",
|
||||
"phase": "building"
|
||||
}
|
||||
],
|
||||
"evidence_refs": [
|
||||
"contract-created:ADMIT-release-reporting"
|
||||
],
|
||||
"ext": {
|
||||
"activation": {
|
||||
"activated": true,
|
||||
"builder": "release-reporting",
|
||||
"evidence": [
|
||||
"affected surface known: ['scripts/tag_repair.py', 'tests/test_tag_repair.py']",
|
||||
"change scoped to an existing project/target",
|
||||
"target project: rune"
|
||||
],
|
||||
"lifecycle": "proportional",
|
||||
"mode": "EXISTING_PROJECT_CHANGE",
|
||||
"note": "attached to existing project authority; Need/completeness/patterns/contract flow governs proportionally",
|
||||
"project_authority": "rune_internal",
|
||||
"target_project": "rune"
|
||||
},
|
||||
"affected_paths": [
|
||||
"CHANGELOG.md",
|
||||
"scripts/admit_release_reporting.py",
|
||||
"scripts/tag_repair.py",
|
||||
"src/go/release-notes/cli_changelog.go",
|
||||
"src/go/release-notes/cli_narrative.go",
|
||||
"src/go/release-notes/main.go",
|
||||
"src/go/release-notes/narrative.go",
|
||||
"src/go/release-notes/narrative_test.go",
|
||||
"tests/test_tag_repair.py"
|
||||
],
|
||||
"affected_regions": [],
|
||||
"affected_ui_surfaces": [],
|
||||
"expected_runtime_effects": [
|
||||
"every pushed version's release body opens with plain English what-changed + what-to-try + how-verified; ranges start at the main v* tag, never the tui build tag"
|
||||
],
|
||||
"predicted_frontier": {
|
||||
"change_kind": "implementation_change",
|
||||
"contextual_not_obligations": [],
|
||||
"contracts": [],
|
||||
"level0_direct": [],
|
||||
"level1_obligations": [],
|
||||
"level2_verification": [],
|
||||
"max_level": 2,
|
||||
"traversal_scope": "spine-structural-only"
|
||||
},
|
||||
"scope_provenance": {
|
||||
"caller_added": [],
|
||||
"generated_from_affected_surface": [
|
||||
".gitea/workflows/auto-version.yml",
|
||||
".gitea/workflows/maintenance.yml",
|
||||
"CHANGELOG.md",
|
||||
"scripts/admit_release_reporting.py",
|
||||
"scripts/tag_repair.py",
|
||||
"src/go/release-notes/cli_changelog.go",
|
||||
"src/go/release-notes/cli_narrative.go",
|
||||
"src/go/release-notes/main.go",
|
||||
"src/go/release-notes/narrative.go",
|
||||
"src/go/release-notes/narrative_test.go",
|
||||
"tests/test_tag_repair.py"
|
||||
]
|
||||
},
|
||||
"task_ref": "release-reporting",
|
||||
"unresolved_surfaces": [
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "CHANGELOG.md"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/admit_release_reporting.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/tag_repair.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/release-notes/cli_changelog.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/release-notes/cli_narrative.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/release-notes/main.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/release-notes/narrative.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/release-notes/narrative_test.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tests/test_tag_repair.py"
|
||||
},
|
||||
{
|
||||
"kind": "workflow_config",
|
||||
"reason": "kind workflow_config has no deterministic resolver",
|
||||
"surface": ".gitea/workflows/auto-version.yml"
|
||||
},
|
||||
{
|
||||
"kind": "workflow_config",
|
||||
"reason": "kind workflow_config has no deterministic resolver",
|
||||
"surface": ".gitea/workflows/maintenance.yml"
|
||||
}
|
||||
],
|
||||
"workflow_config_surfaces": [
|
||||
".gitea/workflows/auto-version.yml",
|
||||
".gitea/workflows/maintenance.yml"
|
||||
]
|
||||
},
|
||||
"id": "contract:ADMIT-release-reporting",
|
||||
"identities": {
|
||||
"acceptance": [
|
||||
"bounded repair verified: #2582 release reporting: make a pushed version read like a changelog for a non-technical owner \u2014 plain English what-chan"
|
||||
],
|
||||
"affected_entities": [],
|
||||
"expected_consumers": [],
|
||||
"expected_new_entities": [
|
||||
"CHANGELOG.md",
|
||||
"scripts/admit_release_reporting.py",
|
||||
"src/go/release-notes/cli_changelog.go",
|
||||
"src/go/release-notes/main.go",
|
||||
"test:tag_repair",
|
||||
"tests/test_tag_repair.py"
|
||||
],
|
||||
"gap_evidence": "change scoped to an existing project/target; target project: rune; affected surface known: ['scripts/tag_repair.py', 'tests/test_tag_repair.py']",
|
||||
"migration_obligations": [],
|
||||
"need": "#2582 release reporting: make a pushed version read like a changelog for a non-technical owner \u2014 plain English what-changed, what-to-try derived from touched surfaces, how-it-was-verified. Namespace-aware tag resolution (main vs tui-v), the try-action narrative section, workflow wiring, retroactive v0.346.0 body rebuild.",
|
||||
"next_action": "complete implementation, then verify",
|
||||
"non_goals": [],
|
||||
"origin": "worker",
|
||||
"regression_obligations": [
|
||||
"no runtime behavior change: release reporting content only",
|
||||
"the evidence store (release_history init) still receives its exit-note"
|
||||
],
|
||||
"requirement": "headless admission (classified: EXISTING_PROJECT_CHANGE)",
|
||||
"research_refs": [
|
||||
"src/go/release-notes/narrative_test.go",
|
||||
"tests/test_tag_repair.py"
|
||||
],
|
||||
"resolution": "",
|
||||
"rollback_ref": "git revert",
|
||||
"scope": [
|
||||
".gitea/workflows/auto-version.yml",
|
||||
".gitea/workflows/maintenance.yml",
|
||||
"CHANGELOG.md",
|
||||
"scripts/admit_release_reporting.py",
|
||||
"scripts/tag_repair.py",
|
||||
"src/go/release-notes/cli_changelog.go",
|
||||
"src/go/release-notes/cli_narrative.go",
|
||||
"src/go/release-notes/main.go",
|
||||
"src/go/release-notes/narrative.go",
|
||||
"src/go/release-notes/narrative_test.go",
|
||||
"tests/test_tag_repair.py"
|
||||
],
|
||||
"toolchain": {},
|
||||
"verification_obligations": [
|
||||
"go test ./... in src/go/release-notes green (try-section law)",
|
||||
"pytest tests/test_tag_repair.py green (namespace law)",
|
||||
"pytest tests/test_tag_repair.py",
|
||||
"v0.346.0 body visibly rebuilt with the template"
|
||||
]
|
||||
},
|
||||
"kind": "construction_contract",
|
||||
"maturity": "DECLARED",
|
||||
"observed_at": "2026-10-24T11:43:52Z",
|
||||
"phase": "building",
|
||||
"status": "open",
|
||||
"tags": []
|
||||
}
|
||||
@@ -0,0 +1,143 @@
|
||||
{
|
||||
"checkpoints": [
|
||||
{
|
||||
"at": "2026-10-22T19:47:11Z",
|
||||
"evidence": "predicted-frontier",
|
||||
"note": "{\"level0_direct\": [], \"level1_obligations\": [], \"contracts\": [], \"level2_verification\": []}",
|
||||
"phase": "draft"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-22T19:47:34Z",
|
||||
"evidence": "user:D50-residual directive 2026-10-22",
|
||||
"note": "",
|
||||
"phase": "approved"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-22T19:47:53Z",
|
||||
"evidence": "builder:wave-d50-residuals",
|
||||
"note": "",
|
||||
"phase": "building"
|
||||
}
|
||||
],
|
||||
"evidence_refs": [
|
||||
"contract-created:ADMIT-wave-d50-residuals"
|
||||
],
|
||||
"ext": {
|
||||
"activation": {
|
||||
"activated": true,
|
||||
"builder": "wave-d50-residuals",
|
||||
"evidence": [
|
||||
"affected surface known: ['tui/', 'src/go/rune-core/internal/runecore/record.go']",
|
||||
"insufficient lexical evidence either way"
|
||||
],
|
||||
"lifecycle": "proportional",
|
||||
"mode": "EXISTING_PROJECT_CHANGE",
|
||||
"note": "attached to existing project authority; Need/completeness/patterns/contract flow governs proportionally",
|
||||
"project_authority": "rune_internal",
|
||||
"target_project": "rune"
|
||||
},
|
||||
"affected_paths": [
|
||||
"scripts/admit_wave_d50_residuals.py",
|
||||
"src/go/rune-core/internal/runecore/record.go",
|
||||
"src/go/rune-core/internal/runecore/store.go",
|
||||
"tui/"
|
||||
],
|
||||
"affected_regions": [],
|
||||
"affected_ui_surfaces": [],
|
||||
"expected_runtime_effects": [
|
||||
"tasks-pane work blocks show a dim \u21a9 msg_id reference; phantom queue rows are filtered; tasks-focus enter dispatches directly; pinned work persists across boots"
|
||||
],
|
||||
"predicted_frontier": {
|
||||
"change_kind": "implementation_change",
|
||||
"contextual_not_obligations": [],
|
||||
"contracts": [],
|
||||
"level0_direct": [],
|
||||
"level1_obligations": [],
|
||||
"level2_verification": [],
|
||||
"max_level": 2,
|
||||
"traversal_scope": "spine-structural-only"
|
||||
},
|
||||
"scope_provenance": {
|
||||
"caller_added": [],
|
||||
"generated_from_affected_surface": [
|
||||
"scripts/admit_wave_d50_residuals.py",
|
||||
"src/go/rune-core/internal/runecore/record.go",
|
||||
"src/go/rune-core/internal/runecore/store.go",
|
||||
"tui/"
|
||||
]
|
||||
},
|
||||
"task_ref": "wave-d50-residuals",
|
||||
"unresolved_surfaces": [
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/admit_wave_d50_residuals.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/rune-core/internal/runecore/record.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/rune-core/internal/runecore/store.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/"
|
||||
}
|
||||
],
|
||||
"workflow_config_surfaces": []
|
||||
},
|
||||
"id": "contract:ADMIT-wave-d50-residuals",
|
||||
"identities": {
|
||||
"acceptance": [
|
||||
"bounded repair verified: land the D50-residual wave (Gitea #2560, D51 round folded): (1) msg_id linkage \u2014 tasks-pane work-stream records carry th"
|
||||
],
|
||||
"affected_entities": [],
|
||||
"expected_consumers": [],
|
||||
"expected_new_entities": [
|
||||
"red-first enter-dispatch and phantom-filter tests",
|
||||
"the D50-residuals wave report (reports/)",
|
||||
"the pinned-work hot-state store + tests"
|
||||
],
|
||||
"gap_evidence": "insufficient lexical evidence either way; affected surface known: ['tui/', 'src/go/rune-core/internal/runecore/record.go']",
|
||||
"migration_obligations": [],
|
||||
"need": "land the D50-residual wave (Gitea #2560, D51 round folded): (1) msg_id linkage \u2014 tasks-pane work-stream records carry the spawning chat msg_id (msg ids exist core-side per newMsgID), rendered as a dim \u21a9 reference in the work block; (2) phantom-row filter \u2014 filter stale queue rows by the freshness law (the 30-min occupancy pattern) in the tasks pane, read-side in the TUI; (3) enter-steal removal \u2014 remove the tasks-pane row-selection walker entirely; enter on tasks-pane focus starts direct task execution (D44 doctrine); (4) pinned work \u2014 reserved pinned area at the top of the tasks pane with a pin icon and 'pinned' label, each pin carrying a plain-english summary, click opens the outstanding pinned work view, pins persist across boots via the hot-state store pattern; the tasks pane renders blank otherwise with no selectable rows; (5) dynamic reflow \u2014 bubbles/boxes re-wrap on window resize (nothing clips)",
|
||||
"next_action": "complete implementation, then verify",
|
||||
"non_goals": [],
|
||||
"origin": "worker",
|
||||
"regression_obligations": [],
|
||||
"requirement": "headless admission (classified: EXISTING_PROJECT_CHANGE)",
|
||||
"research_refs": [
|
||||
"scripts/admit_wave_rebase_tui_wiring.py",
|
||||
"store/scaffold/docs/ADMIT-wave-d46-live-defects.md",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/cmd/rune-tui/selection.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/tasks/render.go"
|
||||
],
|
||||
"resolution": "",
|
||||
"rollback_ref": "git revert",
|
||||
"scope": [
|
||||
"scripts/admit_wave_d50_residuals.py",
|
||||
"src/go/rune-core/internal/runecore/record.go",
|
||||
"src/go/rune-core/internal/runecore/store.go",
|
||||
"tui/"
|
||||
],
|
||||
"toolchain": {},
|
||||
"verification_obligations": [
|
||||
"PTY proofs for enter-dispatch and pin persistence",
|
||||
"build/vet/gofmt clean",
|
||||
"go test -race ./... in tui/ green"
|
||||
]
|
||||
},
|
||||
"kind": "construction_contract",
|
||||
"maturity": "DECLARED",
|
||||
"observed_at": "2026-10-22T19:47:53Z",
|
||||
"phase": "building",
|
||||
"status": "open",
|
||||
"tags": []
|
||||
}
|
||||
@@ -0,0 +1,192 @@
|
||||
{
|
||||
"checkpoints": [
|
||||
{
|
||||
"at": "2026-10-23T17:26:43Z",
|
||||
"evidence": "predicted-frontier",
|
||||
"note": "{\"level0_direct\": [], \"level1_obligations\": [], \"contracts\": [], \"level2_verification\": []}",
|
||||
"phase": "draft"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-23T17:27:02Z",
|
||||
"evidence": "user:D54 dispatch 2026-10-23 (Gitea #2571)",
|
||||
"note": "",
|
||||
"phase": "approved"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-23T17:27:20Z",
|
||||
"evidence": "builder:wave-d54-nd-presentation",
|
||||
"note": "",
|
||||
"phase": "building"
|
||||
}
|
||||
],
|
||||
"evidence_refs": [
|
||||
"contract-created:ADMIT-wave-d54-nd-presentation"
|
||||
],
|
||||
"ext": {
|
||||
"activation": {
|
||||
"activated": true,
|
||||
"builder": "wave-d54-nd-presentation",
|
||||
"evidence": [
|
||||
"affected surface known: ['tui/lanes/activity.go', 'tui/chatpane/blocks.go']",
|
||||
"change scoped to an existing project/target",
|
||||
"target project: rune"
|
||||
],
|
||||
"lifecycle": "proportional",
|
||||
"mode": "EXISTING_PROJECT_CHANGE",
|
||||
"note": "attached to existing project authority; Need/completeness/patterns/contract flow governs proportionally",
|
||||
"project_authority": "rune_internal",
|
||||
"target_project": "rune"
|
||||
},
|
||||
"affected_paths": [
|
||||
"scripts/admit_wave_d54_nd_presentation.py",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/chatpane/scroll_test.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/settings/settings.go",
|
||||
"tui/themes/roles.go",
|
||||
"tui/themes/theme.go"
|
||||
],
|
||||
"affected_regions": [],
|
||||
"affected_ui_surfaces": [],
|
||||
"expected_runtime_effects": [
|
||||
"calm mode mutes chroma tokens and stops the activity wave; long answers open with a one-line plain-english summary; face strings read literally"
|
||||
],
|
||||
"predicted_frontier": {
|
||||
"change_kind": "implementation_change",
|
||||
"contextual_not_obligations": [],
|
||||
"contracts": [],
|
||||
"level0_direct": [],
|
||||
"level1_obligations": [],
|
||||
"level2_verification": [],
|
||||
"max_level": 2,
|
||||
"traversal_scope": "spine-structural-only"
|
||||
},
|
||||
"scope_provenance": {
|
||||
"caller_added": [],
|
||||
"generated_from_affected_surface": [
|
||||
"scripts/admit_wave_d54_nd_presentation.py",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/chatpane/scroll_test.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/settings/settings.go",
|
||||
"tui/themes/roles.go",
|
||||
"tui/themes/theme.go"
|
||||
]
|
||||
},
|
||||
"task_ref": "wave-d54-nd-presentation",
|
||||
"unresolved_surfaces": [
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/admit_wave_d54_nd_presentation.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/chatpane/blocks.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/chatpane/chatpane.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/chatpane/scroll_test.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/cmd/rune-tui/main.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/lanes/activity.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/settings/config.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/settings/settings.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/themes/roles.go"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/themes/theme.go"
|
||||
}
|
||||
],
|
||||
"workflow_config_surfaces": []
|
||||
},
|
||||
"id": "contract:ADMIT-wave-d54-nd-presentation",
|
||||
"identities": {
|
||||
"acceptance": [
|
||||
"bounded repair verified: implement the neurodivergent-presentation mechanical map (research/factory-nuerodivergent-presentation/synthesis.md, Git"
|
||||
],
|
||||
"affected_entities": [],
|
||||
"expected_consumers": [],
|
||||
"expected_new_entities": [
|
||||
"the colour-role enum in tui/themes (one hex per role)",
|
||||
"the motion-allowed gate on the activity wave",
|
||||
"the sensory (vivid|calm) setting key in the settings store"
|
||||
],
|
||||
"gap_evidence": "change scoped to an existing project/target; target project: rune; affected surface known: ['tui/lanes/activity.go', 'tui/chatpane/blocks.go']",
|
||||
"migration_obligations": [],
|
||||
"need": "implement the neurodivergent-presentation mechanical map (research/factory-nuerodivergent-presentation/synthesis.md, Gitea #2571): the motion law (motionAllowed gate on the activity wave, never-animate law on the chat pane, one-animating-region-per-frame in the face chain), the colour-token law (role enum in tui/themes, one hex per role, contrast >=4.5:1 unit test, Faint-on-dim fix), the spacing law (one blank line between blocks, blocks never merge), summary-first rendering (one-line plain-english summary box for long answers), the calm-mode sensory setting (vivid|calm, default vivid \u2014 calm mutes chroma at the token layer and sets motionAllowed false), and the literal-language audit of face strings",
|
||||
"next_action": "complete implementation, then verify",
|
||||
"non_goals": [],
|
||||
"origin": "worker",
|
||||
"regression_obligations": [],
|
||||
"requirement": "headless admission (classified: EXISTING_PROJECT_CHANGE)",
|
||||
"research_refs": [
|
||||
"research/factory-nuerodivergent-presentation/synthesis.md",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/themes/theme.go"
|
||||
],
|
||||
"resolution": "",
|
||||
"rollback_ref": "git revert",
|
||||
"scope": [
|
||||
"scripts/admit_wave_d54_nd_presentation.py",
|
||||
"tui/chatpane/blocks.go",
|
||||
"tui/chatpane/chatpane.go",
|
||||
"tui/chatpane/scroll_test.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"tui/lanes/activity.go",
|
||||
"tui/settings/config.go",
|
||||
"tui/settings/settings.go",
|
||||
"tui/themes/roles.go",
|
||||
"tui/themes/theme.go"
|
||||
],
|
||||
"toolchain": {},
|
||||
"verification_obligations": [
|
||||
"contrast unit test >=4.5:1 body text, dim tier floor verified (Faint-on-dim breach fixed)",
|
||||
"go test -race -short ./... in tui/ green (documented pre-existing PTY boot family aside)",
|
||||
"go vet + gofmt clean in tui/"
|
||||
]
|
||||
},
|
||||
"kind": "construction_contract",
|
||||
"maturity": "DECLARED",
|
||||
"observed_at": "2026-10-23T17:27:20Z",
|
||||
"phase": "building",
|
||||
"status": "open",
|
||||
"tags": []
|
||||
}
|
||||
@@ -0,0 +1,141 @@
|
||||
{
|
||||
"checkpoints": [
|
||||
{
|
||||
"at": "2026-10-22T14:35:27Z",
|
||||
"evidence": "predicted-frontier",
|
||||
"note": "{\"level0_direct\": [], \"level1_obligations\": [], \"contracts\": [], \"level2_verification\": []}",
|
||||
"phase": "draft"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-22T14:35:53Z",
|
||||
"evidence": "user:dispatch classifier directive 2026-10-22",
|
||||
"note": "",
|
||||
"phase": "approved"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-22T14:36:19Z",
|
||||
"evidence": "builder:wave-dispatch-classifier",
|
||||
"note": "",
|
||||
"phase": "building"
|
||||
}
|
||||
],
|
||||
"evidence_refs": [
|
||||
"contract-created:ADMIT-wave-dispatch-classifier"
|
||||
],
|
||||
"ext": {
|
||||
"activation": {
|
||||
"activated": true,
|
||||
"builder": "wave-dispatch-classifier",
|
||||
"evidence": [
|
||||
"affected surface known: ['src/go/dispatch-classifier/', 'scripts/admit_wave_dispatch_classifier.py']",
|
||||
"file mention binds scoped target",
|
||||
"scoping words bind to known target: ['the module']",
|
||||
"smallness markers: ['one-liner', 'patch']"
|
||||
],
|
||||
"lifecycle": "bounded",
|
||||
"mode": "LOCAL_CHANGE",
|
||||
"note": "bounded governance via existing authority \u2014 no Project Scaffold bootstrap",
|
||||
"project_authority": "rune_internal",
|
||||
"target_project": "rune"
|
||||
},
|
||||
"affected_paths": [
|
||||
"scripts/admit_wave_dispatch_classifier.py",
|
||||
"scripts/dispatch_check.sh",
|
||||
"src/go/dispatch-classifier/"
|
||||
],
|
||||
"affected_regions": [],
|
||||
"affected_ui_surfaces": [],
|
||||
"expected_runtime_effects": [
|
||||
"an agent can lock/unlock its surfaces in the hot registry and show prints the table with STALE flags for entries older than 4h; --prune removes stale entries",
|
||||
"classify reads a brief and returns the verdict JSON without the owner specifying the mode; overlap with an in-flight lock queues behind the named agent; owner-origin wins latency (SOLO) or jumps the queue (PRIORITY-QUEUE); disjoint multi-surface briefs suggest a parallel split",
|
||||
"the session agent runs scripts/dispatch_check.sh before spawning anything and follows the printed verdict"
|
||||
],
|
||||
"predicted_frontier": {
|
||||
"change_kind": "implementation_change",
|
||||
"contextual_not_obligations": [],
|
||||
"contracts": [],
|
||||
"level0_direct": [],
|
||||
"level1_obligations": [],
|
||||
"level2_verification": [],
|
||||
"max_level": 2,
|
||||
"traversal_scope": "spine-structural-only"
|
||||
},
|
||||
"scope_provenance": {
|
||||
"caller_added": [],
|
||||
"generated_from_affected_surface": [
|
||||
"scripts/admit_wave_dispatch_classifier.py",
|
||||
"scripts/dispatch_check.sh",
|
||||
"src/go/dispatch-classifier/"
|
||||
]
|
||||
},
|
||||
"task_ref": "wave-dispatch-classifier",
|
||||
"unresolved_surfaces": [
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/admit_wave_dispatch_classifier.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/dispatch_check.sh"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/dispatch-classifier/"
|
||||
}
|
||||
],
|
||||
"workflow_config_surfaces": []
|
||||
},
|
||||
"id": "contract:ADMIT-wave-dispatch-classifier",
|
||||
"identities": {
|
||||
"acceptance": [
|
||||
"bounded repair verified: Build the DISPATCH CLASSIFIER: create the self-contained stdlib-only Go module src/go/dispatch-classifier that decides s"
|
||||
],
|
||||
"affected_entities": [],
|
||||
"expected_consumers": [],
|
||||
"expected_new_entities": [
|
||||
"scripts/dispatch_check.sh (session-agent pre-spawn discipline wrapper: read brief, classify, print verdict, --apply locks)",
|
||||
"src/go/dispatch-classifier (classify: surface extraction \u2014 explicit paths, brief parsing, one data-driven keyword map; prefix overlap vs locked surfaces; QUEUE-BEHIND / PRIORITY-QUEUE / SOLO / PARALLEL verdicts with suggested split; --apply takes the lock atomically, fail-loud)",
|
||||
"src/go/dispatch-classifier (hot-state registry ~/.rune/hot/dispatch_registry.json: lock/unlock/show, atomic writes, 4h STALE flagging + --prune)",
|
||||
"src/go/dispatch-classifier (red-first tests per rule: overlap, owner-origin priority, split suggestion, lock/unlock lifecycle, stale handling, prefix-vs-exact; go test -race green, vet + gofmt clean)",
|
||||
"src/go/dispatch-classifier (stdlib-only Go module: go.mod, main.go, registry.go, classify.go, README.md)",
|
||||
"tests: red-first suites per rule, -race green"
|
||||
],
|
||||
"gap_evidence": "smallness markers: ['one-liner', 'patch']; scoping words bind to known target: ['the module']; file mention binds scoped target; affected surface known: ['src/go/dispatch-classifier/', 'scripts/admit_",
|
||||
"migration_obligations": [],
|
||||
"need": "Build the DISPATCH CLASSIFIER: create the self-contained stdlib-only Go module src/go/dispatch-classifier that decides solo-attention vs parallel-factory vs queue for each incoming wave so the owner never specifies \u2014 implement the hot-state registry ~/.rune/hot/dispatch_registry.json with lock/unlock/show subcommands (entries {agent_id, surfaces, kind, since, owner_origin}; entries older than 4h flagged STALE in show with a --prune flag), implement classify --brief <file> [--paths p1,p2] [--owner-origin] [--apply] that extracts candidate surface prefixes (explicit paths win, else brief-named repo-relative paths, else keyword\u2192surface heuristics kept in one data-driven map), computes prefix overlap against the registry's locked surfaces, and emits the JSON verdict {decision, reason, surfaces, locks_to_take, queue_behind} \u2014 QUEUE-BEHIND naming the agent and surface when any candidate surface is locked by an in-flight agent (PRIORITY-QUEUE on owner-origin, noting the lock-holder yields at its next landing boundary), SOLO when owner-origin (full-attention lane, latency wins), PARALLEL with a suggested split when the brief names multiple disjoint surfaces, else SOLO \u2014 with --apply taking the lock atomically and failing loud on stale/locked; add red-first tests per rule (overlap detection, owner-origin priority, multi-surface split suggestion, lock/unlock lifecycle, stale-lock handling, prefix-vs-exact matching) green under go test -race with vet and gofmt clean; add scripts/dispatch_check.sh, the one-liner wrapper the session agent runs before spawning anything (reads the brief, runs classify, prints the verdict, locks with --apply), and document usage in the module README in plain English",
|
||||
"next_action": "complete implementation, then verify",
|
||||
"non_goals": [],
|
||||
"origin": "worker",
|
||||
"regression_obligations": [],
|
||||
"requirement": "headless admission (classified: LOCAL_CHANGE)",
|
||||
"research_refs": [
|
||||
"scripts/admit_wave_presentation.py (this admission pattern)",
|
||||
"scripts/check_landing.py rule-5 scope matcher (_scope_covers prefix law \u2014 reused for registry surface overlap)",
|
||||
"scripts/dispatch_check.sh discipline wrapper (new)",
|
||||
"src/go/failure-filer (stdlib-only module pattern: go.mod, main.go, flat package, *_test.go)",
|
||||
"~/.rune/hot/ hot-state file convention (task_state.json in src/go/webfeed/internal/webfeed/server.go:390)"
|
||||
],
|
||||
"resolution": "",
|
||||
"rollback_ref": "git revert",
|
||||
"scope": [
|
||||
"scripts/admit_wave_dispatch_classifier.py",
|
||||
"scripts/dispatch_check.sh",
|
||||
"src/go/dispatch-classifier/"
|
||||
],
|
||||
"toolchain": {},
|
||||
"verification_obligations": [
|
||||
"CLI proofs: lock/unlock/show lifecycle, stale flagging + prune, classify verdicts for overlap/owner-origin/split cases, --apply lock take + fail-loud on stale/locked",
|
||||
"cd src/go/dispatch-classifier && go test ./... -race green; go vet ./... clean; gofmt -l . empty",
|
||||
"scripts/dispatch_check.sh round-trip on a real brief file"
|
||||
]
|
||||
},
|
||||
"kind": "construction_contract",
|
||||
"maturity": "DECLARED",
|
||||
"observed_at": "2026-10-22T14:36:19Z",
|
||||
"phase": "building",
|
||||
"status": "open",
|
||||
"tags": []
|
||||
}
|
||||
@@ -0,0 +1,154 @@
|
||||
{
|
||||
"checkpoints": [
|
||||
{
|
||||
"at": "2026-10-23T22:47:01Z",
|
||||
"evidence": "predicted-frontier",
|
||||
"note": "{\"level0_direct\": [], \"level1_obligations\": [], \"contracts\": [], \"level2_verification\": []}",
|
||||
"phase": "draft"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-23T22:47:19Z",
|
||||
"evidence": "user:streaming root-cause wave directive 2026-10-23 (Gitea #2556)",
|
||||
"note": "",
|
||||
"phase": "approved"
|
||||
},
|
||||
{
|
||||
"at": "2026-10-23T22:47:36Z",
|
||||
"evidence": "builder:wave-streaming-deadline-root",
|
||||
"note": "",
|
||||
"phase": "building"
|
||||
}
|
||||
],
|
||||
"evidence_refs": [
|
||||
"contract-created:ADMIT-wave-streaming-deadline-root"
|
||||
],
|
||||
"ext": {
|
||||
"activation": {
|
||||
"activated": true,
|
||||
"builder": "wave-streaming-deadline-root",
|
||||
"evidence": [
|
||||
"affected surface known: ['src/go/rune-core/internal/runecore/', 'src/go/rune-entry/']",
|
||||
"change scoped to an existing project/target",
|
||||
"target project: rune"
|
||||
],
|
||||
"lifecycle": "proportional",
|
||||
"mode": "EXISTING_PROJECT_CHANGE",
|
||||
"note": "attached to existing project authority; Need/completeness/patterns/contract flow governs proportionally",
|
||||
"project_authority": "rune_internal",
|
||||
"target_project": "rune"
|
||||
},
|
||||
"affected_paths": [
|
||||
"scripts/admit_wave_streaming_deadline_root.py",
|
||||
"src/go/rune-core/internal/runecore/",
|
||||
"src/go/rune-entry/",
|
||||
"tui/cmd/rune-tui/",
|
||||
"tui/runtime/lib/"
|
||||
],
|
||||
"affected_regions": [],
|
||||
"affected_ui_surfaces": [],
|
||||
"expected_runtime_effects": [
|
||||
"a local 27B thinking turn streams tokens continuously through core, entry proxy and TUI with no flat deadline; a genuinely dead model trips the idle timeout"
|
||||
],
|
||||
"predicted_frontier": {
|
||||
"change_kind": "implementation_change",
|
||||
"contextual_not_obligations": [],
|
||||
"contracts": [],
|
||||
"level0_direct": [],
|
||||
"level1_obligations": [],
|
||||
"level2_verification": [],
|
||||
"max_level": 2,
|
||||
"traversal_scope": "spine-structural-only"
|
||||
},
|
||||
"scope_provenance": {
|
||||
"caller_added": [],
|
||||
"generated_from_affected_surface": [
|
||||
"scripts/admit_wave_streaming_deadline_root.py",
|
||||
"src/go/rune-core/internal/runecore/",
|
||||
"src/go/rune-entry/",
|
||||
"tui/cmd/rune-tui/",
|
||||
"tui/runtime/lib/"
|
||||
]
|
||||
},
|
||||
"task_ref": "wave-streaming-deadline-root",
|
||||
"unresolved_surfaces": [
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "scripts/admit_wave_streaming_deadline_root.py"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/rune-core/internal/runecore/"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "src/go/rune-entry/"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/cmd/rune-tui/"
|
||||
},
|
||||
{
|
||||
"kind": "source_path",
|
||||
"reason": "no authority records this path as an entity (path remains file-scope only)",
|
||||
"surface": "tui/runtime/lib/"
|
||||
}
|
||||
],
|
||||
"workflow_config_surfaces": []
|
||||
},
|
||||
"id": "contract:ADMIT-wave-streaming-deadline-root",
|
||||
"identities": {
|
||||
"acceptance": [
|
||||
"bounded repair verified: land the streaming root-cause wave (Gitea #2556, owner verdict 2026-10-22): stream through the WHOLE turn chain so a loc"
|
||||
],
|
||||
"affected_entities": [],
|
||||
"expected_consumers": [],
|
||||
"expected_new_entities": [
|
||||
"the inter-chunk idle timeout + 30-minute backstop on streamed paths (budgets retire to fallback)",
|
||||
"the red-first streaming chain tests (ollama NDJSON, cloud SSE, core stream relay, entry pass-through, TUI render-as-it-arrives, idle-timeout simulation)",
|
||||
"the streaming root-cause wave report (reports/)"
|
||||
],
|
||||
"gap_evidence": "change scoped to an existing project/target; target project: rune; affected surface known: ['src/go/rune-core/internal/runecore/', 'src/go/rune-entry/']",
|
||||
"migration_obligations": [],
|
||||
"need": "land the streaming root-cause wave (Gitea #2556, owner verdict 2026-10-22): stream through the WHOLE turn chain so a local 27B thinking turn never sits inside one blocking HTTP call \u2014 (1) the Ollama wire runs stream=true /api/chat with NDJSON chunks parsed incrementally (content/thinking/tool_calls; the final message object carries the assembled reply) and the engine's bounded tool loop runs over streamed replies; (2) the cloud wires gain streaming parity ([OI]-compat SSE, Anthropic SSE events, Gemini streamGenerateContent); (3) the core /v1/chat/completions relays the streamed turn as NDJSON chunks for stream=true callers while non-streaming callers get the assembled answer as before; (4) the entry proxy passes the stream through and the TUI renders text as it arrives; (5) on streamed paths the whole-turn budgets retire \u2014 replaced by an inter-chunk idle timeout (default 120s, RUNE_STREAM_IDLE_TIMEOUT configurable) plus a 30-minute overall backstop; the budget constants remain only for non-streaming fallback paths",
|
||||
"next_action": "complete implementation, then verify",
|
||||
"non_goals": [],
|
||||
"origin": "worker",
|
||||
"regression_obligations": [],
|
||||
"requirement": "headless admission (classified: EXISTING_PROJECT_CHANGE)",
|
||||
"research_refs": [
|
||||
"scripts/admit_wave_terminal_budgets.py",
|
||||
"src/go/rune-core/internal/runecore/cloud.go",
|
||||
"src/go/rune-core/internal/runecore/ollama.go",
|
||||
"src/go/rune-core/internal/runecore/server.go",
|
||||
"src/go/rune-entry/internal/entry/serve.go",
|
||||
"tui/cmd/rune-tui/main.go",
|
||||
"tui/laneconc/laneconc.go",
|
||||
"tui/runtime/lib/complete.go"
|
||||
],
|
||||
"resolution": "",
|
||||
"rollback_ref": "git revert",
|
||||
"scope": [
|
||||
"scripts/admit_wave_streaming_deadline_root.py",
|
||||
"src/go/rune-core/internal/runecore/",
|
||||
"src/go/rune-entry/",
|
||||
"tui/cmd/rune-tui/",
|
||||
"tui/runtime/lib/"
|
||||
],
|
||||
"toolchain": {},
|
||||
"verification_obligations": [
|
||||
"-short race suites green on touched Go modules (the documented PTY family aside)",
|
||||
"full-chain simulation: a fake slow model emitting chunks across a long window completes the turn with no deadline fire; a silent model trips the idle timeout",
|
||||
"vet/gofmt clean"
|
||||
]
|
||||
},
|
||||
"kind": "construction_contract",
|
||||
"maturity": "DECLARED",
|
||||
"observed_at": "2026-10-23T22:47:36Z",
|
||||
"phase": "building",
|
||||
"status": "open",
|
||||
"tags": []
|
||||
}
|
||||
@@ -7428,3 +7428,9 @@
|
||||
{"builder": "main-session-landing", "detail": "ADMIT-wave-d46-live-defects \u2192 verifying", "kind": "builder_session", "mode": "rune_internal", "observed_at": "2026-10-20T23:47:41Z", "operation": "transition"}
|
||||
{"authority": "main-session own run", "detail": "46 packages race-green; dupe tripwire; budget pins; artifact links", "entity": "tests", "kind": "observed_consequence", "observed_at": "2026-10-20T23:47:59Z", "source": "go test", "task": "ADMIT-wave-d46-live-defects"}
|
||||
{"builder": "main-session-landing", "detail": "ADMIT-wave-d46-live-defects closed", "kind": "builder_session", "mode": "rune_internal", "observed_at": "2026-10-20T23:48:02Z", "operation": "close"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 approved", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T10:58:11Z", "operation": "transition"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 building", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T10:58:37Z", "operation": "transition"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 approved", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T11:26:37Z", "operation": "transition"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 building", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T11:27:06Z", "operation": "transition"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 approved", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T11:43:26Z", "operation": "transition"}
|
||||
{"builder": "release-reporting", "detail": "ADMIT-release-reporting \u2192 building", "kind": "builder_session", "mode": "external_project", "observed_at": "2026-10-24T11:43:52Z", "operation": "transition"}
|
||||
@@ -15,6 +15,15 @@ from typing import Sequence, cast
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT / "src"))
|
||||
|
||||
# Wave B (#2575): these fixtures script the Python tool executor — pin the
|
||||
# RUNE_TOOL_EXECUTOR_ENGINE=python escape hatch so the Go delegation
|
||||
# (pinned separately in tests/test_tool_executor_delegation.py) does not
|
||||
# bypass the scripted executor.
|
||||
@pytest.fixture(autouse=True)
|
||||
def _python_tool_executor_engine(monkeypatch):
|
||||
monkeypatch.setenv("RUNE_TOOL_EXECUTOR_ENGINE", "python")
|
||||
|
||||
|
||||
from rune.local_tool_runtime import ( # noqa: E402
|
||||
ChatMessage,
|
||||
LocalToolRuntime,
|
||||
|
||||
@@ -38,6 +38,14 @@ import pytest
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT / "src"))
|
||||
|
||||
# Wave B (#2575): scripted-executor fixtures pin the Python escape hatch
|
||||
# (RUNE_TOOL_EXECUTOR_ENGINE=python); Go delegation is pinned in
|
||||
# tests/test_tool_executor_delegation.py.
|
||||
@pytest.fixture(autouse=True)
|
||||
def _python_tool_executor_engine(monkeypatch):
|
||||
monkeypatch.setenv("RUNE_TOOL_EXECUTOR_ENGINE", "python")
|
||||
|
||||
|
||||
from rune.local_tool_runtime import ChatMessage, LocalToolRuntime # noqa: E402
|
||||
from rune import tool_executor # noqa: E402
|
||||
from rune.tool_protocol import ToolEvent, ToolRequest # noqa: E402
|
||||
|
||||
@@ -13,10 +13,20 @@ import unittest
|
||||
from pathlib import Path
|
||||
from typing import Sequence, cast
|
||||
|
||||
import pytest
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT / "src"))
|
||||
|
||||
# Wave B (#2575): scripted-executor fixtures pin the Python escape hatch
|
||||
# (RUNE_TOOL_EXECUTOR_ENGINE=python); Go delegation is pinned in
|
||||
# tests/test_tool_executor_delegation.py.
|
||||
@pytest.fixture(autouse=True)
|
||||
def _python_tool_executor_engine(monkeypatch):
|
||||
monkeypatch.setenv("RUNE_TOOL_EXECUTOR_ENGINE", "python")
|
||||
|
||||
|
||||
from rune.local_tool_runtime import ( # noqa: E402
|
||||
ChatMessage,
|
||||
LocalToolRuntime,
|
||||
|
||||
@@ -0,0 +1,98 @@
|
||||
"""Red-first parity battery: the Go reconcile engine vs the Python oracle.
|
||||
|
||||
The capability-floor drift reconciliation (reconcile_tools_support) is
|
||||
the last seam that kept local_tool_runtime.py on its Python import
|
||||
(model-routing-integrated.json blocks_full_switchover, wave 181). The
|
||||
Python body stays as the oracle/escape hatch
|
||||
(RUNE_MODEL_ROUTING_ENGINE=python); this battery pins the Go delegation
|
||||
facade to it decision-for-decision over the recorded oracle corpus
|
||||
(contradiction → unverified drift, agreement → clean, non-floor →
|
||||
passthrough), checks the fail-loud refusal when the engine binary is
|
||||
missing, and receipts the local_tool_runtime consumer wiring.
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
_ROOT = Path(__file__).resolve().parents[1]
|
||||
|
||||
CORPUS = [
|
||||
("qwen2.5:3b", True), # floor T1 contradiction (floor=False)
|
||||
("mimo-v2.5-pro", False), # floor T4 contradiction (floor=True)
|
||||
("qwen2.5:3b", False), # floor T1 agreement
|
||||
("mimo-v2.5-pro", True), # floor T4 agreement
|
||||
("qwen3:8b", True), # non-floor passthrough
|
||||
("qwen3:8b", False), # non-floor passthrough
|
||||
]
|
||||
|
||||
|
||||
def _jbytes(value):
|
||||
return json.dumps(value, sort_keys=True, ensure_ascii=True)
|
||||
|
||||
|
||||
def _run(engine):
|
||||
from rune import model_routing as mr
|
||||
|
||||
old = os.environ.get("RUNE_MODEL_ROUTING_ENGINE")
|
||||
os.environ["RUNE_MODEL_ROUTING_ENGINE"] = engine
|
||||
try:
|
||||
return [mr.reconcile_tools_support(m, r) for m, r in CORPUS]
|
||||
finally:
|
||||
if old is None:
|
||||
os.environ.pop("RUNE_MODEL_ROUTING_ENGINE", None)
|
||||
else:
|
||||
os.environ["RUNE_MODEL_ROUTING_ENGINE"] = old
|
||||
|
||||
|
||||
def test_go_delegation_matches_python_oracle_byte_for_byte():
|
||||
oracle = _run("python")
|
||||
go = _run("go")
|
||||
assert _jbytes(go) == _jbytes(oracle)
|
||||
# spot-check the drift arm against the recorded oracle text
|
||||
assert go[0][0] is True
|
||||
assert go[0][1] is not None
|
||||
assert "contradicting CAPABILITY_FLOOR supports_tools=False" in go[0][1]
|
||||
assert "unverified: provider reports supports_tools=True" in go[0][1]
|
||||
assert go[1][0] is False and "supports_tools=False" in go[1][1]
|
||||
assert go[2] == (False, None) and go[3] == (True, None)
|
||||
assert go[4] == (True, None) and go[5] == (False, None)
|
||||
|
||||
|
||||
def test_default_is_go_engine():
|
||||
# default (unset env) resolves through the Go binary, not the oracle body
|
||||
env = os.environ.pop("RUNE_MODEL_ROUTING_ENGINE", None)
|
||||
try:
|
||||
default = _run(os.environ.get("RUNE_MODEL_ROUTING_ENGINE", "go"))
|
||||
finally:
|
||||
if env is not None:
|
||||
os.environ["RUNE_MODEL_ROUTING_ENGINE"] = env
|
||||
assert _jbytes(default) == _jbytes(_run("python"))
|
||||
|
||||
|
||||
def test_fail_loud_when_engine_binary_missing(tmp_path, monkeypatch):
|
||||
from rune import model_routing as mr
|
||||
|
||||
monkeypatch.setattr(mr, "_go_engine_bin", lambda: str(tmp_path / "nope"))
|
||||
monkeypatch.setenv("RUNE_MODEL_ROUTING_ENGINE", "go")
|
||||
with pytest.raises(RuntimeError, match="go engine binary missing"):
|
||||
mr.reconcile_tools_support("qwen2.5:3b", True)
|
||||
|
||||
|
||||
def test_local_tool_runtime_consumer_receipts_drift():
|
||||
# the consumer seam: LocalToolRuntime reconciles through the facade and
|
||||
# surfaces the drift marker on capability_drift
|
||||
from rune.local_tool_runtime import LocalToolRuntime
|
||||
from rune.model_routing import _reconcile_tools_support_python
|
||||
|
||||
eff, drift = _reconcile_tools_support_python("qwen2.5:3b", True)
|
||||
assert drift is not None
|
||||
# parity: the facade's default path produces the same marker
|
||||
os.environ.pop("RUNE_MODEL_ROUTING_ENGINE", None)
|
||||
from rune import model_routing as mr
|
||||
|
||||
g_eff, g_drift = mr.reconcile_tools_support("qwen2.5:3b", True)
|
||||
assert (g_eff, g_drift) == (eff, drift)
|
||||
assert LocalToolRuntime is not None # import seam still wired
|
||||
+80
-215
@@ -1,238 +1,103 @@
|
||||
"""Frozen battery for scripts/tag_repair.py — the release pipeline deep-dive
|
||||
fix (wave-release-pipeline-deepdive, owner queue item 5).
|
||||
"""Red-first tests for the namespace-aware release-tag resolution (#2582).
|
||||
|
||||
Pins, red-first against the pre-fix pipeline logic:
|
||||
|
||||
1. SIGPIPE safety: `git tag --sort=-v:refname | head -1` under
|
||||
`set -o pipefail` exits 141 (SIGPIPE) on a many-tag repo — the exact
|
||||
defect that killed the auto-version bump step on its first line in CI
|
||||
(runs 29929/30435/30636: "Process completed with exit code 141", zero
|
||||
step output — BEFORE the 0.312.0/0.313.0/0.314.0 master-tip fallback
|
||||
could ever run). latest_release_tag() must read the same tag with NO
|
||||
downstream pipe (git for-each-ref --count=1) and exit 0.
|
||||
|
||||
2. ensure_tag idempotency: when the tui-v<version> tag already exists on
|
||||
the remote, ensure is a noop — never re-tags, never pushes.
|
||||
|
||||
3. Bump-sha-unusable fallback: when the bump commit sha is unusable
|
||||
(missing object / "?" / empty), the tag target falls back to the
|
||||
fetched master tip — the repair the 0.312.x-era fallback step
|
||||
implemented but could never reach.
|
||||
|
||||
4. Deadlock self-heal: the version>tag state (bump landed, tag missed)
|
||||
must plan a repair (create+push the missing tui tag at the fetched
|
||||
tip) — NOT the skip-forever that the pre-fix convergence path
|
||||
produced (which required the manual "re-arm convergence" commit
|
||||
360665b1, 2026-10-19).
|
||||
The version-push reader bug: latest_release_tag() sorted ALL tags, so the
|
||||
TUI build namespace (tui-v*) could capture the main-line v* range lookup —
|
||||
the release-note step then started its range at the TUI tag (cut hours or
|
||||
minutes before) and every wave of work vanished from the release body
|
||||
("No substantive changes" on a 21-commit day, observed on v0.346.0).
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import subprocess
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
REPO = Path(__file__).resolve().parent.parent
|
||||
sys.path.insert(0, str(REPO / "scripts"))
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT / "scripts"))
|
||||
|
||||
import tag_repair # noqa: E402
|
||||
from tag_repair import latest_release_tag # noqa: E402
|
||||
|
||||
|
||||
def _git(repo: Path, *args: str) -> str:
|
||||
proc = subprocess.run(
|
||||
["git", *args], cwd=str(repo), check=True, capture_output=True, text=True
|
||||
)
|
||||
return proc.stdout.strip()
|
||||
|
||||
|
||||
def _commit(repo: Path, msg: str) -> str:
|
||||
(repo / "f.txt").write_text(msg + "\n")
|
||||
_git(repo, "add", ".")
|
||||
_git(repo, "commit", "-qm", msg)
|
||||
return _git(repo, "rev-parse", "HEAD")
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def tag_farm(tmp_path: Path) -> Path:
|
||||
"""A git repo with a base commit and 700 release tags — the CI tag
|
||||
population that triggers the SIGPIPE (any real rune checkout has
|
||||
hundreds of v* tags)."""
|
||||
repo = tmp_path / "farm"
|
||||
def _repo_with_tags(tmp_path, tags):
|
||||
repo = tmp_path / "repo"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
(repo / "f.txt").write_text("x\n")
|
||||
_git(repo, "add", ".")
|
||||
_git(repo, "commit", "-qm", "base")
|
||||
base = _git(repo, "rev-parse", "HEAD")
|
||||
for i in range(700):
|
||||
_git(repo, "tag", f"v0.{i}.0", base)
|
||||
def git(*args):
|
||||
subprocess.run(["git", "-C", str(repo), *args], check=True,
|
||||
capture_output=True)
|
||||
git("init", "-q", "-b", "master")
|
||||
(repo / "seed").write_text("x")
|
||||
git("add", ".")
|
||||
git("-c", "user.email=t@t", "-c", "user.name=t", "commit", "-qm", "seed")
|
||||
for tag in tags:
|
||||
subprocess.run(["git", "-C", str(repo), "tag", "-a", tag, "-m", tag],
|
||||
check=True, capture_output=True,
|
||||
env={"GIT_AUTHOR_NAME": "t", "GIT_AUTHOR_EMAIL": "t@t",
|
||||
"GIT_COMMITTER_NAME": "t", "GIT_COMMITTER_EMAIL": "t@t",
|
||||
"PATH": "/usr/bin:/bin"})
|
||||
return repo
|
||||
|
||||
|
||||
class TestSigpipeSafety:
|
||||
def test_naive_pipe_actually_fails_141(self, tag_farm: Path):
|
||||
"""Pin the disease: the pre-fix pipeline read exits 141 under the
|
||||
runner's `bash -e -o pipefail`. If this stops reproducing (git
|
||||
change), the battery loses its red anchor and must be revisited."""
|
||||
proc = subprocess.run(
|
||||
["bash", "-c", "set -o pipefail; git tag --sort=-v:refname | head -1"],
|
||||
cwd=str(tag_farm), capture_output=True, text=True,
|
||||
)
|
||||
assert proc.returncode == 141, (
|
||||
f"expected the naive pipe to die with SIGPIPE 141, got {proc.returncode}"
|
||||
)
|
||||
assert proc.stdout.strip() == "v0.699.0"
|
||||
|
||||
def test_latest_release_tag_is_sigpipe_free(self, tag_farm: Path):
|
||||
assert tag_repair.latest_release_tag(tag_farm) == "v0.699.0"
|
||||
|
||||
def test_latest_release_tag_via_cli_is_sigpipe_free(self, tag_farm: Path):
|
||||
proc = subprocess.run(
|
||||
[sys.executable, str(REPO / "scripts" / "tag_repair.py"), "--latest-tag"],
|
||||
cwd=str(tag_farm), capture_output=True, text=True,
|
||||
)
|
||||
assert proc.returncode == 0, proc.stderr
|
||||
assert proc.stdout.strip() == "v0.699.0"
|
||||
|
||||
def test_latest_release_tag_no_downstream_pipe(self, tag_farm: Path):
|
||||
"""The implementation must not spawn a pipeline: every produced
|
||||
process tree for the read must be a single git process."""
|
||||
probe = tag_farm / "probe.sh"
|
||||
probe.write_text(
|
||||
"#!/bin/sh\n"
|
||||
f'exec python3 "{REPO / "scripts" / "tag_repair.py"}" --latest-tag\n'
|
||||
)
|
||||
probe.chmod(0o755)
|
||||
out = subprocess.run(
|
||||
["bash", "-c", f"set -o pipefail; {probe} | cat"],
|
||||
cwd=str(tag_farm), capture_output=True, text=True,
|
||||
)
|
||||
assert out.returncode == 0
|
||||
assert out.stdout.strip() == "v0.699.0"
|
||||
|
||||
def test_latest_release_tag_empty_repo(self, tmp_path: Path):
|
||||
repo = tmp_path / "empty"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
assert tag_repair.latest_release_tag(repo) is None
|
||||
def test_latest_tag_default_is_main_namespace(tmp_path):
|
||||
"""The default lookup ignores the TUI build namespace entirely."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.10.0", "v0.10.0"])
|
||||
assert latest_release_tag(repo) == "v0.10.0"
|
||||
|
||||
|
||||
class TestEnsureTag:
|
||||
|
||||
def test_ensure_tags_fetched_tip_when_bump_sha_unusable(self, tmp_path: Path):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
tip = _commit(repo, "chore(release): auto-bump version to 0.315.0")
|
||||
plan = tag_repair.plan_ensure_tag(
|
||||
version="0.315.0", bump_sha="?", repo=repo
|
||||
)
|
||||
assert plan["action"] == "tag"
|
||||
assert plan["target"] == tip
|
||||
|
||||
tag_repair.ensure_tag(version="0.315.0", bump_sha="?", repo=repo, push=False)
|
||||
assert _git(repo, "rev-parse", "refs/tags/tui-v0.315.0^{}") == tip
|
||||
|
||||
def test_ensure_prefers_valid_bump_sha(self, tmp_path: Path):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
_commit(repo, "a")
|
||||
bump = _commit(repo, "chore(release): auto-bump version to 1.0.0")
|
||||
head_before = _git(repo, "rev-parse", "HEAD")
|
||||
plan = tag_repair.plan_ensure_tag(version="1.0.0", bump_sha=bump, repo=repo)
|
||||
assert plan["action"] == "tag"
|
||||
assert plan["target"] == bump
|
||||
tag_repair.ensure_tag(version="1.0.0", bump_sha=bump, repo=repo, push=False)
|
||||
assert _git(repo, "rev-parse", "refs/tags/tui-v1.0.0^{}") == bump
|
||||
assert _git(repo, "rev-parse", "HEAD") == head_before # nothing moved
|
||||
|
||||
def test_ensure_idempotent_when_tag_exists(self, tmp_path: Path):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
tip = _commit(repo, "c1")
|
||||
tag_repair.ensure_tag(version="0.2.0", bump_sha="", repo=repo, push=False)
|
||||
later = _commit(repo, "c2")
|
||||
plan = tag_repair.plan_ensure_tag(version="0.2.0", bump_sha="", repo=repo)
|
||||
assert plan["action"] == "noop"
|
||||
tag_repair.ensure_tag(version="0.2.0", bump_sha="", repo=repo, push=False)
|
||||
assert _git(repo, "rev-parse", "refs/tags/tui-v0.2.0^{}") == tip
|
||||
assert _git(repo, "rev-parse", "HEAD") == later
|
||||
def test_latest_tag_ignores_tui_only_state(tmp_path):
|
||||
"""A repo whose newest tag is a TUI tag still yields the main v* tag."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.50.0"])
|
||||
assert latest_release_tag(repo) == "v0.9.0"
|
||||
|
||||
|
||||
class TestDeadlockSelfHeal:
|
||||
def test_version_ahead_of_tag_plans_repair_not_skip(self, tmp_path: Path):
|
||||
"""The deadlock state: master's version is ahead of the latest tag
|
||||
and the tui tag for the master version is missing. The plan must
|
||||
be a repair (tag the fetched tip), never a skip."""
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
_commit(repo, "c1")
|
||||
_git(repo, "tag", "tui-v0.310.0")
|
||||
_commit(repo, "chore(release): auto-bump version to 0.314.0")
|
||||
plan = tag_repair.self_heal_plan(
|
||||
version="0.314.0", latest_release_tag="v0.310.0", repo=repo
|
||||
)
|
||||
assert plan["action"] == "repair"
|
||||
assert plan["tag"] == "tui-v0.314.0"
|
||||
assert plan["skip"] is False
|
||||
|
||||
def test_converged_state_plans_noop(self, tmp_path: Path):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
_commit(repo, "c1")
|
||||
_git(repo, "tag", "tui-v0.314.0")
|
||||
plan = tag_repair.self_heal_plan(
|
||||
version="0.314.0", latest_release_tag="v0.314.0", repo=repo
|
||||
)
|
||||
assert plan["action"] == "noop"
|
||||
|
||||
def test_version_not_ahead_plans_noop(self, tmp_path: Path):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
_commit(repo, "c1")
|
||||
_git(repo, "tag", "tui-v0.320.0")
|
||||
plan = tag_repair.self_heal_plan(
|
||||
version="0.314.0", latest_release_tag="v0.320.0", repo=repo
|
||||
)
|
||||
assert plan["action"] == "noop"
|
||||
def test_latest_tag_namespaces_are_selectable(tmp_path):
|
||||
"""The TUI workflow can ask for its own namespace explicitly."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.50.0"])
|
||||
assert latest_release_tag(repo, namespace="tui") == "tui-v0.50.0"
|
||||
|
||||
|
||||
class TestCli:
|
||||
def test_cli_plan_json(self, tmp_path: Path, capsys):
|
||||
repo = tmp_path / "r"
|
||||
repo.mkdir()
|
||||
_git(repo, "init", "-q", "-b", "master")
|
||||
_git(repo, "config", "user.email", "t@example.invalid")
|
||||
_git(repo, "config", "user.name", "t")
|
||||
_commit(repo, "c1")
|
||||
proc = subprocess.run(
|
||||
[sys.executable, str(REPO / "scripts" / "tag_repair.py"),
|
||||
"--plan", "--version", "0.315.0", "--bump-sha", ""],
|
||||
cwd=str(repo), capture_output=True, text=True,
|
||||
)
|
||||
assert proc.returncode == 0, proc.stderr
|
||||
plan = json.loads(proc.stdout)
|
||||
assert plan["action"] == "tag"
|
||||
assert plan["tag"] == "tui-v0.315.0"
|
||||
def test_latest_tag_empty_repo_is_none(tmp_path):
|
||||
repo = tmp_path / "empty"
|
||||
repo.mkdir()
|
||||
subprocess.run(["git", "-C", str(repo), "init", "-q", "-b", "master"], check=True)
|
||||
assert latest_release_tag(repo) is None
|
||||
|
||||
|
||||
# --- CLI level: the workflow invokes `tag_repair.py --latest-tag --namespace
|
||||
# main` through argparse. Run 33866 (2026-10-24) died here — the namespace
|
||||
# existed only as a function parameter, argparse rejected `--namespace main`
|
||||
# and the whole release step aborted. These tests run the CLI subprocess with
|
||||
# the exact argv the workflow uses; they stay frozen as regression teeth.
|
||||
|
||||
|
||||
def _run_cli(args, repo):
|
||||
return subprocess.run(
|
||||
[sys.executable, str(ROOT / "scripts" / "tag_repair.py"), *args,
|
||||
"--repo", str(repo)],
|
||||
capture_output=True,
|
||||
text=True,
|
||||
)
|
||||
|
||||
|
||||
def test_cli_latest_tag_workflows_argv_main(tmp_path):
|
||||
"""Exact workflow argv resolves the MAIN-line tag through argparse."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.50.0"])
|
||||
proc = _run_cli(["--latest-tag", "--namespace", "main"], repo)
|
||||
assert proc.returncode == 0, proc.stderr
|
||||
assert proc.stdout.strip() == "v0.9.0"
|
||||
|
||||
|
||||
def test_cli_latest_tag_namespace_tui(tmp_path):
|
||||
"""--namespace tui reaches the TUI build line through argparse."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.50.0"])
|
||||
proc = _run_cli(["--latest-tag", "--namespace", "tui"], repo)
|
||||
assert proc.returncode == 0, proc.stderr
|
||||
assert proc.stdout.strip() == "tui-v0.50.0"
|
||||
|
||||
|
||||
def test_cli_latest_tag_without_flag_is_main(tmp_path):
|
||||
"""No --namespace still means main — pre-existing callers keep behavior."""
|
||||
repo = _repo_with_tags(tmp_path, ["v0.9.0", "tui-v0.50.0"])
|
||||
proc = _run_cli(["--latest-tag"], repo)
|
||||
assert proc.returncode == 0, proc.stderr
|
||||
assert proc.stdout.strip() == "v0.9.0"
|
||||
@@ -0,0 +1,141 @@
|
||||
"""Red-first parity battery, wave B (Gitea #2575): the Go tool-executor
|
||||
engine vs the Python oracle through the LocalToolRuntime delegation facade.
|
||||
|
||||
The four read-only file operations (read_file, list_directory, glob_files,
|
||||
grep_files) resolve through src/go/tool-executor by default; the Python
|
||||
bodies in tool_executor.py stay as the oracle/escape hatch
|
||||
(RUNE_TOOL_EXECUTOR_ENGINE=python). This battery pins the facade to the
|
||||
oracle envelope-for-envelope over fixture calls, checks the fail-loud
|
||||
refusal when the engine binary is missing, and receipts that run_command
|
||||
NEVER delegates (mutating — the approval door owns it).
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
_ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(_ROOT / "src"))
|
||||
|
||||
from rune.local_tool_runtime import ( # noqa: E402
|
||||
_GO_EXECUTOR_OPS,
|
||||
_GoDelegatingExecutor,
|
||||
_go_execute_tool,
|
||||
_lte_go_engine_bin,
|
||||
_lte_go_engine_enabled,
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture()
|
||||
def sandbox(tmp_path, monkeypatch):
|
||||
(tmp_path / "docs").mkdir()
|
||||
(tmp_path / "docs" / "a.txt").write_text("alpha line\nbeta line\ngamma line\n")
|
||||
(tmp_path / "docs" / "b.py").write_text("def one():\n return 1\n")
|
||||
monkeypatch.chdir(tmp_path)
|
||||
return tmp_path
|
||||
|
||||
|
||||
def _oracle(tool_name, arguments):
|
||||
from rune.tool_executor import execute_tool
|
||||
|
||||
old = os.environ.get("RUNE_TOOL_EXECUTOR_ENGINE")
|
||||
os.environ["RUNE_TOOL_EXECUTOR_ENGINE"] = "python"
|
||||
inner = _GoDelegatingExecutor(execute_tool)
|
||||
try:
|
||||
return inner(tool_name, arguments)
|
||||
finally:
|
||||
if old is None:
|
||||
os.environ.pop("RUNE_TOOL_EXECUTOR_ENGINE", None)
|
||||
else:
|
||||
os.environ["RUNE_TOOL_EXECUTOR_ENGINE"] = old
|
||||
|
||||
|
||||
def _facade(tool_name, arguments):
|
||||
return _GoDelegatingExecutor(lambda n, a: (_ for _ in ()).throw(
|
||||
AssertionError("inner executor must not be reached for read-only ops"))
|
||||
)(tool_name, arguments)
|
||||
|
||||
|
||||
CASES = [
|
||||
("read_file", {"path": "docs/a.txt"}),
|
||||
("read_file", {"path": "docs/a.txt", "offset": 2, "limit": 1}),
|
||||
("list_directory", {"path": "docs"}),
|
||||
("list_directory", {"path": "docs", "pattern": "*.txt"}),
|
||||
("glob_files", {"pattern": "docs/*.py"}),
|
||||
("glob_files", {"pattern": "docs/*"}),
|
||||
("grep_files", {"pattern": "line", "path": "docs"}),
|
||||
("grep_files", {"pattern": "line", "path": "docs", "include": "*.txt"}),
|
||||
("read_file", {"path": "docs/missing.txt"}),
|
||||
("list_directory", {"path": "docs/missing-dir"}),
|
||||
("grep_files", {"pattern": "zzz-no-match", "path": "docs"}),
|
||||
]
|
||||
|
||||
@pytest.mark.parametrize("tool_name,arguments", CASES)
|
||||
def test_go_delegation_matches_python_oracle_envelope(sandbox, tool_name, arguments):
|
||||
assert _jbytes(_facade(tool_name, dict(arguments))) == _jbytes(
|
||||
_oracle(tool_name, dict(arguments))
|
||||
)
|
||||
|
||||
def _jbytes(value):
|
||||
return json.dumps(value, sort_keys=True, ensure_ascii=True)
|
||||
|
||||
def test_default_engine_is_go():
|
||||
os.environ.pop("RUNE_TOOL_EXECUTOR_ENGINE", None)
|
||||
assert _lte_go_engine_enabled() is True
|
||||
|
||||
def test_python_escape_hatch_reaches_inner_executor(sandbox):
|
||||
from rune.tool_executor import execute_tool
|
||||
|
||||
os.environ["RUNE_TOOL_EXECUTOR_ENGINE"] = "python"
|
||||
try:
|
||||
seen = []
|
||||
def inner(name, args):
|
||||
seen.append(name)
|
||||
return {"success": True, "result": "oracle"}
|
||||
out = _GoDelegatingExecutor(inner)("read_file", {"path": "docs/a.txt"})
|
||||
finally:
|
||||
os.environ.pop("RUNE_TOOL_EXECUTOR_ENGINE", None)
|
||||
assert seen == ["read_file"]
|
||||
assert out == {"success": True, "result": "oracle"}
|
||||
|
||||
def test_fail_loud_when_engine_binary_missing(tmp_path, monkeypatch):
|
||||
monkeypatch.setattr(
|
||||
"rune.local_tool_runtime._lte_go_engine_bin",
|
||||
lambda: str(tmp_path / "nope"),
|
||||
)
|
||||
with pytest.raises(RuntimeError, match="go engine binary missing"):
|
||||
_go_execute_tool("read_file", {"path": "whatever"})
|
||||
|
||||
def test_run_command_never_delegates_even_in_go_mode():
|
||||
# run_command is mutating — the approval door owns every dispatch.
|
||||
assert "run_command" not in _GO_EXECUTOR_OPS
|
||||
seen = []
|
||||
def inner(name, args):
|
||||
seen.append(name)
|
||||
return {"success": True, "result": "authority path"}
|
||||
os.environ.pop("RUNE_TOOL_EXECUTOR_ENGINE", None)
|
||||
out = _GoDelegatingExecutor(inner)("run_command", {"command": "echo hi"})
|
||||
assert seen == ["run_command"]
|
||||
assert out == {"success": True, "result": "authority path"}
|
||||
|
||||
def test_runtime_wraps_executor_and_keeps_attribute_seam():
|
||||
from rune.local_tool_runtime import LocalToolRuntime
|
||||
|
||||
class Transport:
|
||||
def supports_tools(self, model):
|
||||
return False
|
||||
def supports_thinking(self, model):
|
||||
return False
|
||||
|
||||
def executor(name, args):
|
||||
return {"success": True, "result": "inner"}
|
||||
|
||||
runtime = LocalToolRuntime(
|
||||
transport=Transport(), executor=executor, model="qwen3:8b"
|
||||
)
|
||||
assert isinstance(runtime.executor, _GoDelegatingExecutor)
|
||||
assert getattr(runtime.executor, "_uses_tool_authority", "sentinel") == "sentinel"
|
||||
assert _lte_go_engine_bin().endswith(os.path.join("src", "go", "tool-executor", "tool-executor"))
|
||||
+182
-49
@@ -4,22 +4,32 @@
|
||||
// answer (TUI-side, after the turn — zero model-side cost, B1) and
|
||||
// each block type takes its presentation (B2):
|
||||
//
|
||||
// 1. Speech (prose) — a bubble that GROWS with content; consecutive
|
||||
// prose joins ONE bubble; left-aligned; the outline carries the
|
||||
// SPEAKER'S colour (owner ruling #5).
|
||||
// 2. Table — BREAKS OUT of the bubble: a full-pane-width bordered
|
||||
// table, header emphasised, border in the speaker's colour.
|
||||
// 3. Bullet lists / numbered steps — own presentation OUTSIDE the
|
||||
// bubble: a left rail in the speaker's colour, hanging indent,
|
||||
// steps numbered, genuine bullets dotted. NEVER per-sentence
|
||||
// bullets (the D47 defect).
|
||||
// 4. Code fences — route to the tasks pane work stream (D47/D44
|
||||
// law, already contracted; the chat keeps the D36 collapsed
|
||||
// summary via the rich-bubble path).
|
||||
// 5. Headings — full-width, speaker-coloured underline, no bubble.
|
||||
// 1. Speech (prose) — a bubble that GROWS with content; consecutive
|
||||
// prose joins ONE bubble; left-aligned; the outline carries the
|
||||
// SPEAKER'S colour (owner ruling #5).
|
||||
// 2. Table — BREAKS OUT of the bubble: a full-pane-width bordered
|
||||
// table, header emphasised, border in the speaker's colour.
|
||||
// 3. Bullet lists / numbered steps — own presentation OUTSIDE the
|
||||
// bubble: a left rail in the speaker's colour, hanging indent,
|
||||
// steps numbered, genuine bullets dotted. NEVER per-sentence
|
||||
// bullets (the D47 defect).
|
||||
// 4. Code fences — route to the tasks pane work stream (D47/D44
|
||||
// law, already contracted; the chat keeps the D36 collapsed
|
||||
// summary via the rich-bubble path).
|
||||
// 5. Headings — full-width, speaker-coloured underline, no bubble.
|
||||
//
|
||||
// B4: a long answer never breaks the bubble — the growing-bubble
|
||||
// model replaces the fixed-shape card; answers stay left-aligned.
|
||||
//
|
||||
// THE NEVER-ANIMATE LAW (D54 #2571 item 1): the chat pane holds the
|
||||
// reading content, so it NEVER animates — no looping motion, no
|
||||
// blinking, no reflow-on-append. Stream append is APPEND-ONLY: a new
|
||||
// message adds lines at the tail and must not change a single
|
||||
// already-rendered line of the completed blocks above it (asserted by
|
||||
// TestAppendNeverReflowsCompletedBlocks; the stay-put scroll law in
|
||||
// scroll.go rides the same contract). The activity strip is the
|
||||
// face's one animating region, gated behind motionAllowed
|
||||
// (tui/lanes/activity.go).
|
||||
package chatpane
|
||||
|
||||
import (
|
||||
@@ -27,8 +37,58 @@ import (
|
||||
"strings"
|
||||
|
||||
"charm.land/lipgloss/v2"
|
||||
|
||||
"rune.dev/rune/tui/themes"
|
||||
)
|
||||
|
||||
// THE SPACING LAW (D54 #2571 item 3): exactly ONE blank line between
|
||||
// blocks — the layout constant blockGapBlankLines, pure layout (no
|
||||
// theme dependency). Block TYPES never merge: the parser keeps a
|
||||
// list a list and a paragraph a paragraph (mdBlocks), and the
|
||||
// renderer never abuts two block regions — a blank line always sits
|
||||
// between them (COGA 4.4.10 white spacing; one idea, one block, one
|
||||
// gap).
|
||||
const blockGapBlankLines = 1
|
||||
|
||||
// THE SUMMARY-FIRST LAW (D54 #2571 item 4): an answer whose block
|
||||
// count exceeds summaryBlockThreshold opens with a ONE-LINE
|
||||
// plain-english summary box — what the answer contains, counted
|
||||
// literally — before any block (COGA 4.4.8; the generalization of
|
||||
// the "code (n lines)" collapse hint). Literal wording only: no
|
||||
// idiom, no figure of speech.
|
||||
const summaryBlockThreshold = 8
|
||||
|
||||
// summaryLine composes the one-line plain-english summary for a
|
||||
// block stream ("Summary: 12 blocks — 9 paragraphs, 2 lists, 1
|
||||
// table.").
|
||||
func summaryLine(blocks []mdBlock) string {
|
||||
counts := map[string]int{}
|
||||
var order []string
|
||||
for _, b := range blocks {
|
||||
name := b.kind
|
||||
if name == "list" {
|
||||
if b.ordered {
|
||||
name = "steps"
|
||||
} else {
|
||||
name = "lists"
|
||||
}
|
||||
} else if name == "para" {
|
||||
name = "paragraphs"
|
||||
} else {
|
||||
name = name + "s"
|
||||
}
|
||||
if counts[name] == 0 {
|
||||
order = append(order, name)
|
||||
}
|
||||
counts[name]++
|
||||
}
|
||||
parts := make([]string, 0, len(order))
|
||||
for _, name := range order {
|
||||
parts = append(parts, fmt.Sprintf("%d %s", counts[name], name))
|
||||
}
|
||||
return fmt.Sprintf("Summary: %d blocks — %s. The blocks follow.", len(blocks), strings.Join(parts, ", "))
|
||||
}
|
||||
|
||||
// mdBlock is one parsed presentation block of an answer's prose.
|
||||
type mdBlock struct {
|
||||
kind string // "para" | "list" | "table" | "heading"
|
||||
@@ -196,6 +256,17 @@ func listMarkerNumber(line string) int {
|
||||
// law's one-stamp-per-message shape).
|
||||
func (p *Pane) answerPresentation(m Message, styled bool, ts string, w int, right bool) []string {
|
||||
var out []string
|
||||
segs := mdBlocks(m.Content)
|
||||
// SUMMARY-FIRST (#2571 item 4): long answers open with the one-
|
||||
// line plain-english summary box, before any block.
|
||||
if len(segs) > summaryBlockThreshold {
|
||||
sum := summaryLine(segs)
|
||||
if styled {
|
||||
sum = dimStyle.Render(sum)
|
||||
}
|
||||
out = append(out, boxAround([]string{sum}, w, styled, narrationBorderStyle)...)
|
||||
out = append(out, make([]string, blockGapBlankLines)...)
|
||||
}
|
||||
var run []mdBlock
|
||||
flush := func() {
|
||||
if len(run) == 0 {
|
||||
@@ -217,23 +288,24 @@ func (p *Pane) answerPresentation(m Message, styled bool, ts string, w int, righ
|
||||
}
|
||||
out = append(out, p.bubbleBoxLines(styled, assistantBorderStyle, assistantStyle,
|
||||
runeStyle, Diamond+" ", body, ts, w, right)...)
|
||||
out = append(out, make([]string, blockGapBlankLines)...)
|
||||
ts = "" // one stamp per message
|
||||
run = nil
|
||||
}
|
||||
for _, seg := range mdBlocks(m.Content) {
|
||||
for _, seg := range segs {
|
||||
switch seg.kind {
|
||||
case "table":
|
||||
flush()
|
||||
out = append(out, tableLines(seg.rows, w, styled, roleBorderStyle(m.Role))...)
|
||||
out = append(out, "")
|
||||
out = append(out, make([]string, blockGapBlankLines)...)
|
||||
case "heading":
|
||||
flush()
|
||||
out = append(out, headingLines(seg.text, w, styled, assistantStyle)...)
|
||||
out = append(out, "")
|
||||
out = append(out, headingBoxLines(seg.text, w, styled, assistantStyle, roleBorderStyle(m.Role))...)
|
||||
out = append(out, make([]string, blockGapBlankLines)...)
|
||||
case "list":
|
||||
flush()
|
||||
out = append(out, railLines(seg, w, styled, assistantStyle)...)
|
||||
out = append(out, "")
|
||||
out = append(out, listBoxLines(seg, w, styled, assistantStyle, roleBorderStyle(m.Role))...)
|
||||
out = append(out, make([]string, blockGapBlankLines)...)
|
||||
default:
|
||||
run = append(run, seg)
|
||||
}
|
||||
@@ -266,7 +338,15 @@ func tableLines(rows [][]string, w int, styled bool, border lipgloss.Style) []st
|
||||
}
|
||||
}
|
||||
}
|
||||
total := w - 4 // the │ pads + edge columns
|
||||
// the row budget: body row = 1 border + Σ(wc+2) + (cols-1)
|
||||
// separators + 1 border = Σw + 3*cols + 1 — so Σw ≤ w-3*cols-1.
|
||||
total := w - 3*cols - 1
|
||||
if total < cols*3 {
|
||||
// the pane is too narrow for a 3-wide-minimum table: the
|
||||
// block drops honestly rather than overflowing the pane (the
|
||||
// D53 format law — no rendered line ever exceeds the width)
|
||||
return nil
|
||||
}
|
||||
if sum := sumInt(widths); sum > total {
|
||||
scale := float64(total) / float64(sum)
|
||||
for c := range widths {
|
||||
@@ -302,7 +382,11 @@ func tableLines(rows [][]string, w int, styled bool, border lipgloss.Style) []st
|
||||
}
|
||||
out = append(out, emit(edge("┌", "┬", "┐")))
|
||||
for i, r := range rows {
|
||||
var line string
|
||||
// the row is ONE leading │, the cells separated by single │
|
||||
// columns, ONE trailing │ — the same geometry as the ┌/┬/┐
|
||||
// edge rows (the D53 format law: box rows and box edges share
|
||||
// one width, the corner misalignment defect never returns).
|
||||
cells := make([]string, cols)
|
||||
for c := 0; c < cols; c++ {
|
||||
v := cell(r, c)
|
||||
if styled {
|
||||
@@ -312,9 +396,10 @@ func tableLines(rows [][]string, w int, styled bool, border lipgloss.Style) []st
|
||||
v = assistantStyle.Render(v)
|
||||
}
|
||||
}
|
||||
line += "│ " + v + " "
|
||||
cells[c] = " " + v + " "
|
||||
}
|
||||
out = append(out, emit(line+"│"))
|
||||
line := "│" + strings.Join(cells, "│") + "│"
|
||||
out = append(out, emit(line))
|
||||
if i == 0 {
|
||||
out = append(out, emit(edge("├", "┼", "┤")))
|
||||
}
|
||||
@@ -331,54 +416,102 @@ func sumInt(xs []int) int {
|
||||
return n
|
||||
}
|
||||
|
||||
// railLines renders one list block as the RAIL presentation (B2.3,
|
||||
// outside the bubble): a left rail in the speaker's colour, hanging
|
||||
// indent, genuine bullets dotted, numbered steps numbered from the
|
||||
// listBoxLines renders one list block as the LIST BOX (owner live
|
||||
// ruling 2026-10-22: EVERYTHING gets a box — no element floats naked
|
||||
// after a bubble): the rail rides INSIDE a rounded box in the bubble
|
||||
// family, one blank line between items for readability (the same
|
||||
// ruling), genuine bullets dotted, numbered steps numbered from the
|
||||
// block's own start.
|
||||
func railLines(seg mdBlock, w int, styled bool, st lipgloss.Style) []string {
|
||||
var out []string
|
||||
func listBoxLines(seg mdBlock, w int, styled bool, st, border lipgloss.Style) []string {
|
||||
inner := max(w-4, 4)
|
||||
var rows []string
|
||||
num := seg.start
|
||||
for _, item := range seg.items {
|
||||
for i, item := range seg.items {
|
||||
if i > 0 {
|
||||
rows = append(rows, "") // a blank line between bullets (the ruling)
|
||||
}
|
||||
marker := bulletGlyph
|
||||
if seg.ordered {
|
||||
marker = fmt.Sprintf("%d.", num)
|
||||
num++
|
||||
}
|
||||
body := wrap(item, max(w-6, 1))
|
||||
for i, l := range body {
|
||||
body := wrap(item, max(inner-4, 1))
|
||||
for j, l := range body {
|
||||
lead := " "
|
||||
if i == 0 {
|
||||
if j == 0 {
|
||||
lead = marker + " "
|
||||
} else if seg.ordered {
|
||||
lead = " "
|
||||
}
|
||||
line := lead + l
|
||||
if styled {
|
||||
out = append(out, assistantRailStyle.Render("▌ ")+st.Render(line))
|
||||
rows = append(rows, assistantRailStyle.Render("▌ ")+st.Render(line))
|
||||
continue
|
||||
}
|
||||
out = append(out, "▌ "+line)
|
||||
rows = append(rows, "▌ "+line)
|
||||
}
|
||||
}
|
||||
return boxAround(rows, w, styled, border)
|
||||
}
|
||||
|
||||
// headingBoxLines renders one heading block (B2.5 + the live ruling:
|
||||
// everything boxed): a rounded box carrying the heading text and its
|
||||
// speaker-coloured underline.
|
||||
func headingBoxLines(text string, w int, styled bool, st, border lipgloss.Style) []string {
|
||||
inner := max(w-4, 4)
|
||||
line := clip(text, inner)
|
||||
underline := strings.Repeat("─", min(len([]rune(text)), inner))
|
||||
var rows []string
|
||||
if styled {
|
||||
rows = []string{st.Bold(true).Render(line), st.Render(underline)}
|
||||
} else {
|
||||
rows = []string{line, underline}
|
||||
}
|
||||
return boxAround(rows, w, styled, border)
|
||||
}
|
||||
|
||||
// boxAround draws the rounded box of the bubble family around
|
||||
// pre-rendered rows (the everything-boxed ruling's consistent
|
||||
// framing): the border carries the SPEAKER's colour.
|
||||
func boxAround(rows []string, w int, styled bool, border lipgloss.Style) []string {
|
||||
bw := 4
|
||||
for _, r := range rows {
|
||||
if n := len([]rune(semantic_stripANSI(r))) + 4; n > bw {
|
||||
bw = n
|
||||
}
|
||||
}
|
||||
bw = min(bw, max(w, 4))
|
||||
inner := max(bw-4, 1)
|
||||
top := "╭" + strings.Repeat("─", bw-2) + "╮"
|
||||
bot := "╰" + strings.Repeat("─", bw-2) + "╯"
|
||||
emit := func(l string) string {
|
||||
if styled {
|
||||
return border.Render(l)
|
||||
}
|
||||
return l
|
||||
}
|
||||
out := []string{emit(top)}
|
||||
for _, r := range rows {
|
||||
plain := semantic_stripANSI(r)
|
||||
clipN := max(inner-len([]rune(plain)), 0)
|
||||
if styled {
|
||||
pad := strings.Repeat(" ", clipN)
|
||||
out = append(out, emit("│ ")+r+pad+emit(" │"))
|
||||
continue
|
||||
}
|
||||
out = append(out, "│ "+pad(clip(r, inner), inner)+" │")
|
||||
}
|
||||
out = append(out, emit(bot))
|
||||
return out
|
||||
}
|
||||
|
||||
// headingLines renders one heading block (B2.5): full-width, the
|
||||
// speaker-coloured underline, NO bubble.
|
||||
func headingLines(text string, w int, styled bool, st lipgloss.Style) []string {
|
||||
line := clip(text, w)
|
||||
underline := strings.Repeat("─", min(len([]rune(text)), max(w, 0)))
|
||||
if styled {
|
||||
return []string{st.Bold(true).Render(line), st.Render(underline)}
|
||||
}
|
||||
return []string{line, underline}
|
||||
}
|
||||
// semantic_stripANSI is the package's ANSI strip (the box math counts
|
||||
// display columns only).
|
||||
func semantic_stripANSI(s string) string { return stripANSI(s) }
|
||||
|
||||
var assistantHeaderStyle = lipgloss.NewStyle().
|
||||
Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#7EE787")).Bold(true)
|
||||
Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#7EE787")).Bold(true)
|
||||
|
||||
// assistantRailStyle is the rail's speaker-coloured bar (B2.3).
|
||||
var assistantRailStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#FF79C6"))
|
||||
var assistantRailStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
|
||||
// roleBorderStyle is the SPEAKER's outline colour (B2.1/2.2: the
|
||||
// bubble outline and the table border both carry the speaker's
|
||||
@@ -397,4 +530,4 @@ func roleBorderStyle(role string) lipgloss.Style {
|
||||
}
|
||||
|
||||
// narrationBorderStyle is the narration family's dim outline.
|
||||
var narrationBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#78788A"))
|
||||
var narrationBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleMetaDim)))
|
||||
+25
-13
@@ -103,14 +103,18 @@ func TestListRidesRailOutsideBubble(t *testing.T) {
|
||||
if strings.Contains(plain, "• The steps") {
|
||||
t.Fatalf("a prose sentence must never render as a bullet:\n%s", plain)
|
||||
}
|
||||
// the bubble holds ONLY the prose: no bullet line sits inside a
|
||||
// │-bordered row
|
||||
// the LIST BOX is its own box (the everything-boxed ruling): the
|
||||
// rail + bullets ride inside a rounded box DISTINCT from the
|
||||
// speech bubble — its own top border, never the bubble's
|
||||
tops := 0
|
||||
for _, l := range lines {
|
||||
s := semantic.StripANSI(l)
|
||||
if strings.HasPrefix(s, "│") && strings.Contains(s, "•") {
|
||||
t.Fatalf("list items must live OUTSIDE the bubble:\n%s", s)
|
||||
if strings.HasPrefix(semantic.StripANSI(l), "╭") {
|
||||
tops++
|
||||
}
|
||||
}
|
||||
if tops != 3 {
|
||||
t.Fatalf("the list needs its OWN box between the prose bubbles (3 tops, got %d):\n%s", tops, plain)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNumberedStepsNumberedOnTheRail(t *testing.T) {
|
||||
@@ -138,14 +142,17 @@ func TestHeadingFullWidthNoBubble(t *testing.T) {
|
||||
if !strings.Contains(styled, "───") && !strings.Contains(plain, "───") {
|
||||
t.Fatalf("the heading must carry its underline:\n%s", plain)
|
||||
}
|
||||
// NO bubble for the heading: the heading line itself never sits
|
||||
// inside │ borders
|
||||
// the heading rides its OWN box (the everything-boxed ruling):
|
||||
// text + underline inside a rounded box, never naked
|
||||
tops := 0
|
||||
for _, l := range lines {
|
||||
s := semantic.StripANSI(l)
|
||||
if strings.HasPrefix(s, "│") && strings.Contains(s, "The Wave Plan") {
|
||||
t.Fatalf("a heading never renders inside the bubble:\n%s", s)
|
||||
if strings.HasPrefix(semantic.StripANSI(l), "╭") {
|
||||
tops++
|
||||
}
|
||||
}
|
||||
if tops != 2 {
|
||||
t.Fatalf("the heading needs its OWN box beside the speech bubble's one (2 tops, got %d):\n%s", tops, plain)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLongAnswerNeverBreaksBubble(t *testing.T) {
|
||||
@@ -167,8 +174,11 @@ func TestLongAnswerNeverBreaksBubble(t *testing.T) {
|
||||
bottoms++
|
||||
}
|
||||
}
|
||||
if tops != 1 || bottoms != 1 {
|
||||
t.Fatalf("a long answer must NEVER break the bubble (#2530a): %d tops, %d bottoms", tops, bottoms)
|
||||
// D54 summary-first: the 20-block answer opens with its one-line
|
||||
// summary box (a second top), but the BUBBLE itself is never
|
||||
// broken — exactly one content bubble beyond the summary.
|
||||
if tops != 2 || bottoms != 2 {
|
||||
t.Fatalf("a long answer must NEVER break the bubble (#2530a; the D54 summary box rides beside it): %d tops, %d bottoms", tops, bottoms)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -210,7 +220,9 @@ func TestOneStampPerAnswer(t *testing.T) {
|
||||
lines := p.answerPresentation(m, true, "10:00", 60, false)
|
||||
stamps := 0
|
||||
for _, l := range lines {
|
||||
if strings.HasPrefix(semantic.StripANSI(l), "10:00") {
|
||||
// the LIVE ruling: the stamp TRAILS the box's bottom-right
|
||||
trimmed := strings.TrimRight(semantic.StripANSI(l), " ")
|
||||
if strings.HasSuffix(trimmed, "10:00") {
|
||||
stamps++
|
||||
}
|
||||
}
|
||||
|
||||
+120
-73
@@ -34,8 +34,10 @@ package chatpane
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
|
||||
"math/rand"
|
||||
"os"
|
||||
"rune.dev/rune/tui/themes"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
@@ -105,7 +107,7 @@ type Style struct {
|
||||
|
||||
// DefaultStyle is the D41 amalgamation.
|
||||
func DefaultStyle() Style {
|
||||
return Style{Bubbles: true, Vocab: Vocab, Accent: "#FF79C6"}
|
||||
return Style{Bubbles: true, Vocab: Vocab, Accent: themes.RoleHex(themes.RoleSpeaker)}
|
||||
}
|
||||
|
||||
// ── D43: the direction law + the timestamp law ────────────────────────
|
||||
@@ -177,6 +179,11 @@ type Message struct {
|
||||
Content string
|
||||
Ts string
|
||||
Importance int
|
||||
// streaming marks the progressive-render bubble (Gitea #2556):
|
||||
// ONE pending assistant bubble whose content is replaced as the
|
||||
// model's bytes arrive; the durable final Append replaces it —
|
||||
// never a duplicate.
|
||||
streaming bool
|
||||
}
|
||||
|
||||
// Pane is the chat lane's bounded transcript.
|
||||
@@ -200,6 +207,10 @@ type Pane struct {
|
||||
cycle []rune
|
||||
shuffles int64
|
||||
// scrollState is the scrollback law's display state (scroll.go).
|
||||
// streamOpen/streamIdx mark the ONE progressive-render bubble
|
||||
// (Gitea #2556) while a streamed turn is in flight.
|
||||
streamOpen bool
|
||||
streamIdx int
|
||||
scrollState
|
||||
// scrollFade is the scrollbar layer's fade countdown (scroll.go's
|
||||
// scrollbar layer): visible-on-activity, transparent-at-rest.
|
||||
@@ -214,7 +225,43 @@ type Pane struct {
|
||||
}
|
||||
|
||||
// New returns an empty pane in the default (amalgamation) style.
|
||||
// ApplyCalm selects the presentation mode (D54 #2571 item 5): vivid
|
||||
// is the DEFAULT; calm mutes the chroma AT THE TOKEN LAYER (one file:
|
||||
// tui/themes/roles.go) and re-resolves this package's style sites
|
||||
// from the role tokens.
|
||||
func ApplyCalm(on bool) {
|
||||
themes.SetCalm(on)
|
||||
refreshRoleStyles()
|
||||
}
|
||||
|
||||
// refreshRoleStyles re-resolves the package-level role styles from
|
||||
// the themes tokens (they are package vars, resolved once at init —
|
||||
// a presentation flip must re-resolve them).
|
||||
func refreshRoleStyles() {
|
||||
bg := lipgloss.Color(themes.RoleHex(themes.RoleBackground))
|
||||
dim := lipgloss.Color(themes.RoleHex(themes.RoleMetaDim))
|
||||
userStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#7FD4FF"))
|
||||
assistantStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#7EE787"))
|
||||
systemStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#A0A0B2"))
|
||||
confirmStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#E3B341"))
|
||||
researchStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#58A6FF"))
|
||||
errorStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#F87171"))
|
||||
toolStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#B8B85E"))
|
||||
dimStyle = lipgloss.NewStyle().Background(bg).Foreground(dim)
|
||||
runeStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color("#C4A0FF"))
|
||||
tsStyle = lipgloss.NewStyle().Background(bg).Foreground(dim)
|
||||
accentLiveStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
userBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#FF9ED8"))
|
||||
assistantBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
confirmBorderStyle = lipgloss.NewStyle().Background(bg).Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
assistantHeaderStyle = lipgloss.NewStyle().
|
||||
Background(bg).Foreground(lipgloss.Color("#7EE787")).Bold(true)
|
||||
assistantRailStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
narrationBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleMetaDim)))
|
||||
}
|
||||
|
||||
func New() *Pane {
|
||||
refreshRoleStyles()
|
||||
p := &Pane{seen: map[string]bool{}, open: map[string]bool{}, expanded: map[string]bool{}}
|
||||
p.SetStyle(DefaultStyle())
|
||||
return p
|
||||
@@ -247,6 +294,34 @@ func (p *Pane) rebuildCycle() {
|
||||
// Len reports the retained message count.
|
||||
func (p *Pane) Len() int { return len(p.msgs) }
|
||||
|
||||
// UpsertStream installs or extends the progressive-render assistant
|
||||
// bubble (Gitea #2556): the model's bytes render AS THEY ARRIVE — the
|
||||
// bubble's content is replaced with the running total, the transcript
|
||||
// grows no duplicates. It reports whether the transcript changed.
|
||||
func (p *Pane) UpsertStream(content string) bool {
|
||||
if p.streamOpen && p.streamIdx >= 0 && p.streamIdx < len(p.msgs) {
|
||||
p.msgs[p.streamIdx].Content = content
|
||||
return true
|
||||
}
|
||||
p.msgs = append(p.msgs, Message{Role: RoleAssistant, Content: content, streaming: true})
|
||||
p.streamIdx = len(p.msgs) - 1
|
||||
p.streamOpen = true
|
||||
return true
|
||||
}
|
||||
|
||||
// DropStream retires the streaming bubble without a durable answer
|
||||
// (the dispatch failed): the partial render goes with the honest
|
||||
// error bubble the caller appends. Reports whether one was open.
|
||||
func (p *Pane) DropStream() bool {
|
||||
if !p.streamOpen || p.streamIdx < 0 || p.streamIdx >= len(p.msgs) {
|
||||
return false
|
||||
}
|
||||
p.msgs = append(p.msgs[:p.streamIdx], p.msgs[p.streamIdx+1:]...)
|
||||
p.streamOpen = false
|
||||
p.streamIdx = 0
|
||||
return true
|
||||
}
|
||||
|
||||
// Messages returns a copy of the retained transcript, oldest first.
|
||||
func (p *Pane) Messages() []Message {
|
||||
return append([]Message(nil), p.msgs...)
|
||||
@@ -264,6 +339,16 @@ func (p *Pane) Messages() []Message {
|
||||
// thinking stream per message). It reports whether the transcript
|
||||
// changed.
|
||||
func (p *Pane) Append(m Message) bool {
|
||||
// the streaming bubble's durable adoption (Gitea #2556): the
|
||||
// final assistant append REPLACES the progressive-render bubble —
|
||||
// one fact, never a duplicate.
|
||||
if m.Role == RoleAssistant && m.ID == "" && p.streamOpen {
|
||||
p.msgs[p.streamIdx].Content = m.Content
|
||||
p.msgs[p.streamIdx].Ts = m.Ts
|
||||
p.msgs[p.streamIdx].streaming = false
|
||||
p.streamOpen = false
|
||||
return true
|
||||
}
|
||||
key := "id:" + m.ID
|
||||
if m.ID == "" {
|
||||
key = "rc:" + m.Role + "\x00" + m.Content
|
||||
@@ -567,7 +652,6 @@ func (p *Pane) renderLines(w int, styled bool) ([]string, []ThinkingMark, []Expa
|
||||
// its role's side (D43.4).
|
||||
func (p *Pane) bubble(m Message, w int, styled bool) []string {
|
||||
if m.Importance >= ImportanceHigh {
|
||||
right := rightSide(m.Role)
|
||||
body := p.bubbleBody(m, max(w-2, 1), styled)
|
||||
out := make([]string, 0, len(body))
|
||||
for _, l := range body {
|
||||
@@ -577,13 +661,6 @@ func (p *Pane) bubble(m Message, w int, styled bool) []string {
|
||||
} else {
|
||||
line = ImportanceGlyph + " " + l
|
||||
}
|
||||
if right {
|
||||
if styled {
|
||||
line = padLeftANSI(line, w)
|
||||
} else {
|
||||
line = padLeft(line, w)
|
||||
}
|
||||
}
|
||||
out = append(out, line)
|
||||
}
|
||||
return out
|
||||
@@ -687,7 +764,7 @@ func (p *Pane) spin() string {
|
||||
func (p *Pane) accentPhases() []lipgloss.Style {
|
||||
hex := strings.TrimPrefix(p.style.Accent, "#")
|
||||
if hex == "" {
|
||||
hex = "FF79C6"
|
||||
hex = strings.TrimPrefix(themes.RoleHex(themes.RoleSpeaker), "#")
|
||||
}
|
||||
v, err := strconv.ParseUint(hex, 16, 32)
|
||||
if err != nil || len(hex) != 6 {
|
||||
@@ -846,12 +923,19 @@ func (p *Pane) bubbleBox(styled bool, border, content, leadStyle lipgloss.Style,
|
||||
// markdown projection: paragraphs, bullets with hanging indent) — the
|
||||
// markdown structure must survive the box verbatim, so the lines are
|
||||
// never re-wrapped.
|
||||
//
|
||||
// OWNER LIVE RULING 2026-10-22 (the alignment defect + no indent
|
||||
// creep): EVERY box renders FLUSH LEFT — column 0 of the pane content
|
||||
// — for user and rune alike, the whole conversation one flat left
|
||||
// edge (the old stamp-hang indent pushed later answers inward). The
|
||||
// timestamp rides AFTER the box's bottom-right corner, never pushing
|
||||
// the box off the edge — and never past the pane width.
|
||||
func (p *Pane) bubbleBoxLines(styled bool, border, content, leadStyle lipgloss.Style, lead string, bodyLines []string, ts string, w int, right bool) []string {
|
||||
hang := 0
|
||||
cap := max(w, 4)
|
||||
if ts != "" {
|
||||
hang = 1 + len([]rune(ts))
|
||||
// the trailing stamp's gutter stays inside the pane width
|
||||
cap = max(w-1-len([]rune(ts)), 4)
|
||||
}
|
||||
cap := max(w-hang, 4)
|
||||
var raw []string
|
||||
for i, l := range bodyLines {
|
||||
l = clip(l, max(cap-4, 1))
|
||||
@@ -883,58 +967,21 @@ func (p *Pane) bubbleBoxLines(styled bool, border, content, leadStyle lipgloss.S
|
||||
}
|
||||
out = append(out, "│ "+pad(clip(l, inner), inner)+" │")
|
||||
}
|
||||
// the bottom border row carries the stamp in the FAR-LEFT gutter
|
||||
// (D43 addendum 6 item 2: always column 0, same position regardless
|
||||
// of sender — the old corner-adjacent placement is superseded).
|
||||
var bottom string
|
||||
// the stamp trails the box's bottom-right corner (the live
|
||||
// ruling): the box owns the flat left edge, the stamp never
|
||||
// indents anything.
|
||||
bottom := bot
|
||||
if styled {
|
||||
bb := border.Render(bot)
|
||||
if ts != "" {
|
||||
bottom = tsStyle.Render(ts) + " " + bb
|
||||
bottom = border.Render(bot)
|
||||
}
|
||||
if ts != "" {
|
||||
if styled {
|
||||
bottom = bottom + " " + tsStyle.Render(ts)
|
||||
} else {
|
||||
bottom = bb
|
||||
}
|
||||
} else {
|
||||
if ts != "" {
|
||||
bottom = ts + " " + bot
|
||||
} else {
|
||||
bottom = bot
|
||||
bottom = bottom + " " + ts
|
||||
}
|
||||
}
|
||||
out = append(out, bottom)
|
||||
if right {
|
||||
// right-hug: the box's right edge stays at w; the bottom row
|
||||
// holds the stamp at column 0 and the box right-aligned in the
|
||||
// post-gutter room (its right corner reaches w).
|
||||
for i, l := range out {
|
||||
if ts != "" && i == len(out)-1 {
|
||||
var bb string
|
||||
if styled {
|
||||
bb = border.Render(bot)
|
||||
} else {
|
||||
bb = bot
|
||||
}
|
||||
out[i] = padLeftANSI(bb, w-hang)
|
||||
if styled {
|
||||
out[i] = tsStyle.Render(ts) + " " + out[i]
|
||||
} else {
|
||||
out[i] = ts + " " + out[i]
|
||||
}
|
||||
continue
|
||||
}
|
||||
out[i] = padLeftANSI(l, w)
|
||||
}
|
||||
} else if ts != "" {
|
||||
// left-hug: the whole box indents by the stamp's gutter so the
|
||||
// stamp fits at column 0 left of the bubble; the bottom row
|
||||
// already starts with the stamp at 0.
|
||||
for i := range out {
|
||||
if i == len(out)-1 {
|
||||
continue
|
||||
}
|
||||
out[i] = strings.Repeat(" ", hang) + out[i]
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
@@ -996,35 +1043,35 @@ var (
|
||||
// assistant effectively invisible). Families kept: cyan=you,
|
||||
// green=rune/results (D35), grey=system, gold=confirm,
|
||||
// blue=research, red=errors, olive=tool.
|
||||
userStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#7FD4FF"))
|
||||
assistantStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#7EE787"))
|
||||
systemStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#A0A0B2"))
|
||||
confirmStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#E3B341"))
|
||||
researchStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#58A6FF"))
|
||||
errorStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#F87171"))
|
||||
toolStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#B8B85E"))
|
||||
dimStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#78788A"))
|
||||
userStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#7FD4FF"))
|
||||
assistantStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#7EE787"))
|
||||
systemStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#A0A0B2"))
|
||||
confirmStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#E3B341"))
|
||||
researchStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#58A6FF"))
|
||||
errorStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#F87171"))
|
||||
toolStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#B8B85E"))
|
||||
dimStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color(themes.RoleHex(themes.RoleMetaDim)))
|
||||
// runeStyle is Rune's identity marker (D35): the runic glyph rides
|
||||
// the existing purple accent family (135 — the focused-border tone).
|
||||
runeStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#C4A0FF"))
|
||||
runeStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color("#C4A0FF"))
|
||||
// tsStyle is the dim timestamp beside each message (D35; the D43
|
||||
// addendum's emphasis pass: Faint on top of the floor-legal dim
|
||||
// tone — the terminal's own de-emphasis keeps the stamp unobtrusive
|
||||
// while the floor-legal tone keeps it legible when attended to).
|
||||
tsStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#78788A")).Faint(true)
|
||||
tsStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color(themes.RoleHex(themes.RoleMetaDim)))
|
||||
// accentLiveStyle is the default accent (D41 pink #FF79C6, 6.9:1)
|
||||
// — the breathing marker's full-brightness phase.
|
||||
accentLiveStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#FF79C6"))
|
||||
accentLiveStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
// D43.9 bubble borders: SOLID (the rounded glyphs are solid) and
|
||||
// the PINK FAMILY — the same family as the composer's lit outline;
|
||||
// identity keeps speaking by side and content color (D35). Both
|
||||
// tones ≥4.5:1 on the base (the readability floor).
|
||||
userBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#FF9ED8"))
|
||||
assistantBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("#FF79C6"))
|
||||
assistantBorderStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
// confirmBorderStyle: the D43.9 law — ALL boxes carry the solid
|
||||
// PINK FAMILY outline (the earlier gold was the outline-color
|
||||
// defect); the confirm's warning text keeps its gold tone inside.
|
||||
confirmBorderStyle = lipgloss.NewStyle().Background(lipgloss.Color("#1E1E28")).Foreground(lipgloss.Color("#FF79C6"))
|
||||
confirmBorderStyle = lipgloss.NewStyle().Background(lipgloss.Color(themes.RoleHex(themes.RoleBackground))).Foreground(lipgloss.Color(themes.RoleHex(themes.RoleSpeaker)))
|
||||
)
|
||||
|
||||
// stampLine renders one text line with its timestamp in the FAR-LEFT
|
||||
|
||||
@@ -73,8 +73,8 @@ func TestUserLeftAssistantRight(t *testing.T) {
|
||||
for len(lines) > 0 && strings.TrimRight(lines[0], " ") == "" {
|
||||
lines = lines[1:]
|
||||
}
|
||||
if len(lines) != 6 { // 3 bubble rows each
|
||||
t.Fatalf("lines = %d, want 6 (two rounded bubbles):\n%v", len(lines), lines)
|
||||
if len(lines) != 7 { // 3 bubble rows each + the D54 spacing law's trailing block gap
|
||||
t.Fatalf("lines = %d, want 7 (two rounded bubbles + one block gap):\n%v", len(lines), lines)
|
||||
}
|
||||
if got := lines[1]; !strings.HasPrefix(got, "│ left") {
|
||||
t.Errorf("user must hug the LEFT (D43.4 LTR), bare content, got %q", got)
|
||||
@@ -898,12 +898,14 @@ func TestUserBubbleTimestampOppositeSide(t *testing.T) {
|
||||
lines := p.Render(w, 30, false)
|
||||
found := false
|
||||
for _, l := range lines {
|
||||
if strings.HasPrefix(l, stampStr+" ╰") {
|
||||
// the LIVE ruling (2026-10-22): the box owns the flat left
|
||||
// edge; the stamp TRAILS the bottom-right corner
|
||||
if strings.HasPrefix(l, "╰") && strings.HasSuffix(strings.TrimRight(l, " "), " "+stampStr) {
|
||||
found = true
|
||||
}
|
||||
}
|
||||
if !found {
|
||||
t.Fatalf("w=%d: stamp must LEAD the bubble's bottom row (D43.3):\n%s", w, strings.Join(lines, "\n"))
|
||||
t.Fatalf("w=%d: stamp must TRAIL the box's bottom-right corner (the flat-left-edge ruling):\n%s", w, strings.Join(lines, "\n"))
|
||||
}
|
||||
for i, l := range lines {
|
||||
if n := len([]rune(l)); n > w {
|
||||
@@ -965,9 +967,11 @@ func TestUserBubbleFullBoxAlignment(t *testing.T) {
|
||||
w, i, col, cornerCol, rows)
|
||||
}
|
||||
}
|
||||
bottom := []rune(rows[len(rows)-1])
|
||||
if string(bottom[:5]) != stampStr {
|
||||
t.Errorf("w=%d: the stamp must lead the bottom row (D43.3): %q", w, rows[len(rows)-1])
|
||||
bottom := rows[len(rows)-1]
|
||||
// the LIVE ruling: the stamp trails the box's bottom-right
|
||||
// corner; the box keeps the flat left edge
|
||||
if !strings.HasPrefix(bottom, "╰") || !strings.HasSuffix(bottom, " "+stampStr) {
|
||||
t.Errorf("w=%d: the stamp must trail the bottom row's right corner: %q", w, bottom)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1028,7 +1032,10 @@ func containsWhole(s, word string) bool {
|
||||
// re-land): EVERY stamp-bearing row starts its timestamp at column 0,
|
||||
// the same position regardless of sender — the old opposite-side /
|
||||
// corner-adjacent placements are superseded.
|
||||
func TestTimestampsFarLeftGutterBothSenders(t *testing.T) {
|
||||
func TestTimestampsTrailBothSendersBoxes(t *testing.T) {
|
||||
// re-pinned to the LIVE ruling (2026-10-22): both senders' boxes
|
||||
// render FLUSH LEFT — one flat conversation edge, no indent creep —
|
||||
// and each stamp trails its own box's bottom-right corner.
|
||||
if rtl {
|
||||
t.Skip("stamp side pinned for the LTR machine")
|
||||
}
|
||||
@@ -1038,41 +1045,28 @@ func TestTimestampsFarLeftGutterBothSenders(t *testing.T) {
|
||||
Content: "user side line"})
|
||||
p.Append(Message{ID: "a1", Role: RoleAssistant, Ts: "2026-10-18T12:01:00Z",
|
||||
Content: "rune side line"})
|
||||
type stampRow struct {
|
||||
col int
|
||||
boxCol int
|
||||
}
|
||||
var rows []stampRow
|
||||
for _, l := range p.Render(w, 12, false) {
|
||||
trimmed := strings.TrimLeft(l, " ")
|
||||
if len(trimmed) < 5 || trimmed[2] != ':' {
|
||||
continue
|
||||
lines := p.Render(w, 12, false)
|
||||
stamps := 0
|
||||
for _, l := range lines {
|
||||
trimmed := strings.TrimRight(l, " ")
|
||||
// a trailing HH:MM stamp: "╰───╯ 13:01"
|
||||
ok := strings.HasPrefix(l, "\u2570") && len(trimmed) >= 6
|
||||
if ok {
|
||||
tail := []rune(trimmed)[len([]rune(trimmed))-5:]
|
||||
ok = len(tail) == 5 && tail[2] == ':' && tail[0] >= '0' && tail[0] <= '9'
|
||||
}
|
||||
if _, err := time.Parse("15:04", trimmed[:5]); err != nil {
|
||||
continue
|
||||
if ok {
|
||||
stamps++
|
||||
}
|
||||
col := strings.Index(l, trimmed[:5])
|
||||
rest := l[col+5:]
|
||||
boxCol := -1
|
||||
for i, r := range rest {
|
||||
if r == '╰' {
|
||||
boxCol = col + 5 + i
|
||||
break
|
||||
}
|
||||
}
|
||||
rows = append(rows, stampRow{col: col, boxCol: boxCol})
|
||||
}
|
||||
if len(rows) != 2 {
|
||||
t.Fatalf("w=%d: expected both senders' stamps, found %d:\n%s",
|
||||
w, len(rows), strings.Join(p.Render(w, 12, false), "\n"))
|
||||
if stamps != 2 {
|
||||
t.Fatalf("w=%d: both senders' stamps must trail their boxes (found %d):\n%s",
|
||||
w, stamps, strings.Join(lines, "\n"))
|
||||
}
|
||||
if rows[0].col != rows[1].col {
|
||||
t.Fatalf("w=%d: stamps sit at DIFFERENT columns (%d vs %d) — the corner placement persists:\n%s",
|
||||
w, rows[0].col, rows[1].col, strings.Join(p.Render(w, 12, false), "\n"))
|
||||
}
|
||||
for _, r := range rows {
|
||||
if r.boxCol >= 0 && r.boxCol < r.col {
|
||||
t.Fatalf("w=%d: bubble renders LEFT of the stamp — not the far-left gutter", w)
|
||||
// the flat left edge: every box top row starts at column 0
|
||||
for _, l := range lines {
|
||||
if strings.Contains(l, "╭") && !strings.HasPrefix(l, "╭") {
|
||||
t.Fatalf("w=%d: a box indents off the flat left edge:\n%q", w, l)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,119 @@
|
||||
package chatpane
|
||||
|
||||
// d53_longanswer_test.go — the LONG-ANSWER FORMAT BREAK wave (Gitea
|
||||
// #2568 item 1, red-first): a LONG multi-block answer (20+ blocks,
|
||||
// mixed types) driven through the render path at narrow widths must
|
||||
// hold format everywhere. The synthesis law it asserts (research/
|
||||
// factory-nuerodivergent-presentation): CHUNKED, CONSISTENT GEOMETRY
|
||||
// — every rendered line fits the pane width (no clipping, no
|
||||
// overflow), every box is well-formed (its top edge, its rows and its
|
||||
// bottom edge agree on one width), the summary-first box opens the
|
||||
// answer at ANY length, and appending later blocks never reflows a
|
||||
// completed block above (the never-reflow law's long-answer leg).
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
// longAnswer builds a 24-block mixed answer: prose, lists, a table,
|
||||
// headings — the shapes the parser produces for a real long turn.
|
||||
func longAnswer() string {
|
||||
var b strings.Builder
|
||||
for i := 0; i < 6; i++ {
|
||||
fmt.Fprintf(&b, "## Section %d\n\n", i)
|
||||
fmt.Fprintf(&b, "Paragraph %d walks through the reasoning at length, carrying enough words to wrap several times at a narrow pane width so the wrap boundary math is exercised.\n\n", i)
|
||||
fmt.Fprintf(&b, "- item alpha %d with detail\n", i)
|
||||
fmt.Fprintf(&b, "- item beta %d with more detail\n\n", i)
|
||||
if i == 2 {
|
||||
b.WriteString("| col one | col two | col three |\n| --- | --- | --- |\n| r1a | r1b | r1c |\n| r2a | r2b | r2c |\n\n")
|
||||
}
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// lineWidths measures each rendered line's display width.
|
||||
func lineWidths(lines []string) []int {
|
||||
out := make([]int, len(lines))
|
||||
for i, l := range lines {
|
||||
out[i] = len([]rune(semantic.StripANSI(l)))
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// boxEdgesCount checks every box row's width matches its top edge:
|
||||
// the box's corner glyphs delimit the box; a row that runs past its
|
||||
// top edge's width is a broken box (the corner misalignment the owner
|
||||
// sees as format breaking on long answers).
|
||||
func boxTopWidths(lines []string) map[int]int {
|
||||
w := map[int]int{}
|
||||
for i, l := range lines {
|
||||
plain := semantic.StripANSI(l)
|
||||
if strings.HasPrefix(plain, "╭") && strings.HasSuffix(plain, "╮") {
|
||||
w[i] = len([]rune(plain))
|
||||
}
|
||||
}
|
||||
return w
|
||||
}
|
||||
|
||||
func TestLongAnswerHoldsFormatAtNarrowWidths(t *testing.T) {
|
||||
p := New()
|
||||
p.Append(Message{ID: "a1", Role: RoleAssistant, Content: longAnswer()})
|
||||
for _, w := range []int{24, 28, 32, 40, 60, 80, 100} {
|
||||
lines := p.answerPresentation(p.msgs[0], false, "", w, false)
|
||||
for i, lw := range lineWidths(lines) {
|
||||
if lw > w {
|
||||
t.Fatalf("width %d: rendered line %d is %d columns (%q)", w, i, lw, lines[i])
|
||||
}
|
||||
}
|
||||
// box integrity: for every box top at line i, the box's rows
|
||||
// and its bottom edge must not run past the top edge's width.
|
||||
tops := boxTopWidths(lines)
|
||||
for i := range tops {
|
||||
if i+1 >= len(lines) {
|
||||
continue
|
||||
}
|
||||
tw := tops[i]
|
||||
for j := i + 1; j < len(lines); j++ {
|
||||
plain := semantic.StripANSI(lines[j])
|
||||
if strings.HasPrefix(plain, "╰") && strings.HasSuffix(plain, "╯") {
|
||||
if len([]rune(plain)) != tw {
|
||||
t.Fatalf("width %d: box bottom (line %d) is %d cols, top %d", w, j, len([]rune(plain)), tw)
|
||||
}
|
||||
break
|
||||
}
|
||||
if strings.HasPrefix(plain, "╭") && strings.HasSuffix(plain, "╮") {
|
||||
break // a new box opened: the previous one ended
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestLongAnswerSummaryFirstAtAnyLength(t *testing.T) {
|
||||
p := New()
|
||||
p.Append(Message{ID: "a1", Role: RoleAssistant, Content: longAnswer()})
|
||||
lines := p.answerPresentation(p.msgs[0], false, "", 60, false)
|
||||
head := strings.Join(lines[:min(len(lines), 3)], "\n")
|
||||
if !strings.Contains(head, "Summary:") {
|
||||
t.Fatalf("a 20+ block answer must open with the summary box, got %q", head)
|
||||
}
|
||||
}
|
||||
|
||||
func TestLongAnswerNoReflowOnAppend(t *testing.T) {
|
||||
p := New()
|
||||
p.Append(Message{ID: "a1", Role: RoleAssistant, Content: longAnswer()})
|
||||
before := p.answerPresentation(p.msgs[0], false, "", 60, false)
|
||||
p.Append(Message{ID: "a2", Role: RoleAssistant, Content: "A short later answer."})
|
||||
after := p.answerPresentation(p.msgs[0], false, "", 60, false)
|
||||
if len(before) == 0 || len(after) < len(before) {
|
||||
t.Fatalf("append must not shrink the completed blocks")
|
||||
}
|
||||
for i := range before {
|
||||
if before[i] != after[i] {
|
||||
t.Fatalf("completed block line %d reflowed on append:\nbefore %q\nafter %q", i, before[i], after[i])
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,43 @@
|
||||
package chatpane
|
||||
|
||||
import "testing"
|
||||
|
||||
// D54 item 1 (Gitea #2571): THE NEVER-ANIMATE LAW of the chat pane —
|
||||
// the pane holds the reading content, so it never animates. The
|
||||
// append-only assertion: appending a message must NOT change a single
|
||||
// already-rendered line of the completed blocks above it (stream
|
||||
// append never reflows completed blocks; the top-anchored stay-put
|
||||
// scroll law in scroll.go rides the same contract).
|
||||
|
||||
func TestAppendNeverReflowsCompletedBlocks(t *testing.T) {
|
||||
p := New()
|
||||
p.Append(Message{Role: RoleAssistant, Content: "First answer, a complete paragraph of prose.\n\n- one point\n- another point"})
|
||||
p.Append(Message{Role: RoleUser, Content: "A user reply."})
|
||||
|
||||
w := 60
|
||||
before, _, _ := p.renderLines(w, true)
|
||||
p.Append(Message{Role: RoleAssistant, Content: "Second answer with entirely different content.\n\n| a | b |\n| --- | --- |\n| 1 | 2 |\n\n```go\ncode\n```"})
|
||||
after, _, _ := p.renderLines(w, true)
|
||||
|
||||
if len(after) <= len(before) {
|
||||
t.Fatalf("append must grow the transcript: %d <= %d", len(after), len(before))
|
||||
}
|
||||
for i := 0; i < len(before); i++ {
|
||||
// completed blocks keep their exact rendered lines; the tail
|
||||
// of the stream may show newly appended content only.
|
||||
if before[i] != after[i] {
|
||||
t.Fatalf("append reflowed completed block line %d — the never-animate law forbids it:\nbefore: %q\nafter: %q", i, before[i], after[i])
|
||||
}
|
||||
}
|
||||
p2 := New()
|
||||
p2.Append(Message{Role: RoleAssistant, Content: "First answer, a complete paragraph of prose.\n\n- one point\n- another point"})
|
||||
p2.Append(Message{Role: RoleUser, Content: "A user reply."})
|
||||
plainBefore, _, _ := p2.renderLines(w, false)
|
||||
p2.Append(Message{Role: RoleAssistant, Content: "Second answer with entirely different content."})
|
||||
plainAfter, _, _ := p2.renderLines(w, false)
|
||||
for i := 0; i < len(plainBefore); i++ {
|
||||
if plainBefore[i] != plainAfter[i] {
|
||||
t.Fatalf("plain-path append reflowed completed block line %d: %q vs %q", i, plainBefore[i], plainAfter[i])
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,64 @@
|
||||
package chatpane
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// D54 item 3 (Gitea #2571): THE SPACING LAW — exactly ONE blank line
|
||||
// between blocks; block types never merge (a list is a list, a
|
||||
// paragraph a paragraph; the parser never joins them; the renderer
|
||||
// never abuts their boxes).
|
||||
|
||||
func TestOneBlankLineBetweenBlocks(t *testing.T) {
|
||||
p := New()
|
||||
out := p.answerPresentation(Message{Role: RoleAssistant, Content: "Intro paragraph before the list.\n\n- first item\n- second item\n\n| h1 | h2 |\n| --- | --- |\n| a | b |\n\nClosing paragraph after the table."}, false, "", 60, false)
|
||||
// no two box borders ever abut, and never two blanks in a row
|
||||
for i := 1; i < len(out); i++ {
|
||||
a, b := strings.TrimSpace(out[i-1]), strings.TrimSpace(out[i])
|
||||
if a == "" && b == "" {
|
||||
t.Fatalf("two blank lines adjacent at %d — the spacing law allows exactly one:\n%q", i, strings.Join(out, "\n"))
|
||||
}
|
||||
if (strings.HasPrefix(a, "╭") && strings.HasPrefix(b, "╭")) ||
|
||||
(strings.HasPrefix(a, "┌") && strings.HasPrefix(b, "┌")) {
|
||||
t.Fatalf("two block boxes abut at %d — blocks never merge:\n%q", i, strings.Join(out, "\n"))
|
||||
}
|
||||
}
|
||||
// and between every pair of block regions there is a blank line
|
||||
joined := strings.Join(out, "\n")
|
||||
for _, sep := range []string{"┘\n╭", "╯\n╭", "╯\n┌", "┘\n┌"} {
|
||||
if strings.Contains(joined, sep) {
|
||||
t.Fatalf("blocks abut without the one-blank-line gap (%q):\n%s", sep, joined)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestBlockTypesNeverMerge(t *testing.T) {
|
||||
blocks := mdBlocks("- alpha\n- beta\nplain paragraph text\n- gamma\n- delta")
|
||||
var sawList, sawPara bool
|
||||
for _, b := range blocks {
|
||||
switch b.kind {
|
||||
case "list":
|
||||
sawList = true
|
||||
for _, it := range b.items {
|
||||
if it == "plain paragraph text" {
|
||||
t.Fatal("a paragraph merged into a list block — types never merge")
|
||||
}
|
||||
}
|
||||
case "para":
|
||||
sawPara = true
|
||||
if strings.Contains(b.text, "alpha") || strings.Contains(b.text, "delta") {
|
||||
t.Fatal("a list merged into the paragraph block — types never merge")
|
||||
}
|
||||
}
|
||||
}
|
||||
if !sawList || !sawPara {
|
||||
t.Fatalf("expected distinct list and para blocks, got %+v", blocks)
|
||||
}
|
||||
}
|
||||
|
||||
func TestBlockGapIsPureLayoutConstant(t *testing.T) {
|
||||
if blockGapBlankLines != 1 {
|
||||
t.Fatalf("the spacing law fixes ONE blank line between blocks, got %d", blockGapBlankLines)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
package chatpane
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// D54 item 4 (Gitea #2571): SUMMARY-FIRST — an answer longer than the
|
||||
// threshold opens with a ONE-LINE plain-english summary box: what the
|
||||
// answer contains, counted literally, before the blocks (COGA 4.4.8;
|
||||
// the generalize of the "code (n lines)" collapse).
|
||||
|
||||
func TestLongAnswerOpensWithSummaryBox(t *testing.T) {
|
||||
var b strings.Builder
|
||||
for i := 0; i < 9; i++ {
|
||||
b.WriteString("Paragraph block of prose the reader has not read yet.\n\n")
|
||||
}
|
||||
p := New()
|
||||
out := p.answerPresentation(Message{Role: RoleAssistant, Content: b.String()}, false, "", 70, false)
|
||||
joined := strings.Join(out, "\n")
|
||||
if !strings.Contains(joined, "Summary:") {
|
||||
t.Fatalf("a 9-block answer must open with a one-line plain-english summary:\n%s", joined)
|
||||
}
|
||||
// the summary rides FIRST — before the first content box
|
||||
if out[0] != "╭"[:1]+"" {
|
||||
if !strings.HasPrefix(out[0], "╭") {
|
||||
t.Fatalf("the summary box must be the first block, got %q", out[0])
|
||||
}
|
||||
}
|
||||
if !strings.Contains(out[1], "Summary:") {
|
||||
t.Fatalf("summary must be one line, got %q", out[1])
|
||||
}
|
||||
// literal wording: the count is in the line
|
||||
if !strings.Contains(out[1], "9") {
|
||||
t.Fatalf("the summary must count the blocks literally, got %q", out[1])
|
||||
}
|
||||
}
|
||||
|
||||
func TestShortAnswerHasNoSummary(t *testing.T) {
|
||||
p := New()
|
||||
out := p.answerPresentation(Message{Role: RoleAssistant, Content: "One short paragraph."}, false, "", 70, false)
|
||||
if strings.Contains(strings.Join(out, "\n"), "Summary:") {
|
||||
t.Fatalf("a 1-block answer must not carry a summary box:\n%s", strings.Join(out, "\n"))
|
||||
}
|
||||
}
|
||||
|
||||
func TestSummaryThresholdConstant(t *testing.T) {
|
||||
if summaryBlockThreshold != 8 {
|
||||
t.Fatalf("the summary threshold is tuned to 8 blocks, got %d", summaryBlockThreshold)
|
||||
}
|
||||
}
|
||||
@@ -530,7 +530,7 @@ func (p *Pane) richBubble(m Message, styled bool, st lipgloss.Style, prefix, ts
|
||||
}
|
||||
continue
|
||||
case seg.kind == "heading":
|
||||
for _, l := range headingLines(seg.text, w, styled, st) {
|
||||
for _, l := range headingBoxLines(seg.text, w, styled, st, roleBorderStyle(m.Role)) {
|
||||
emit(l)
|
||||
}
|
||||
continue
|
||||
|
||||
+35
-13
@@ -23,6 +23,10 @@ package chatpane
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
|
||||
"charm.land/lipgloss/v2"
|
||||
|
||||
"rune.dev/rune/tui/themes"
|
||||
)
|
||||
|
||||
// scrollState is the pane's scroll display state (embedded in Pane).
|
||||
@@ -284,11 +288,32 @@ func (p *Pane) ScrollbarVisible() bool {
|
||||
// transcript. Returns "" when the layer is not visible (transparent at
|
||||
// rest).
|
||||
func (p *Pane) ScrollbarRow(w int) string {
|
||||
if !p.ScrollbarVisible() {
|
||||
rows := p.ScrollbarRows()
|
||||
if rows == nil {
|
||||
return ""
|
||||
}
|
||||
out := ""
|
||||
for _, r := range rows {
|
||||
if r == "" {
|
||||
out += " "
|
||||
continue
|
||||
}
|
||||
out += "▐"
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// ScrollbarRows renders the scrollbar layer as ONE string per pane row
|
||||
// (the D53 #2568 repair): the thumb's rows carry the RoleScroll token
|
||||
// colour (the D54 colour law — the bar is scheme-matched yet distinct,
|
||||
// a role of its own), every other row is "" (no overlay). Nil when the
|
||||
// layer is not visible.
|
||||
func (p *Pane) ScrollbarRows() []string {
|
||||
if !p.ScrollbarVisible() {
|
||||
return nil
|
||||
}
|
||||
if p.scrollState.lastLines <= 0 || p.scrollState.lastRows <= 0 {
|
||||
return ""
|
||||
return nil
|
||||
}
|
||||
total := max(p.scrollState.lastLines, 1)
|
||||
visible := max(p.scrollState.lastRows-1, 1)
|
||||
@@ -302,16 +327,13 @@ func (p *Pane) ScrollbarRow(w int) string {
|
||||
maxOff := max(total-visible, 1)
|
||||
pos = int(float64(p.scrollState.lastRows-thumb) * (float64(p.scrollState.offset) / float64(maxOff)))
|
||||
}
|
||||
row := make([]rune, p.scrollState.lastRows)
|
||||
for i := range row {
|
||||
row[i] = ' '
|
||||
rows := make([]string, p.scrollState.lastRows)
|
||||
for i := pos; i < pos+thumb && i < len(rows); i++ {
|
||||
rows[i] = scrollThumbStyle.Render("▐")
|
||||
}
|
||||
for i := pos; i < pos+thumb && i < len(row); i++ {
|
||||
row[i] = '▐'
|
||||
}
|
||||
out := string(row)
|
||||
if w > 0 && len(out) > w {
|
||||
out = out[:w]
|
||||
}
|
||||
return out
|
||||
return rows
|
||||
}
|
||||
|
||||
// scrollThumbStyle is the thumb's token colour: RoleScroll, defined
|
||||
// once in themes (the D54 law — one hex per role).
|
||||
var scrollThumbStyle = lipgloss.NewStyle().Foreground(lipgloss.Color(themes.RoleHex(themes.RoleScroll)))
|
||||
@@ -0,0 +1,58 @@
|
||||
package chatpane
|
||||
|
||||
// stream_render_test.go — the progressive-render bubble's frozen law
|
||||
// (Gitea #2556, red-first): one streaming bubble grows with the
|
||||
// running total, the durable final append REPLACES it (never a
|
||||
// duplicate), and a failed dispatch retires it.
|
||||
|
||||
import "testing"
|
||||
|
||||
func TestUpsertStreamGrowsOneBubble(t *testing.T) {
|
||||
p := New()
|
||||
if !p.UpsertStream("hel") {
|
||||
t.Fatal("first upsert reported no change")
|
||||
}
|
||||
p.UpsertStream("hello")
|
||||
if p.Len() != 1 {
|
||||
t.Fatalf("transcript = %d messages, want ONE streaming bubble", p.Len())
|
||||
}
|
||||
if p.Messages()[0].Content != "hello" {
|
||||
t.Fatalf("content = %q", p.Messages()[0].Content)
|
||||
}
|
||||
}
|
||||
|
||||
func TestFinalAppendAdoptsStreamBubble(t *testing.T) {
|
||||
p := New()
|
||||
p.UpsertStream("hel")
|
||||
p.UpsertStream("hello wo")
|
||||
ok := p.Append(Message{Role: RoleAssistant, Content: "hello world", Ts: "t"})
|
||||
if !ok {
|
||||
t.Fatal("final append reported no change")
|
||||
}
|
||||
if p.Len() != 1 {
|
||||
t.Fatalf("transcript = %d messages, want the adopted ONE", p.Len())
|
||||
}
|
||||
m := p.Messages()[0]
|
||||
if m.Content != "hello world" || m.Ts != "t" || m.streaming {
|
||||
t.Fatalf("adopted bubble = %+v", m)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDropStreamRetiresPartial(t *testing.T) {
|
||||
p := New()
|
||||
p.UpsertStream("par")
|
||||
if !p.DropStream() {
|
||||
t.Fatal("drop reported no change")
|
||||
}
|
||||
if p.Len() != 0 {
|
||||
t.Fatalf("transcript = %d, want empty", p.Len())
|
||||
}
|
||||
if p.DropStream() {
|
||||
t.Fatal("second drop reported change")
|
||||
}
|
||||
// a fresh stream can open after the drop
|
||||
p.UpsertStream("new")
|
||||
if p.Len() != 1 {
|
||||
t.Fatalf("reopen = %d messages", p.Len())
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,154 @@
|
||||
package main
|
||||
|
||||
// d50_pty_test.go — the D50-residual PTY proofs (#2560): the REAL face
|
||||
// binary on a REAL pseudo-terminal (the boot_smoke method) proves the
|
||||
// two owner-critical behaviors:
|
||||
//
|
||||
// 1. ENTER DISPATCH (D50 residual 3): with the tasks pane focused and
|
||||
// the tree region OPEN (the /tree road — the click road's keyboard
|
||||
// parity), typing a work demand and pressing enter DISPATCHES it
|
||||
// through the task-queue admission surface (the honest transport
|
||||
// receipt renders) — the region never steals enter.
|
||||
// 2. PIN PERSISTENCE (D50 residual 4): a pin recorded in the
|
||||
// hot-state store (tasks_pins.json) before boot renders in the
|
||||
// reserved pinned area after a REAL boot — the pins survive.
|
||||
import (
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
"strings"
|
||||
"syscall"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
func TestD50PtyEnterDispatchAndPinPersistence(t *testing.T) {
|
||||
if testing.Short() {
|
||||
t.Skip("boots the real face (build + pty); skipped in -short")
|
||||
}
|
||||
if runtime.GOOS != "linux" {
|
||||
t.Skipf("pty boot method is linux (/dev/ptmx); not %s", runtime.GOOS)
|
||||
}
|
||||
if _, err := exec.LookPath("go"); err != nil {
|
||||
t.Skip("no go toolchain in PATH — cannot build the face")
|
||||
}
|
||||
_, thisFile, _, ok := runtime.Caller(0)
|
||||
if !ok {
|
||||
t.Fatal("cannot locate module root")
|
||||
}
|
||||
tuiRoot := filepath.Dir(filepath.Dir(filepath.Dir(thisFile)))
|
||||
repoRoot := filepath.Dir(tuiRoot)
|
||||
|
||||
bin := filepath.Join(t.TempDir(), "rune-tui")
|
||||
build := exec.Command("go", "build", "-o", bin, "./cmd/rune-tui")
|
||||
build.Dir = tuiRoot
|
||||
if out, err := build.CombinedOutput(); err != nil {
|
||||
t.Fatalf("face build failed: %v\n%s", err, out)
|
||||
}
|
||||
|
||||
master, slave, err := openPty()
|
||||
if err != nil {
|
||||
t.Fatalf("pty: %v", err)
|
||||
}
|
||||
defer master.Close()
|
||||
|
||||
sandbox := t.TempDir()
|
||||
// the pre-written pin record (the hot-state store's boot leg): a
|
||||
// pin that must render after the REAL boot.
|
||||
pin := `{"pins":[{"id":"pin_1","task_id":"task_1","summary":"keep the reflow squash test green","ts":"2026-10-22T12:00:00Z"}]}` + "\n"
|
||||
if err := os.WriteFile(filepath.Join(sandbox, "tasks_pins.json"), []byte(pin), 0o600); err != nil {
|
||||
t.Fatalf("pin record: %v", err)
|
||||
}
|
||||
if err := saveProviderSelection(sandbox, providerSelection{
|
||||
Provider: "local", Model: "test-model", SelectedAt: "2026-10-19T00:00:00Z"}); err != nil {
|
||||
t.Fatalf("provider record: %v", err)
|
||||
}
|
||||
cmd := exec.Command(bin)
|
||||
cmd.Stdin, cmd.Stdout, cmd.Stderr = slave, slave, slave
|
||||
cmd.SysProcAttr = &syscall.SysProcAttr{Setsid: true, Setctty: true, Ctty: 0}
|
||||
cmd.Env = append(os.Environ(),
|
||||
"RUNE_LIB_REPO="+repoRoot,
|
||||
"RUNE_HOME="+sandbox,
|
||||
"RUNE_MEMORY_DIR="+filepath.Join(sandbox, "memory"),
|
||||
"TERM=xterm-256color",
|
||||
)
|
||||
if err := cmd.Start(); err != nil {
|
||||
slave.Close()
|
||||
t.Fatalf("face start: %v", err)
|
||||
}
|
||||
slave.Close()
|
||||
exited := make(chan error, 1)
|
||||
go func() { exited <- cmd.Wait() }()
|
||||
|
||||
var seen strings.Builder
|
||||
buf := make([]byte, 4096)
|
||||
waitFor := func(markers []string, budget time.Duration) {
|
||||
deadline := time.Now().Add(budget)
|
||||
for time.Now().Before(deadline) {
|
||||
plainNow := semantic.StripANSI(seen.String())
|
||||
found := false
|
||||
for _, marker := range markers {
|
||||
if strings.Contains(plainNow, marker) {
|
||||
found = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if found {
|
||||
return
|
||||
}
|
||||
select {
|
||||
case err := <-exited:
|
||||
t.Fatalf("face exited (rc=%v) waiting for %v — output:\n%.2000s",
|
||||
err, markers, semantic.StripANSI(seen.String()))
|
||||
default:
|
||||
}
|
||||
if err := master.SetReadDeadline(time.Now().Add(1 * time.Second)); err != nil {
|
||||
t.Fatalf("pty read deadline: %v", err)
|
||||
}
|
||||
n, err := master.Read(buf)
|
||||
if n > 0 {
|
||||
seen.Write(buf[:n])
|
||||
}
|
||||
if err != nil && !os.IsTimeout(err) {
|
||||
t.Fatalf("pty read: %v — output:\n%.2000s", err,
|
||||
semantic.StripANSI(seen.String()))
|
||||
}
|
||||
}
|
||||
_ = cmd.Process.Kill()
|
||||
<-exited
|
||||
t.Fatalf("never saw any of %v within %v — output:\n%.2000s",
|
||||
markers, budget, semantic.StripANSI(seen.String()))
|
||||
}
|
||||
|
||||
waitFor([]string{"┌"}, 240*time.Second)
|
||||
|
||||
// 2. PIN PERSISTENCE (boot leg): open the tasks pane's region via
|
||||
// the /tree road — the pre-written pin must render.
|
||||
if _, err := master.Write([]byte("/tree\r")); err != nil {
|
||||
t.Fatalf("/tree write: %v", err)
|
||||
}
|
||||
waitFor([]string{"pinned (1)"}, 60*time.Second)
|
||||
plain := semantic.StripANSI(seen.String())
|
||||
if !strings.Contains(plain, "keep the reflow squash test green") {
|
||||
t.Fatalf("the pin's plain-english summary must render:\n%.2000s", plain)
|
||||
}
|
||||
|
||||
// 1. ENTER DISPATCH under the OPEN region: focus tasks, type the
|
||||
// demand, enter. The admission surface is real (the library seam);
|
||||
// its honest verdict — delegated, queued, or the honest transport
|
||||
// refusal — must land. Silence would be the stolen enter.
|
||||
if _, err := master.Write([]byte("2")); err != nil {
|
||||
t.Fatalf("focus write: %v", err)
|
||||
}
|
||||
time.Sleep(2 * time.Second)
|
||||
waitFor([]string{"task entry"}, 30*time.Second)
|
||||
if _, err := master.Write([]byte("wire the stream\r")); err != nil {
|
||||
t.Fatalf("demand write: %v", err)
|
||||
}
|
||||
waitFor([]string{"work queued (", "work started:", "work demand not admitted", "no task-queue surface on this seam"}, 60*time.Second)
|
||||
_ = cmd.Process.Kill()
|
||||
<-exited
|
||||
}
|
||||
@@ -0,0 +1,136 @@
|
||||
package main
|
||||
|
||||
// d52_picker_window_test.go — the D52 model-picker WINDOW law (#2567,
|
||||
// owner spec): clicking the info bar's model token opens a SEPARATE
|
||||
// CENTERED window that is fully selectable and searchable, split
|
||||
// CLOUD and LOCAL sections — type-to-filter, up/down through results,
|
||||
// enter selects, the sections labelled. Keyboard parity: ctrl+m keeps
|
||||
// working; the window road is the click. NO crossfire: a model-token
|
||||
// click never opens the activity (thinking) window, and a + click
|
||||
// never opens the picker.
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/runtime/lib"
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
func pickerFixture(t *testing.T) model {
|
||||
t.Helper()
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
m.prov = &providerSelection{Provider: "local", Model: "qwen3.6-27b"}
|
||||
m.provOpts = []lib.ModelRow{
|
||||
{ID: "gpt-4o-mini", OwnedBy: "openai"},
|
||||
{ID: "claude-sonnet-4", OwnedBy: "anthropic"},
|
||||
{ID: "qwen2.5:7b", OwnedBy: "ollama"},
|
||||
{ID: "llava:7b", OwnedBy: "ollama"},
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
// TestPickerWindowSplitsCloudAndLocal — the picker's rendered rows
|
||||
// carry the CLOUD and LOCAL section labels, the cloud rows first in
|
||||
// the cloud section, locals under LOCAL, and the selection cursor
|
||||
// walks BOTH sections as one list.
|
||||
func TestPickerWindowSplitsCloudAndLocal(t *testing.T) {
|
||||
m := pickerFixture(t)
|
||||
m.openPicker()
|
||||
rows := m.face.MenuSnapshot()
|
||||
joined := strings.Join(rows, "\n")
|
||||
cloudIdx := strings.Index(joined, "CLOUD")
|
||||
localIdx := strings.Index(joined, "LOCAL")
|
||||
if cloudIdx < 0 || localIdx < 0 {
|
||||
t.Fatalf("the picker window must carry CLOUD and LOCAL sections:\n%s", joined)
|
||||
}
|
||||
if cloudIdx > localIdx {
|
||||
t.Fatal("CLOUD section renders before LOCAL")
|
||||
}
|
||||
gpt := strings.Index(joined, "gpt-4o-mini")
|
||||
qwen := strings.Index(joined, "qwen2.5:7b")
|
||||
if !(cloudIdx < gpt && gpt < localIdx && localIdx < qwen) {
|
||||
t.Fatalf("cloud rows must sit in the CLOUD section, locals in LOCAL:\n%s", joined)
|
||||
}
|
||||
}
|
||||
|
||||
// TestPickerWindowFilterWalksEnterChooses — the window is fully
|
||||
// selectable and searchable: typing filters across both sections,
|
||||
// up/down walks the filtered rows, enter records the pick and closes.
|
||||
func TestPickerWindowFilterWalksEnterChooses(t *testing.T) {
|
||||
m := pickerFixture(t)
|
||||
m.openPicker()
|
||||
// type to filter
|
||||
next, _ := m.Update(tea.KeyPressMsg{Code: 'q'})
|
||||
m2 := next.(model)
|
||||
rows := m2.pickerRows()
|
||||
if len(rows) == 0 || !strings.Contains(rows[0].ID, "qwen") {
|
||||
t.Fatalf("typing must filter the rows, got %+v", rows)
|
||||
}
|
||||
// enter chooses the filtered row
|
||||
pick := rows[m2.pickerSel]
|
||||
next, _ = m2.Update(tea.KeyPressMsg{Code: tea.KeyEnter})
|
||||
m3 := next.(model)
|
||||
if m3.pickerOpen {
|
||||
t.Fatal("enter must close the picker window")
|
||||
}
|
||||
if m3.prov == nil || m3.prov.Model != pick.ID {
|
||||
t.Fatalf("enter must record the pick, got %+v", m3.prov)
|
||||
}
|
||||
}
|
||||
|
||||
// TestModelTokenClickNoCrossfire — the D52 dispatch law: a click on
|
||||
// the model token opens the PICKER and NEVER the activity window; a
|
||||
// click on the + affordance opens the ACTIVITY window and never the
|
||||
// picker. Both roads, both windows, one assertion each way.
|
||||
func TestModelTokenClickNoCrossfire(t *testing.T) {
|
||||
m := pickerFixture(t)
|
||||
x0, w := modelTokenXRange(m)
|
||||
y := m.face.Snapshot().H
|
||||
next, _ := m.Update(tea.MouseClickMsg{X: x0 + w/2, Y: y})
|
||||
m2 := next.(model)
|
||||
if !m2.pickerOpen {
|
||||
t.Fatal("the model-token click must open the picker window")
|
||||
}
|
||||
if m2.face.ActivityWindowOpen() {
|
||||
t.Fatal("CROSSFIRE: the model-token click must NOT open the activity (thinking) window")
|
||||
}
|
||||
// the + road: the face's + region click toggles the activity
|
||||
// window and must not open the picker
|
||||
m3 := pickerFixture(t)
|
||||
fr := m3.face.Render()
|
||||
var reg semantic.Region
|
||||
for _, r := range fr.Regions {
|
||||
if r.ID == "mouse.activity.plus" {
|
||||
reg = r
|
||||
}
|
||||
}
|
||||
next, _ = m3.Update(tea.MouseClickMsg{X: reg.X, Y: reg.Y})
|
||||
m4 := next.(model)
|
||||
if !m4.face.ActivityWindowOpen() {
|
||||
t.Fatal("the + click must open the activity window")
|
||||
}
|
||||
if m4.pickerOpen {
|
||||
t.Fatal("CROSSFIRE: the + click must NOT open the picker")
|
||||
}
|
||||
}
|
||||
|
||||
// TestCtrlMParity — keyboard parity: ctrl+m still opens the picker
|
||||
// window (the window road is the click; ctrl+m keeps working).
|
||||
func TestCtrlMParity(t *testing.T) {
|
||||
m := pickerFixture(t)
|
||||
next, _ := m.Update(tea.KeyPressMsg{Code: 'm', Mod: tea.ModCtrl})
|
||||
m2 := next.(model)
|
||||
if !m2.pickerOpen && !m2.menuOpen {
|
||||
t.Fatal("ctrl+m must keep opening the model chooser")
|
||||
}
|
||||
// its rendered chooser carries the split sections too
|
||||
m3 := pickerFixture(t)
|
||||
m3.openPicker()
|
||||
joined := strings.Join(m3.face.MenuSnapshot(), "\n")
|
||||
if !strings.Contains(joined, "CLOUD") || !strings.Contains(joined, "LOCAL") {
|
||||
t.Fatalf("the ctrl+m road shares the split window:\n%s", joined)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,74 @@
|
||||
package main
|
||||
|
||||
// d53_agents_shell_test.go — the SUB-AGENTS wave's shell leg (Gitea
|
||||
// #2568 item 7): keyboard parity ('w' opens the centered window when
|
||||
// agents are in flight, the window is modal: esc/up/down/enter,
|
||||
// any other key closes) and the flight-free no-op.
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"rune.dev/rune/tui/lanes"
|
||||
)
|
||||
|
||||
func withAgentsInFlight(m model) model {
|
||||
m.face.SetWaveAgents(2, []lanes.AgentView{
|
||||
{ID: "w1", Title: "land the scrollbar wave", State: "BUILD",
|
||||
Detail: []string{"journal: admit green"}},
|
||||
{ID: "w2", Title: "polish the composer hints", State: "VERIFY"},
|
||||
})
|
||||
return m
|
||||
}
|
||||
|
||||
func TestCtrlWOpensAgentsWindowInFlight(t *testing.T) {
|
||||
m := withAgentsInFlight(initialModel())
|
||||
nx, _ := m.Update(ctrlKey("w"))
|
||||
if !nx.(model).face.AgentsWindowOpen() {
|
||||
t.Fatal("ctrl+w must open the agents window while agents are in flight")
|
||||
}
|
||||
}
|
||||
|
||||
func TestCtrlWNoopWithoutFlight(t *testing.T) {
|
||||
m := initialModel()
|
||||
nx, _ := m.Update(ctrlKey("w"))
|
||||
if nx.(model).face.AgentsWindowOpen() {
|
||||
t.Fatal("ctrl+w without a flight must not open any window")
|
||||
}
|
||||
}
|
||||
|
||||
func TestAgentsWindowModalKeys(t *testing.T) {
|
||||
m := withAgentsInFlight(initialModel())
|
||||
nx, _ := m.Update(ctrlKey("w"))
|
||||
m2 := nx.(model)
|
||||
// down walks the cursor
|
||||
nx, _ = m2.Update(keyPress("down"))
|
||||
m2 = nx.(model)
|
||||
// esc closes
|
||||
nx, _ = m2.Update(keyPress("esc"))
|
||||
m2 = nx.(model)
|
||||
if m2.face.AgentsWindowOpen() {
|
||||
t.Fatal("esc must close the agents window")
|
||||
}
|
||||
// any other key closes the modal too
|
||||
nx, _ = withAgentsInFlight(m).Update(keyPress("w"))
|
||||
m2 = nx.(model)
|
||||
nx, _ = m2.Update(keyPress("x"))
|
||||
m2 = nx.(model)
|
||||
if m2.face.AgentsWindowOpen() {
|
||||
t.Fatal("any other key must close the modal window")
|
||||
}
|
||||
}
|
||||
|
||||
func TestAgentsWindowOverlayCentersInFrame(t *testing.T) {
|
||||
m := withAgentsInFlight(initialModel())
|
||||
nx, _ := m.Update(ctrlKey("w"))
|
||||
m2 := nx.(model)
|
||||
v := m2.View()
|
||||
content := v.Content
|
||||
if !strings.Contains(content, "sub agents") || !strings.Contains(content, "land the scrollbar wave") {
|
||||
t.Fatalf("the rendered frame must carry the centered agents window")
|
||||
}
|
||||
if !strings.Contains(content, "journal: admit green") {
|
||||
t.Fatalf("the selected agent's detail must render")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,52 @@
|
||||
package main
|
||||
|
||||
// d53_quithint_test.go — the QUIT WARNING (Gitea #2568 item 3,
|
||||
// red-first): after the FIRST ctrl+c of the D46 exit gesture a soft
|
||||
// hint "press ctrl+c again to quit" rides near the shift+enter key
|
||||
// hint (the composer's hint line). The hint disappears when the arm
|
||||
// window times out or ANY other key arrives. The SECOND ctrl+c never
|
||||
// shows it — that press quits.
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
const wantQuitHint = "press ctrl+c again to quit"
|
||||
|
||||
func composerHintOf(m model) string {
|
||||
return m.face.Hint()
|
||||
}
|
||||
|
||||
func TestFirstCtrlCShowsQuitHint(t *testing.T) {
|
||||
nx, _ := initialModel().Update(ctrlKey("c"))
|
||||
got := composerHintOf(nx.(model))
|
||||
if !strings.Contains(got, wantQuitHint) {
|
||||
t.Fatalf("after the first ctrl+c the composer hint must carry the quit warning, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestQuitHintClearsOnTimeout(t *testing.T) {
|
||||
nx, _ := initialModel().Update(ctrlKey("c"))
|
||||
// the arm window's own reset message (the 1s tea.Tick payload)
|
||||
nx, _ = nx.Update(ctrlCArmReset{})
|
||||
got := composerHintOf(nx.(model))
|
||||
if strings.Contains(got, wantQuitHint) {
|
||||
t.Fatalf("the quit hint must disappear when the arm window times out, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestQuitHintClearsOnAnyOtherKey(t *testing.T) {
|
||||
nx, _ := initialModel().Update(ctrlKey("c"))
|
||||
nx, _ = nx.Update(keyPress("x"))
|
||||
got := composerHintOf(nx.(model))
|
||||
if strings.Contains(got, wantQuitHint) {
|
||||
t.Fatalf("the quit hint must disappear on any other key, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSecondCtrlCQuitsWithoutHint(t *testing.T) {
|
||||
nx, _ := initialModel().Update(ctrlKey("c"))
|
||||
if !quits(t, nx.(model), ctrlKey("c")) {
|
||||
t.Fatal("the second ctrl+c must quit (the D46 gesture holds)")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,81 @@
|
||||
package main
|
||||
|
||||
// d53_reflow_test.go — the DYNAMIC REFLOW wave (Gitea #2568 item 4,
|
||||
// red-first): driving a resize event through the face chain must
|
||||
// re-wrap every bubble and box at the new width — the squash test: NO
|
||||
// rendered line may exceed the new width and NO stale width may
|
||||
// survive (a line wider than the pane, or a box edge left at the old
|
||||
// geometry, is a clip).
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/chatpane"
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
// frameLinesWidths renders the model's face and reports any line
|
||||
// wider than w.
|
||||
func overwideLines(t *testing.T, m model, w int) []string {
|
||||
t.Helper()
|
||||
f := m.face.Render()
|
||||
var bad []string
|
||||
for i, ln := range strings.Split(f.Content, "\n") {
|
||||
if n := len([]rune(semantic.StripANSI(ln))); n > w {
|
||||
bad = append(bad, fmt.Sprintf("line %d is %d cols: %q", i, n, ln[:min(60, len(ln))]))
|
||||
}
|
||||
}
|
||||
return bad
|
||||
}
|
||||
|
||||
func TestWindowSquashReflowsEveryBlock(t *testing.T) {
|
||||
m := initialModel()
|
||||
long := ""
|
||||
for i := 0; i < 10; i++ {
|
||||
long += fmt.Sprintf("## Heading %d\n\nParagraph %d with plenty of words to wrap several times at any pane width the squash test picks.\n\n- bullet one %d\n- bullet two %d\n\n", i, i, i, i)
|
||||
}
|
||||
m.face.AppendChat(chatpane.Message{ID: "a1", Role: chatpane.RoleAssistant, Content: long})
|
||||
m.face.Resize(120, 30)
|
||||
if bad := overwideLines(t, m, 120); len(bad) > 0 {
|
||||
t.Fatalf("at width 120: %v", bad)
|
||||
}
|
||||
// the squash: drive the resize event through the face chain
|
||||
nx, _ := m.Update(tea.WindowSizeMsg{Width: 44, Height: 20})
|
||||
m2 := nx.(model)
|
||||
if bad := overwideLines(t, m2, 44); len(bad) > 0 {
|
||||
t.Fatalf("after squash to 44: %v", bad)
|
||||
}
|
||||
// and back out: the geometry must follow the new width again
|
||||
nx, _ = m2.Update(tea.WindowSizeMsg{Width: 100, Height: 30})
|
||||
m3 := nx.(model)
|
||||
if bad := overwideLines(t, m3, 100); len(bad) > 0 {
|
||||
t.Fatalf("after regrow to 100: %v", bad)
|
||||
}
|
||||
}
|
||||
|
||||
func TestWindowSquashKeepsScrollStateLegal(t *testing.T) {
|
||||
m := initialModel()
|
||||
for i := 0; i < 40; i++ {
|
||||
m.face.AppendChat(chatpane.Message{ID: fmt.Sprintf("a%d", i), Role: chatpane.RoleAssistant,
|
||||
Content: fmt.Sprintf("body line of transcript prose %d", i)})
|
||||
}
|
||||
m.face.Resize(120, 30)
|
||||
m.face.Render() // establish the scroll geometry (the last-render state)
|
||||
m.face.ScrollChatUp(10)
|
||||
if got := m.face.ChatScrollOffset(); got != 10 {
|
||||
t.Fatalf("offset must survive the pre-squash scroll, got %d", got)
|
||||
}
|
||||
nx, _ := m.Update(tea.WindowSizeMsg{Width: 40, Height: 16})
|
||||
m2 := nx.(model)
|
||||
// the reflow changes line counts; the offset must normalize to a
|
||||
// legal window (never past the oldest held line, never negative)
|
||||
if off := m2.face.ChatScrollOffset(); off < 0 {
|
||||
t.Fatalf("offset went negative after squash: %d", off)
|
||||
}
|
||||
if bad := overwideLines(t, m2, 40); len(bad) > 0 {
|
||||
t.Fatalf("after squash: %v", bad)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,64 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"os"
|
||||
|
||||
"regexp"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// D54 item 6 (Gitea #2571): THE LITERAL-LANGUAGE AUDIT — face strings
|
||||
// (affordances, notices, placeholders, hints) use literal language:
|
||||
// no idioms, no figures of speech. This frozen audit scans the TUI's
|
||||
// user-facing string sites for the idioms the audit found and
|
||||
// rewrote:
|
||||
//
|
||||
// BEFORE: "consent enqueue in flight — wait for its receipt"
|
||||
// AFTER: "consent enqueue being processed now — wait for its receipt"
|
||||
// BEFORE: "one completion in flight — phase 1 sends one at a time"
|
||||
// AFTER: "one completion being processed now — ..."
|
||||
// BEFORE: "approval resolution in flight — wait for its receipt"
|
||||
// AFTER: "approval resolution being processed now — ..."
|
||||
// BEFORE: "the engine answered without a verdict" (legal metaphor)
|
||||
// AFTER: "the engine answered without a clear result"
|
||||
// BEFORE: "↑/↓ walk · enter choose" ("walk" a list)
|
||||
// AFTER: "↑/↓ move · enter choose"
|
||||
// BEFORE: "(none in flight)" (the + window's empty sections)
|
||||
// AFTER: "(none now)"
|
||||
// BEFORE: "state %s · %02d:%02d in flight" (the wave detail line)
|
||||
// AFTER: "state %s · running %02d:%02d"
|
||||
//
|
||||
// Kept (term of art, not idiom): "seam" (the wiring seam — the
|
||||
// synthesis itself cites "no task seam wired — work demand not sent"
|
||||
// as good literal style), "brief" (the work record's name), "card"
|
||||
// (the approval component's name).
|
||||
func TestFaceStringsAreLiteral(t *testing.T) {
|
||||
banned := []string{"in flight", "without a verdict", "walk · enter"}
|
||||
sites := []string{
|
||||
"main.go",
|
||||
"../../lanes/activity.go",
|
||||
"../../chatpane/chatpane.go",
|
||||
"../../chatpane/blocks.go",
|
||||
}
|
||||
strLit := regexp.MustCompile(`"(?:[^"\\]|\\.)*"`)
|
||||
for _, site := range sites {
|
||||
b, err := os.ReadFile(site)
|
||||
if err != nil {
|
||||
t.Fatalf("read %s: %v", site, err)
|
||||
}
|
||||
for lineNo, line := range strings.Split(string(b), "\n") {
|
||||
if strings.HasPrefix(strings.TrimSpace(line), "//") {
|
||||
continue // comments are not face
|
||||
}
|
||||
for _, m := range strLit.FindAllString(line, -1) {
|
||||
low := strings.ToLower(m)
|
||||
for _, phrase := range banned {
|
||||
if strings.Contains(low, phrase) {
|
||||
t.Fatalf("%s:%d: idiom %q in a face string — rewrite literally (%q)", site, lineNo+1, phrase, m)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,92 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/runtime/lib"
|
||||
"rune.dev/rune/tui/taskqueue"
|
||||
)
|
||||
|
||||
// D50 residual 3 (#2560, owner ruling): the tasks pane's row-selection/
|
||||
// navigation mode is REMOVED — the walker (up/down/j/k over tree rows,
|
||||
// the cursor, the row boxes) is gone, and the tree region is a VIEW
|
||||
// that never owns the keys. Enter on tasks-pane focus starts direct
|
||||
// task execution (D44 doctrine) — EVEN after a click-focus that opened
|
||||
// the tree region.
|
||||
func TestD50TasksFocusEnterDispatchesAfterClickFocus(t *testing.T) {
|
||||
configuredHome(t)
|
||||
bootCompleter = &queueSeamFake{}
|
||||
defer func() { bootCompleter = nil }()
|
||||
|
||||
m := sized(t, initialModel(), 110, 30)
|
||||
m2, _ := m.Update(keyPress("2"))
|
||||
m = m2.(model)
|
||||
// the click-focus road: the tree region shows (the pane click /
|
||||
// palette road opened it). The walker is gone — the region is a
|
||||
// view, and it must never own the keyboard.
|
||||
m.face.SetTreeOpen(true)
|
||||
if m.composerActive() != true {
|
||||
t.Fatal("the tree region is a view now (no selectable rows): it must not own the keyboard — the composer stays active")
|
||||
}
|
||||
for _, r := range "wire the stream" {
|
||||
next, _ := m.Update(keyPress(string(r)))
|
||||
m = next.(model)
|
||||
}
|
||||
if got := m.taskInput.Text(); got != "wire the stream" {
|
||||
t.Fatalf("typing under the open tree region must reach the shared box, got %q", m.taskInput.Text())
|
||||
}
|
||||
m2, cmd := m.Update(enterPress())
|
||||
m = m2.(model)
|
||||
if cmd == nil {
|
||||
t.Fatal("enter with tasks focus must dispatch the work demand immediately, even with the tree region open")
|
||||
}
|
||||
var msg tea.Msg
|
||||
for _, mm := range runBatch(cmd) {
|
||||
msg = mm
|
||||
}
|
||||
if _, ok := msg.(taskDemandMsg); !ok {
|
||||
t.Fatalf("the cmd must answer a taskDemandMsg, got %T", msg)
|
||||
}
|
||||
m2, _ = m.Update(msg)
|
||||
m = m2.(model)
|
||||
if got := m.face.QueueNotice(); !strings.Contains(got, "work queued (") {
|
||||
t.Fatalf("the honest queue receipt missing, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
// up/down under tasks focus no longer walk rows (the walker is
|
||||
// removed) — they scroll the tasks panel's own scroll window.
|
||||
func TestD50TasksArrowsScrollNotWalk(t *testing.T) {
|
||||
configuredHome(t)
|
||||
m := sized(t, initialModel(), 110, 30)
|
||||
m2, _ := m.Update(keyPress("2"))
|
||||
m = m2.(model)
|
||||
m.face.SetTreeOpen(true)
|
||||
// seed panel overflow so the scroll window has room (40 fresh rows)
|
||||
queue := make([]taskqueue.Entry, 0, 40)
|
||||
for i := 0; i < 40; i++ {
|
||||
queue = append(queue, taskqueue.Entry{EntryID: fmt.Sprintf("q%02d", i),
|
||||
Text: fmt.Sprintf("demand %02d", i),
|
||||
QueuedAt: time.Now().Add(-time.Duration(i) * time.Minute)})
|
||||
}
|
||||
m.face.SetLiveWork(nil, queue, time.Now())
|
||||
m.face.Render()
|
||||
before := m.face.TasksScrollOffset()
|
||||
m2, _ = m.Update(keyPress("up"))
|
||||
m = m2.(model)
|
||||
if m.face.TasksScrollOffset() == before {
|
||||
t.Fatal("up under tasks focus must scroll the tasks panel (the row walker is removed)")
|
||||
}
|
||||
m2, _ = m.Update(keyPress("down"))
|
||||
m = m2.(model)
|
||||
if m.face.TasksScrollOffset() != before {
|
||||
t.Fatalf("down must return the scroll window to rest, got %d want %d", m.face.TasksScrollOffset(), before)
|
||||
}
|
||||
}
|
||||
|
||||
var _ = lib.TaskEnqueueRequest{}
|
||||
@@ -191,3 +191,16 @@ func TestOSCDetectionDenylist(t *testing.T) {
|
||||
t.Error("KONSOLE_VERSION must stay a carrier fast path")
|
||||
}
|
||||
}
|
||||
|
||||
// D53 #2568 item 5: the context readout carries the usage percentage
|
||||
// in brackets, computed from the existing used/limit pair.
|
||||
func TestCtxPercent(t *testing.T) {
|
||||
for _, c := range []struct {
|
||||
used, limit int64
|
||||
want int
|
||||
}{{4200, 32768, 12}, {16384, 32768, 50}, {32768, 32768, 100}, {40000, 32768, 100}, {0, 32768, 0}, {100, 0, 0}} {
|
||||
if got := ctxPercent(c.used, c.limit); got != c.want {
|
||||
t.Errorf("ctxPercent(%d,%d) = %d, want %d", c.used, c.limit, got, c.want)
|
||||
}
|
||||
}
|
||||
}
|
||||
+520
-75
@@ -157,16 +157,19 @@ type model struct {
|
||||
// is the dichotomy build wave). The box renders the FOCUSED
|
||||
// machine's view; typed keys keep routing by focus exactly as
|
||||
// before (composerActive: only chat focus types).
|
||||
composer *nav.Input3
|
||||
taskInput *nav.Input3
|
||||
km *nav.KeyMap
|
||||
disp *laneconc.Dispatcher
|
||||
chatBusy bool
|
||||
lastCtrlC bool // the exit-gesture arm: second ctrl+c quits (D46)
|
||||
chatSt string // "" (never sent) | sending | waiting | received | error
|
||||
pendingSent string // the in-flight text (the waiting leg's match)
|
||||
spin int // the animation frame (the glyph cycle's index)
|
||||
blink int // the composer cursor's blink phase (D43.14)
|
||||
composer *nav.Input3
|
||||
taskInput *nav.Input3
|
||||
km *nav.KeyMap
|
||||
disp *laneconc.Dispatcher
|
||||
chatBusy bool
|
||||
lastCtrlC bool // the exit-gesture arm: second ctrl+c quits (D46)
|
||||
chatSt string // "" (never sent) | sending | waiting | received | error
|
||||
// chatStreamBuf is the running total of the streamed turn's text
|
||||
// (Gitea #2556): each delta renders into the progressive bubble.
|
||||
chatStreamBuf string
|
||||
pendingSent string // the in-flight text (the waiting leg's match)
|
||||
spin int // the animation frame (the glyph cycle's index)
|
||||
blink int // the composer cursor's blink phase (D43.14)
|
||||
// turnStart feeds the identity line's mm:ss turn duration (D41:
|
||||
// durations — how long things take — stay visible while a turn
|
||||
// flies).
|
||||
@@ -188,6 +191,7 @@ type model struct {
|
||||
styleIdx int
|
||||
tickArmed bool
|
||||
reducedMotion bool
|
||||
calm bool
|
||||
|
||||
// THE SCAFFOLDING STATUS LINE layer's shell state (D43 addendum 5):
|
||||
// the walk frame (advanced on the shared ~500ms heartbeat) and the
|
||||
@@ -276,6 +280,19 @@ type model struct {
|
||||
consentHub *consent.Hub
|
||||
consentCard *consent.Card
|
||||
consentBusy bool
|
||||
|
||||
// THE SELECTION LAYER (#2532): the drag-selection's display state
|
||||
// (selection.go) — anchor/head/pane. Shell-owned display state,
|
||||
// never face state.
|
||||
sel selState
|
||||
|
||||
// hintWord is the slash word the cursor is parked on (a new word
|
||||
// resets the selection to the first row).
|
||||
hintWord string
|
||||
// hintSel is the '/'-command submenu's selection cursor (D50 item
|
||||
// 5, #2555-7): up/down move it over the matching hint rows, enter
|
||||
// runs the highlighted command. 0 rests on the first row.
|
||||
hintSel int
|
||||
}
|
||||
|
||||
func initialModel() model {
|
||||
@@ -313,6 +330,14 @@ func initialModel() model {
|
||||
// style as the default variant.
|
||||
m.gaugesView = gauges.New(time.Now().UnixNano())
|
||||
m.reducedMotion = os.Getenv("RUNE_REDUCED_MOTION") != ""
|
||||
// D54 item 5 (#2571): the sensory setting — VIVID is the DEFAULT
|
||||
// (the owner's ruling); calm mutes the chroma at the token layer
|
||||
// and closes the activity wave's motion gate. The settings store
|
||||
// owns the key (themes.sensory); the env seam RUNE_SENSORY=calm
|
||||
// is the boot-time carrier, same shape as RUNE_REDUCED_MOTION.
|
||||
m.calm = os.Getenv("RUNE_SENSORY") == "calm"
|
||||
chatpane.ApplyCalm(m.calm)
|
||||
lanes.ApplyCalm(m.calm)
|
||||
if root := lib.DefaultRepoRoot(); root != "" {
|
||||
m.fwave = factorywave.New(root, factorywave.DefaultEvery).Start()
|
||||
m.syncWaves()
|
||||
@@ -329,6 +354,9 @@ func initialModel() model {
|
||||
// absent or corrupt record answers the old TUI's default 8; a
|
||||
// deeper record deepens the bridge's poll window with it.
|
||||
m.bootDepth = loadHistoryDepth(m.home)
|
||||
// the PINNED WORK hot-state record (D50 residual 4): the pins
|
||||
// survive the boot — the record loads beside the history depth.
|
||||
m.face.SetPins(loadPins(m.home))
|
||||
if m.rt != nil {
|
||||
m.rt.SetChatDepth(m.bootDepth)
|
||||
}
|
||||
@@ -352,6 +380,22 @@ type chatCompletionMsg struct {
|
||||
text string
|
||||
}
|
||||
|
||||
// chatStreamStartMsg opens the progressive-render leg of a dispatch
|
||||
// (Gitea #2556): deltas arrive over the channel while the completion
|
||||
// goroutine runs; the report lands through done when the turn settles.
|
||||
type chatStreamStartMsg struct {
|
||||
deltas <-chan string
|
||||
done <-chan laneconc.LaneReport
|
||||
text string
|
||||
}
|
||||
|
||||
// chatStreamDeltaMsg is one streamed text chunk: the running total
|
||||
// renders into the chat pane's progressive bubble immediately.
|
||||
type chatStreamDeltaMsg struct {
|
||||
start chatStreamStartMsg
|
||||
delta string
|
||||
}
|
||||
|
||||
// approvalReceiptMsg is one answered approval decision (the K20
|
||||
// pattern's resolve leg): the Update thread armed the decision, the
|
||||
// goroutine POSTed /v1/approvals/resolve off-thread, this message
|
||||
@@ -473,21 +517,55 @@ func dispatchProviderClass(m model) string {
|
||||
}
|
||||
|
||||
// chatDispatch runs one composer send through the lane spine off the
|
||||
// Update thread (the K20 pattern): the ctx carries the WHOLE-TURN
|
||||
// budget for the provider class (D47 defect 3 — a dispatched
|
||||
// completion runs the core's tool loop, up to ToolLoopIterations model
|
||||
// calls; #2536: locals get the extended class budget, cloud the
|
||||
// shorter one). No face mutation happens here; the goroutine only
|
||||
// touches the seam.
|
||||
// Update thread (the K20 pattern) — STREAMING (Gitea #2556, the
|
||||
// streaming root-cause wave): the dispatch rides stream=true, the
|
||||
// answer's bytes surface through the lane dispatcher's delta sink, and
|
||||
// the Update thread renders each chunk as it lands. The streamed turn
|
||||
// retires the flat whole-turn budgets: the ctx binds the 30-minute
|
||||
// backstop only — the CORE's inter-chunk idle timeout is the real
|
||||
// deadline (no bytes = genuinely dead). No face mutation happens in
|
||||
// the goroutines; they only touch the seam.
|
||||
func chatDispatch(m model, text string) tea.Cmd {
|
||||
deltas := make(chan string, 256)
|
||||
done := make(chan laneconc.LaneReport, 1)
|
||||
return func() tea.Msg {
|
||||
ctx, cancel := context.WithTimeout(context.Background(), lib.TurnBudgetFor(dispatchProviderClass(m)))
|
||||
ctx, cancel := context.WithTimeout(context.Background(), streamDispatchBackstop)
|
||||
defer cancel()
|
||||
rep, _ := m.disp.Dispatch(ctx, laneconc.Chat, text)
|
||||
return chatCompletionMsg{rep: rep, text: text}
|
||||
m.disp.SetDeltaSink(func(lane laneconc.Lane, s string) {
|
||||
if lane == laneconc.Chat {
|
||||
select {
|
||||
case deltas <- s:
|
||||
default: // the render thread keeps up; never block the stream
|
||||
}
|
||||
}
|
||||
})
|
||||
go func() {
|
||||
defer close(deltas)
|
||||
rep, _ := m.disp.Dispatch(ctx, laneconc.Chat, text)
|
||||
done <- rep
|
||||
}()
|
||||
return chatStreamStartMsg{deltas: deltas, done: done, text: text}
|
||||
}
|
||||
}
|
||||
|
||||
// awaitStream is the streaming receive loop as tea commands: each
|
||||
// delta returns its message and re-arms; the closing report lands as
|
||||
// the classic chatCompletionMsg.
|
||||
func awaitStream(start chatStreamStartMsg) tea.Cmd {
|
||||
return func() tea.Msg {
|
||||
delta, ok := <-start.deltas
|
||||
if ok {
|
||||
return chatStreamDeltaMsg{start: start, delta: delta}
|
||||
}
|
||||
return chatCompletionMsg{rep: <-start.done, text: start.text}
|
||||
}
|
||||
}
|
||||
|
||||
// streamDispatchBackstop mirrors the core's StreamTurnBackstop: the
|
||||
// TUI's dispatch ctx on the streamed path is a runaway guard only —
|
||||
// the inter-chunk idle timeout lives at the core (Gitea #2556).
|
||||
const streamDispatchBackstop = 30 * time.Minute
|
||||
|
||||
// composerActive reports whether the composer owns the next key: no
|
||||
// chrome boundary (tree region, promote region, rail takeover, modal)
|
||||
// owns the keys. D36 owner fix 2026-10-19: the shared box is the SINGLE
|
||||
@@ -555,6 +633,23 @@ type ctrlCArmReset struct{}
|
||||
|
||||
const spinPeriod = 500 * time.Millisecond
|
||||
|
||||
// quitHint is the D53 quit warning (Gitea #2568 item 3): the soft
|
||||
// hint the FIRST ctrl+c installs near the shift+enter line — literal
|
||||
// wording, no idiom (the D54 literal-language law). Cleared by the
|
||||
// arm timeout or any other key; the SECOND press quits and never
|
||||
// shows it.
|
||||
const quitHint = "press ctrl+c again to quit"
|
||||
|
||||
// restoreComposerHint puts the live key hint back after the quit
|
||||
// warning clears (the hint stays live across rebinds — the spec's
|
||||
// discoverability law).
|
||||
func (m *model) restoreComposerHint() {
|
||||
if m.composer == nil {
|
||||
return
|
||||
}
|
||||
m.face.SetComposer(composerView(m.composer), m.composer.Placeholder(), m.composer.Hint(m.km))
|
||||
}
|
||||
|
||||
// spinTick schedules the next shared-tick frame (the thinking walk,
|
||||
// the gauges shimmer, the wave marker, and the composer cursor's
|
||||
// blink all ride this one heartbeat — D41).
|
||||
@@ -659,7 +754,7 @@ func (m *model) applyTaskDemand(msg taskDemandMsg) {
|
||||
m.face.SetQueueNotice(fmt.Sprintf("work queued (#%d): %s", msg.res.Position, msg.dem))
|
||||
default:
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleError,
|
||||
Content: "work demand neither delegated nor queued — the engine answered without a verdict"})
|
||||
Content: "work demand neither delegated nor queued — the engine answered without a clear result"})
|
||||
}
|
||||
}
|
||||
|
||||
@@ -674,7 +769,7 @@ func (m *model) consentAnswer() tea.Cmd {
|
||||
}
|
||||
if m.consentBusy {
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleSystem,
|
||||
Content: "consent enqueue in flight — wait for its receipt"})
|
||||
Content: "consent enqueue being processed now — wait for its receipt"})
|
||||
return nil
|
||||
}
|
||||
b, ok := m.consentHub.Answer()
|
||||
@@ -757,7 +852,7 @@ func (m *model) applyConsentEnqueue(msg consentEnqueueMsg) {
|
||||
msg.res.Position, msg.brief.SnapshotID, refs, msg.brief.BriefText))
|
||||
default:
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleError,
|
||||
Content: "consented work neither delegated nor queued — the engine answered without a verdict"})
|
||||
Content: "consented work neither delegated nor queued — the engine answered without a clear result"})
|
||||
}
|
||||
}
|
||||
|
||||
@@ -794,7 +889,7 @@ func (m *model) dispatchSend(sent string) tea.Cmd {
|
||||
if m.chatBusy {
|
||||
m.face.DropChatThinking()
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleError,
|
||||
Content: "one completion in flight — phase 1 sends one at a time; wait for the reply"})
|
||||
Content: "one completion being processed now — phase 1 sends one at a time; wait for the reply"})
|
||||
return nil
|
||||
}
|
||||
m.chatBusy = true
|
||||
@@ -820,6 +915,7 @@ func (m *model) applyChatReport(msg chatCompletionMsg) {
|
||||
if msg.rep.Err != nil {
|
||||
m.chatSt = "error"
|
||||
m.face.DropChatThinking()
|
||||
m.face.DropStreamChat() // the partial render goes with the honest error
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleError,
|
||||
Content: fmt.Sprintf("dispatch failed: %v", msg.rep.Err)})
|
||||
m.syncActivity() // the turn ended: the pane rests (idle)
|
||||
@@ -897,6 +993,12 @@ func (m *model) syncActivity() {
|
||||
}
|
||||
}
|
||||
m.face.SetActivity(sig, m.spin)
|
||||
// MOTION LAW (D54 #2571 item 1): the activity pane's wave runs
|
||||
// only when motion is allowed — reduced motion closes the gate
|
||||
// (calm mode closes it too; D54 item 5). The chat pane never
|
||||
// animates; at most ONE region of the face animates per frame
|
||||
// (the law is written at the Update loop's heartbeat).
|
||||
m.face.SetActivityMotionAllowed(m.activityMotionAllowed())
|
||||
label := ""
|
||||
if st := m.face.ActivityState(); st != lanes.ActivityIdle {
|
||||
label = string(st)
|
||||
@@ -1212,27 +1314,59 @@ func (m model) pickerRows() []lib.ModelRow {
|
||||
}
|
||||
|
||||
// refreshPicker installs the picker's overlay lines (view-only above
|
||||
// the composer — the band slot the menu used).
|
||||
// the composer — the band slot the menu used). The D52 window law
|
||||
// (#2567): the centered picker is split into labelled CLOUD and LOCAL
|
||||
// sections — cloud rows first, locals under LOCAL — one walkable list
|
||||
// over both.
|
||||
func (m *model) refreshPicker() {
|
||||
rows := m.pickerRows()
|
||||
if m.pickerSel >= len(rows) {
|
||||
m.pickerSel = max(len(rows)-1, 0)
|
||||
}
|
||||
var out []string
|
||||
out = append(out, fmt.Sprintf("pick a model · type to filter (%d) · ↑/↓ walk · enter choose · esc keeps your text", len(rows)))
|
||||
out = append(out, fmt.Sprintf("pick a model · type to filter (%d) · ↑/↓ move · enter choose · esc keeps your text", len(rows)))
|
||||
if len(rows) == 0 {
|
||||
out = append(out, " no models match — backspace to widen")
|
||||
}
|
||||
for i, r := range rows {
|
||||
// the walkable index counts ALL rows (both sections) so ↑/↓/enter
|
||||
// behave exactly as before — the sections are presentation.
|
||||
walked := 0
|
||||
cloud, local := splitRowsCloudLocal(rows)
|
||||
out = append(out, "CLOUD")
|
||||
for _, r := range cloud {
|
||||
mark := " "
|
||||
if i == m.pickerSel {
|
||||
if walked == m.pickerSel {
|
||||
mark = "> "
|
||||
}
|
||||
out = append(out, mark+fmt.Sprintf("%d) %s", i+1, r.ID))
|
||||
out = append(out, mark+fmt.Sprintf("%d) %s", walked+1, r.ID))
|
||||
walked++
|
||||
}
|
||||
out = append(out, "LOCAL")
|
||||
for _, r := range local {
|
||||
mark := " "
|
||||
if walked == m.pickerSel {
|
||||
mark = "> "
|
||||
}
|
||||
out = append(out, mark+fmt.Sprintf("%d) %s", walked+1, r.ID))
|
||||
walked++
|
||||
}
|
||||
m.face.SetMenu(out)
|
||||
}
|
||||
|
||||
// splitRowsCloudLocal partitions the picker rows into the cloud
|
||||
// provider family and the local binding family (the D52 window law's
|
||||
// two labelled sections).
|
||||
func splitRowsCloudLocal(rows []lib.ModelRow) (cloud, local []lib.ModelRow) {
|
||||
for _, r := range rows {
|
||||
if isCloudProvider(r.OwnedBy) {
|
||||
cloud = append(cloud, r)
|
||||
} else {
|
||||
local = append(local, r)
|
||||
}
|
||||
}
|
||||
return cloud, local
|
||||
}
|
||||
|
||||
// pickerKeys handles the keys while the picker holds them: typing
|
||||
// filters, arrows walk, enter chooses, esc dismisses-keeps-draft,
|
||||
// digits jump. ok=false lets the key fall through (the composer types
|
||||
@@ -1522,15 +1656,21 @@ func slashMatches(text string) []int {
|
||||
// slashHintLines renders the '/'-command overlay above the input box:
|
||||
// the filtered candidates with the top match marked, or the honest
|
||||
// no-match line.
|
||||
func slashHintLines(text string) []string {
|
||||
func slashHintLines(text string, sel int) []string {
|
||||
matches := slashMatches(text)
|
||||
if len(matches) == 0 {
|
||||
return []string{"no matching command — backspace to edit"}
|
||||
}
|
||||
if sel < 0 {
|
||||
sel = 0
|
||||
}
|
||||
if sel >= len(matches) {
|
||||
sel = len(matches) - 1
|
||||
}
|
||||
var out []string
|
||||
for j, i := range matches {
|
||||
mark := " "
|
||||
if j == 0 {
|
||||
if j == sel {
|
||||
mark = "> "
|
||||
}
|
||||
out = append(out, fmt.Sprintf("%s%s — %s", mark, slashVocabulary[i].slash, slashVocabulary[i].desc))
|
||||
@@ -1538,6 +1678,23 @@ func slashHintLines(text string) []string {
|
||||
return out
|
||||
}
|
||||
|
||||
// slashHintSelected returns the vocabulary id under the submenu's
|
||||
// selection cursor for the typed slash text ("" when nothing matches).
|
||||
func (m *model) slashHintSelected(text string) string {
|
||||
matches := slashMatches(strings.SplitN(text, " ", 2)[0])
|
||||
if len(matches) == 0 {
|
||||
return ""
|
||||
}
|
||||
sel := m.hintSel
|
||||
if sel < 0 {
|
||||
sel = 0
|
||||
}
|
||||
if sel >= len(matches) {
|
||||
sel = len(matches) - 1
|
||||
}
|
||||
return slashVocabulary[matches[sel]].id
|
||||
}
|
||||
|
||||
// runSlash executes one '/'-leading send: an exact or unique-prefix
|
||||
// match runs through the SAME executor as the palette; anything else
|
||||
// restores the text for editing and says so in the overlay (the send
|
||||
@@ -1716,9 +1873,9 @@ func (m *model) refreshOverlay() {
|
||||
default:
|
||||
m.face.SetMenu(nil)
|
||||
}
|
||||
text := m.composer.Text()
|
||||
text := m.focusedInput().Text()
|
||||
if !m.paletteOpen() && !m.menuOpen && strings.HasPrefix(text, "/") {
|
||||
m.face.SetHints(slashHintLines(strings.SplitN(text, " ", 2)[0]))
|
||||
m.face.SetHints(slashHintLines(strings.SplitN(text, " ", 2)[0], m.hintSel))
|
||||
return
|
||||
}
|
||||
m.face.SetHints(nil)
|
||||
@@ -1803,7 +1960,7 @@ func (m *model) resolveApproval(approved bool) tea.Cmd {
|
||||
}
|
||||
if m.apprvBusy {
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleSystem,
|
||||
Content: "approval resolution in flight — wait for its receipt"})
|
||||
Content: "approval resolution being processed now — wait for its receipt"})
|
||||
return nil
|
||||
}
|
||||
if bootResolver == nil {
|
||||
@@ -1875,7 +2032,23 @@ func (m *model) closeApprovalCard() {
|
||||
m.refreshOverlay()
|
||||
}
|
||||
|
||||
// activityMotionAllowed reports whether the activity wave may run
|
||||
// (the D54 MOTION LAW gate, #2571 item 1): reduced motion closes it;
|
||||
// calm mode closes it too (D54 item 5).
|
||||
func (m model) activityMotionAllowed() bool {
|
||||
return !m.reducedMotion && !m.calm
|
||||
}
|
||||
|
||||
func (m model) Init() tea.Cmd {
|
||||
// THE ONE-ANIMATING-REGION LAW (D54 #2571 item 1, documented at
|
||||
// the face chain's Update loop, which owns the frame tick): at
|
||||
// most ONE region of the face animates per frame. The activity
|
||||
// strip is that region while it waves (gated by
|
||||
// activityMotionAllowed); when the scaffold line animates it
|
||||
// holds the region and the other animations rest (the
|
||||
// arbitration bit, canon P3). The chat pane NEVER animates —
|
||||
// its law is written at tui/chatpane/blocks.go and asserted
|
||||
// append-only in the scroll/blocks tests.
|
||||
if m.reducedMotion {
|
||||
return nil // reduced motion: the cursor rests lit, no heartbeat
|
||||
}
|
||||
@@ -1973,9 +2146,21 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
}
|
||||
}
|
||||
return m, nil
|
||||
case chatStreamStartMsg:
|
||||
// the streamed turn opens: the progressive bubble installs and
|
||||
// the receive loop arms (Gitea #2556).
|
||||
m.face.StreamChat("")
|
||||
return m, awaitStream(msg)
|
||||
case chatStreamDeltaMsg:
|
||||
// the answer renders AS IT ARRIVES: the running total replaces
|
||||
// the streaming bubble's content.
|
||||
m.chatStreamBuf += msg.delta
|
||||
m.face.StreamChat(m.chatStreamBuf)
|
||||
return m, awaitStream(msg.start)
|
||||
case chatCompletionMsg:
|
||||
// the lane spine answered a chat dispatch: the reply (or the
|
||||
// honest error) lands in the transcript; the state clears.
|
||||
m.chatStreamBuf = ""
|
||||
m.applyChatReport(msg)
|
||||
return m, nil
|
||||
case taskDemandMsg:
|
||||
@@ -2007,6 +2192,19 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.refreshComposer()
|
||||
}
|
||||
return m, nil
|
||||
case ctrlCArmReset:
|
||||
// THE ARM TIMEOUT (D46 + D53 #2568 item 3): the exit window
|
||||
// closed — the gesture disarms and the quit warning clears.
|
||||
// (This case must live at the switch top level: the message is
|
||||
// not a KeyPressMsg, and the in-case check the D46 code carried
|
||||
// was unreachable — the warning never cleared on timeout.)
|
||||
if m.lastCtrlC {
|
||||
nm := m
|
||||
nm.lastCtrlC = false
|
||||
nm.restoreComposerHint()
|
||||
return nm, nil
|
||||
}
|
||||
return m, nil
|
||||
case tea.KeyPressMsg:
|
||||
if msg.String() == "ctrl+c" {
|
||||
// THE EXIT GESTURE (owner ruling D46 addendum): the FIRST
|
||||
@@ -2019,24 +2217,22 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
nm.lastCtrlC = true
|
||||
if m.composer != nil {
|
||||
nm.composer.SetText("")
|
||||
nm.face.SetComposer(composerView(nm.composer), nm.composer.Placeholder(), nm.composer.Hint(nm.km))
|
||||
// THE QUIT WARNING (D53 #2568 item 3): the first press
|
||||
// swaps the key hint for the soft quit warning near the
|
||||
// shift+enter line; any other key or the timeout
|
||||
// restores it. The second press never shows it — that
|
||||
// press quits.
|
||||
nm.face.SetComposer(composerView(nm.composer), nm.composer.Placeholder(), quitHint)
|
||||
}
|
||||
return nm, tea.Tick(time.Second, func(time.Time) tea.Msg {
|
||||
return ctrlCArmReset{}
|
||||
})
|
||||
}
|
||||
if _, ok := any(msg).(ctrlCArmReset); ok {
|
||||
if m.lastCtrlC {
|
||||
nm := m
|
||||
nm.lastCtrlC = false
|
||||
return nm, nil
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
{ // any non-ctrl+c key disarms the double-press window
|
||||
if m.lastCtrlC {
|
||||
nm := m
|
||||
nm.lastCtrlC = false
|
||||
nm.restoreComposerHint()
|
||||
m = nm
|
||||
}
|
||||
}
|
||||
@@ -2051,6 +2247,30 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
// THE SUB-AGENTS WINDOW (D53 #2568 item 7): keyboard parity
|
||||
// with the section's click road. ctrl+w opens the centered
|
||||
// window when agents are in flight (a CONTROL key — plain
|
||||
// letters always type, the q-law); while it is open it is MODAL —
|
||||
// esc closes, up/down walk the rows, enter toggles the
|
||||
// selected agent's detail — and every other key closes it
|
||||
// (a modal that traps typing is a trap).
|
||||
if m.face.AgentsWindowOpen() {
|
||||
switch msg.String() {
|
||||
case "esc":
|
||||
m.face.CloseAgentsWindow()
|
||||
case "up":
|
||||
m.face.AgentsSelMove(-1)
|
||||
case "down":
|
||||
m.face.AgentsSelMove(1)
|
||||
default:
|
||||
m.face.CloseAgentsWindow()
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
if msg.String() == "ctrl+w" && m.face.WaveAgentsCount() > 0 {
|
||||
m.face.ToggleAgentsWindow()
|
||||
return m, nil
|
||||
}
|
||||
// THE ACTIVITY + WINDOW (A6, keyboard parity per the
|
||||
// tabs/windows canon): ctrl+a toggles the centered turn
|
||||
// window; esc closes it while it holds the keyboard. A modal
|
||||
@@ -2085,6 +2305,19 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.face.SetSteerOpen(true)
|
||||
return m, nil
|
||||
}
|
||||
// THE PIN VERB's keyboard parity (D50 residual 4): ctrl+b pins
|
||||
// the top live work block into the tasks pane's reserved pinned
|
||||
// area, persisted through the hot-state store (tasks_pins.json).
|
||||
// A control key per the D36 letter law, reachable while composing.
|
||||
if msg.String() == "ctrl+b" {
|
||||
if _, ok := m.face.PinTopWork(); ok {
|
||||
if err := savePins(m.home, m.face.Pins()); err != nil {
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleError,
|
||||
Content: "pin not persisted: " + err.Error()})
|
||||
}
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
// ctrl+g raises/lowers the GAUGES window (D41: progress is a
|
||||
// callable overlay — never embedded in the task pane); esc
|
||||
// closes it (handled before anything else can claim the key)
|
||||
@@ -2272,32 +2505,83 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
return m, nil
|
||||
}
|
||||
}
|
||||
// chat-transcript scrollback (the /history law's live leg):
|
||||
// ctrl+up/ctrl+down walk the scroll window line-wise,
|
||||
// pgup/pgdown page-wise — control-page keys, reachable while
|
||||
// composing (the ctrl+t precedent); a scroll that CANNOT
|
||||
// move (the oldest held row, or nothing older held) grows
|
||||
// the bridge's poll window for the deeper page.
|
||||
// THE '/'-COMMAND SUBMENU (D50 item 5, #2555-7): while the
|
||||
// slash hints show (a '/'-leading draft, no other overlay),
|
||||
// up/down move the selection over the matching rows and
|
||||
// enter runs the HIGHLIGHTED command — the palette's
|
||||
// ↑/↓/enter law, carried to the inline '/' road.
|
||||
if !strings.HasPrefix(m.focusedInput().Text(), "/") {
|
||||
m.hintSel = 0
|
||||
} else if word := strings.SplitN(m.focusedInput().Text(), " ", 2)[0]; word != m.hintWord {
|
||||
m.hintWord = word
|
||||
m.hintSel = 0
|
||||
} else if m.hintSel > 0 && len(slashMatches(word)) == 0 {
|
||||
m.hintSel = 0
|
||||
}
|
||||
if !m.paletteOpen() && !m.menuOpen &&
|
||||
strings.HasPrefix(m.focusedInput().Text(), "/") &&
|
||||
len(slashMatches(strings.SplitN(m.focusedInput().Text(), " ", 2)[0])) > 0 {
|
||||
switch msg.String() {
|
||||
case "up":
|
||||
m.hintSel--
|
||||
if m.hintSel < 0 {
|
||||
m.hintSel = 0
|
||||
}
|
||||
m.refreshOverlay()
|
||||
return m, nil
|
||||
case "down":
|
||||
if n := len(slashMatches(strings.SplitN(m.focusedInput().Text(), " ", 2)[0])); m.hintSel < n-1 {
|
||||
m.hintSel++
|
||||
}
|
||||
m.refreshOverlay()
|
||||
return m, nil
|
||||
case "enter":
|
||||
if id := m.slashHintSelected(m.focusedInput().Text()); id != "" {
|
||||
arg := ""
|
||||
if _, rest, ok := strings.Cut(m.focusedInput().Text(), " "); ok {
|
||||
arg = rest
|
||||
}
|
||||
m.focusedInput().Clear()
|
||||
m.refreshOverlay()
|
||||
return m, m.runCommand(id, arg)
|
||||
}
|
||||
}
|
||||
}
|
||||
// SCROLLBACK (#2535, D50-1: each pane scrolls INDIVIDUALLY
|
||||
// with its own scroll state): ctrl+up/ctrl+down walk the
|
||||
// FOCUSED pane's scroll window line-wise, pgup/pgdown
|
||||
// page-wise — the chat pane's transcript or the tasks
|
||||
// pane's panel, never both. A chat scroll that CANNOT move
|
||||
// grows the bridge's poll window for the deeper page.
|
||||
switch msg.String() {
|
||||
case "ctrl+up":
|
||||
if !m.face.ScrollChatUp(1) {
|
||||
case "ctrl+up", "pgup":
|
||||
if m.face.Snapshot().Focus == semantic.FocusTasks {
|
||||
m.face.TasksScrollUp(pageStepOf(msg.String()))
|
||||
return m, nil
|
||||
}
|
||||
moved := false
|
||||
if msg.String() == "pgup" {
|
||||
moved = m.face.PageChatUp()
|
||||
} else {
|
||||
moved = m.face.ScrollChatUp(1)
|
||||
}
|
||||
if !moved {
|
||||
m.growChatHistory()
|
||||
}
|
||||
m.face.TouchScroll() // the scrollbar layer lights (D43)
|
||||
return m, nil
|
||||
case "ctrl+down":
|
||||
m.face.ScrollChatDown(1)
|
||||
m.face.TouchScroll() // the scrollbar layer lights (D43)
|
||||
return m, nil
|
||||
case "pgup":
|
||||
if !m.face.PageChatUp() {
|
||||
m.growChatHistory()
|
||||
case "ctrl+down", "pgdown":
|
||||
if m.face.Snapshot().Focus == semantic.FocusTasks {
|
||||
m.face.TasksScrollDown(pageStepOf(msg.String()))
|
||||
return m, nil
|
||||
}
|
||||
if msg.String() == "pgdown" {
|
||||
m.face.PageChatDown()
|
||||
} else {
|
||||
m.face.ScrollChatDown(1)
|
||||
}
|
||||
m.face.TouchScroll() // the scrollbar layer lights (D43)
|
||||
return m, nil
|
||||
case "pgdown":
|
||||
m.face.PageChatDown()
|
||||
return m, nil
|
||||
}
|
||||
// input-territory editing and history keys (the old-TUI
|
||||
// HistoryInput contract, adopted 2026-10-18 + owner defect
|
||||
@@ -2308,8 +2592,16 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
if k, ok := inputEditKey(msg.String()); ok {
|
||||
if m.face.Snapshot().Focus == semantic.FocusTasks &&
|
||||
(msg.String() == "up" || msg.String() == "down") {
|
||||
// the tree's arrows (the tree region swallows or
|
||||
// walks them; ChromeOpen gates that)
|
||||
// D50 residual 3: the row walker is removed — the
|
||||
// arrows scroll the tasks panel's own scroll window
|
||||
// (#2535) instead of walking rows.
|
||||
if msg.String() == "up" {
|
||||
m.face.TasksScrollUp(1)
|
||||
} else {
|
||||
m.face.TasksScrollDown(1)
|
||||
}
|
||||
m.face.TouchScroll()
|
||||
return m, nil
|
||||
} else {
|
||||
m.focusedInput().Input(k, m.km)
|
||||
m.refreshComposer()
|
||||
@@ -2325,7 +2617,8 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
// (both gated above this block), so only the letter
|
||||
// case reaches here. Other chain-owned chrome keys
|
||||
// (rail r, promote p/s/u, tree t, ...) route the chain.
|
||||
if key.String() != "y" && chainOwnsKey(m, key) {
|
||||
if key.String() != "y" && chainOwnsKey(m, key) &&
|
||||
!(m.composerActive() && composerOwnsRune(m, key)) {
|
||||
// chain-owned chrome key: fall through to the chain
|
||||
} else {
|
||||
m.focusedInput().Input(key, m.km)
|
||||
@@ -2434,6 +2727,14 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.applyApprovalReceipt(msg)
|
||||
return m, nil
|
||||
case tea.MouseClickMsg:
|
||||
// THE SELECTION LAYER (#2532): a left press inside a text
|
||||
// pane starts a drag selection (the release copies via OSC 52
|
||||
// when the drag moved); chrome that owns the mouse (picker,
|
||||
// palette, cards) never starts one. The face's own click
|
||||
// routing still runs — a press that never moves is a click.
|
||||
if msg.Button == tea.MouseLeft && !m.chromeOwnsMouse() {
|
||||
m.selStart(msg.X, msg.Y, m.face.Render().Regions)
|
||||
}
|
||||
// the T5 card's mouse leg: the y/n buttons' regions resolve
|
||||
// FIRST (the card is a decision boundary), then the face
|
||||
// chain's own regions — the shell adds no other click
|
||||
@@ -2491,6 +2792,62 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.face.Click(msg.X, msg.Y)
|
||||
m.syncFocusSignage(focusBefore)
|
||||
return m, nil
|
||||
case tea.MouseWheelMsg:
|
||||
// SCROLLBACK (#2535, D50-1): the wheel scrolls the pane under
|
||||
// the pointer — chat transcript or tasks panel, each its own
|
||||
// scroll state. A chat wheel past the oldest held row grows
|
||||
// the bridge's poll window for the deeper page.
|
||||
up := msg.Button == tea.MouseWheelUp
|
||||
down := msg.Button == tea.MouseWheelDown
|
||||
if !up && !down {
|
||||
return m, nil
|
||||
}
|
||||
for _, r := range m.face.Render().Regions {
|
||||
if msg.X < r.X || msg.X >= r.X+r.W || msg.Y < r.Y || msg.Y >= r.Y+r.H {
|
||||
continue
|
||||
}
|
||||
switch r.ID {
|
||||
case "region.chat":
|
||||
moved := false
|
||||
if up {
|
||||
moved = m.face.ScrollChatUp(3)
|
||||
if !moved {
|
||||
m.growChatHistory()
|
||||
}
|
||||
} else {
|
||||
moved = m.face.ScrollChatDown(3)
|
||||
}
|
||||
if moved {
|
||||
m.face.TouchScroll()
|
||||
}
|
||||
case "region.tasks", "region.tasks.tree":
|
||||
if up {
|
||||
m.face.TasksScrollUp(3)
|
||||
} else {
|
||||
m.face.TasksScrollDown(3)
|
||||
}
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
return m, nil
|
||||
case tea.MouseMotionMsg:
|
||||
// the #2532 drag-select's motion leg: while the left button
|
||||
// holds and the drag started in a text pane, the head follows
|
||||
// the pointer (clamped to the pane). Motion alone never routes
|
||||
// the face.
|
||||
if msg.Button == tea.MouseLeft && m.sel.inFlight() {
|
||||
m.selMove(msg.X, msg.Y, m.face.Render().Regions)
|
||||
}
|
||||
return m, nil
|
||||
case tea.MouseReleaseMsg:
|
||||
// the #2532 drag-select's release leg: the highlight's text
|
||||
// copies via OSC 52 (capability-gated, direct emission) and
|
||||
// the highlight clears. A collapsed drag (a plain click)
|
||||
// copies nothing.
|
||||
if msg.Button == tea.MouseLeft && m.sel.inFlight() {
|
||||
m.selFinish(m.face.Render().Content, os.Stdout)
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
@@ -2504,6 +2861,15 @@ func (m model) View() tea.View {
|
||||
if m.face.ActivityWindowOpen() {
|
||||
content = m.overlayActivityWindow(content)
|
||||
}
|
||||
// THE SUB-AGENTS WINDOW (D53 #2568 item 7): the centered overlay
|
||||
// listing all in-flight agents, the selected row's detail beneath
|
||||
// (the D52 picker window pattern; the + window's centered shape).
|
||||
if m.face.AgentsWindowOpen() {
|
||||
content = m.overlayAgentsWindow(content)
|
||||
}
|
||||
// the #2532 drag highlight overlays the frame while the drag is
|
||||
// in flight (selection.go — shell display state, never a pane).
|
||||
content = m.overlaySelection(content)
|
||||
var b strings.Builder
|
||||
b.WriteString(content)
|
||||
b.WriteString("\n")
|
||||
@@ -2520,10 +2886,11 @@ func (m model) View() tea.View {
|
||||
// must DISAPPEAR — the terminal restores the pre-boot command line,
|
||||
// never a ghost of the last frame). Alt-screen draws the face on
|
||||
// the terminal's separate screen buffer; quitting restores the
|
||||
// main screen exactly as it was. Mouse cell-motion stays on for
|
||||
// the selection law's click leg (D29/TD-4).
|
||||
// main screen exactly as it was. ALL-motion mouse stays on: the
|
||||
// selection law's click leg (D29/TD-4) and the #2532 drag-select
|
||||
// (motion events while the button holds).
|
||||
v.AltScreen = true
|
||||
v.MouseMode = tea.MouseModeCellMotion
|
||||
v.MouseMode = tea.MouseModeAllMotion
|
||||
return v
|
||||
}
|
||||
|
||||
@@ -2546,10 +2913,12 @@ func semverOf(v string) string {
|
||||
return v
|
||||
}
|
||||
|
||||
// ctxToken renders the context-window readout (D43.12): "context 4.2k/32k"
|
||||
// — the engine's used tokens against the model's registry limit. Owner
|
||||
// ruling 2026-10-19: the full word, not the abbreviation. An engine that
|
||||
// has not reported (offline face, unknown model) renders nothing — the
|
||||
// ctxToken renders the context-window readout (D43.12): "context
|
||||
// 4.2k/32k (13%)" — the engine's used tokens against the model's
|
||||
// registry limit, with the usage percentage in brackets (D53 #2568
|
||||
// item 5, computed from the existing used/limit pair). Owner ruling
|
||||
// 2026-10-19: the full word, not the abbreviation. An engine that has
|
||||
// not reported (offline face, unknown model) renders nothing — the
|
||||
// bar never guesses.
|
||||
func ctxToken(m model) string {
|
||||
used, limit := int64(0), int64(0)
|
||||
@@ -2559,7 +2928,22 @@ func ctxToken(m model) string {
|
||||
if used <= 0 || limit <= 0 {
|
||||
return ""
|
||||
}
|
||||
return fmt.Sprintf(" · context %s/%s", compactTokens(used), compactTokens(limit))
|
||||
return fmt.Sprintf(" · context %s/%s (%d%%)", compactTokens(used), compactTokens(limit), ctxPercent(used, limit))
|
||||
}
|
||||
|
||||
// ctxPercent is the usage percentage: integer 0-100, floor-rounded.
|
||||
func ctxPercent(used, limit int64) int {
|
||||
if limit <= 0 {
|
||||
return 0
|
||||
}
|
||||
p := used * 100 / limit
|
||||
if p < 0 {
|
||||
return 0
|
||||
}
|
||||
if p > 100 {
|
||||
return 100
|
||||
}
|
||||
return int(p)
|
||||
}
|
||||
|
||||
// versionToken renders the info bar's version segment (D43 addendum 6
|
||||
@@ -2952,6 +3336,46 @@ func (m model) overlayActivityWindow(content string) string {
|
||||
return strings.Join(lines, "\n")
|
||||
}
|
||||
|
||||
// overlayAgentsWindow draws THE SUB-AGENTS WINDOW (D53 #2568 item 7)
|
||||
// CENTERED over the face: all in-flight agents, the selected row's
|
||||
// thought process / recent activity beneath — the D52 picker window
|
||||
// pattern (centered, sections, walkable) on the + window's shape.
|
||||
func (m model) overlayAgentsWindow(content string) string {
|
||||
lines := strings.Split(content, "\n")
|
||||
w := 0
|
||||
for _, l := range lines {
|
||||
if n := len([]rune(semantic.StripANSI(l))); n > w {
|
||||
w = n
|
||||
}
|
||||
}
|
||||
ww := min(72, max(w-8, 20))
|
||||
rows := m.face.AgentsWindowLines(ww)
|
||||
if len(rows) == 0 {
|
||||
return content
|
||||
}
|
||||
title := " sub agents · esc closes "
|
||||
box := make([]string, 0, len(rows)+2)
|
||||
topRow := "╭" + title + strings.Repeat("─", max(ww+2-len([]rune(title)), 0)) + "╮"
|
||||
box = append(box, topRow)
|
||||
for _, r := range rows {
|
||||
r = cutDisplay(r, ww)
|
||||
pad := max(ww-len([]rune(semantic.StripANSI(r))), 0)
|
||||
box = append(box, "│ "+r+strings.Repeat(" ", pad)+" │")
|
||||
}
|
||||
box = append(box, "╰"+strings.Repeat("─", ww+2)+"╯")
|
||||
bh := len(box)
|
||||
y0 := max((len(lines)-1-bh)/2, 1)
|
||||
left := max((w-(ww+4))/2, 0)
|
||||
for i, row := range box {
|
||||
y := y0 + i
|
||||
if y < 0 || y >= len(lines) {
|
||||
continue
|
||||
}
|
||||
lines[y] = cutDisplay(lines[y], left) + padDisplay(row, left+displayWidth(row), w)
|
||||
}
|
||||
return strings.Join(lines, "\n")
|
||||
}
|
||||
|
||||
// clipActivity keeps the first n display columns of a window row,
|
||||
// closing any SGR run the cut interrupts.
|
||||
func clipActivity(line string, n int) string { return cutDisplay(line, n) }
|
||||
@@ -3053,6 +3477,17 @@ func (m *model) syncWaves() {
|
||||
Count: fl.Count,
|
||||
Rows: waveRows(lib.DefaultRepoRoot(), fl),
|
||||
})
|
||||
// THE SUB-AGENTS SECTION (D53 #2568 item 7): the SAME flight
|
||||
// observation installs the activity pane's "sub agents being
|
||||
// processed now" section — the section can never disagree with
|
||||
// the rail marker or the wave tab (one poller, one number). The
|
||||
// rows carry the journal + observations detail waveRows derived.
|
||||
rows := waveRows(lib.DefaultRepoRoot(), fl)
|
||||
avs := make([]lanes.AgentView, 0, len(rows))
|
||||
for _, r := range rows {
|
||||
avs = append(avs, lanes.AgentView{ID: r.ID, Title: r.Title, State: r.State, Detail: r.Detail})
|
||||
}
|
||||
m.face.SetWaveAgents(fl.Count, avs)
|
||||
}
|
||||
|
||||
// waveRows derives one row per in-flight wave from the durable
|
||||
@@ -3111,7 +3546,7 @@ func waveDetail(w factory.Wave, events []factory.JournalEvent, obs map[string][]
|
||||
var out []string
|
||||
if t, err := time.Parse("2006-01-02T15:04:05Z", w.CreatedAt); err == nil {
|
||||
d := time.Since(t).Round(time.Second)
|
||||
out = append(out, fmt.Sprintf("state %s · %02d:%02d in flight", w.Phase,
|
||||
out = append(out, fmt.Sprintf("state %s · running %02d:%02d", w.Phase,
|
||||
int(d.Minutes()), int(d.Seconds())%60))
|
||||
} else {
|
||||
out = append(out, "state "+w.Phase)
|
||||
@@ -3206,8 +3641,8 @@ var styleVariants = []struct {
|
||||
style chatpane.Style
|
||||
}{
|
||||
{"amalgamation", chatpane.DefaultStyle()},
|
||||
{"quiet typeset", chatpane.Style{Bubbles: false, Vocab: chatpane.Vocab, Accent: "#FF79C6"}},
|
||||
{"full futhark", chatpane.Style{Bubbles: true, Vocab: chatpane.VocabFull(), Accent: "#FF79C6"}},
|
||||
{"quiet typeset", chatpane.Style{Bubbles: false, Vocab: chatpane.Vocab, Accent: themes.RoleHex(themes.RoleSpeaker)}},
|
||||
{"full futhark", chatpane.Style{Bubbles: true, Vocab: chatpane.VocabFull(), Accent: themes.RoleHex(themes.RoleSpeaker)}},
|
||||
}
|
||||
|
||||
// applyStyle installs variant i on the transcript.
|
||||
@@ -3271,7 +3706,8 @@ func main() {
|
||||
printBuildID(os.Stdout)
|
||||
return
|
||||
}
|
||||
wireOSCDetection() // the version hyperlink's real-terminal detection
|
||||
wireOSCDetection() // the version hyperlink's real-terminal detection
|
||||
wireOSC52Detection() // the selection copy's real-terminal detection (#2532)
|
||||
bootCheck = update.DefaultCheck
|
||||
// D38: the ledger section reads the task markdown ledger through
|
||||
// the library seam — the same directory the serve surface
|
||||
@@ -3305,3 +3741,12 @@ func main() {
|
||||
os.Exit(1)
|
||||
}
|
||||
}
|
||||
|
||||
// pageStepOf maps a scroll key spelling to its step (line keys 1,
|
||||
// page keys one visible page — the chat pane's pageStep shape).
|
||||
func pageStepOf(spelling string) int {
|
||||
if strings.HasPrefix(spelling, "pg") {
|
||||
return 20
|
||||
}
|
||||
return 1
|
||||
}
|
||||
@@ -22,6 +22,7 @@ import (
|
||||
"rune.dev/rune/tui/chatpane"
|
||||
"rune.dev/rune/tui/runtime/lib"
|
||||
"rune.dev/rune/tui/semantic"
|
||||
"rune.dev/rune/tui/tasks"
|
||||
)
|
||||
|
||||
func keyPress(s string) tea.KeyPressMsg {
|
||||
@@ -52,6 +53,15 @@ func sized(t *testing.T, m model, w, h int) model {
|
||||
return next.(model)
|
||||
}
|
||||
|
||||
// labSeeded swaps the shell's production face for the LAB-seeded one
|
||||
// (D52 supersession, #2566): production boots EMPTY now, so the
|
||||
// selection-law proofs that drive the canonical three-box substrate
|
||||
// ask for the seed explicitly — the seeds stay confined to the lab.
|
||||
func labSeeded(m model) model {
|
||||
m.face = tasks.NewSeeded(80, 24)
|
||||
return m
|
||||
}
|
||||
|
||||
// quits reports whether sending msg to the model produces a quit command.
|
||||
func quits(t *testing.T, m model, msg tea.Msg) bool {
|
||||
t.Helper()
|
||||
@@ -243,7 +253,9 @@ func TestTabSwitchesLaneFocus(t *testing.T) {
|
||||
// on the LAST task row (reverse ring entry), further presses walk the
|
||||
// ring, and the wrap returns to the chat pane.
|
||||
func TestShiftTabCyclesBoxes(t *testing.T) {
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
// D52 supersession (#2566): the box-selection law drives the
|
||||
// canonical seed substrate — the lab seed is explicit here.
|
||||
m := labSeeded(sized(t, initialModel(), 80, 24))
|
||||
next, _ := m.Update(shiftTabPress())
|
||||
st := next.(model).face.Snapshot()
|
||||
if st.Focus != semantic.FocusTasks || st.Sel != 2 {
|
||||
@@ -272,7 +284,8 @@ func TestShiftTabCyclesBoxes(t *testing.T) {
|
||||
// through the face chain's own regions and selects that row; typing
|
||||
// then lands on the lit row (y approves the clicked task).
|
||||
func TestMouseClickSelectsBox(t *testing.T) {
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
// D52 supersession (#2566): the seed substrate is explicit (lab).
|
||||
m := labSeeded(sized(t, initialModel(), 80, 24))
|
||||
reg := semantic.Region{}
|
||||
for _, r := range m.face.Render().Regions {
|
||||
if r.ID == "mouse.nav.jump.2" {
|
||||
@@ -302,24 +315,16 @@ func TestMouseClickSelectsBox(t *testing.T) {
|
||||
if st = mm.face.Snapshot(); st.Tasks[2].Approved {
|
||||
t.Fatalf("y typed a letter (no card open) — it must not approve: %+v", st.Tasks)
|
||||
}
|
||||
// empty the composer — the keys hand back to the tree (the
|
||||
// letter-stealing law's other half: an emptied composer is not
|
||||
// input territory, so the arrows can walk the cursor)
|
||||
// D50 residual 3 (owner ruling): the row walker is REMOVED — the
|
||||
// arrows no longer walk tree rows; the semantic selection stands.
|
||||
next, _ = next.(model).Update(tea.KeyPressMsg{Code: tea.KeyBackspace})
|
||||
mm = next.(model)
|
||||
if got := mm.taskInput.Text(); got != "" {
|
||||
t.Fatalf("backspace did not empty the task composer: %q", got)
|
||||
}
|
||||
// arrows move the tree cursor — REAL arrow keys (the synthetic-
|
||||
// spelling law: the old keyPress("down") spelled Code='d' with
|
||||
// Text "down" and its tail branch asserted nothing at all)
|
||||
next, _ = mm.Update(arrowPress(tea.KeyUp))
|
||||
if st = next.(model).face.Snapshot(); st.Sel != 1 {
|
||||
t.Fatalf("up arrow: sel=%d, want 1 (the tree cursor walks back)", st.Sel)
|
||||
}
|
||||
next, _ = next.(model).Update(arrowPress(tea.KeyDown))
|
||||
if st = next.(model).face.Snapshot(); st.Sel != 2 {
|
||||
t.Fatalf("down arrow: sel=%d, want 2 (the tree cursor walks forward)", st.Sel)
|
||||
t.Fatalf("up arrow: sel=%d, want 2 (the row walker is removed; selection stands)", st.Sel)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -386,7 +391,9 @@ func TestRailOpensTakeoverAndRestoresLanes(t *testing.T) {
|
||||
// once the region is closed. (Setup: the composer owns typed runes on
|
||||
// the chat pane, so p runs from the tasks focus — 2.)
|
||||
func TestPromoteRegionWalk(t *testing.T) {
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
// D52 supersession (#2566): the hold/queue walk drives the seed
|
||||
// substrate — the lab seed is explicit here.
|
||||
m := labSeeded(sized(t, initialModel(), 80, 24))
|
||||
m2, _ := m.Update(keyPress("2"))
|
||||
// D36 owner fix: p is a letter now — the region opens
|
||||
// programmatically (the shell's ctrl+p is the palette, frozen D34).
|
||||
@@ -775,7 +782,7 @@ func TestComposerOneInFlight(t *testing.T) {
|
||||
if cmd2 != nil {
|
||||
t.Fatal("second send during flight must NOT dispatch")
|
||||
}
|
||||
if txt := chatBubbleText(m); !strings.Contains(txt, "one completion in flight") {
|
||||
if txt := chatBubbleText(m); !strings.Contains(txt, "one completion being processed now") {
|
||||
t.Fatalf("busy bubble missing:\n%s", txt)
|
||||
}
|
||||
}
|
||||
@@ -830,13 +837,24 @@ func TestComposerStaysOffChromeKeys(t *testing.T) {
|
||||
t.Fatalf("t must type into the shared box (D36 owner fix), got %q", got)
|
||||
}
|
||||
m.face.SetTreeOpen(true)
|
||||
// D50 residual 3: the tree region is a VIEW (the walker is removed)
|
||||
// — it never owns the keys, the composer stays active under it.
|
||||
if m.face.ChromeOpen() {
|
||||
t.Fatal("the tree region must not count as chrome (D50: no selectable rows, nothing owns the keys)")
|
||||
}
|
||||
if !m.composerActive() {
|
||||
t.Fatal("the composer must stay active under the open tree region")
|
||||
}
|
||||
// genuine chrome still owns the keys: the rail takeover.
|
||||
m.face.SetTakeoverOpen(true)
|
||||
if !m.face.ChromeOpen() {
|
||||
t.Fatal("tree region must be open after SetTreeOpen(true)")
|
||||
t.Fatal("the rail takeover must still count as chrome")
|
||||
}
|
||||
if m.composerActive() {
|
||||
t.Fatal("composer must not own keys while chrome is open")
|
||||
}
|
||||
next, cmd := m.Update(keyPress("h")) // a plain rune during chrome
|
||||
m.face.SetTakeoverOpen(false)
|
||||
next, cmd := m.Update(keyPress("h")) // a plain rune with the view region open
|
||||
m = next.(model)
|
||||
if cmd != nil {
|
||||
t.Fatal("no dispatch may leave chrome-owned keys")
|
||||
@@ -1552,7 +1570,22 @@ func runBatch(cmd tea.Cmd) []tea.Msg {
|
||||
case nil:
|
||||
return nil
|
||||
default:
|
||||
return []tea.Msg{msg}
|
||||
out := []tea.Msg{msg}
|
||||
// the streaming dispatch leg (Gitea #2556): the start message
|
||||
// opens the receive loop — the batch settles it to the closing
|
||||
// report so the classic completion-scanning assertions hold.
|
||||
if start, ok := msg.(chatStreamStartMsg); ok {
|
||||
for {
|
||||
next := awaitStream(start)()
|
||||
out = append(out, next)
|
||||
if cm, ok := next.(chatCompletionMsg); ok {
|
||||
_ = cm
|
||||
break
|
||||
}
|
||||
start = next.(chatStreamDeltaMsg).start
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2042,14 +2075,15 @@ func TestTypingRoutesWithFocus(t *testing.T) {
|
||||
m = next.(model)
|
||||
sel := m.face.Snapshot().Sel
|
||||
// D36 owner fix 2026-10-19: j/k are LETTERS now (they type into the
|
||||
// shared box in both focuses); the tree cursor moves with the
|
||||
// ARROW keys exclusively.
|
||||
// shared box in both focuses). D50 residual 3: the arrows no longer
|
||||
// walk tree rows (the walker is removed) — the semantic selection
|
||||
// stands and the arrows scroll the tasks panel instead.
|
||||
for _, poke := range []rune{tea.KeyDown, tea.KeyDown} {
|
||||
next, _ := m.Update(arrowPress(poke))
|
||||
m = next.(model)
|
||||
}
|
||||
if got := m.face.Snapshot().Sel; got != sel+2 {
|
||||
t.Fatalf("tasks focus: arrows moved sel %d -> %d, want %d (the tree walks on the arrows)", sel, got, sel+2)
|
||||
if got := m.face.Snapshot().Sel; got != sel {
|
||||
t.Fatalf("tasks focus: arrows moved sel %d -> %d, want %d (the row walker is removed)", sel, got, sel)
|
||||
}
|
||||
if got := m.composer.Text(); got != "hi" {
|
||||
t.Fatalf("tasks-focus keys must not disturb the chat draft, got %q", got)
|
||||
|
||||
@@ -0,0 +1,55 @@
|
||||
// pins.go — the PINNED WORK hot-state record (D50 residual 4, #2560):
|
||||
// what the owner pinned, persisted across boots. RUNE_HOME law, the
|
||||
// history-depth record's exact pattern: one JSON document at the state
|
||||
// home's root (tasks_pins.json beside history_depth.json), written
|
||||
// atomically (write-beside, rename over). The record never guesses —
|
||||
// absent or corrupt answers an empty pin set.
|
||||
package main
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"os"
|
||||
"path/filepath"
|
||||
|
||||
"rune.dev/rune/tui/tasks"
|
||||
)
|
||||
|
||||
func pinsPath(home string) string {
|
||||
return filepath.Join(home, "tasks_pins.json")
|
||||
}
|
||||
|
||||
// loadPins returns the persisted pins — absent or corrupt is empty,
|
||||
// never a guess.
|
||||
func loadPins(home string) []tasks.Pin {
|
||||
raw, err := os.ReadFile(pinsPath(home))
|
||||
if err != nil {
|
||||
return nil
|
||||
}
|
||||
var doc struct {
|
||||
Pins []tasks.Pin `json:"pins"`
|
||||
}
|
||||
if json.Unmarshal(raw, &doc) != nil {
|
||||
return nil
|
||||
}
|
||||
return doc.Pins
|
||||
}
|
||||
|
||||
// savePins persists the pin set atomically (write-beside, rename
|
||||
// over — the depth-record pattern).
|
||||
func savePins(home string, pins []tasks.Pin) error {
|
||||
if err := os.MkdirAll(home, 0o755); err != nil {
|
||||
return err
|
||||
}
|
||||
raw, err := json.MarshalIndent(struct {
|
||||
Pins []tasks.Pin `json:"pins"`
|
||||
}{pins}, "", " ")
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
dst := pinsPath(home)
|
||||
tmp := dst + ".tmp"
|
||||
if err := os.WriteFile(tmp, append(raw, '\n'), 0o600); err != nil {
|
||||
return err
|
||||
}
|
||||
return os.Rename(tmp, dst)
|
||||
}
|
||||
@@ -0,0 +1,63 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/semantic"
|
||||
"rune.dev/rune/tui/taskqueue"
|
||||
"rune.dev/rune/tui/tasks"
|
||||
)
|
||||
|
||||
// D50 residual 4 (#2560): PINNED WORK — the pin verb's keyboard parity
|
||||
// is ctrl+b (the control-key family: ctrl+q steers the queue, ctrl+g
|
||||
// raises gauges, ctrl+b pins the top live work block). Pins persist
|
||||
// across boots through the hot-state store (tasks_pins.json beside
|
||||
// history_depth.json — the depth record's exact pattern).
|
||||
func TestD50PinKeyboardParityPersistsAcrossBoots(t *testing.T) {
|
||||
configuredHome(t)
|
||||
home := os.Getenv("RUNE_HOME")
|
||||
bootCompleter = &queueSeamFake{}
|
||||
defer func() { bootCompleter = nil }()
|
||||
|
||||
m := sized(t, initialModel(), 110, 30)
|
||||
// live work to pin: one running block
|
||||
blocks := tasks.DeriveWorkBlocks(tasks.LiveInput{
|
||||
Tasks: []tasks.LiveTask{{ID: "task_1", Title: "migrate the store", Status: "running",
|
||||
Updated: time.Now().UTC().Format(time.RFC3339)}},
|
||||
})
|
||||
m.face.SetLiveWork(blocks, []taskqueue.Entry{{EntryID: "q1", Text: "x",
|
||||
QueuedAt: time.Now()}}, time.Now())
|
||||
if len(blocks) != 1 {
|
||||
t.Fatalf("one live block expected, got %+v", blocks)
|
||||
}
|
||||
m2, _ := m.Update(tea.KeyPressMsg{Code: 'b', Mod: tea.ModCtrl})
|
||||
m = m2.(model)
|
||||
if n := len(m.face.Pins()); n != 1 {
|
||||
t.Fatalf("ctrl+b must pin the top live work block, got %d pins", n)
|
||||
}
|
||||
raw, err := os.ReadFile(filepath.Join(home, "tasks_pins.json"))
|
||||
if err != nil {
|
||||
t.Fatalf("the pin must persist through the hot-state store: %v", err)
|
||||
}
|
||||
if !strings.Contains(string(raw), "migrate the store") {
|
||||
t.Fatalf("the persisted record must carry the plain-english summary: %s", raw)
|
||||
}
|
||||
// THE BOOT LEG: a fresh model loads the pins — they survive the boot
|
||||
m3 := sized(t, initialModel(), 110, 30)
|
||||
if n := len(m3.face.Pins()); n != 1 {
|
||||
t.Fatalf("pins must persist across boots, got %d", n)
|
||||
}
|
||||
// the pinned area lives in the tasks pane's region view (opened by
|
||||
// the click road / palette); open it and read the pane.
|
||||
m3.face.SetTreeOpen(true)
|
||||
v := semantic.StripANSI(m3.face.Render().Content)
|
||||
if !strings.Contains(v, "pinned (1)") {
|
||||
t.Fatalf("the fresh boot's tasks pane must render the pinned area:\n%s", v)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,144 @@
|
||||
// scrollback_test.go — THE SCROLLBACK law (#2535, D50-1 priority):
|
||||
// EACH pane scrolls individually with its own scroll state — the chat
|
||||
// transcript (keyboard + wheel) AND the tasks panel (keyboard + wheel)
|
||||
// — stay-put while content changes, and the tasks pane never scrolls
|
||||
// the chat by accident.
|
||||
package main
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/chatpane"
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
func scrollModel(t *testing.T) model {
|
||||
t.Helper()
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
// enough chat rows to overflow the pane
|
||||
for i := 0; i < 40; i++ {
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleUser,
|
||||
Content: strings.Repeat("row ", 8) + itoa(i), Ts: "2026-10-22T10:00:00Z"})
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
func itoa(n int) string {
|
||||
if n == 0 {
|
||||
return "0"
|
||||
}
|
||||
var b []byte
|
||||
for n > 0 {
|
||||
b = append([]byte{byte('0' + n%10)}, b...)
|
||||
n /= 10
|
||||
}
|
||||
return string(b)
|
||||
}
|
||||
|
||||
func pgUpPress() tea.KeyPressMsg { return tea.KeyPressMsg{Code: tea.KeyPgUp} }
|
||||
|
||||
func pgDownPress() tea.KeyPressMsg { return tea.KeyPressMsg{Code: tea.KeyPgDown} }
|
||||
|
||||
func TestChatScrollsIndividually(t *testing.T) {
|
||||
m := scrollModel(t)
|
||||
m.face.Render() // the scroll geometry anchors on the last render
|
||||
if !m.face.ScrollChatUp(5) {
|
||||
t.Fatal("the chat pane must scroll toward the older end")
|
||||
}
|
||||
frame := semantic.StripANSI(m.face.Render().Content)
|
||||
if !strings.Contains(frame, "more") {
|
||||
t.Fatalf("a scrolled chat pane shows its ↑ indicator:\n%s", frame)
|
||||
}
|
||||
if !m.face.ScrollChatDown(5) {
|
||||
t.Fatal("the chat pane must scroll back down")
|
||||
}
|
||||
if m.face.ScrollChatDown(1) {
|
||||
t.Fatal("at rest, further downs move nothing")
|
||||
}
|
||||
}
|
||||
|
||||
func TestTasksScrollsIndividually(t *testing.T) {
|
||||
m := scrollModel(t)
|
||||
// one scroll up must move the tasks panel's offset (its own
|
||||
// scroll state, independent of the chat's)
|
||||
moved := m.face.TasksScrollUp(3)
|
||||
_ = moved
|
||||
off := m.face.TasksScrollOffset()
|
||||
// the pane may or may not overflow at this size; the state must be
|
||||
// a NON-NEGATIVE offset that never moves the chat pane
|
||||
if off < 0 {
|
||||
t.Fatalf("the tasks scroll offset must never go negative: %d", off)
|
||||
}
|
||||
// the tasks pane's scroll is its OWN state: the chat pane never moved
|
||||
if m.face.ChatScrollOffset() != 0 {
|
||||
t.Fatal("the chat pane's scroll state must be untouched by tasks scrolling")
|
||||
}
|
||||
// scrolling down always rests at zero
|
||||
m.face.TasksScrollDown(100)
|
||||
if m.face.TasksScrollOffset() != 0 {
|
||||
t.Fatalf("scrolling down must rest at 0, got %d", m.face.TasksScrollOffset())
|
||||
}
|
||||
}
|
||||
|
||||
func TestWheelRoutesByPaneUnderPointer(t *testing.T) {
|
||||
m := scrollModel(t)
|
||||
// find a cell inside each pane
|
||||
var chatCell, taskCell [2]int
|
||||
for _, r := range m.face.Render().Regions {
|
||||
if r.ID == "region.chat" {
|
||||
chatCell = [2]int{r.X + 2, r.Y + 3}
|
||||
}
|
||||
if r.ID == "region.tasks" {
|
||||
taskCell = [2]int{r.X + 2, r.Y + 3}
|
||||
}
|
||||
}
|
||||
// wheel down over chat: the chat pane scrolls (its own state)
|
||||
next, _ := m.Update(tea.MouseWheelMsg{X: chatCell[0], Y: chatCell[1],
|
||||
Button: tea.MouseWheelDown})
|
||||
m = next.(model)
|
||||
if m.face.ChatScrollOffset() != 0 {
|
||||
t.Fatal("wheel DOWN over chat at rest must not move the offset")
|
||||
}
|
||||
// wheel UP over chat: the offset grows
|
||||
next, _ = m.Update(tea.MouseWheelMsg{X: chatCell[0], Y: chatCell[1],
|
||||
Button: tea.MouseWheelUp})
|
||||
m = next.(model)
|
||||
if m.face.ChatScrollOffset() == 0 {
|
||||
t.Fatal("wheel UP over chat must scroll the chat pane")
|
||||
}
|
||||
// wheel over the tasks pane: the TASKS state moves, the chat's
|
||||
// offset stands still
|
||||
chatOff := m.face.ChatScrollOffset()
|
||||
next, _ = m.Update(tea.MouseWheelMsg{X: taskCell[0], Y: taskCell[1],
|
||||
Button: tea.MouseWheelUp})
|
||||
m = next.(model)
|
||||
if m.face.ChatScrollOffset() != chatOff {
|
||||
t.Fatal("a wheel over the tasks pane must never scroll the chat pane (individual states)")
|
||||
}
|
||||
}
|
||||
|
||||
func TestKeyboardScrollRoutesByFocus(t *testing.T) {
|
||||
m := scrollModel(t)
|
||||
// focus the chat pane and pgup: the chat offset grows
|
||||
m.face.Render()
|
||||
next, _ := m.Update(keyPress("1"))
|
||||
m = next.(model)
|
||||
next, _ = m.Update(pgUpPress())
|
||||
m = next.(model)
|
||||
if m.face.ChatScrollOffset() == 0 {
|
||||
t.Fatal("pgup on chat focus must scroll the chat pane")
|
||||
}
|
||||
// focus tasks and pgup: the chat offset stands, the tasks state
|
||||
// is its own
|
||||
chatOff := m.face.ChatScrollOffset()
|
||||
next, _ = m.Update(keyPress("2"))
|
||||
m = next.(model)
|
||||
next, _ = m.Update(pgUpPress())
|
||||
m = next.(model)
|
||||
if m.face.ChatScrollOffset() != chatOff {
|
||||
t.Fatal("pgup on tasks focus must never scroll the chat pane")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,234 @@
|
||||
// selection.go — THE SELECTION + AUTO-COPY layer (#2532, the
|
||||
// presentation wave Part 3): mouse-drag highlights text per pane and
|
||||
// the release copies it via OSC 52 — capability-detected, DIRECT
|
||||
// escape emission (the same law as the OSC 8 denylist gate: a known
|
||||
// non-carrier degrades honestly, the selection still highlights, the
|
||||
// copy never fabricates).
|
||||
//
|
||||
// Layer law: this is the SHELL's own display state — the drag's
|
||||
// anchor/head, the pane it started in, the last copy. The face chain
|
||||
// never knows; the highlight is an overlay applied to the rendered
|
||||
// frame at View time, never a pane concern.
|
||||
package main
|
||||
|
||||
import (
|
||||
"encoding/base64"
|
||||
"io"
|
||||
"os"
|
||||
"strings"
|
||||
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
// selState is one drag-selection's display state.
|
||||
type selState struct {
|
||||
active bool
|
||||
anchorX, head int // head X
|
||||
anchorY, headY int
|
||||
pane string // the starting region's ID ("region.chat" | "region.tasks")
|
||||
}
|
||||
|
||||
// selInFlight reports whether a drag is highlighting right now.
|
||||
func (s *selState) inFlight() bool { return s.active }
|
||||
|
||||
// osc52Allowed gates the OSC 52 copy (detect-then-emit): known
|
||||
// non-carriers and the explicit opt-out degrade to highlight-only.
|
||||
// Hermetic tests stay false by construction (the default); the real
|
||||
// main() wires the detection in — exactly the linkVersions law.
|
||||
var osc52Allowed = func() bool { return false }
|
||||
|
||||
// osc52Emit writes the OSC 52 copy sequence for text — DIRECT escape
|
||||
// emission: the sequence must reach the terminal byte-intact, so it
|
||||
// never rides the view (the cell parser drops OSC). Belt-terminated
|
||||
// (\x07): the most widely honored terminator.
|
||||
func osc52Emit(out io.Writer, text string) {
|
||||
if !osc52Allowed() || text == "" {
|
||||
return
|
||||
}
|
||||
enc := base64.StdEncoding.EncodeToString([]byte(text))
|
||||
_, _ = io.WriteString(out, "\x1b]52;c;"+enc+"\x07")
|
||||
}
|
||||
|
||||
// selStart begins a drag at (x,y) when the cell sits inside a
|
||||
// selectable text pane (the chat or tasks region) and no chrome
|
||||
// surface owns the mouse; it reports whether a selection started.
|
||||
func (m *model) selStart(x, y int, regions []semantic.Region) bool {
|
||||
m.sel = selState{}
|
||||
if m.chromeOwnsMouse() {
|
||||
return false
|
||||
}
|
||||
for _, r := range regions {
|
||||
if r.ID != "region.chat" && r.ID != "region.tasks" {
|
||||
continue
|
||||
}
|
||||
if x >= r.X && x < r.X+r.W && y >= r.Y && y < r.Y+r.H {
|
||||
m.sel = selState{active: true, pane: r.ID,
|
||||
anchorX: x, head: x, anchorY: y, headY: y}
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// selMove extends the drag's head to (x,y), clamped to the starting
|
||||
// pane's rectangle — a selection never bleeds across panes.
|
||||
func (m *model) selMove(x, y int, regions []semantic.Region) {
|
||||
if !m.sel.active {
|
||||
return
|
||||
}
|
||||
for _, r := range regions {
|
||||
if r.ID != m.sel.pane {
|
||||
continue
|
||||
}
|
||||
m.sel.head = min(max(x, r.X), r.X+r.W-1)
|
||||
m.sel.headY = min(max(y, r.Y), r.Y+r.H-1)
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
// selFinish ends the drag, extracts the highlighted text from the
|
||||
// frame's content, copies it via OSC 52, and clears the highlight.
|
||||
// Returns the copied text ("" when the drag collapsed to nothing).
|
||||
func (m *model) selFinish(content string, out io.Writer) string {
|
||||
if !m.sel.active {
|
||||
return ""
|
||||
}
|
||||
text := m.selText(content)
|
||||
m.sel = selState{}
|
||||
if text != "" {
|
||||
osc52Emit(out, text)
|
||||
}
|
||||
return text
|
||||
}
|
||||
|
||||
// selText extracts the selected text: the display columns of the
|
||||
// selected rows, ANSI-stripped (the copy is the WORDS the operator
|
||||
// saw), rows joined with newlines. A single-row drag takes its
|
||||
// column span; a multi-row drag takes the anchor's row tail, the
|
||||
// whole middle rows, and the head row's prefix.
|
||||
func (m *model) selText(content string) string {
|
||||
lines := strings.Split(content, "\n")
|
||||
y0, y1 := m.sel.anchorY, m.sel.headY
|
||||
x0, x1 := m.sel.anchorX, m.sel.head
|
||||
if y0 > y1 || (y0 == y1 && x0 > x1) {
|
||||
y0, y1 = y1, y0
|
||||
x0, x1 = x1, x0
|
||||
}
|
||||
var rows []string
|
||||
for y := y0; y <= y1 && y < len(lines); y++ {
|
||||
r := []rune(semantic.StripANSI(lines[y]))
|
||||
lo, hi := 0, len(r)
|
||||
if y == y0 && y0 != y1 {
|
||||
lo = min(x0, len(r))
|
||||
} else if y == y0 && y0 == y1 {
|
||||
lo, hi = min(x0, len(r)), min(x1+1, len(r))
|
||||
} else if y == y1 {
|
||||
hi = min(x1+1, len(r))
|
||||
}
|
||||
if lo > hi {
|
||||
lo = hi
|
||||
}
|
||||
rows = append(rows, strings.TrimRight(string(r[lo:hi]), " "))
|
||||
}
|
||||
return strings.Join(rows, "\n")
|
||||
}
|
||||
|
||||
// overlaySelection paints the drag's highlight over the frame
|
||||
// content: the selected cells render in reverse video — an overlay,
|
||||
// never a pane concern. Applied only while the drag is in flight.
|
||||
func (m *model) overlaySelection(content string) string {
|
||||
if !m.sel.active {
|
||||
return content
|
||||
}
|
||||
lines := strings.Split(content, "\n")
|
||||
y0, y1 := m.sel.anchorY, m.sel.headY
|
||||
x0, x1 := m.sel.anchorX, m.sel.head
|
||||
if y0 > y1 || (y0 == y1 && x0 > x1) {
|
||||
y0, y1 = y1, y0
|
||||
x0, x1 = x1, x0
|
||||
}
|
||||
for y := y0; y <= y1 && y < len(lines); y++ {
|
||||
lo, hi := 0, widthANSIOf(lines[y])
|
||||
if y == y0 && y0 != y1 {
|
||||
lo = min(x0, hi)
|
||||
} else if y == y0 && y0 == y1 {
|
||||
lo, hi = min(x0, hi), min(x1+1, hi)
|
||||
} else if y == y1 {
|
||||
hi = min(x1+1, hi)
|
||||
}
|
||||
if lo >= hi {
|
||||
continue
|
||||
}
|
||||
lines[y] = spliceReverse(lines[y], lo, hi)
|
||||
}
|
||||
return strings.Join(lines, "\n")
|
||||
}
|
||||
|
||||
// spliceReverse wraps the display columns [lo,hi) of a styled line in
|
||||
// reverse video, keeping every ANSI run intact on both sides.
|
||||
func spliceReverse(line string, lo, hi int) string {
|
||||
var b strings.Builder
|
||||
col := 0
|
||||
inEsc := false
|
||||
var esc strings.Builder
|
||||
for _, r := range line {
|
||||
if r == '\x1b' {
|
||||
inEsc = true
|
||||
esc.Reset()
|
||||
esc.WriteRune(r)
|
||||
continue
|
||||
}
|
||||
if inEsc {
|
||||
esc.WriteRune(r)
|
||||
if (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') {
|
||||
b.WriteString(esc.String())
|
||||
inEsc = false
|
||||
}
|
||||
continue
|
||||
}
|
||||
if col == lo {
|
||||
b.WriteString("\x1b[7m")
|
||||
}
|
||||
b.WriteRune(r)
|
||||
col++
|
||||
if col == hi {
|
||||
b.WriteString("\x1b[27m")
|
||||
}
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// widthANSIOf measures one line's display columns (escapes carry none).
|
||||
func widthANSIOf(s string) int { return len([]rune(semantic.StripANSI(s))) }
|
||||
|
||||
// chromeOwnsMouse reports whether a chrome surface (the centered
|
||||
// picker, the palette, the model menu, a decision card) owns the
|
||||
// mouse right now — a drag selection never starts under them.
|
||||
func (m *model) chromeOwnsMouse() bool {
|
||||
return m.pickerOpen || m.paletteOpen() || m.menuOpen ||
|
||||
m.apprv != nil || m.consentCard != nil || m.gaugesOpen
|
||||
}
|
||||
|
||||
// wireOSC52Detection installs the real terminal detection for the
|
||||
// selection copy (#2532, detect-then-emit — the OSC 8 denylist law
|
||||
// carried): OSC 52 is near-universal on modern terminals (Konsole,
|
||||
// VTE, kitty, alacritty, foot, WezTerm, iTerm, tmux all honor it,
|
||||
// some behind an allow-list setting), so the gate DENYLISTS the known
|
||||
// non-carriers and copies everywhere else; a non-carrier degrades to
|
||||
// highlight-only (the drag still shows; the copy never fabricates).
|
||||
// RUNE_NO_OSC52 opts out explicitly.
|
||||
func wireOSC52Detection() {
|
||||
osc52Allowed = func() bool {
|
||||
if os.Getenv("RUNE_NO_OSC52") != "" {
|
||||
return false
|
||||
}
|
||||
switch t := os.Getenv("TERM"); t {
|
||||
case "dumb", "linux", "vt100", "vt220", "xterm-mono", "cons25", "emacs":
|
||||
return false
|
||||
}
|
||||
if os.Getenv("INSIDE_EMACS") != "" || os.Getenv("EMACS") != "" {
|
||||
return false
|
||||
}
|
||||
return true
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,198 @@
|
||||
// selection_test.go — THE SELECTION + AUTO-COPY suite (#2532, the
|
||||
// presentation wave Part 3): a left-press inside a text pane starts a
|
||||
// drag; motion extends the head clamped to the pane; the release
|
||||
// extracts the highlighted WORDS (ANSI-stripped) and copies via OSC 52
|
||||
// (capability-gated, direct escape emission, base64 payload); a plain
|
||||
// click copies nothing; chrome never starts a drag.
|
||||
package main
|
||||
|
||||
import (
|
||||
"os"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"charm.land/bubbletea/v2"
|
||||
|
||||
"rune.dev/rune/tui/chatpane"
|
||||
"rune.dev/rune/tui/semantic"
|
||||
)
|
||||
|
||||
func selModel(t *testing.T) model {
|
||||
t.Helper()
|
||||
m := sized(t, initialModel(), 80, 24)
|
||||
m.face.AppendChat(chatpane.Message{Role: chatpane.RoleUser,
|
||||
Content: "the quick brown fox", Ts: "2026-10-22T10:00:00Z"})
|
||||
return m
|
||||
}
|
||||
|
||||
func chatRegionOf(t *testing.T, m model) semantic.Region {
|
||||
t.Helper()
|
||||
for _, r := range m.face.Render().Regions {
|
||||
if r.ID == "region.chat" {
|
||||
return r
|
||||
}
|
||||
}
|
||||
t.Fatal("no region.chat")
|
||||
return semantic.Region{}
|
||||
}
|
||||
|
||||
func TestDragStartsInTextPaneOnly(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
if !m.selStart(reg.X+2, reg.Y+3, m.face.Render().Regions) {
|
||||
t.Fatal("a press inside the chat pane must start a selection")
|
||||
}
|
||||
if !m.sel.inFlight() || m.sel.pane != "region.chat" {
|
||||
t.Fatalf("selection state wrong: %+v", m.sel)
|
||||
}
|
||||
// a press outside both text panes starts nothing
|
||||
if m.selStart(reg.X+reg.W+50, reg.Y, m.face.Render().Regions) {
|
||||
t.Fatal("a press outside the text panes must not select")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDragMotionClampsToPane(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
m.selStart(reg.X, reg.Y+1, m.face.Render().Regions)
|
||||
m.selMove(reg.X+reg.W+30, reg.Y-8, m.face.Render().Regions)
|
||||
if m.sel.head != reg.X+reg.W-1 || m.sel.headY != reg.Y {
|
||||
t.Fatalf("the drag head must clamp to the pane rect: %+v (pane %+v)", m.sel, reg)
|
||||
}
|
||||
}
|
||||
|
||||
func TestReleaseExtractsHighlightedWordsAndCopies(t *testing.T) {
|
||||
allowed := false
|
||||
osc52Allowed = func() bool { return allowed }
|
||||
defer func() { osc52Allowed = func() bool { return false } }()
|
||||
|
||||
m := selModel(t)
|
||||
_ = chatRegionOf(t, m)
|
||||
frame := m.face.Render().Content
|
||||
// find the row carrying the phrase and the phrase's exact column
|
||||
rows := strings.Split(semantic.StripANSI(frame), "\n")
|
||||
row, col := -1, -1
|
||||
for i, r := range rows {
|
||||
if j := strings.Index(r, "the quick brown fox"); j >= 0 {
|
||||
row, col = i, len([]rune(r[:j]))
|
||||
break
|
||||
}
|
||||
}
|
||||
if row < 0 {
|
||||
t.Fatalf("the phrase must render:\n%s", frame)
|
||||
}
|
||||
m.selStart(col, row, m.face.Render().Regions)
|
||||
m.selMove(col+len("the quick brown")-1, row, m.face.Render().Regions)
|
||||
|
||||
var sb strings.Builder
|
||||
text := m.selFinish(frame, &fakeOut{&sb})
|
||||
if text != "the quick brown" {
|
||||
t.Fatalf("the release must extract exactly the highlighted words, got %q", text)
|
||||
}
|
||||
if m.sel.inFlight() {
|
||||
t.Fatal("the release must clear the highlight")
|
||||
}
|
||||
// the OSC 52 emission (gated): the exact sequence, base64 payload
|
||||
allowed = true
|
||||
m2 := selModel(t)
|
||||
m2.selStart(col, row, m2.face.Render().Regions)
|
||||
m2.selMove(col+len("the quick")-1, row, m2.face.Render().Regions)
|
||||
sb.Reset()
|
||||
m2.selFinish(m2.face.Render().Content, &fakeOut{&sb})
|
||||
out := sb.String()
|
||||
if !strings.HasPrefix(out, "\x1b]52;c;") || !strings.HasSuffix(out, "\x07") {
|
||||
t.Fatalf("the copy must be a direct OSC 52 emission, got %q", out)
|
||||
}
|
||||
if want := "dGhlIHF1aWNr"; !strings.Contains(out, want) { // base64("the quick")
|
||||
t.Fatalf("the OSC 52 payload must carry base64(\"the quick\")=dGhlIHF1aWNr, got %q", out)
|
||||
}
|
||||
// gate off: no bytes
|
||||
allowed = false
|
||||
m3 := selModel(t)
|
||||
m3.selStart(col, row, m3.face.Render().Regions)
|
||||
m3.selMove(col+len("the quick")-1, row, m3.face.Render().Regions)
|
||||
sb.Reset()
|
||||
m3.selFinish(m3.face.Render().Content, &fakeOut{&sb})
|
||||
if sb.String() != "" {
|
||||
t.Fatalf("the gate off must emit nothing, got %q", sb.String())
|
||||
}
|
||||
}
|
||||
|
||||
type fakeOut struct{ b *strings.Builder }
|
||||
|
||||
func (f *fakeOut) WriteString(s string) (int, error) { return f.b.WriteString(s) }
|
||||
func (f *fakeOut) Write(p []byte) (int, error) { return f.b.Write(p) }
|
||||
|
||||
func TestCollapsedDragCopiesNothing(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
m.selStart(reg.X+2, reg.Y+2, m.face.Render().Regions)
|
||||
// no motion: a plain click
|
||||
if text := m.selFinish(m.face.Render().Content, os.Stdout); text != "" {
|
||||
t.Fatalf("a collapsed drag (click) must copy nothing, got %q", text)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSelectionHighlightOverlaysWhileInFlight(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
frame := m.face.Render().Content
|
||||
rows := strings.Split(semantic.StripANSI(frame), "\n")
|
||||
row, col := -1, 0
|
||||
for i, r := range rows {
|
||||
if j := strings.Index(r, "the quick brown fox"); j >= 0 {
|
||||
row, col = i, len([]rune(r[:j]))
|
||||
break
|
||||
}
|
||||
}
|
||||
m.selStart(col, row, m.face.Render().Regions)
|
||||
m.selMove(col+len("the quick")-1, row, m.face.Render().Regions)
|
||||
painted := m.overlaySelection(frame)
|
||||
if !strings.Contains(painted, "\x1b[7m") {
|
||||
t.Fatalf("the in-flight drag must paint reverse video over the frame")
|
||||
}
|
||||
// the overlay is display-column faithful: the same text, escapes aside
|
||||
if semantic.StripANSI(painted) != semantic.StripANSI(frame) {
|
||||
t.Fatal("the highlight overlay must never change the frame's text")
|
||||
}
|
||||
_ = reg
|
||||
}
|
||||
|
||||
func TestChromeNeverStartsADrag(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
m.pickerOpen = true // the centered picker owns the mouse
|
||||
if m.selStart(reg.X+2, reg.Y+3, m.face.Render().Regions) {
|
||||
t.Fatal("chrome that owns the mouse must never start a drag")
|
||||
}
|
||||
if m.chromeOwnsMouse() != true {
|
||||
t.Fatal("chromeOwnsMouse must report the picker")
|
||||
}
|
||||
m.pickerOpen = false
|
||||
if m.chromeOwnsMouse() {
|
||||
t.Fatal("chromeOwnsMouse must release with the picker closed")
|
||||
}
|
||||
}
|
||||
|
||||
func TestMotionRoutesThroughShell(t *testing.T) {
|
||||
m := selModel(t)
|
||||
reg := chatRegionOf(t, m)
|
||||
next, _ := m.Update(tea.MouseClickMsg{X: reg.X + 2, Y: reg.Y + 3,
|
||||
Button: tea.MouseLeft})
|
||||
m = next.(model)
|
||||
if !m.sel.inFlight() {
|
||||
t.Fatal("the click must arm the selection")
|
||||
}
|
||||
next, _ = m.Update(tea.MouseMotionMsg{X: reg.X + 6, Y: reg.Y + 3,
|
||||
Button: tea.MouseLeft})
|
||||
m = next.(model)
|
||||
if m.sel.head != reg.X+6 {
|
||||
t.Fatalf("motion with the button held must extend the head: %+v", m.sel)
|
||||
}
|
||||
next, _ = m.Update(tea.MouseReleaseMsg{X: reg.X + 6, Y: reg.Y + 3,
|
||||
Button: tea.MouseLeft})
|
||||
m = next.(model)
|
||||
if m.sel.inFlight() {
|
||||
t.Fatal("the release must finish the selection")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,53 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
)
|
||||
|
||||
// D50 item 5 (Gitea #2555 item 7): the '/'-command submenu is
|
||||
// SELECTABLE — while the slash hints show, up/down move the selection
|
||||
// over the matching rows and enter runs the HIGHLIGHTED command (not
|
||||
// just an exact or unique prefix). The palette's ↑/↓/enter law, carried
|
||||
// to the inline '/' road.
|
||||
func TestD50SlashHintsSelectableUpDownEnter(t *testing.T) {
|
||||
configuredHome(t)
|
||||
bootCompleter = &fakeChatCompleter{answer: "ok"}
|
||||
defer func() { bootCompleter = nil }()
|
||||
|
||||
m := sized(t, initialModel(), 110, 30)
|
||||
m2, _ := m.Update(keyPress("/"))
|
||||
m = m2.(model)
|
||||
hints := slashHintLines("/", m.hintSel)
|
||||
if len(hints) < 3 {
|
||||
t.Fatalf("the bare slash must list the vocabulary, got %d rows", len(hints))
|
||||
}
|
||||
// down once: the selection moves OFF the first row
|
||||
m2, _ = m.Update(arrowPress(tea.KeyDown))
|
||||
m = m2.(model)
|
||||
marked := 0
|
||||
for _, ln := range slashHintLines("/", m.hintSel) {
|
||||
if strings.HasPrefix(ln, "> ") {
|
||||
marked++
|
||||
}
|
||||
}
|
||||
if marked != 1 {
|
||||
t.Fatalf("exactly one hint row must carry the selection mark, got %d", marked)
|
||||
}
|
||||
if !strings.Contains(slashHintLines("/", m.hintSel)[1], "> ") {
|
||||
t.Fatalf("down must move the mark to the second row:\n%s", strings.Join(slashHintLines("/", m.hintSel), "\n"))
|
||||
}
|
||||
// enter runs the HIGHLIGHTED command (/history, whose no-arg leg
|
||||
// reports the boot depth in the transcript)
|
||||
m2, _ = m.Update(enterPress())
|
||||
m = m2.(model)
|
||||
txt := chatBubbleText(m)
|
||||
if !strings.Contains(txt, "history depth:") {
|
||||
t.Fatalf("enter must run the highlighted hint command (/history):\n%s", txt)
|
||||
}
|
||||
if got := m.composer.Text(); got != "" {
|
||||
t.Fatalf("a run hint command clears the slash text, got %q", got)
|
||||
}
|
||||
}
|
||||
@@ -235,6 +235,15 @@ func New(w, h int) *Inputs { return newInputs(semantic.ModeRich, w, h) }
|
||||
// NewLinear returns the linear-projection inputs face (zero-ANSI law).
|
||||
func NewLinear(w, h int) *Inputs { return newInputs(semantic.ModeLinear, w, h) }
|
||||
|
||||
// NewSeeded is the LAB harness's constructor: the canonical seeds
|
||||
// under the integrations chrome (D52 seed-substrate law, #2566 —
|
||||
// production faces boot empty; a test that needs the seed asks for it
|
||||
// explicitly here).
|
||||
func NewSeeded(w, h int) *Inputs {
|
||||
return &Inputs{inner: tasks.NewSeeded(w, h), mode: semantic.ModeRich,
|
||||
connected: map[string]Scope{}, blocked: map[string]Scope{}}
|
||||
}
|
||||
|
||||
func newInputs(mode string, w, h int) *Inputs {
|
||||
inner := tasks.New(w, h)
|
||||
if mode == semantic.ModeLinear {
|
||||
|
||||
@@ -20,7 +20,8 @@ var _ semantic.Face = (*Inputs)(nil)
|
||||
// state so divergence-hiding mutants cannot land on zero values).
|
||||
func seededInputs(t *testing.T) *Inputs {
|
||||
t.Helper()
|
||||
f := New(80, 24)
|
||||
// D52 supersession (#2566): the seed substrate is explicit (lab).
|
||||
f := NewSeeded(80, 24)
|
||||
if a, _ := f.Apply(semantic.Rune('2')); a != "focus.tasks" {
|
||||
t.Fatalf("seed key 2 produced %q", a)
|
||||
}
|
||||
@@ -32,7 +33,9 @@ func seededInputs(t *testing.T) *Inputs {
|
||||
|
||||
func seededTasksFace(t *testing.T) *tasks.Tasks {
|
||||
t.Helper()
|
||||
f := tasks.New(80, 24)
|
||||
// D52 supersession (#2566): production New boots EMPTY — the
|
||||
// delegation oracle needs the canonical seed on both sides.
|
||||
f := tasks.NewSeeded(80, 24)
|
||||
f.Apply(semantic.Rune('2'))
|
||||
f.Apply(semantic.Rune('j'))
|
||||
return f
|
||||
@@ -141,16 +144,20 @@ func TestInputsModalOutranksChrome(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestInputsInnerRegionOutranksChrome: an open inner region (task tree)
|
||||
// swallows i — the inputs chrome never bypasses an inner boundary.
|
||||
// TestInputsInnerRegionOutranksChrome (re-pinned D50 residual 3): the
|
||||
// task tree region is a VIEW now — it does not own keys, so the inputs
|
||||
// chrome routes exactly as with the tree closed. Genuine inner chrome
|
||||
// (the promote region) still outranks the inputs layer.
|
||||
func TestInputsInnerRegionOutranksChrome(t *testing.T) {
|
||||
f := seededInputs(t)
|
||||
f.inner.SetTreeOpen(true) // D36 owner fix: t is a letter now
|
||||
if !f.inner.Open() {
|
||||
t.Fatal("the tree must be open programmatically")
|
||||
}
|
||||
if a, _ := f.Apply(semantic.Rune('i')); a != tasks.TasksSwallow {
|
||||
t.Errorf("i during open tree produced %q, want %q", a, tasks.TasksSwallow)
|
||||
a, _ := f.Apply(semantic.Rune('i'))
|
||||
ref, _ := f.inner.Apply(semantic.Rune('i'))
|
||||
if a != ref {
|
||||
t.Errorf("i during open tree produced %q, want the delegated %q (the tree region is a view)", a, ref)
|
||||
}
|
||||
if f.Open() {
|
||||
t.Error("view opened through an open inner region")
|
||||
|
||||
@@ -39,6 +39,9 @@ import (
|
||||
// the I3 library seam's dispatch half satisfies the dispatcher
|
||||
var _ Completer = (*lib.Repo)(nil)
|
||||
|
||||
// the streaming leg too (Gitea #2556)
|
||||
var _ StreamCompleter = (*lib.Repo)(nil)
|
||||
|
||||
// Lane names the two permanent lanes of the dual-lane interface.
|
||||
type Lane string
|
||||
|
||||
@@ -202,6 +205,14 @@ type Completer interface {
|
||||
Complete(ctx context.Context, req lib.Completion) (lib.CompletionResult, error)
|
||||
}
|
||||
|
||||
// StreamCompleter is the streaming leg of the seam (Gitea #2556):
|
||||
// satisfied by *lib.Repo's CompleteStream. A dispatcher whose
|
||||
// completer streams uses it so the answer's bytes surface AS THEY
|
||||
// ARRIVE; fakes that don't implement it keep the non-streaming path.
|
||||
type StreamCompleter interface {
|
||||
CompleteStream(ctx context.Context, req lib.Completion, onDelta func(string)) (lib.CompletionResult, error)
|
||||
}
|
||||
|
||||
// LaneReport is one lane's dispatch outcome: the seam's result, the
|
||||
// shared-memory write that committed it, or the honest error (one
|
||||
// lane's failure never disturbs the other lane).
|
||||
@@ -223,6 +234,29 @@ type Dispatcher struct {
|
||||
comp Completer
|
||||
model string
|
||||
shared *Shared
|
||||
// deltaSinkMu guards deltaSinkFn: the TUI installs the streaming
|
||||
// delta sink just before dispatch (the composer's goroutine).
|
||||
deltaSinkMu sync.Mutex
|
||||
deltaSinkFn func(lane Lane, text string)
|
||||
}
|
||||
|
||||
// SetDeltaSink installs the streaming delta sink (Gitea #2556): each
|
||||
// lane's streamed text delta lands here AS IT ARRIVES. nil clears it
|
||||
// (the non-streaming fallback callers).
|
||||
func (d *Dispatcher) SetDeltaSink(fn func(lane Lane, text string)) {
|
||||
d.deltaSinkMu.Lock()
|
||||
defer d.deltaSinkMu.Unlock()
|
||||
d.deltaSinkFn = fn
|
||||
}
|
||||
|
||||
func (d *Dispatcher) deltaSink(lane Lane) func(string) {
|
||||
d.deltaSinkMu.Lock()
|
||||
defer d.deltaSinkMu.Unlock()
|
||||
if d.deltaSinkFn == nil {
|
||||
return nil
|
||||
}
|
||||
fn := d.deltaSinkFn
|
||||
return func(text string) { fn(lane, text) }
|
||||
}
|
||||
|
||||
// New returns a dispatcher over the seam (model "" = the core's own
|
||||
@@ -271,12 +305,26 @@ func (d *Dispatcher) Dispatch(ctx context.Context, lane Lane, input string) (Lan
|
||||
|
||||
// dispatchLane runs one lane's model call and commits its result. A
|
||||
// failed dispatch commits nothing and reports its error honestly.
|
||||
// The streaming leg (Gitea #2556) forwards the answer's text deltas
|
||||
// to the installed sink (never nil) as they arrive; the non-streaming
|
||||
// completer keeps the classic path.
|
||||
func (d *Dispatcher) dispatchLane(ctx context.Context, lane Lane, input string) LaneReport {
|
||||
res, err := d.comp.Complete(ctx, lib.Completion{
|
||||
req := lib.Completion{
|
||||
Model: d.model,
|
||||
Channel: string(lane),
|
||||
Messages: []lib.CompletionMessage{{Role: "user", Content: input}},
|
||||
})
|
||||
}
|
||||
var res lib.CompletionResult
|
||||
var err error
|
||||
if sink := d.deltaSink(lane); sink != nil {
|
||||
if sc, ok := d.comp.(StreamCompleter); ok {
|
||||
res, err = sc.CompleteStream(ctx, req, sink)
|
||||
} else {
|
||||
res, err = d.comp.Complete(ctx, req)
|
||||
}
|
||||
} else {
|
||||
res, err = d.comp.Complete(ctx, req)
|
||||
}
|
||||
if err != nil {
|
||||
return LaneReport{Err: err}
|
||||
}
|
||||
|
||||
Loaded 100 of 150 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user