conductor/rune
1
2 Fork 1
Code Issues 38 Pull Requests 32 Actions 4 Packages Projects Releases 564 Wiki Activity

[P1-09] Fix permission/confirmation semantics and confirmation-path bug #32

New Issue
Closed
opened 2026-08-28 20:54:40 +01:00 by conductor · 2 comments
conductor commented 2026-08-28 20:54:40 +01:00
Owner
Copy link
Copy source

Plain summary

Permission semantics become explicit and correct: no variables-before-initialization bugs, a clear owner-confirmation policy distinguishing read-only / reversible / destructive / external actions, and the TUI never auto-approves owner-required actions.

Example

A destructive delete asks for confirmation; a read-only query doesn't — and nothing marked owner-required slips through auto-approved.

Technical details

Parent epic: #16

Manifest ID: P1-09

Priority: P1
Action:

  • correct variables used before initialization;
  • owner confirmation policy must be explicit;
  • distinguish read-only, reversible, destructive and external actions;
  • TUI confirmation must not auto-approve actions marked owner-required.

Acceptance criteria:

  • tests for read/write/delete/external actions;
  • no ambiguous “needs confirmation but auto-confirmed” state.

Dependencies: P0-05.

Resolved dependency references

  • Depends on: #21 (P0-05)
  • Blocks: None.

Relevant source files

Not specified in the handoff. P0-01 must identify authoritative paths before implementation; do not guess by adding another path.

Do not do

  • Do not begin this issue before its dependencies are complete.
  • Do not create a parallel authority path; replace, extend, or remain dormant.
  • Do not add unrelated cognitive subsystems or additive feature growth.
  • Do not treat module/schema existence, background activity, or model self-report as acceptance evidence.

Source directive

Preserved from /home/nick/Desktop/rune_v1_course_correction_handoff.md, Section 14. The handoff is authoritative if this issue summary is ambiguous.

Pipeline requirements

  • TDD: frozen/regression tests written first, red → green
  • ruff check and ruff format --check clean
  • Spec-compliance review gate: PASS
  • Code-quality review gate: Approved
  • Full orchestration suite regression green
  • Canary passes (where applicable)
  • Closed with a properly formatted closing comment + commit/PR references
## Plain summary Permission semantics become explicit and correct: no variables-before-initialization bugs, a clear owner-confirmation policy distinguishing read-only / reversible / destructive / external actions, and the TUI never auto-approves owner-required actions. ## Example A destructive delete asks for confirmation; a read-only query doesn't — and nothing marked owner-required slips through auto-approved. ## Technical details Parent epic: #16 Manifest ID: **P1-09** **Priority:** P1 **Action:** - correct variables used before initialization; - owner confirmation policy must be explicit; - distinguish read-only, reversible, destructive and external actions; - TUI confirmation must not auto-approve actions marked owner-required. **Acceptance criteria:** - tests for read/write/delete/external actions; - no ambiguous “needs confirmation but auto-confirmed” state. **Dependencies:** P0-05. --- ## Resolved dependency references - Depends on: #21 (P0-05) - Blocks: None. ## Relevant source files Not specified in the handoff. P0-01 must identify authoritative paths before implementation; do not guess by adding another path. ## Do not do - Do not begin this issue before its dependencies are complete. - Do not create a parallel authority path; replace, extend, or remain dormant. - Do not add unrelated cognitive subsystems or additive feature growth. - Do not treat module/schema existence, background activity, or model self-report as acceptance evidence. ## Source directive Preserved from `/home/nick/Desktop/rune_v1_course_correction_handoff.md`, Section 14. The handoff is authoritative if this issue summary is ambiguous. ## Pipeline requirements - [ ] TDD: frozen/regression tests written first, red → green - [ ] `ruff check` and `ruff format --check` clean - [ ] Spec-compliance review gate: PASS - [ ] Code-quality review gate: Approved - [ ] Full orchestration suite regression green - [ ] Canary passes (where applicable) - [ ] Closed with a properly formatted closing comment + commit/PR references
conductor added the P1 — highv1-course-correction labels 2026-08-28 20:54:40 +01:00
gitea-actions Bot added the buggrowth labels 2026-08-28 20:55:32 +01:00
gitea-actions Bot added the custodian label 2026-09-03 22:54:08 +01:00
conductor removed the bug label 2026-09-11 13:16:08 +01:00
conductor commented 2026-10-08 13:00:37 +01:00
Author
Owner
Copy link
Copy source

VERIFIED PROGRAMMATICALLY (no code change needed): the condition this issue targets already holds in-tree. See verification comment for the evidence.

VERIFIED PROGRAMMATICALLY (no code change needed): the condition this issue targets already holds in-tree. See verification comment for the evidence.
conductor commented 2026-10-08 13:08:00 +01:00
Author
Owner
Copy link
Copy source

CLOSED PROGRAMMATICALLY — commit 8bb31cd (contract BUILDER-2026-10-08T12:07:20Z-9c626b). The issue condition holds in-tree; the pinning tests prevent silent regression.

CLOSED PROGRAMMATICALLY — commit 8bb31cd (contract BUILDER-2026-10-08T12:07:20Z-9c626b). The issue condition holds in-tree; the pinning tests prevent silent regression.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
P0 — critical
Spine/core correctness or blocks other work — do first
 P1 — high
Material user value or real defect (money, bugs, next-stage dep)
 P2 — medium
Quality/consolidation improvement
 P3 — low
Measurement / benchmark / deferred policy
 blocked
Dependencies open
 bug
Confirmed defect or regression
 custodian
epic
Rune v1 course-correction issue graph
 feature
New capability or improvement
 governance
growth
identity
in-progress
Currently being worked on by Rune
 incomplete
Incomplete work — draft PR with ledger, awaiting resume
 infrastructure
life
memory
memory-atlas
Memory Research Atlas child domain
 needs-testing
Needs manual testing with dumbed-down steps before close
 perception
ready
Order satisfied - Rune may start
 release-drift
research
Research jobs — spikes, watchlists, evidence work
 rune
rune
 scaffolding
scaffolding
 spine,correction
spine,correction
 spine,deferred
spine,deferred
 spine,resolved
spine,resolved
 strangler,burn,endgame,deferred
strangler,burn,endgame,deferred
 strangler,burn,endgame,inventory,epic
strangler,burn,endgame,inventory,epic
 tui
tui
 tui,epic
tui,epic
 tui,openspec
tui,openspec
 v1-course-correction
Rune v1 course-correction issue graph
No labels P1 — high custodian growth v1-course-correction
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
conductor
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conductor/rune#32