conductor/rune
1
2 Fork 1
Code Issues 30 Pull Requests 3 Actions Packages Projects Releases 561 Wiki Activity

fix(release): tag_repair CLI --namespace flag — workflow argv form (#2582) #2584

Open
conductor wants to merge 0 commits from fix/2582-namespace-cli-flag into master
pull from: fix/2582-namespace-cli-flag
merge into: conductor:master
Conversation 1 Commits - Files Changed -
conductor commented 2026-10-24 15:23:31 +01:00
Owner
Copy link
Copy source

Bug-fix discharge — run 33866 argparse rejection (#2582)

Finding (root cause): the first live post-merge auto-version run (33866) died at step 3 — tag_repair.py: error: unrecognized arguments: --namespace main. Every workflow caller passes --namespace main, but the flag existed only as a FUNCTION parameter (latest_release_tag(namespace=…)); argparse never knew it. My original fix tested the function, not the CLI form the workflows invoke.

Red test (written before the fix): tests/test_tag_repair.py gains three CLI-level tests running the exact workflow argv through subprocess:

  • --latest-tag --namespace main → asserts the MAIN-line tag (v0.9.0, not the TUI tag)
  • --latest-tag --namespace tui → asserts tui-v0.50.0
  • --latest-tag without the flag → default stays main (pre-existing callers keep behavior)

The red signature matched production exactly: the two flag-bearing forms exited 2 on argparse rejection while the flagless form stayed green.

Fix: argparse --namespace (choices main/tui/any, default main) + handler pass-through in scripts/tag_repair.py.

Verification: 7/7 tests green. Mutation spot-check: handler mutated to hardcode namespace="main" → exactly the tui CLI test went red → reverted → green. Zero pyright delta (ratchet identical — 261/572 — with and without the change; the drift is the unswept master state tracked on PR #2550). Ruff clean, py_compile clean, issue reconciliation green (72 records, 100 live issues in window).

Merge note: required checks fail on INHERITED base reds — the CI-repair wave lives on PR #2550, not this tree. Same owner-consented override as the #2583 merge.

## Bug-fix discharge — run 33866 argparse rejection (#2582) **Finding (root cause):** the first live post-merge auto-version run (33866) died at step 3 — `tag_repair.py: error: unrecognized arguments: --namespace main`. Every workflow caller passes `--namespace main`, but the flag existed only as a FUNCTION parameter (`latest_release_tag(namespace=…)`); argparse never knew it. My original fix tested the function, not the CLI form the workflows invoke. **Red test (written before the fix):** `tests/test_tag_repair.py` gains three CLI-level tests running the exact workflow argv through subprocess: - `--latest-tag --namespace main` → asserts the MAIN-line tag (`v0.9.0`, not the TUI tag) - `--latest-tag --namespace tui` → asserts `tui-v0.50.0` - `--latest-tag` without the flag → default stays main (pre-existing callers keep behavior) The red signature matched production exactly: the two flag-bearing forms exited 2 on argparse rejection while the flagless form stayed green. **Fix:** argparse `--namespace` (choices main/tui/any, default main) + handler pass-through in `scripts/tag_repair.py`. **Verification:** 7/7 tests green. Mutation spot-check: handler mutated to hardcode `namespace="main"` → exactly the tui CLI test went red → reverted → green. Zero pyright delta (ratchet identical — 261/572 — with and without the change; the drift is the unswept master state tracked on PR #2550). Ruff clean, py_compile clean, issue reconciliation green (72 records, 100 live issues in window). **Merge note:** required checks fail on INHERITED base reds — the CI-repair wave lives on PR #2550, not this tree. Same owner-consented override as the #2583 merge.
conductor added 1 commit 2026-10-24 15:23:31 +01:00
fix(release): tag_repair CLI --namespace flag — workflow argv form (#2582)
Auto-label / auto-label (pull_request) Successful in 1s
Details
Local-Model First-Pass Review (#131) / first-pass-review (pull_request) Successful in 20s
Details
Spec gate (headless) / spec-gate (pull_request) Successful in 20s
Details
CI Pipeline / documentation (pull_request) Successful in 10s
Details
CI Pipeline / best-practices (pull_request) Successful in 10s
Details
CI Pipeline / rust-surface (pull_request) Failing after 25s
Details
CI Pipeline / gitea-offline (pull_request) Successful in 28s
Details
CI Pipeline / go-surface (pull_request) Failing after 42s
Details
CI Pipeline / lint (pull_request) Failing after 55s
Details
CI Pipeline / type-check (pull_request) Failing after 57s
Details
CI Pipeline / canary (pull_request) Failing after 3m13s
Details
CI Pipeline / unit-tests (pull_request) Failing after 30m37s
Details
CI Pipeline / required-checks (pull_request) Failing after 1s
Details
CI Pipeline / CI Pipeline / notify-event-bridge (pull_request) Failing after 5s
Details
CI Pipeline / lint (push) Canceled after 0s
Details
CI Pipeline / unit-tests (push) Canceled after 0s
Details
CI Pipeline / go-surface (push) Canceled after 0s
Details
CI Pipeline / rust-surface (push) Canceled after 0s
Details
CI Pipeline / canary (push) Canceled after 0s
Details
CI Pipeline / best-practices (push) Canceled after 0s
Details
CI Pipeline / documentation (push) Canceled after 0s
Details
CI Pipeline / type-check (push) Canceled after 0s
Details
CI Pipeline / gitea-offline (push) Canceled after 0s
Details
CI Pipeline / required-checks (push) Canceled after 0s
Details
CI Pipeline / CI Pipeline / notify-event-bridge (push) Canceled after 0s
Details
Auto-version and Release / release (push) Canceled after 17s
Details
deploy / deploy (push) Canceled after 16s
Details
0de6f1bba4
gitea-actions Bot added the P1 — highbuggovernancegrowth labels 2026-10-24 15:23:35 +01:00
gitea-actions Bot commented 2026-10-24 15:23:54 +01:00
Copy link
Copy source

🤖 Headless spec gate (non-blocking, #204 first slice)

Spec-gate agent produced no text output — check runner logs.

Deterministic floors still govern the merge

This comment is advisory. Required checks (lint, tests, canaries, type-check, coverage, dependency lock, impact gate) remain the merge authority per docs/adversarial-review.md proportionality.

🤖 **Headless spec gate (non-blocking, #204 first slice)** Spec-gate agent produced no text output — check runner logs. <details><summary>Deterministic floors still govern the merge</summary> This comment is advisory. Required checks (lint, tests, canaries, type-check, coverage, dependency lock, impact gate) remain the merge authority per docs/adversarial-review.md proportionality.</details>
Some required checks failed
Auto-label / auto-label (pull_request) Successful in 1s
Details
Local-Model First-Pass Review (#131) / first-pass-review (pull_request) Successful in 20s
Details
Spec gate (headless) / spec-gate (pull_request) Successful in 20s
Details
CI Pipeline / documentation (pull_request) Successful in 10s
Details
CI Pipeline / best-practices (pull_request) Successful in 10s
Details
CI Pipeline / rust-surface (pull_request) Failing after 25s
Details
CI Pipeline / gitea-offline (pull_request) Successful in 28s
Details
CI Pipeline / go-surface (pull_request) Failing after 42s
Details
CI Pipeline / lint (pull_request) Failing after 55s
Details
CI Pipeline / type-check (pull_request) Failing after 57s
Details
CI Pipeline / canary (pull_request) Failing after 3m13s
Details
CI Pipeline / unit-tests (pull_request) Failing after 30m37s
Details
CI Pipeline / required-checks (pull_request) Failing after 1s
Required
Details
CI Pipeline / CI Pipeline / notify-event-bridge (pull_request) Failing after 5s
Details
CI Pipeline / lint (push) Canceled after 0s
Details
CI Pipeline / unit-tests (push) Canceled after 0s
Details
CI Pipeline / go-surface (push) Canceled after 0s
Details
CI Pipeline / rust-surface (push) Canceled after 0s
Details
CI Pipeline / canary (push) Canceled after 0s
Details
CI Pipeline / best-practices (push) Canceled after 0s
Details
CI Pipeline / documentation (push) Canceled after 0s
Details
CI Pipeline / type-check (push) Canceled after 0s
Details
CI Pipeline / gitea-offline (push) Canceled after 0s
Details
CI Pipeline / required-checks (push) Canceled after 0s
Details
CI Pipeline / CI Pipeline / notify-event-bridge (push) Canceled after 0s
Details
Auto-version and Release / release (push) Canceled after 17s
Details
deploy / deploy (push) Canceled after 16s
Details
This branch is already included in the target branch. There is nothing to merge.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/2582-namespace-cli-flag:fix/2582-namespace-cli-flag
git checkout fix/2582-namespace-cli-flag
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0 — critical
Spine/core correctness or blocks other work — do first
 P1 — high
Material user value or real defect (money, bugs, next-stage dep)
 P2 — medium
Quality/consolidation improvement
 P3 — low
Measurement / benchmark / deferred policy
 blocked
Dependencies open
 bug
Confirmed defect or regression
 custodian
epic
Rune v1 course-correction issue graph
 feature
New capability or improvement
 governance
growth
identity
in-progress
Currently being worked on by Rune
 incomplete
Incomplete work — draft PR with ledger, awaiting resume
 infrastructure
life
memory
memory-atlas
Memory Research Atlas child domain
 needs-testing
Needs manual testing with dumbed-down steps before close
 perception
ready
Order satisfied - Rune may start
 release-drift
research
Research jobs — spikes, watchlists, evidence work
 rune
rune
 scaffolding
scaffolding
 spine,correction
spine,correction
 spine,deferred
spine,deferred
 spine,resolved
spine,resolved
 strangler,burn,endgame,deferred
strangler,burn,endgame,deferred
 strangler,burn,endgame,inventory,epic
strangler,burn,endgame,inventory,epic
 tui
tui
 tui,epic
tui,epic
 tui,openspec
tui,openspec
 v1-course-correction
Rune v1 course-correction issue graph
No labels P1 — high bug governance growth
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
conductor
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conductor/rune#2584