fix(deploy_qualify): canonical-default server/repo fallback for out-of-CI consumers #327

Merged
conductor merged 2 commits from t21.4-qualify-defaults-fix into master 2026-09-17 03:13:43 +01:00
Owner

Root fix found during T21.4 G10 dogfood: deploy_qualify.py main() required
GITEA_SERVER/GITEA_REPO env vars that only CI exports — the await_operation
first-class tool therefore could never resolve a real verdict (silent
pending). Fallback to gitea_auth canonical defaults when env is absent;
CI behavior unchanged (env always exported).

Propagation: deploy qualification authority touched; no umbrella membership changes; dependent umbrellas unaffected (single-script env fallback, verified by test_deploy_qualify.py + test_ci_event_wait.py 31 green).

Root fix found during T21.4 G10 dogfood: deploy_qualify.py main() required GITEA_SERVER/GITEA_REPO env vars that only CI exports — the await_operation first-class tool therefore could never resolve a real verdict (silent pending). Fallback to gitea_auth canonical defaults when env is absent; CI behavior unchanged (env always exported). Propagation: deploy qualification authority touched; no umbrella membership changes; dependent umbrellas unaffected (single-script env fallback, verified by test_deploy_qualify.py + test_ci_event_wait.py 31 green).
conductor added 1 commit 2026-09-17 03:03:13 +01:00
fix(deploy_qualify): canonical-default Gitea server/repo fallback — out-of-CI consumers got silent pending verdicts
Auto-label / auto-label (pull_request) Successful in 5s
Auto-label / priority-gate (pull_request) Skipped
CI Pipeline / documentation (pull_request) Successful in 7s
CI Pipeline / canary (pull_request) Successful in 38s
CI Pipeline / gitea-offline (pull_request) Successful in 16s
CI Pipeline / best-practices (pull_request) Successful in 13s
CI Pipeline / lint (pull_request) Successful in 41s
CI Pipeline / type-check (pull_request) Successful in 27s
CI Pipeline / unit-tests (pull_request) Successful in 2m51s
CI Pipeline / required-checks (pull_request) Successful in 1s
CI Pipeline / CI Pipeline / notify-event-bridge (pull_request) Successful in 7s
deploy / deploy (push) Skipped
CI Pipeline / best-practices (push) Successful in 3s
CI Pipeline / documentation (push) Successful in 3s
CI Pipeline / lint (push) Failing after 37s
CI Pipeline / gitea-offline (push) Successful in 18s
CI Pipeline / canary (push) Failing after 49s
CI Pipeline / type-check (push) Successful in 41s
CI Pipeline / unit-tests (push) Failing after 4m3s
CI Pipeline / required-checks (push) Failing after 8s
CI Pipeline / CI Pipeline / notify-event-bridge (push) Successful in 6s
00013f8c0b
The await_operation first-class tool (and any local deploy_qualify.py
caller) never exported GITEA_SERVER/GITEA_REPO, so main() printed
'pending' unconditionally — the first-class wait could never resolve
success even against a green, converged deployment. CI behavior is
unchanged (env always exported there); the fallback only fires when
the caller omitted the vars. Root-caused live in T21.4 G10 dogfood.
gitea-actions Bot added the bugcustodianinfrastructure labels 2026-09-17 03:03:46 +01:00
conductor added 1 commit 2026-09-17 03:08:27 +01:00
Merge branch 'master' into t21.4-qualify-defaults-fix
CI Pipeline / best-practices (pull_request) Successful in 10s
CI Pipeline / documentation (pull_request) Successful in 14s
CI Pipeline / canary (pull_request) Successful in 34s
CI Pipeline / type-check (pull_request) Successful in 29s
CI Pipeline / gitea-offline (pull_request) Successful in 23s
CI Pipeline / lint (push) Successful in 45s
CI Pipeline / canary (push) Successful in 34s
CI Pipeline / best-practices (push) Successful in 5s
CI Pipeline / documentation (push) Successful in 12s
CI Pipeline / gitea-offline (push) Successful in 16s
CI Pipeline / type-check (push) Successful in 33s
CI Pipeline / unit-tests (pull_request) Successful in 2m51s
deploy / deploy (push) Skipped
CI Pipeline / lint (pull_request) Successful in 37s
Spec gate (headless) / spec-gate (pull_request) Successful in 15s
CI Pipeline / required-checks (pull_request) Successful in 3s
CI Pipeline / CI Pipeline / notify-event-bridge (pull_request) Successful in 7s
CI Pipeline / unit-tests (push) Successful in 2m50s
CI Pipeline / required-checks (push) Successful in 2s
CI Pipeline / CI Pipeline / notify-event-bridge (push) Successful in 12s
Auto-version and Release / release (pull_request) Failing after 1m11s
ae6d4a0d98

🤖 Headless spec gate (non-blocking, #204 first slice)

Spec-gate agent produced no text output — check runner logs.

Deterministic floors still govern the merge

This comment is advisory. Required checks (lint, tests, canaries, type-check, coverage, dependency lock, impact gate) remain the merge authority per docs/adversarial-review.md proportionality.

🤖 **Headless spec gate (non-blocking, #204 first slice)** Spec-gate agent produced no text output — check runner logs. <details><summary>Deterministic floors still govern the merge</summary> This comment is advisory. Required checks (lint, tests, canaries, type-check, coverage, dependency lock, impact gate) remain the merge authority per docs/adversarial-review.md proportionality.</details>
conductor merged commit 212239ca7b into master 2026-09-17 03:13:43 +01:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conductor/rune#327